From: cnattras <cnattras@f7af4fe6-9843-0410-8265-dc069ae4e863>
Date: Mon, 14 Mar 2011 12:23:39 +0000 (+0000)
Subject: Another pass at fixing coverity issues
X-Git-Url: http://git.uio.no/git/?a=commitdiff_plain;h=1b8c3d66a5093975ade28d8fe34c2b5a7ca8ae86;p=u%2Fmrichter%2FAliRoot.git

Another pass at fixing coverity issues
---

diff --git a/PWG4/totEt/AliAnalysisEtReconstructed.cxx b/PWG4/totEt/AliAnalysisEtReconstructed.cxx
index d929a1db711..da92f73030a 100644
--- a/PWG4/totEt/AliAnalysisEtReconstructed.cxx
+++ b/PWG4/totEt/AliAnalysisEtReconstructed.cxx
@@ -341,13 +341,16 @@ bool AliAnalysisEtReconstructed::CheckGoodVertex(AliVParticle* track)
 
     Float_t bxy = 999.;
     Float_t bz = 999.;
-    if(track) { 
-      dynamic_cast<AliESDtrack*>(track)->GetImpactParametersTPC(bxy,bz);    
-    } 
-    else {
+    if(!track){
       AliError("ERROR: no track");
       return kFALSE;
     }
+    AliESDtrack *esdTrack = dynamic_cast<AliESDtrack*>(track);
+    if(!esdTrack){
+      AliError("ERROR: no track");
+      return kFALSE;
+    }
+    esdTrack->GetImpactParametersTPC(bxy,bz);
 
 
     bool status = (TMath::Abs(track->Xv()) < fCuts->GetReconstructedVertexXCut()) && 
diff --git a/PWG4/totEt/AliAnalysisHadEtReconstructed.cxx b/PWG4/totEt/AliAnalysisHadEtReconstructed.cxx
index 67f5fd82fb5..38b67f47fc1 100644
--- a/PWG4/totEt/AliAnalysisHadEtReconstructed.cxx
+++ b/PWG4/totEt/AliAnalysisHadEtReconstructed.cxx
@@ -388,13 +388,16 @@ Bool_t AliAnalysisHadEtReconstructed::CheckGoodVertex(AliVParticle* track)
 
     Float_t bxy = 999.;
     Float_t bz = 999.;
-    if(track) {
-      dynamic_cast<AliESDtrack*>(track)->GetImpactParametersTPC(bxy,bz);
+    if(!track){
+      AliError("ERROR: no track");
+      return kFALSE;
     }
-    else {
+    AliESDtrack *esdTrack = dynamic_cast<AliESDtrack*>(track);
+    if(!esdTrack){
       AliError("ERROR: no track");
       return kFALSE;
     }
+    esdTrack->GetImpactParametersTPC(bxy,bz);
 
     bool status = (TMath::Abs(track->Xv()) < fCuts->GetReconstructedVertexXCut()) && 
       (TMath::Abs(track->Yv()) < fCuts->GetReconstructedVertexYCut()) &&