From: hristov Date: Tue, 14 Feb 2012 13:47:24 +0000 (+0000) Subject: Coverity (Yves) X-Git-Url: http://git.uio.no/git/?a=commitdiff_plain;h=2c45ad6f9fa1914ed81971a7747f73704f8f9496;p=u%2Fmrichter%2FAliRoot.git Coverity (Yves) --- diff --git a/STEER/STEER/AliCorrQAChecker.h b/STEER/STEER/AliCorrQAChecker.h index 83db83fd732..9b6059cfab9 100644 --- a/STEER/STEER/AliCorrQAChecker.h +++ b/STEER/STEER/AliCorrQAChecker.h @@ -28,13 +28,13 @@ class AliCorrQAChecker: public AliQACheckerBase { public: AliCorrQAChecker() : AliQACheckerBase("Corr","Corr Quality Assurance Data Maker") {;} // ctor - AliCorrQAChecker(const AliCorrQAChecker& qac) : AliQACheckerBase(qac.GetName(), qac.GetTitle()) {;} // cpy ctor - virtual ~AliCorrQAChecker() {;} // dtor virtual void Run(AliQAv1::ALITASK_t /*tsk*/, TNtupleD ** /*nt*/, AliDetectorRecoParam * /*recoParam*/) ; private: + AliCorrQAChecker(const AliCorrQAChecker& qac); // cpy ctor + virtual ~AliCorrQAChecker(); // dtor Double_t * CheckN(AliQAv1::ALITASK_t index, TNtupleD ** nData, AliDetectorRecoParam * recoParam) ; ClassDef(AliCorrQAChecker,1) // description diff --git a/STEER/STEER/AliQACheckerBase.cxx b/STEER/STEER/AliQACheckerBase.cxx index 93847e6f3dc..fc61b2648d1 100644 --- a/STEER/STEER/AliQACheckerBase.cxx +++ b/STEER/STEER/AliQACheckerBase.cxx @@ -88,44 +88,6 @@ AliQACheckerBase::AliQACheckerBase(const char * name, const char * title) : } } -//____________________________________________________________________________ -AliQACheckerBase::AliQACheckerBase(const AliQACheckerBase& qac) : - TNamed(qac.GetName(), qac.GetTitle()), - fDataSubDir(qac.fDataSubDir), - fRefSubDir(qac.fRefSubDir), - fRefOCDBSubDir(qac.fRefOCDBSubDir), - fLowTestValue(new Float_t[AliQAv1::kNBIT]), - fUpTestValue(new Float_t[AliQAv1::kNBIT]), - fImage(new TCanvas*[AliRecoParam::kNSpecies]), - fPrintImage(kTRUE), - fExternParamList(new TList()) -{ - //copy ctor - for (Int_t index = 0 ; index < AliQAv1::kNBIT ; index++) { - fLowTestValue[index] = qac.fLowTestValue[index] ; - fUpTestValue[index] = qac.fUpTestValue[index] ; - } - for (Int_t specie = 0 ; specie < AliRecoParam::kNSpecies ; specie++) { - fImage[specie] = qac.fImage[specie] ; - fRefOCDBSubDir[specie] = qac.fRefOCDBSubDir[specie] ; - } - if (qac.fExternParamList) { - TIter next(qac.fExternParamList) ; - TParameter * p ; - while ( (p = (TParameter*)next()) ) - fExternParamList->Add(p) ; - } -} - -//____________________________________________________________________________ -AliQACheckerBase& AliQACheckerBase::operator = (const AliQACheckerBase& qac ) -{ - // Equal operator. - this->~AliQACheckerBase(); - new(this) AliQACheckerBase(qac); - return *this; -} - //____________________________________________________________________________ AliQACheckerBase::~AliQACheckerBase() { diff --git a/STEER/STEER/AliQACheckerBase.h b/STEER/STEER/AliQACheckerBase.h index 4afb4ec0060..cc5b0020c80 100644 --- a/STEER/STEER/AliQACheckerBase.h +++ b/STEER/STEER/AliQACheckerBase.h @@ -33,8 +33,6 @@ class AliQACheckerBase: public TNamed { public: AliQACheckerBase(const char * name = "", const char * title = "") ; // ctor - AliQACheckerBase(const AliQACheckerBase& qac) ; - AliQACheckerBase& operator = (const AliQACheckerBase& qac) ; virtual ~AliQACheckerBase() ; // dtor void DeleteImages() ; @@ -70,6 +68,8 @@ protected: TList * fExternParamList; //List of external parameters (TParameter) private: + AliQACheckerBase(const AliQACheckerBase& qac) ; + AliQACheckerBase& operator = (const AliQACheckerBase& qac) ; void PrivateCheck(Double_t * rv, AliQAv1::ALITASK_t index, const AliDetectorRecoParam * recoParam) ; ClassDef(AliQACheckerBase,3) // description diff --git a/TRD/AliTRDQAChecker.h b/TRD/AliTRDQAChecker.h index 60f70f0e294..9c86513e5f7 100644 --- a/TRD/AliTRDQAChecker.h +++ b/TRD/AliTRDQAChecker.h @@ -33,13 +33,13 @@ class AliTRDQAChecker: public AliQACheckerBase { public: AliTRDQAChecker() : AliQACheckerBase("TRD","TRD Quality Assurance Data Maker") {;} // ctor - AliTRDQAChecker(const AliTRDQAChecker& qac) : AliQACheckerBase(qac.GetName(), qac.GetTitle()) {;} // cpy ctor - AliTRDQAChecker& operator=(const AliTRDQAChecker& qac) {if(this!=&qac){AliQACheckerBase::operator=(qac);}return *this;} //ass operator virtual ~AliTRDQAChecker() {;} // dtor virtual void Check(Double_t * test, AliQAv1::ALITASK_t /*index*/, TObjArray** /*list*/, const AliDetectorRecoParam* /*param*/) ; private: + AliTRDQAChecker(const AliTRDQAChecker& qac); // cpy ctor + AliTRDQAChecker& operator=(const AliTRDQAChecker& qac); //ass operator ClassDef(AliTRDQAChecker,1) // description