]> git.uio.no Git - ifi-stolz-refaktor.git/log
ifi-stolz-refaktor.git
10 years agoRemoving unused import.
Erlend Kristiansen [Fri, 13 Dec 2013 14:03:53 +0000 (15:03 +0100)]
Removing unused import.

10 years agoMaking method private.
Erlend Kristiansen [Thu, 12 Dec 2013 15:58:07 +0000 (16:58 +0100)]
Making method private.

10 years agoRemoving the storage of safe prefixes in ExtractAndMoveMethodAnalyzer,
Erlend Kristiansen [Thu, 12 Dec 2013 15:54:04 +0000 (16:54 +0100)]
Removing the storage of safe prefixes in ExtractAndMoveMethodAnalyzer,
         and instead calculate them each time they are requested.

10 years agoRaising the bar for what kind of failures that shall disqualify a
Erlend Kristiansen [Thu, 12 Dec 2013 12:22:01 +0000 (13:22 +0100)]
Raising the bar for what kind of failures that shall disqualify a
refactoring, from a warning to an error.

10 years agoRenaming a field and removing redundant configuration of
Erlend Kristiansen [Thu, 12 Dec 2013 11:42:04 +0000 (12:42 +0100)]
Renaming a field and removing redundant configuration of
MoveInstanceMethodProcessor.

10 years agoRenaming "extractors" to "analyzers".
Erlend Kristiansen [Wed, 11 Dec 2013 21:10:50 +0000 (22:10 +0100)]
Renaming "extractors" to "analyzers".

10 years agoBreaking up long static method to strip a text selection. Fixing some
Erlend Kristiansen [Wed, 11 Dec 2013 20:34:35 +0000 (21:34 +0100)]
Breaking up long static method to strip a text selection. Fixing some
bugs in the same code.

10 years agoRemoving some unused code.
Erlend Kristiansen [Tue, 10 Dec 2013 17:06:45 +0000 (18:06 +0100)]
Removing some unused code.

10 years agoSeparating the execution logic for the extract method and the move
Erlend Kristiansen [Tue, 10 Dec 2013 15:14:23 +0000 (16:14 +0100)]
Separating the execution logic for the extract method and the move
method refactorings in ExtractAndMoveMethodExecutor.

10 years agoSome simple renamings.
Erlend Kristiansen [Tue, 10 Dec 2013 12:09:12 +0000 (13:09 +0100)]
Some simple renamings.

10 years agoMoving away from one RefaktorChangerException with Reason enum to an
Erlend Kristiansen [Tue, 10 Dec 2013 12:00:43 +0000 (13:00 +0100)]
Moving away from one RefaktorChangerException with Reason enum to an
exception hierarchy.

10 years agoMoving the selection validation checking to the SelectionValidator
Erlend Kristiansen [Tue, 10 Dec 2013 11:07:30 +0000 (12:07 +0100)]
Moving the selection validation checking to the SelectionValidator
(former SelectionChecker).

10 years agoAdding the interface PropertiesExtractor.
Erlend Kristiansen [Mon, 9 Dec 2013 20:20:22 +0000 (21:20 +0100)]
Adding the interface PropertiesExtractor.
Flattening out the extractor class hierarchy.

10 years agoRefactoring a bit of the precondition checking.
Erlend Kristiansen [Mon, 9 Dec 2013 18:26:01 +0000 (19:26 +0100)]
Refactoring a bit of the precondition checking.

10 years agoAdding final modifier to executorManager.
Erlend Kristiansen [Sun, 8 Dec 2013 09:12:48 +0000 (10:12 +0100)]
Adding final modifier to executorManager.

10 years agoRemoving some garbage code from SaferRefactoring*.
Erlend Kristiansen [Sun, 8 Dec 2013 09:07:14 +0000 (10:07 +0100)]
Removing some garbage code from SaferRefactoring*.

10 years agoIntroducing the Executor/ExecutorManager pattern for the rest of the changers.
Erlend Kristiansen [Sat, 7 Dec 2013 17:11:16 +0000 (18:11 +0100)]
Introducing the Executor/ExecutorManager pattern for the rest of the changers.

10 years agoAdding Executor interface and ExecutorManager.
Erlend Kristiansen [Sat, 7 Dec 2013 16:00:56 +0000 (17:00 +0100)]
Adding Executor interface and ExecutorManager.

10 years agoRenaming RefactoringExecutor to RefactoringPerformer.
Erlend Kristiansen [Sat, 7 Dec 2013 15:36:01 +0000 (16:36 +0100)]
Renaming RefactoringExecutor to RefactoringPerformer.
Removing a field and using a parameter instead.

10 years agoMade RefactoringExecutor interface and a concrete implementation that is
Erlend Kristiansen [Sat, 7 Dec 2013 15:20:49 +0000 (16:20 +0100)]
Made RefactoringExecutor interface and a concrete implementation that is
used for actually executing refactorings.

10 years agoFixing some names.
Erlend Kristiansen [Sat, 7 Dec 2013 14:02:01 +0000 (15:02 +0100)]
Fixing some names.

10 years agoSetting some members to private.
Erlend Kristiansen [Fri, 6 Dec 2013 14:13:55 +0000 (15:13 +0100)]
Setting some members to private.

10 years agoSome small refactorings in PrefixSet.
Erlend Kristiansen [Fri, 6 Dec 2013 14:10:46 +0000 (15:10 +0100)]
Some small refactorings in PrefixSet.

10 years agoRemoving some use of null values in Prefix.
Erlend Kristiansen [Fri, 6 Dec 2013 13:52:57 +0000 (14:52 +0100)]
Removing some use of null values in Prefix.

10 years agoRemoving some Reasons from RefaktorChangerException.
Erlend Kristiansen [Fri, 6 Dec 2013 12:43:26 +0000 (13:43 +0100)]
Removing some Reasons from RefaktorChangerException.

10 years agoCleaning up.
Erlend Kristiansen [Thu, 5 Dec 2013 20:14:51 +0000 (21:14 +0100)]
Cleaning up.

10 years agoAdding MoveMethodTargetFinder to ExtractAndMoveMethodChanger.
Erlend Kristiansen [Thu, 5 Dec 2013 20:07:29 +0000 (21:07 +0100)]
Adding MoveMethodTargetFinder to ExtractAndMoveMethodChanger.

10 years agoRefactoring.
Erlend Kristiansen [Thu, 5 Dec 2013 18:30:13 +0000 (19:30 +0100)]
Refactoring.

10 years agoFixing possible problem with finding move target from method parameters.
Erlend Kristiansen [Thu, 5 Dec 2013 18:18:16 +0000 (19:18 +0100)]
Fixing possible problem with finding move target from method parameters.

10 years agoRefactoring some code.
Erlend Kristiansen [Thu, 5 Dec 2013 17:03:53 +0000 (18:03 +0100)]
Refactoring some code.

10 years agoSome refactoring. Getting rid of IDocument dependency in Prefix among
Erlend Kristiansen [Wed, 4 Dec 2013 16:10:10 +0000 (17:10 +0100)]
Some refactoring. Getting rid of IDocument dependency in Prefix among
other things.

10 years agoDoing some refactoring.
Erlend Kristiansen [Wed, 4 Dec 2013 13:31:48 +0000 (14:31 +0100)]
Doing some refactoring.

10 years agoDoing some refactoring.
Erlend Kristiansen [Mon, 2 Dec 2013 13:22:45 +0000 (14:22 +0100)]
Doing some refactoring.

10 years agoSome more cleaning.
Erlend Kristiansen [Fri, 29 Nov 2013 17:25:51 +0000 (18:25 +0100)]
Some more cleaning.

10 years agoCleaning some code.
Erlend Kristiansen [Fri, 29 Nov 2013 16:52:48 +0000 (17:52 +0100)]
Cleaning some code.

10 years agoExchanging the SmartTextSelection in favor of a
Erlend Kristiansen [Fri, 29 Nov 2013 15:21:47 +0000 (16:21 +0100)]
Exchanging the SmartTextSelection in favor of a
CompilationUnitTextSelection that enforces the use of a compilation unit
instead of a document.

10 years agoRenaming SmartTextSelection to DocumentTextSelection.
Erlend Kristiansen [Fri, 29 Nov 2013 13:53:17 +0000 (14:53 +0100)]
Renaming SmartTextSelection to DocumentTextSelection.

10 years agoDid some refactoring on the initialization of ExtractAndMoveMethodChanger.
Erlend Kristiansen [Fri, 29 Nov 2013 13:37:56 +0000 (14:37 +0100)]
Did some refactoring on the initialization of ExtractAndMoveMethodChanger.

10 years agoMoving Reason class from ExtractAndMoveMethodChanger to RefaktorChangerException.
Erlend Kristiansen [Fri, 29 Nov 2013 11:29:04 +0000 (12:29 +0100)]
Moving Reason class from ExtractAndMoveMethodChanger to RefaktorChangerException.

10 years agoFixing bug regarding faulty use of own RefaktorChanger API.
Erlend Kristiansen [Fri, 29 Nov 2013 10:29:12 +0000 (11:29 +0100)]
Fixing bug regarding faulty use of own RefaktorChanger API.

10 years agoMoving RefaktorChangerException to no.uio.ifi.refaktor.changers package.
Erlend Kristiansen [Fri, 29 Nov 2013 09:52:03 +0000 (10:52 +0100)]
Moving RefaktorChangerException to no.uio.ifi.refaktor.changers package.

10 years agoAdding the use of exceptions to handle precondition checking instead of
Erlend Kristiansen [Fri, 29 Nov 2013 07:19:41 +0000 (08:19 +0100)]
Adding the use of exceptions to handle precondition checking instead of
using a lot of boolean checking.

10 years agoChanging the RefaktorHandleUtils.findCompilationUnitFromEditorInput to
Erlend Kristiansen [Fri, 29 Nov 2013 06:05:08 +0000 (07:05 +0100)]
Changing the RefaktorHandleUtils.findCompilationUnitFromEditorInput to
RefaktorHandleUtils.findCompilationUnitFromEditor.

10 years agoAdding method to find file from editor in DocumentUtils.
Erlend Kristiansen [Fri, 29 Nov 2013 05:55:14 +0000 (06:55 +0100)]
Adding method to find file from editor in DocumentUtils.
Using the new method in ExtractAndMoveMethodHandler.

10 years agoSplitting method with to many responsibilities (including side effects)
Erlend Kristiansen [Fri, 29 Nov 2013 05:46:34 +0000 (06:46 +0100)]
Splitting method with to many responsibilities (including side effects)
    in DocumentUtils.

10 years agoChanging prefix equality to also consider the variable binding of the
Erlend Kristiansen [Thu, 28 Nov 2013 19:25:19 +0000 (20:25 +0100)]
Changing prefix equality to also consider the variable binding of the
first variable. This implies that all extractors must be constructed
with a compilation unit.

REFA-5
REFA-9

10 years agoAdding the output of unfixes and safe prefixes to the PrefixView.
Erlend Kristiansen [Wed, 27 Nov 2013 16:26:43 +0000 (17:26 +0100)]
Adding the output of unfixes and safe prefixes to the PrefixView.

10 years agoChanging the name of the UnionOfLongestCommonPrefixesExtractor to PrefixesExtractor.
Erlend Kristiansen [Wed, 27 Nov 2013 15:55:54 +0000 (16:55 +0100)]
Changing the name of the UnionOfLongestCommonPrefixesExtractor to PrefixesExtractor.

10 years agoMaking prefix collectors work on all qualified names
Erlend Kristiansen [Wed, 27 Nov 2013 12:35:54 +0000 (13:35 +0100)]
Making prefix collectors work on all qualified names
instead of just method invocations.

Changing some tests to reflect new functionality.

REFA-5

10 years agoMaking prefix collectors work on all method invocations
Erlend Kristiansen [Wed, 27 Nov 2013 12:25:16 +0000 (13:25 +0100)]
Making prefix collectors work on all method invocations
instead of just expression statements.

Changing some tests to reflect new functionality.

REFA-5

10 years agoDeleting some unused classes.
Erlend Kristiansen [Wed, 27 Nov 2013 11:30:28 +0000 (12:30 +0100)]
Deleting some unused classes.

10 years agoAdding test to expose cases where a variable declaration that is used as
Erlend Kristiansen [Wed, 27 Nov 2013 11:24:46 +0000 (12:24 +0100)]
Adding test to expose cases where a variable declaration that is used as
target for the move is also in the selection. I.e. adding its name to
the unfixes.

Changing the UnfixesCollector to pass the test.

REFA-9

10 years agoAdding a TODO in the code.
Erlend Kristiansen [Tue, 26 Nov 2013 15:37:49 +0000 (16:37 +0100)]
Adding a TODO in the code.

10 years agoAdding to the thesis about property collectors.
Erlend Kristiansen [Tue, 26 Nov 2013 15:37:18 +0000 (16:37 +0100)]
Adding to the thesis about property collectors.

10 years agoDoing some minor refactoring.
Erlend Kristiansen [Tue, 26 Nov 2013 12:36:33 +0000 (13:36 +0100)]
Doing some minor refactoring.

10 years agoMoving Prefix and PrefixSet into the package no.uio.ifi.refaktor.prefix.
Erlend Kristiansen [Tue, 26 Nov 2013 12:34:48 +0000 (13:34 +0100)]
Moving Prefix and PrefixSet into the package no.uio.ifi.refaktor.prefix.

10 years agoRefactoring some names and adds some JavaDoc.
Erlend Kristiansen [Tue, 26 Nov 2013 12:18:58 +0000 (13:18 +0100)]
Refactoring some names and adds some JavaDoc.

10 years agoUnifying logic from PrefixesCollector and LongestCommonPrefixCollector
Erlend Kristiansen [Mon, 25 Nov 2013 12:49:22 +0000 (13:49 +0100)]
Unifying logic from PrefixesCollector and LongestCommonPrefixCollector
into PrefixCollectorBase. Plus some other refactoring.

REFA-5

10 years agoSeparating the logic of extractors into collectors. ++
Erlend Kristiansen [Mon, 25 Nov 2013 11:18:26 +0000 (12:18 +0100)]
Separating the logic of extractors into collectors. ++

REFA-5
REFA-9

10 years agoThesis work. Writing about the Extract and Move Method refactoring.
Erlend Kristiansen [Sun, 24 Nov 2013 21:44:04 +0000 (22:44 +0100)]
Thesis work. Writing about the Extract and Move Method refactoring.

10 years agoImproving the method in Prefix for finding the name of the sourrounding
Erlend Kristiansen [Sun, 24 Nov 2013 20:10:38 +0000 (21:10 +0100)]
Improving the method in Prefix for finding the name of the sourrounding
type.

10 years agoAdding to the section about Eclipse shortcomings.
Erlend Kristiansen [Wed, 20 Nov 2013 21:38:31 +0000 (22:38 +0100)]
Adding to the section about Eclipse shortcomings.

10 years agoAdding a file listing some files with Eclipse source code and some of
Erlend Kristiansen [Wed, 20 Nov 2013 21:31:10 +0000 (22:31 +0100)]
Adding a file listing some files with Eclipse source code and some of
their authors.

10 years agoDoing some refactoring.
Erlend Kristiansen [Wed, 20 Nov 2013 13:19:34 +0000 (14:19 +0100)]
Doing some refactoring.

10 years agoStarting to write about Eclipse shortcomings.
Erlend Kristiansen [Tue, 19 Nov 2013 18:33:26 +0000 (19:33 +0100)]
Starting to write about Eclipse shortcomings.

10 years agoWriting more about the design of the LTK.
Erlend Kristiansen [Tue, 19 Nov 2013 17:16:03 +0000 (18:16 +0100)]
Writing more about the design of the LTK.

10 years agoStarting on the chapter about the design of refactorings in Eclipse.
Erlend Kristiansen [Mon, 18 Nov 2013 20:04:00 +0000 (21:04 +0100)]
Starting on the chapter about the design of refactorings in Eclipse.

10 years agoWriting about hacking the refactoring undo management.
Erlend Kristiansen [Mon, 18 Nov 2013 18:17:38 +0000 (19:17 +0100)]
Writing about hacking the refactoring undo management.

10 years agoMinor changes.
Erlend Kristiansen [Thu, 14 Nov 2013 14:42:38 +0000 (15:42 +0100)]
Minor changes.

10 years agoChanging test to get a higher degree of code coverage.
Erlend Kristiansen [Fri, 8 Nov 2013 07:37:20 +0000 (08:37 +0100)]
Changing test to get a higher degree of code coverage.

10 years agoAdding some outlines to the thesis.
Erlend Kristiansen [Thu, 7 Nov 2013 20:07:20 +0000 (21:07 +0100)]
Adding some outlines to the thesis.

10 years agoAdding some JavaDoc and cleaning up a bit.
Erlend Kristiansen [Thu, 7 Nov 2013 19:18:37 +0000 (20:18 +0100)]
Adding some JavaDoc and cleaning up a bit.

10 years agoMoving ExtractAndMoveMethodPrefixesExtractor to
Erlend Kristiansen [Thu, 7 Nov 2013 15:20:50 +0000 (16:20 +0100)]
Moving ExtractAndMoveMethodPrefixesExtractor to
no.uio.ifi.refaktor.extractors package.

10 years agoSome small improvement changes.
Erlend Kristiansen [Thu, 7 Nov 2013 14:43:20 +0000 (15:43 +0100)]
Some small improvement changes.

10 years agoFixing logical flaw in Prefix.shadows().
Erlend Kristiansen [Thu, 7 Nov 2013 14:31:36 +0000 (15:31 +0100)]
Fixing logical flaw in Prefix.shadows().

REFA-5

10 years agoSub-prefixes of a prefix is now returned as a PrefixSet.
Erlend Kristiansen [Thu, 7 Nov 2013 13:39:29 +0000 (14:39 +0100)]
Sub-prefixes of a prefix is now returned as a PrefixSet.

REFA-5

10 years agoRemoving a lot of package files.
Erlend Kristiansen [Thu, 7 Nov 2013 13:18:41 +0000 (14:18 +0100)]
Removing a lot of package files.

10 years agoSome small refactoring.
Erlend Kristiansen [Wed, 6 Nov 2013 13:52:12 +0000 (14:52 +0100)]
Some small refactoring.

10 years agoMoving functionality from ExtractAndMoveMethodPrefixesExtractor to Prefix and PrefixSet
Erlend Kristiansen [Wed, 6 Nov 2013 13:48:34 +0000 (14:48 +0100)]
Moving functionality from ExtractAndMoveMethodPrefixesExtractor to Prefix and PrefixSet

REFA-5

10 years agoMoving some functionality from UnionOfLongestCommonPrefixesExtractor to PrefixSet.
Erlend Kristiansen [Wed, 6 Nov 2013 12:43:21 +0000 (13:43 +0100)]
Moving some functionality from UnionOfLongestCommonPrefixesExtractor to PrefixSet.

REFA-5

10 years agoNow using custom PrefixSet instead of Set<Prefix> in extractors.
Erlend Kristiansen [Tue, 5 Nov 2013 15:31:57 +0000 (16:31 +0100)]
Now using custom PrefixSet instead of Set<Prefix> in extractors.

REFA-5

10 years agoNow using Set instead of Map for prefixes in extractors.
Erlend Kristiansen [Tue, 5 Nov 2013 14:49:16 +0000 (15:49 +0100)]
Now using Set instead of Map for prefixes in extractors.

REFA-5

10 years agoExtractAndMoveMethodPrefixesExtractor filters out those prefixes that
Erlend Kristiansen [Mon, 4 Nov 2013 19:39:25 +0000 (20:39 +0100)]
ExtractAndMoveMethodPrefixesExtractor filters out those prefixes that
starts with a simpleName that is assigned to within the selection.

REFA-9

10 years agoAdding ObjectAid class diagram of some refator classes.
Erlend Kristiansen [Fri, 1 Nov 2013 15:33:27 +0000 (16:33 +0100)]
Adding ObjectAid class diagram of some refator classes.

10 years agoAdding failing test for ExtractAndMoveMethodChanger that is supposed
Erlend Kristiansen [Fri, 1 Nov 2013 15:29:43 +0000 (16:29 +0100)]
Adding failing test for ExtractAndMoveMethodChanger that is supposed
to catch cases where a parameter is assigned.

10 years agoCode example for submitted bug regarding the Move Method refactoring:
Erlend Kristiansen [Wed, 30 Oct 2013 15:19:23 +0000 (16:19 +0100)]
Code example for submitted bug regarding the Move Method refactoring:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=420726

10 years agoMade the retrieval of the extracted IMethod, for use with the move
Erlend Kristiansen [Fri, 25 Oct 2013 14:24:26 +0000 (16:24 +0200)]
Made the retrieval of the extracted IMethod, for use with the move
refactoring, more robust.

10 years agoExtractAndMoveMethodHandler: Adding the possibility for the user to change the name...
Erlend Kristiansen [Thu, 24 Oct 2013 13:38:58 +0000 (15:38 +0200)]
ExtractAndMoveMethodHandler: Adding the possibility for the user to change the name of the extracted method.

10 years agoFixed ASimpleExampleExtractTempTest
Erlend Kristiansen [Thu, 24 Oct 2013 12:14:21 +0000 (14:14 +0200)]
Fixed ASimpleExampleExtractTempTest

10 years agoDoing some small refactorings.
Erlend Kristiansen [Thu, 24 Oct 2013 09:48:31 +0000 (11:48 +0200)]
Doing some small refactorings.

10 years agoFixing bug that made handlers reuse the last changer instead of creating
Erlend Kristiansen [Thu, 24 Oct 2013 09:47:22 +0000 (11:47 +0200)]
Fixing bug that made handlers reuse the last changer instead of creating
a new one when executed multiple times.

10 years agoAdding test.
Erlend Kristiansen [Thu, 24 Oct 2013 09:46:28 +0000 (11:46 +0200)]
Adding test.

10 years agoAdding test for ExtractAndMoveMethodChanger.
Erlend Kristiansen [Wed, 23 Oct 2013 18:36:26 +0000 (20:36 +0200)]
Adding test for ExtractAndMoveMethodChanger.
Currently it does not expose any bugs.

10 years agoMaking the abstraction of a RefaktorChanger that can be used to make
Erlend Kristiansen [Wed, 23 Oct 2013 16:17:07 +0000 (18:17 +0200)]
Making the abstraction of a RefaktorChanger that can be used to make
changes to the workspace, by handlers and others.
Unit tests should use instances of this class directly instead of calling handlers.

10 years agoYou wouldn't believe this...
Volker Stolz [Thu, 26 Sep 2013 18:00:47 +0000 (20:00 +0200)]
You wouldn't believe this...

10 years agoMerge branch 'master' of gitolite@git.uio.no:ifi-stolz-refaktor
Volker Stolz [Thu, 26 Sep 2013 17:36:40 +0000 (19:36 +0200)]
Merge branch 'master' of gitolite@git.uio.no:ifi-stolz-refaktor

10 years agoLalalala...
Volker Stolz [Thu, 26 Sep 2013 17:35:26 +0000 (19:35 +0200)]
Lalalala...

10 years agoBuckminster, again.
Volker Stolz [Thu, 26 Sep 2013 16:59:03 +0000 (18:59 +0200)]
Buckminster, again.

10 years agoMerge branch 'master' of git.uio.no:ifi-stolz-refaktor
Erlend Kristiansen [Thu, 26 Sep 2013 13:53:42 +0000 (15:53 +0200)]
Merge branch 'master' of git.uio.no:ifi-stolz-refaktor

Conflicts:
software/no.uio.ifi.refaktor/META-INF/MANIFEST.MF
software/no.uio.ifi.refaktor/src/no/uio/ifi/refaktor/handlers/ExtractAndMoveMethodHandler.java

10 years agoMinor changes. Changing/adding some debug statements.
Erlend Kristiansen [Thu, 26 Sep 2013 13:50:56 +0000 (15:50 +0200)]
Minor changes. Changing/adding some debug statements.