From accb0197e1e5fc1f76f89f3a855f27e521a9cbb4 Mon Sep 17 00:00:00 2001 From: morsch Date: Sat, 29 Jan 2011 18:07:46 +0000 Subject: [PATCH] Coverity fixes. --- ANALYSIS/AliESDpidCuts.cxx | 12 ++++++------ ANALYSIS/AliESDv0Cuts.cxx | 6 +++--- ANALYSIS/AliTagAnalysis.cxx | 12 ++++++------ 3 files changed, 15 insertions(+), 15 deletions(-) diff --git a/ANALYSIS/AliESDpidCuts.cxx b/ANALYSIS/AliESDpidCuts.cxx index aeb6908cf8e..e2573e5620f 100644 --- a/ANALYSIS/AliESDpidCuts.cxx +++ b/ANALYSIS/AliESDpidCuts.cxx @@ -214,15 +214,15 @@ void AliESDpidCuts::DefineHistograms(Color_t color){ } Char_t hname[256], htitle[256]; for(Int_t imode = 0; imode < 2; imode++){ - sprintf(hname, "fHclusterRatio%s", imode ? "After" : "Before"); - sprintf(htitle, "TPC cluster Ratio %s cuts;Ratio;Entries", imode ? "after" : "before"); + snprintf(hname, 256, "fHclusterRatio%s", imode ? "After" : "Before"); + snprintf(htitle, 256, "TPC cluster Ratio %s cuts;Ratio;Entries", imode ? "after" : "before"); fHclusterRatio[imode] = new TH1F(hname, htitle, 20, 0., 1.); for(Int_t ispec = 0; ispec < AliPID::kSPECIES; ispec++){ - sprintf(hname, "fHnSigma%sTPC%s", AliPID::ParticleName(ispec), imode ? "after" : "before"); - sprintf(htitle, "TPC sigma for %s %s cuts;sigma;Entries", AliPID::ParticleName(ispec), imode ? "after" : "before"); + snprintf(hname, 256, "fHnSigma%sTPC%s", AliPID::ParticleName(ispec), imode ? "after" : "before"); + snprintf(htitle, 256, "TPC sigma for %s %s cuts;sigma;Entries", AliPID::ParticleName(ispec), imode ? "after" : "before"); fHnSigmaTPC[ispec][imode] = new TH1F(hname, htitle, 200, -10., 10.); - sprintf(hname, "fHnSigma%sTOF%s", AliPID::ParticleName(ispec), imode ? "after" : "before"); - sprintf(htitle, "TOF sigma for %s %s cuts;sigma;Entries", AliPID::ParticleName(ispec), imode ? "after" : "before"); + snprintf(hname, 256, "fHnSigma%sTOF%s", AliPID::ParticleName(ispec), imode ? "after" : "before"); + snprintf(htitle, 256, "TOF sigma for %s %s cuts;sigma;Entries", AliPID::ParticleName(ispec), imode ? "after" : "before"); fHnSigmaTOF[ispec][imode] = new TH1F(hname, htitle, 200, -10., 10.); } } diff --git a/ANALYSIS/AliESDv0Cuts.cxx b/ANALYSIS/AliESDv0Cuts.cxx index 519e30f2a62..1afb2de836a 100644 --- a/ANALYSIS/AliESDv0Cuts.cxx +++ b/ANALYSIS/AliESDv0Cuts.cxx @@ -643,8 +643,8 @@ Int_t AliESDv0Cuts::CountAcceptedV0s(AliESDEvent* esd) Char_t str[256]; for (Int_t i=0; i<2; i++) { - if (i==0) sprintf(str," "); - else sprintf(str,"_cut"); + if (i==0) snprintf(str,256, " "); + else snprintf(str,256, "_cut"); fhDcaPosToVertex[i] = new TH1F(Form("dcaPosToVertex%s",str),"",120,0,3); fhDcaNegToVertex[i] = new TH1F(Form("dcaNegToVertex%s",str),"",120,0,3); @@ -706,7 +706,7 @@ Bool_t AliESDv0Cuts::LoadHistograms(const Char_t* dir) else { gDirectory->cd("after_cuts"); - sprintf(str,"_cut"); + snprintf(str,5, "_cut"); } fhDcaPosToVertex[i] = dynamic_cast (gDirectory->Get(Form("dcaPosToVertex%s",str) )); diff --git a/ANALYSIS/AliTagAnalysis.cxx b/ANALYSIS/AliTagAnalysis.cxx index 5f09ced55a8..77bd1081ac4 100644 --- a/ANALYSIS/AliTagAnalysis.cxx +++ b/ANALYSIS/AliTagAnalysis.cxx @@ -674,27 +674,27 @@ AliTagAnalysis::CreateChainFromCollection(const char* collectionname, const char char nstr[2000]; - sprintf(nstr, "TotalEvents=%i", iTotalEvents); + snprintf(nstr, 2000, "TotalEvents=%i", iTotalEvents); TObjString *iTotStr = new TObjString(nstr); aUserInfo->Add(iTotStr); - sprintf(nstr, "AcceptedEvents=%i", iAccepted); + snprintf(nstr, 2000, "AcceptedEvents=%i", iAccepted); TObjString *iAccStr = new TObjString(nstr); aUserInfo->Add(iAccStr); - sprintf(nstr, "RejectedRun=%i", iRejRun); + snprintf(nstr, 2000, "RejectedRun=%i", iRejRun); TObjString *iRejRunStr = new TObjString(nstr); aUserInfo->Add(iRejRunStr); - sprintf(nstr, "RejectedLHC=%i", iRejLHC); + snprintf(nstr, 2000, "RejectedLHC=%i", iRejLHC); TObjString *iRejLHCStr = new TObjString(nstr); aUserInfo->Add(iRejLHCStr); - sprintf(nstr, "RejectedDet=%i", iRejDet); + snprintf(nstr, 2000, "RejectedDet=%i", iRejDet); TObjString *iRejDetStr = new TObjString(nstr); aUserInfo->Add(iRejDetStr); - sprintf(nstr, "RejectedEvt=%i", iRejEvt); + snprintf(nstr, 2000, "RejectedEvt=%i", iRejEvt); TObjString *iRejEvtStr = new TObjString(nstr); aUserInfo->Add(iRejEvtStr); -- 2.43.0