From fa358bbd93709971c00629460ccc45ef5fafec9d Mon Sep 17 00:00:00 2001
From: masera <masera@f7af4fe6-9843-0410-8265-dc069ae4e863>
Date: Mon, 14 Nov 2011 11:34:12 +0000
Subject: [PATCH] Coverity

---
 ITS/AliITSDDLRawData.cxx          | 13 ++++++----
 ITS/AliITSOnlineSPDfoAnalyzer.cxx |  1 +
 ITS/AliITSsimulationSDD.cxx       | 42 -------------------------------
 ITS/AliITSsimulationSDD.h         |  9 ++++---
 4 files changed, 14 insertions(+), 51 deletions(-)

diff --git a/ITS/AliITSDDLRawData.cxx b/ITS/AliITSDDLRawData.cxx
index c11cb38e431..f9616f9cdba 100644
--- a/ITS/AliITSDDLRawData.cxx
+++ b/ITS/AliITSDDLRawData.cxx
@@ -66,10 +66,10 @@ fSDDRawFormat(source.fSDDRawFormat){
 
 AliITSDDLRawData& AliITSDDLRawData::operator=(const AliITSDDLRawData &source){
   //Assigment operator
-  this->fIndex=source.fIndex;
-  this->fHalfStaveModule=source.fHalfStaveModule;
-  this->fVerbose=source.fVerbose;
-  this->fSDDRawFormat=source.fSDDRawFormat;
+  fIndex=source.fIndex;
+  fHalfStaveModule=source.fHalfStaveModule;
+  fVerbose=source.fVerbose;
+  fSDDRawFormat=source.fSDDRawFormat;
   return *this;
 }
 
@@ -648,7 +648,10 @@ Int_t AliITSDDLRawData::RawDataSDD(TBranch* branch, AliITSDDLModuleMapSDD* ddlsd
     for(Int_t ibit=0; ibit<5; ibit++) header.SetAttribute(ibit);
     for(Int_t ibit=5; ibit<8; ibit++) header.ResetAttribute(ibit);  
   }
-  UInt_t skippedword, carlosFooterWord,fifoFooterWord,jitterWord;
+  UInt_t skippedword=0; 
+  UInt_t carlosFooterWord=0;
+  UInt_t fifoFooterWord=0;
+  UInt_t jitterWord=0;
   Bool_t retcode;
   retcode = AliBitPacking::PackWord(0x3FFFFFFF,carlosFooterWord,0,31);
   retcode = AliBitPacking::PackWord(0x3F1F1F1F,fifoFooterWord,0,31);
diff --git a/ITS/AliITSOnlineSPDfoAnalyzer.cxx b/ITS/AliITSOnlineSPDfoAnalyzer.cxx
index dd0481f3eab..d4c13559458 100644
--- a/ITS/AliITSOnlineSPDfoAnalyzer.cxx
+++ b/ITS/AliITSOnlineSPDfoAnalyzer.cxx
@@ -404,6 +404,7 @@ TArrayI AliITSOnlineSPDfoAnalyzer::ChooseDACValues(Int_t hs, Int_t chip) const
   // is taken.
   
   TH1D *tmp[5];
+  for(Int_t jj=0;jj<5;jj++)tmp[jj]=NULL;
   if(fNdims > 5) printf("AliITSOnlineSPDfoAnalyzer::ChooseDACValues -> N. of dimensions are more than expected! Break! \n");
   TArrayI dacs(fNdims+1);
   
diff --git a/ITS/AliITSsimulationSDD.cxx b/ITS/AliITSsimulationSDD.cxx
index 9739fd70911..efe968c097f 100644
--- a/ITS/AliITSsimulationSDD.cxx
+++ b/ITS/AliITSsimulationSDD.cxx
@@ -74,49 +74,7 @@ fScaleSize(0){
     SetCrosstalkFlag();
     SetDoFFT();
 }
-//______________________________________________________________________
-AliITSsimulationSDD::AliITSsimulationSDD(const AliITSsimulationSDD &source) :
-    AliITSsimulation(source),
-fITS(source.fITS),
-fHitMap2(source.fHitMap2),
-fHitSigMap2(source.fHitSigMap2),
-fHitNoiMap2(source.fHitNoiMap2),
-fElectronics(source.fElectronics),
-fInZR(source.fInZR),
-fInZI(source.fInZI),
-fOutZR(source.fOutZR),
-fOutZI(source.fOutZI),
-fAnodeFire(source.fAnodeFire),
-fHis(source.fHis),
-fFlag(source.fFlag),
-fCrosstalkFlag(source.fCrosstalkFlag),
-fDoFFT(source.fDoFFT),
-fNofMaps(source.fNofMaps),
-fMaxNofSamples(source.fMaxNofSamples),
-fScaleSize(source.fScaleSize){
-    // Copy constructor to satify Coding roules only.
-
-}
-//______________________________________________________________________
-AliITSsimulationSDD& AliITSsimulationSDD::operator=(const AliITSsimulationSDD &src){
-    // Assignment operator to satify Coding roules only.
 
-    if(this==&src) return *this;
-    Error("AliITSsimulationSDD","Not allowed to make a = with "
-          "AliITSsimulationSDD Using default creater instead");
-    return *this ;
-}
-/*
-//______________________________________________________________________
-AliITSsimulation& AliITSsimulationSDD::operator=(const AliITSsimulation &src){
-    // Assignment operator to satify Coding roules only.
-
-    if(this==&src) return *this;
-    Error("AliITSsimulationSSD","Not allowed to make a = with "
-          "AliITSsimulationSDD Using default creater instead");
-    return *this ;
-}
-*/
 //______________________________________________________________________
 AliITSsimulationSDD::AliITSsimulationSDD(AliITSDetTypeSim* dettyp):
 AliITSsimulation(dettyp),
diff --git a/ITS/AliITSsimulationSDD.h b/ITS/AliITSsimulationSDD.h
index 1fb339e9397..641c4fe20a0 100644
--- a/ITS/AliITSsimulationSDD.h
+++ b/ITS/AliITSsimulationSDD.h
@@ -31,11 +31,9 @@ class AliITSsimulationSDD : public AliITSsimulation {
     AliITSsimulationSDD(); // default constructor
     //Standard Constructor
     AliITSsimulationSDD(AliITSDetTypeSim* dettyp);
-    // Copy operator
-    AliITSsimulationSDD(const AliITSsimulationSDD &source);
+
     virtual ~AliITSsimulationSDD(); // Destructor
-    // = operator
-    AliITSsimulationSDD& operator=(const AliITSsimulationSDD &source);
+
     //    virtual AliITSsimulation& operator=(const AliITSsimulation &source);
     // Initilize variables for this simulation
     void Init();
@@ -114,6 +112,9 @@ class AliITSsimulationSDD : public AliITSsimulation {
     virtual void PrintStatus() const;
 
   private:
+    AliITSsimulationSDD(const AliITSsimulationSDD &source);
+    AliITSsimulationSDD& operator=(const AliITSsimulationSDD &source);
+
     // virtual void GetBaseline(Int_t mod);  // read baseline values from a file
     // Variables and pointers for local use only. Not Streamed out.
     AliITS         *fITS;          //! local pointer to ITS
-- 
2.39.3