From 15be6f41436204aed59abe1e0426b57e2fadcfb3 Mon Sep 17 00:00:00 2001 From: masera Date: Fri, 20 Jun 2014 19:07:21 +0200 Subject: [PATCH] Coverity fixes --- ITS/AliITSClusterFinderV2SSD.cxx | 11 ++++++----- ITS/AliITSDDLRawData.cxx | 1 + ITS/AliITSMultReconstructor.cxx | 22 ---------------------- ITS/AliITSQASDDDataMakerRec.cxx | 10 ++++------ ITS/AliITSQASPDDataMakerRec.cxx | 6 +++--- ITS/AliITSRealignTracks.cxx | 15 +++++++-------- ITS/AliITSTPArrayFit.cxx | 6 +++--- ITS/AliITSTrackleterSPDEff.cxx | 4 ++-- ITS/AliITSVertexer.cxx | 4 ++-- ITS/AliITSv11GeometrySDD.cxx | 8 ++++---- ITS/AliITSv11GeometrySSD.cxx | 4 +++- 11 files changed, 35 insertions(+), 56 deletions(-) diff --git a/ITS/AliITSClusterFinderV2SSD.cxx b/ITS/AliITSClusterFinderV2SSD.cxx index 9c4c91c8edc..2d8c9716bb5 100644 --- a/ITS/AliITSClusterFinderV2SSD.cxx +++ b/ITS/AliITSClusterFinderV2SSD.cxx @@ -185,11 +185,11 @@ void AliITSClusterFinderV2SSD::FindClustersSSD(TClonesArray *alldigits) { cout<<"this is module "<fLastSSD1) layer = 5; - + */ //-------------------------------------------------------- // start 1D-clustering from the first digit in the digits array // @@ -510,9 +510,10 @@ void AliITSClusterFinderV2SSD::FindClustersSSD(AliITSRawStreamSSD* input) continue; } - Int_t layer = 4; + /* Int_t layer = 4; if (fModule>fLastSSD1) layer = 5; + */ AliITSCalibrationSSD* cal = (AliITSCalibrationSSD*)fDetTypeRec->GetCalibrationModel(fModule); if( !cal ){ @@ -1298,7 +1299,7 @@ FindClustersSSD(const Ali1Dcluster* neg, Int_t nn, // if ( (cnegative[ip]==2) && cpositive[negativepair[10*ip]]==2){ Float_t minchargediff =4.; - Float_t minchargeratio =0.2; + // Float_t minchargeratio =0.2; Int_t j=-1; for (Int_t di=0;diGetEventSpecie()]; fSDDhRawsTask = 0; @@ -615,10 +615,10 @@ Int_t AliITSQASDDDataMakerRec::InitRaws() hddl->GetYaxis()->SetTitle("DDL Number"); rv = fAliITSQADataMakerRec->Add2RawsList(hddl,fOnlineOffsetRaws+offsRW, expert, !image, !saveCorr); fSDDhRawsTask++; - Int_t indexlast1 = 0; - + + Int_t indexlast1 = 0; fTimeBinSize = 4; - indexlast = 0; + index1 = 0; indexlast1 = fSDDhRawsTask; for(Int_t moduleSDD =0; moduleSDDNext()) { - ildcID = rawReader->GetLDCId(); iddl = rawReader->GetDDLID();// - fgkDDLIDshift; if(iddl<0)isddmod=-1; //printf("----------------------iddl %i\n",iddl); diff --git a/ITS/AliITSQASPDDataMakerRec.cxx b/ITS/AliITSQASPDDataMakerRec.cxx index 5afe76defd3..933e0302b40 100644 --- a/ITS/AliITSQASPDDataMakerRec.cxx +++ b/ITS/AliITSQASPDDataMakerRec.cxx @@ -481,8 +481,8 @@ Int_t AliITSQASPDDataMakerRec::MakeRaws(AliRawReader* rawReader) Int_t chipKey; Int_t col, row; UInt_t module, colM, rowM; - Bool_t isFiredChip[1200]; - for(Int_t ichK=0; ichK<1200; ichK++) isFiredChip[ichK] = kFALSE; + // Bool_t isFiredChip[1200]; + // for(Int_t ichK=0; ichK<1200; ichK++) isFiredChip[ichK] = kFALSE; Bool_t isOnlineFiredChip[1200]; for(Int_t iOnlineKey=0; iOnlineKey<1200; iOnlineKey++) isOnlineFiredChip[iOnlineKey] = kFALSE; UInt_t nFastOr[2]={0,0}; @@ -497,7 +497,7 @@ Int_t AliITSQASPDDataMakerRec::MakeRaws(AliRawReader* rawReader) row = rawStreamSPD.GetChipRow(); isOnlineFiredChip[iEq*60+iHalfStave*10+iChip] = kTRUE; chipKey = rawStreamSPD.GetOfflineChipKeyFromOnline(iEq,iHalfStave,iChip); - isFiredChip[chipKey] = kTRUE; + // isFiredChip[chipKey] = kTRUE; rawStreamSPD.OnlineToOffline(iEq, iHalfStave, iChip, col, row, module, colM, rowM); diff --git a/ITS/AliITSRealignTracks.cxx b/ITS/AliITSRealignTracks.cxx index 8fd352dca98..ae72f00de9e 100644 --- a/ITS/AliITSRealignTracks.cxx +++ b/ITS/AliITSRealignTracks.cxx @@ -896,14 +896,14 @@ Bool_t AliITSRealignTracks::FirstAlignmentLayers(const Bool_t *layers,Int_t minN sequence->Set(nMod); - Int_t ilayer,imod; + // Int_t imod; for(Int_t iter=0;iter0&&fDraw)UpdateDraw(sequence,iter,iter); modAligned=0; for(Int_t k=0;kAt(k); - ilayer=AliGeomManager::VolUIDToLayer(voluid,imod); + // ilayer=AliGeomManager::VolUIDToLayer(voluid,imod); volIn->AddAt(voluid,0); found=0; if(!fitall){ @@ -1006,13 +1006,12 @@ Bool_t AliITSRealignTracks::FirstAlignmentSPD(Int_t minNtracks,Int_t iterations, } sequence->Set(nMod); - Int_t ilayer,imod; for(Int_t iter=0;iterAt(k); - ilayer=AliGeomManager::VolUIDToLayer(voluid,imod); + // ilayer=AliGeomManager::VolUIDToLayer(voluid,imod); volIn->AddAt(voluid,0); found=0; if(!fitall){ @@ -1112,7 +1111,7 @@ Bool_t AliITSRealignTracks::AlignVolumesITS(const TArrayI *volids, const TArrayI Double_t frac; TGeoHMatrix hM; - Double_t phiglob,smearing,rotorig[9],normplanevect[3]={0.,0.,0.},normplanevect2[3]={0.,0.,0.}; + Double_t smearing,rotorig[9],normplanevect[3]={0.,0.,0.},normplanevect2[3]={0.,0.,0.}; Double_t *deltarot; TMatrixDSym covmatrx(6); AliAlignObj *modAlign; @@ -1160,7 +1159,7 @@ Bool_t AliITSRealignTracks::AlignVolumesITS(const TArrayI *volids, const TArrayI normplanevect[2]=0.; } - phiglob=TMath::ATan2(normplanevect[1],normplanevect[0]); + // phiglob=TMath::ATan2(normplanevect[1],normplanevect[0]); modAlign=GetAlignObj(volids->At(0)); modAlign->GetMatrix(hM); @@ -1749,7 +1748,7 @@ AliAlignObjParams* AliITSRealignTracks::MediateAlignObj(const TArrayI *volIDs,In // defined by the array volIDs up to lastVolid position in this array //The aim of such a method is to look for collective movement of a given set of modules - UShort_t volid; + // UShort_t volid; TGeoHMatrix hm; Double_t *rot,*transl; @@ -1758,7 +1757,7 @@ AliAlignObjParams* AliITSRealignTracks::MediateAlignObj(const TArrayI *volIDs,In for(Int_t ivol=0;ivolAt(ivol); + // volid=volIDs->At(ivol); GetAlignObj(volIDs->At(ivol))->GetMatrix(hm); diff --git a/ITS/AliITSTPArrayFit.cxx b/ITS/AliITSTPArrayFit.cxx index 94b2d4019be..9f40b2b47c6 100644 --- a/ITS/AliITSTPArrayFit.cxx +++ b/ITS/AliITSTPArrayFit.cxx @@ -1199,7 +1199,7 @@ Bool_t AliITSTPArrayFit::FitHelixCrude(Int_t extQ) Double_t normS[3]; // // Positive t-params: along the track direction for negative track, against for positive - Double_t pcur = ptot, ecurr = etot; + // Double_t pcur = ptot, ecurr = etot; for (int ip=fFirstPosT;ipParticle(ipart); Int_t nret=0; TParticle* dau = 0; - Int_t nDau = 0; + // Int_t nDau = 0; Int_t pdgDau; Int_t firstDau = part->GetFirstDaughter(); // if no daugther stored then no way to understand i // its real fate ! But you have to take it ! if (firstDau > 0) { // if it has daugther(s) try to infer if it is "detectable" as a tracklet Int_t lastDau = part->GetLastDaughter(); - nDau = lastDau - firstDau + 1; + // nDau = lastDau - firstDau + 1; Double_t distMax=0.; Int_t jmax=0; for(Int_t j=firstDau; j<=lastDau; j++) { diff --git a/ITS/AliITSVertexer.cxx b/ITS/AliITSVertexer.cxx index 6ecff35c54f..be766592b2f 100644 --- a/ITS/AliITSVertexer.cxx +++ b/ITS/AliITSVertexer.cxx @@ -226,8 +226,8 @@ void AliITSVertexer::WriteCurrentVertex(){ fCurrentVertex->SetName("Vertex"); // const char * name = fCurrentVertex->GetName(); // itsLoader->SetVerticesContName(name); - Int_t rc = itsLoader->PostVertex(fCurrentVertex); - rc = itsLoader->WriteVertices(); + itsLoader->PostVertex(fCurrentVertex); + itsLoader->WriteVertices(); } //______________________________________________________________________ diff --git a/ITS/AliITSv11GeometrySDD.cxx b/ITS/AliITSv11GeometrySDD.cxx index 31644bbed1e..f0a601053bd 100755 --- a/ITS/AliITSv11GeometrySDD.cxx +++ b/ITS/AliITSv11GeometrySDD.cxx @@ -1913,7 +1913,7 @@ TGeoVolumeAssembly *AliITSv11GeometrySDD::CreateLadder(Int_t iLay) { cableHV[iSegment].SetInitialNode(virtualLadder); }; Double_t x1[3], x2[3], x3[3], - vY[3] = {0,1,0}, vZ[3] = {0,0,1}, vYZ[3]={0,1,1}; + vY[3] = {0,1,0}, vZ[3] = {0,0,1}; x1[0] = -fgkTransitHVtailXpos; x2[0] = -fgkTransitHVtailXpos; @@ -1940,7 +1940,7 @@ TGeoVolumeAssembly *AliITSv11GeometrySDD::CreateLadder(Int_t iLay) { cableHV[iSegment].CreateAndInsertBoxCableSegment(2,0); }; - vYZ[2] = -1; + // vYZ[2] = -1; x1[0] = fgkTransitHVtailXpos; x2[0] = fgkTransitHVtailXpos; x3[0] = fgkTransitHVtailXpos; @@ -5441,14 +5441,14 @@ TGeoVolumeAssembly *AliITSv11GeometrySDD::CreateDetectorsAssembly(Int_t iLay) { // Int_t nDetectors = fgkLay3Ndet; - Double_t ladderLength = fgkLay3LadderLength; + // Double_t ladderLength = fgkLay3LadderLength; Double_t *sensorZPos = fLay3sensorZPos; TGeoVolume *sensorSDD = fSDDsensor3; if (iLay==3) {} else if (iLay==4) { nDetectors = fgkLay4Ndet; - ladderLength = fgkLay4LadderLength; + // ladderLength = fgkLay4LadderLength; sensorZPos = fLay4sensorZPos; sensorSDD = fSDDsensor4; } else { diff --git a/ITS/AliITSv11GeometrySSD.cxx b/ITS/AliITSv11GeometrySSD.cxx index 76c8557a336..748cd970304 100644 --- a/ITS/AliITSv11GeometrySSD.cxx +++ b/ITS/AliITSv11GeometrySSD.cxx @@ -3870,8 +3870,9 @@ void AliITSv11GeometrySSD::SetLadder(){ ///////////////////////////////////////////////////////////////////////////// /// Generating Ladder Mother Volume Containing Ladder ///////////////////////////////////////////////////////////////////////////// - TGeoXtru* laddershape[fgkladdernumber]; + /* TGeoXtru* laddershape[fgkladdernumber]; for(Int_t i=0; i