From f8b1c575c252b85179e921b2e74191eaa6ce5a60 Mon Sep 17 00:00:00 2001
From: shahoian <shahoian@f7af4fe6-9843-0410-8265-dc069ae4e863>
Date: Fri, 28 Jan 2011 11:36:48 +0000
Subject: [PATCH] Coverity fixes

---
 STEER/AliLHCData.cxx      | 4 ++--
 STEER/AliLHCDipValT.h     | 4 ++--
 STEER/AliMagF.cxx         | 2 +-
 STEER/AliMinResSolve.cxx  | 2 ++
 STEER/AliMultiplicity.cxx | 4 ++--
 5 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/STEER/AliLHCData.cxx b/STEER/AliLHCData.cxx
index 25fa9682aae..9175025ba4f 100755
--- a/STEER/AliLHCData.cxx
+++ b/STEER/AliLHCData.cxx
@@ -349,7 +349,7 @@ Int_t AliLHCData::FillScalarRecord(int refs[2], const char* rec, const char* rec
     dim += 1;
   }
   //
-  Bool_t last = kFALSE;
+  // Bool_t last = kFALSE;
   while (iFirst<=iLast) {
     AliDCSArray *dcsVal = (AliDCSArray*) arr->At(iFirst++);
     double tstamp = dcsVal->GetTimeStamp();
@@ -377,7 +377,7 @@ Int_t AliLHCData::FillScalarRecord(int refs[2], const char* rec, const char* rec
     //
     fData.Add(curValF);
     refs[kNStor]++;
-    if (last) break;
+    // if (last) break;
   }
   //
   if (fFile2Process) {
diff --git a/STEER/AliLHCDipValT.h b/STEER/AliLHCDipValT.h
index 439d9eaf65b..b2413fc658d 100755
--- a/STEER/AliLHCDipValT.h
+++ b/STEER/AliLHCDipValT.h
@@ -188,9 +188,9 @@ void AliLHCDipValT<Element>::SetSize(Int_t sz)
   if (sz>0) {
     arr = new Element[sz];
     int nc = GetSizeTotal() > sz ? sz:GetSizeTotal(); // n elems to copy
-    if (nc) memcpy(arr, fArray, nc*sizeof(Element));
+    if (nc && fArray) memcpy(arr, fArray, nc*sizeof(Element));
     if (nc<sz) memset(arr+nc, 0, (sz-nc)*sizeof(Element));
-    if (GetSizeTotal()) delete[] fArray;
+    if (fArray) delete[] fArray;
     fArray = arr;
     fSizeTot = sz;
   }
diff --git a/STEER/AliMagF.cxx b/STEER/AliMagF.cxx
index e709b6ef71f..b90a5240ea5 100644
--- a/STEER/AliMagF.cxx
+++ b/STEER/AliMagF.cxx
@@ -524,7 +524,7 @@ AliMagF* AliMagF::CreateFieldMap(Float_t l3Cur, Float_t diCur, Int_t convention,
   else if (btypestr.Contains(protonBeam)) btype = kBeamTypepp;
   else AliInfoGeneral("AliMagF",Form("Assume no LHC magnet field for the beam type %s, ",beamtype));
   char ttl[80];
-  sprintf(ttl,"L3: %+5d Dip: %+4d kA; %s | Polarities in %s convention",(int)TMath::Sign(l3Cur,float(sclL3)),
+  snprintf(ttl,79,"L3: %+5d Dip: %+4d kA; %s | Polarities in %s convention",(int)TMath::Sign(l3Cur,float(sclL3)),
 	  (int)TMath::Sign(diCur,float(sclDip)),uniform ? " Constant":"",
 	  convention==kConvLHC ? "LHC":"DCS2008");
   // LHC and DCS08 conventions have opposite dipole polarities
diff --git a/STEER/AliMinResSolve.cxx b/STEER/AliMinResSolve.cxx
index b8a2b8a6f73..49d88eb11ea 100644
--- a/STEER/AliMinResSolve.cxx
+++ b/STEER/AliMinResSolve.cxx
@@ -975,6 +975,7 @@ Int_t  AliMinResSolve::PreconILUKsymb(Int_t lofM)
   delete[] jbuf;
   for(int i=fSize; i--;) if (fMatU->GetRow(i)->GetNElems()) delete[] ulvl[i]; 
   delete[] ulvl; 
+  delete[] iw;
   //
   fMatL->SortIndices();
   fMatU->SortIndices();
@@ -1101,6 +1102,7 @@ Int_t  AliMinResSolve::PreconILUKsymbDense(Int_t lofM)
   delete[] jbuf;
   for(int i=fSize; i--;) if (fMatU->GetRow(i)->GetNElems()) delete[] ulvl[i]; 
   delete[] ulvl; 
+  delete[] iw;
   //
   fMatL->SortIndices();
   fMatU->SortIndices();
diff --git a/STEER/AliMultiplicity.cxx b/STEER/AliMultiplicity.cxx
index 76e62f61749..c47bd1744b1 100644
--- a/STEER/AliMultiplicity.cxx
+++ b/STEER/AliMultiplicity.cxx
@@ -273,8 +273,8 @@ void AliMultiplicity::Duplicate(const AliMultiplicity& m){
   }
   fDPhiWindow2   = m.fDPhiWindow2;
   fDThetaWindow2 = m.fDThetaWindow2;
-  fDPhiShift     = fDPhiShift;
-  fNStdDev       = fNStdDev;
+  fDPhiShift     = m.fDPhiShift;
+  fNStdDev       = m.fNStdDev;
   fFastOrFiredChips = m.fFastOrFiredChips;
   fClusterFiredChips = m.fClusterFiredChips;
 }
-- 
2.43.0