From 0eb7227a08e64cc24007b50b40f9d1f97d65585b Mon Sep 17 00:00:00 2001
From: kleinb <kleinb@f7af4fe6-9843-0410-8265-dc069ae4e863>
Date: Sat, 12 Feb 2011 11:13:54 +0000
Subject: [PATCH] coverity fixes

---
 PWG4/JetTasks/AliAnalysisTaskThreeJets.cxx | 13 +++----
 PWG4/JetTasks/AliHistogramsUE.cxx          | 40 +++++++++++-----------
 2 files changed, 27 insertions(+), 26 deletions(-)

diff --git a/PWG4/JetTasks/AliAnalysisTaskThreeJets.cxx b/PWG4/JetTasks/AliAnalysisTaskThreeJets.cxx
index ca6ec55c60d..7b1d22be3d4 100644
--- a/PWG4/JetTasks/AliAnalysisTaskThreeJets.cxx
+++ b/PWG4/JetTasks/AliAnalysisTaskThreeJets.cxx
@@ -36,6 +36,7 @@
 #include <TMatrixDSym.h>
 #include <TMatrixDSymEigen.h>
 #include <TProfile.h>
+#include <TRandom.h>
 
 #include "AliAnalysisTaskThreeJets.h"
 #include "AliAnalysisManager.h"
@@ -680,7 +681,7 @@ void AliAnalysisTaskThreeJets::UserExec(Option_t * )
     Double_t pTrackMCAll[kTracks];
     TLorentzVector vTrackMC[kTracks];
     TVector3 pTrackMCBoost[kTracks];
-    Double_t eventShapes[4];
+    Double_t eventShapes[4] = {0,};
     
     Int_t nAccTr = 0;
     Int_t nInJet[kMaxJets];
@@ -777,10 +778,10 @@ void AliAnalysisTaskThreeJets::UserExec(Option_t * )
 	  AliAnalysisHelperJetTasks::GetEventShapes(n01MC, pTrackMC, nAllTracksMC, eventShapes);
 	  // 	}
 	  if(eventShapes[0] < 2/TMath::Pi()){
-	    Double_t eventShapesTest[4];
+	    Double_t eventShapesTest[4] = {0,};
 	    TVector3 n01Test;
 	    Int_t rnd_max = nAllTracksMC;
-	    Int_t k = (rand()%rnd_max)+3;
+	    Int_t k = (Int_t)(gRandom->Rndm()*rnd_max)+3;
 	    while(TMath::Abs(pTrackMC[k].X()) < 10e-5 && TMath::Abs(pTrackMC[k].Y()) < 10e-5){
 	      k--;
 	    }
@@ -969,7 +970,7 @@ void AliAnalysisTaskThreeJets::UserExec(Option_t * )
   Double_t * eTracks = new Double_t[kTracks];
   Double_t pTracks[kTracks];
   Int_t * idxTracks = new Int_t[kTracks];
-  Double_t eventShapesRec[4];
+  Double_t eventShapesRec[4] = {0,};
   Int_t jetMult[kMaxJets];
   //  TLorentzVector vTracksAll[kTracks];
   //  Double_t pTracksAll[kTracks];
@@ -1054,10 +1055,10 @@ void AliAnalysisTaskThreeJets::UserExec(Option_t * )
       AliAnalysisHelperJetTasks::GetEventShapes(n01, pTrack, nTracksALL, eventShapesRec);
       // 	}
       if(eventShapesRec[0] < 2/TMath::Pi()){
-	Double_t eventShapesTest[4];
+	Double_t eventShapesTest[4] = {0,};
 	TVector3 n01Test;
 	Int_t rnd_max = nTracksALL;
-	Int_t k = (rand()%rnd_max)+3;
+	Int_t k = (Int_t)(gRandom->Rndm()*rnd_max)+3;
 	while(TMath::Abs(pTrack[k].X()) < 10e-5 && TMath::Abs(pTrack[k].Y()) < 10e-5){
 	  k--;
 	}
diff --git a/PWG4/JetTasks/AliHistogramsUE.cxx b/PWG4/JetTasks/AliHistogramsUE.cxx
index 5b4083bac64..0a7e6b79f2d 100644
--- a/PWG4/JetTasks/AliHistogramsUE.cxx
+++ b/PWG4/JetTasks/AliHistogramsUE.cxx
@@ -972,15 +972,15 @@ TObjArray*  AliHistogramsUE::GetHistosForPlotting(TString data, TString branches
 	
 	TObjArray *arr=new TObjArray;
 
-	TH1F *hjets[20];		// accepted leading jets
-        TH1F *hnjets[20];          // number of accepted jets
-	TH2F *hetaphi[20];         // delta-phi particle-jet correlation
-	TH2F *hptfull[20];         // particle pT all regions vs. jet pT 
-	TH2F *hpttransv[20];       // particle pT transv. regions vs. jet pT 
-	TH1F *hmax[20];    	// sum pT in MAX region
-        TH1F *hmin[20];    	// sum pT in MIN region
-        TH1F *hmultmax[20];	// multiplicity in MAX region
-        TH1F *hmultmin[20];       // multiplicity in MIN region
+	TH1F *hjets[20]     = {0,};	  // accepted leading jets
+        TH1F *hnjets[20]    = {0,};       // number of accepted jets
+	TH2F *hetaphi[20]   = {0,};       // delta-phi particle-jet correlation
+	TH2F *hptfull[20]   = {0,};       // particle pT all regions vs. jet pT 
+	TH2F *hpttransv[20] = {0,};       // particle pT transv. regions vs. jet pT 
+	TH1F *hmax[20]      = {0,};    	  // sum pT in MAX region
+        TH1F *hmin[20]      = {0,};       // sum pT in MIN region
+        TH1F *hmultmax[20]  = {0,};	  // multiplicity in MAX region
+        TH1F *hmultmin[20]  = {0,};       // multiplicity in MIN region
 
 	for (Int_t i =0; i<br; i++){
 
@@ -1110,8 +1110,8 @@ void AliHistogramsUE::PlotBranchesUE(TString file, TString branches, Double_t mi
   TObject *o=0;
   Int_t br=0;
   while ( (o=next()) ){
-	br++;
-        }
+    br++;
+  }
   
 
   //Canvas
@@ -1119,15 +1119,15 @@ void AliHistogramsUE::PlotBranchesUE(TString file, TString branches, Double_t mi
  
   //Histograms 
   TObjArray *arrH=GetHistosForPlotting(file.Data(),branches.Data());
-  TH1F *hnjets[20];
-  TH1F *hjets[20];
-  TH1F *hmax[20];
-  TH1F *hmin[20];
-  TH1F *hmultmax[20];
-  TH1F *hmultmin[20];
-  TH2F *hetaphi[20];
-  TH2F *hptfull[20];
-  TH2F *hpttransv[20];
+  TH1F *hnjets[20] = {0,};
+  TH1F *hjets[20]  = {0,};
+  TH1F *hmax[20]   = {0,};
+  TH1F *hmin[20]   = {0,};
+  TH1F *hmultmax[20]  = {0,};
+  TH1F *hmultmin[20]  = {0,};
+  TH2F *hetaphi[20]   = {0,};
+  TH2F *hptfull[20]   = {0,};
+  TH2F *hpttransv[20] = {0,};
 
   for (Int_t i= 0; i<br; i++){
 	hnjets[i]=((TH1F*)arrH->At(9*i));
-- 
2.43.0