From b84aaa8bf0ffd8228a9f1b6d35ba9851227dd05d Mon Sep 17 00:00:00 2001 From: akisiel Date: Mon, 17 Oct 2011 10:14:59 +0000 Subject: [PATCH] Fix Coverity warnings --- .../AliFemto/AliFemtoEventReaderESDChainKine.cxx | 9 +++++++++ .../AliFemtoEventReaderKinematicsChain.cxx | 4 ++-- PWG2/FEMTOSCOPY/AliFemto/AliFemtoMCTrackCut.cxx | 13 +++++++------ PWG2/FEMTOSCOPY/AliFemtoUser/AliFemtoPairCutPt.cxx | 14 ++++++++++---- 4 files changed, 28 insertions(+), 12 deletions(-) diff --git a/PWG2/FEMTOSCOPY/AliFemto/AliFemtoEventReaderESDChainKine.cxx b/PWG2/FEMTOSCOPY/AliFemto/AliFemtoEventReaderESDChainKine.cxx index 48fb6cd809a..a49f97db5d1 100644 --- a/PWG2/FEMTOSCOPY/AliFemto/AliFemtoEventReaderESDChainKine.cxx +++ b/PWG2/FEMTOSCOPY/AliFemto/AliFemtoEventReaderESDChainKine.cxx @@ -47,6 +47,7 @@ using namespace std; AliFemtoEventReaderESDChainKine::AliFemtoEventReaderESDChainKine(): fFileName(" "), fConstrained(true), + fReadInner(false), fUseTPCOnly(false), fNumberofEvent(0), fCurEvent(0), @@ -54,6 +55,8 @@ AliFemtoEventReaderESDChainKine::AliFemtoEventReaderESDChainKine(): fEvent(0x0), fStack(0x0), fGenHeader(0x0), + fTrackType(kGlobal), + fEstEventMult(kV0Centrality), fRotateToEventPlane(0), fESDpid(0), fIsPidOwner(0) @@ -67,6 +70,7 @@ AliFemtoEventReaderESDChainKine::AliFemtoEventReaderESDChainKine(const AliFemtoE AliFemtoEventReader(aReader), fFileName(" "), fConstrained(true), + fReadInner(false), fUseTPCOnly(false), fNumberofEvent(0), fCurEvent(0), @@ -74,18 +78,23 @@ AliFemtoEventReaderESDChainKine::AliFemtoEventReaderESDChainKine(const AliFemtoE fEvent(0x0), fStack(0x0), fGenHeader(0x0), + fTrackType(kGlobal), + fEstEventMult(kV0Centrality), fRotateToEventPlane(0), fESDpid(0), fIsPidOwner(0) { // Copy constructor fConstrained = aReader.fConstrained; + fReadInner = aReader.fReadInner; fUseTPCOnly = aReader.fUseTPCOnly; fNumberofEvent = aReader.fNumberofEvent; fCurEvent = aReader.fCurEvent; fCurFile = aReader.fCurFile; fEvent = new AliESDEvent(); fStack = aReader.fStack; + fTrackType = aReader.fTrackType; + fEstEventMult = aReader.fEstEventMult; fRotateToEventPlane = aReader.fRotateToEventPlane; fESDpid = aReader.fESDpid; fIsPidOwner = aReader.fIsPidOwner; diff --git a/PWG2/FEMTOSCOPY/AliFemto/AliFemtoEventReaderKinematicsChain.cxx b/PWG2/FEMTOSCOPY/AliFemto/AliFemtoEventReaderKinematicsChain.cxx index cc90a13a3fe..a53dea430b0 100644 --- a/PWG2/FEMTOSCOPY/AliFemto/AliFemtoEventReaderKinematicsChain.cxx +++ b/PWG2/FEMTOSCOPY/AliFemto/AliFemtoEventReaderKinematicsChain.cxx @@ -141,8 +141,8 @@ AliFemtoEvent* AliFemtoEventReaderKinematicsChain::ReturnHbtEvent() hbtEvent->SetTriggerCluster(0); //Vertex - double fV1[3]; - double fVCov[6]; + double fV1[3] = {0.0,0.0,0.0}; + double fVCov[6] = {0.0, 0.0, 0.0, 0.0, 0.0, 0.0}; AliFmThreeVectorF vertex(0,0,0); diff --git a/PWG2/FEMTOSCOPY/AliFemto/AliFemtoMCTrackCut.cxx b/PWG2/FEMTOSCOPY/AliFemto/AliFemtoMCTrackCut.cxx index 21c51b08b78..49139ebde5e 100644 --- a/PWG2/FEMTOSCOPY/AliFemto/AliFemtoMCTrackCut.cxx +++ b/PWG2/FEMTOSCOPY/AliFemto/AliFemtoMCTrackCut.cxx @@ -22,6 +22,7 @@ ClassImp(AliFemtoMCTrackCut) AliFemtoMCTrackCut::AliFemtoMCTrackCut() : fCharge(0), fLabel(0), + fPDGcode(211), fNTracksPassed(0), fNTracksFailed(0) { @@ -154,17 +155,17 @@ AliFemtoString AliFemtoMCTrackCut::Report() // Prepare report from the execution string tStemp; char tCtemp[100]; - sprintf(tCtemp,"Particle mass:\t%E\n",this->Mass()); + snprintf(tCtemp,100,"Particle mass:\t%E\n",this->Mass()); tStemp=tCtemp; - sprintf(tCtemp,"Particle charge:\t%d\n",fCharge); + snprintf(tCtemp,100,"Particle charge:\t%d\n",fCharge); tStemp+=tCtemp; - sprintf(tCtemp,"Particle pT:\t%E - %E\n",fPt[0],fPt[1]); + snprintf(tCtemp,100,"Particle pT:\t%E - %E\n",fPt[0],fPt[1]); tStemp+=tCtemp; - sprintf(tCtemp,"Particle rapidity:\t%E - %E\n",fRapidity[0],fRapidity[1]); + snprintf(tCtemp,100,"Particle rapidity:\t%E - %E\n",fRapidity[0],fRapidity[1]); tStemp+=tCtemp; - sprintf(tCtemp,"Particle eta:\t%E - %E\n",fEta[0],fEta[1]); + snprintf(tCtemp,100,"Particle eta:\t%E - %E\n",fEta[0],fEta[1]); tStemp+=tCtemp; - sprintf(tCtemp,"Number of tracks which passed:\t%ld Number which failed:\t%ld\n",fNTracksPassed,fNTracksFailed); + snprintf(tCtemp,100,"Number of tracks which passed:\t%ld Number which failed:\t%ld\n",fNTracksPassed,fNTracksFailed); tStemp += tCtemp; AliFemtoString returnThis = tStemp; return returnThis; diff --git a/PWG2/FEMTOSCOPY/AliFemtoUser/AliFemtoPairCutPt.cxx b/PWG2/FEMTOSCOPY/AliFemtoUser/AliFemtoPairCutPt.cxx index ca8647099d1..eac37be591b 100644 --- a/PWG2/FEMTOSCOPY/AliFemtoUser/AliFemtoPairCutPt.cxx +++ b/PWG2/FEMTOSCOPY/AliFemtoUser/AliFemtoPairCutPt.cxx @@ -20,7 +20,9 @@ ClassImp(AliFemtoPairCutPt) AliFemtoPairCutPt::AliFemtoPairCutPt(): AliFemtoPairCut(), fSumPtMin(0), - fSumPtMax(10000) + fSumPtMax(10000), + fNPairsFailed(0), + fNPairsPassed(0) { } @@ -28,7 +30,9 @@ AliFemtoPairCutPt::AliFemtoPairCutPt(): AliFemtoPairCutPt::AliFemtoPairCutPt(double lo, double hi): AliFemtoPairCut(), fSumPtMin(lo), - fSumPtMax(hi) + fSumPtMax(hi), + fNPairsFailed(0), + fNPairsPassed(0) { fSumPtMin=lo; fSumPtMax=hi; @@ -37,7 +41,9 @@ AliFemtoPairCutPt::AliFemtoPairCutPt(double lo, double hi): AliFemtoPairCutPt::AliFemtoPairCutPt(const AliFemtoPairCutPt& c) : AliFemtoPairCut(c), fSumPtMin(0), - fSumPtMax(0) + fSumPtMax(0), + fNPairsFailed(0), + fNPairsPassed(0) { fSumPtMin = c.fSumPtMin; fSumPtMax = c.fSumPtMax; @@ -76,7 +82,7 @@ AliFemtoString AliFemtoPairCutPt::Report(){ string stemp = "AliFemtoPairCutPt Pair Cut\n"; char ctemp[100]; stemp += ctemp; - sprintf(ctemp,"Number of pairs which passed:\t%ld Number which failed:\t%ld\n",fNPairsPassed,fNPairsFailed); + snprintf(ctemp,100,"Number of pairs which passed:\t%ld Number which failed:\t%ld\n",(long int) fNPairsPassed,(long int) fNPairsFailed); stemp += ctemp; AliFemtoString returnThis = stemp; return returnThis;} -- 2.43.5