Fixes for coding conventions and coverity. Removed unnecessary calls to GetBz (Ruben)

[u/mrichter/AliRoot.git] / ITS / AliITSAlignMille2Module.cxx

diff --git a/ITS/AliITSAlignMille2Module.cxx b/ITS/AliITSAlignMille2Module.cxx
index 5d967c64b959534e8804453200887948718075fc..82475bb22ea8979516dd500c06b9592dc5c2223f 100644 (file)
--- a/ITS/AliITSAlignMille2Module.cxx
+++ b/ITS/AliITSAlignMille2Module.cxx
@@ -377,7 +377,7 @@ Bool_t AliITSAlignMille2Module::BelongsTo(AliITSAlignMille2Module* parent) const
 }\r
 \r
 //-------------------------------------------------------------\r
-TGeoHMatrix *AliITSAlignMille2Module::GetSensitiveVolumeModifiedMatrix(UShort_t voluid, Double_t *delta,Bool_t local)\r
+TGeoHMatrix *AliITSAlignMille2Module::GetSensitiveVolumeModifiedMatrix(UShort_t voluid, const Double_t *delta,Bool_t local)\r
 {\r
   // modify the original TGeoHMatrix of the sensitive module 'voluid' according\r
   // with a delta transform. applied to the supermodule matrix\r
@@ -419,7 +419,7 @@ TGeoHMatrix *AliITSAlignMille2Module::GetSensitiveVolumeModifiedMatrix(UShort_t
 }\r
 \r
 //-------------------------------------------------------------\r
-AliAlignObjParams *AliITSAlignMille2Module::GetSensitiveVolumeMisalignment(UShort_t voluid, Double_t *deltalocal)\r
+AliAlignObjParams *AliITSAlignMille2Module::GetSensitiveVolumeMisalignment(UShort_t voluid, const Double_t *deltalocal)\r
 {\r
   // calculate misalignment of sens.vol. 'voluid' according with a displacement 'deltalocal'\r
   // of the mother volume. The misalignment is returned as AliAlignObjParams object\r
@@ -444,7 +444,7 @@ AliAlignObjParams *AliITSAlignMille2Module::GetSensitiveVolumeMisalignment(UShor
 }\r
 \r
 //-------------------------------------------------------------\r
-AliAlignObjParams *AliITSAlignMille2Module::GetSensitiveVolumeMisalignment(UShort_t voluid, AliAlignObjParams *a)\r
+AliAlignObjParams *AliITSAlignMille2Module::GetSensitiveVolumeMisalignment(UShort_t voluid, const AliAlignObjParams *a)\r
 {\r
   // return the misalignment of the sens. vol. 'voluid' corresponding with \r
   // a misalignment 'a' in the mother volume\r
@@ -529,7 +529,7 @@ AliAlignObjParams *AliITSAlignMille2Module::GetSensitiveVolumeMisalignment(UShor
 \r
 // >> RS\r
 //-------------------------------------------------------------\r
-AliAlignObjParams *AliITSAlignMille2Module::GetSensitiveVolumeTotalMisalignment(UShort_t voluid, Double_t *deltalocal)\r
+AliAlignObjParams *AliITSAlignMille2Module::GetSensitiveVolumeTotalMisalignment(UShort_t voluid, const Double_t *deltalocal)\r
 {\r
   // calculate misalignment of sens.vol. 'voluid' according with a displacement 'deltalocal'\r
   // of the mother volume. The misalignment is returned as AliAlignObjParams object including\r
@@ -615,7 +615,7 @@ AliAlignObjParams *AliITSAlignMille2Module::GetSensitiveVolumeTotalMisalignment(
 //-------------------------------------------------------------\r
 \r
 //-------------------------------------------------------------\r
-AliAlignObjParams *AliITSAlignMille2Module::GetSensitiveVolumeGlobalMisalignment(UShort_t voluid, Double_t *deltalocal)\r
+AliAlignObjParams *AliITSAlignMille2Module::GetSensitiveVolumeGlobalMisalignment(UShort_t voluid, const Double_t *deltalocal)\r
 {\r
   // calculate misalignment of sens.vol. 'voluid' according with a displacement 'deltalocal'\r
   // of the mother volume. The misalignment is returned as AliAlignObjParams object\r
@@ -750,6 +750,7 @@ UShort_t AliITSAlignMille2Module::GetVolumeIDFromIndex(Int_t index) {
 //-------------------------------------------------------------\r
 void AliITSAlignMille2Module::Print(Option_t*) const \r
 {\r
+  // print data\r
   //\r
   const char* typeName[] = {"SPD","SDD","SSD"};\r
   printf("*** ITS SuperModule for AliITSAlignMille ***\n");\r
@@ -777,6 +778,7 @@ void AliITSAlignMille2Module::Print(Option_t*) const
 //-------------------------------------------------------------\r
 Bool_t AliITSAlignMille2Module::IsAlignable() const\r
 {\r
+  // it it alignable?\r
   TGeoManager* geoManager = AliGeomManager::GetGeometry();\r
   if (!geoManager) {\r
     AliInfo("Couldn't initialize geometry");\r
@@ -796,6 +798,7 @@ void AliITSAlignMille2Module::GetLocalMatrix(TGeoHMatrix &mat) const
 //-------------------------------------------------------------\r
 void AliITSAlignMille2Module::AssignDetType()\r
 {\r
+  // assign the detector type\r
   TString tp = GetName();\r
   if      (tp.Contains("SPD",TString::kIgnoreCase)) fDetType = kSPD;\r
   else if (tp.Contains("SDD",TString::kIgnoreCase)) fDetType = kSDD;\r
@@ -817,6 +820,7 @@ void AliITSAlignMille2Module::AssignDetType()
 //-------------------------------------------------------------\r
 void AliITSAlignMille2Module::EvaluateDOF()\r
 {\r
+  // count d.o.f.\r
   fNParFree = 0;\r
   for (int i=fNParTot;i--;) if (IsFreeDOF(i)) fNParFree++;\r
 }\r
@@ -843,7 +847,7 @@ void AliITSAlignMille2Module::GetSensVolLocalParams(UShort_t volid,Double_t *t,
 }\r
 \r
 //-------------------------------------------------------------\r
-void AliITSAlignMille2Module::GetSensVolGlobalParams(UShort_t volid,Double_t* loct,Double_t* locr,Double_t *t, Double_t *r)\r
+void AliITSAlignMille2Module::GetSensVolGlobalParams(UShort_t volid,const Double_t* loct, const Double_t* locr,Double_t *t, Double_t *r)\r
 {\r
   // return global parameters of the sensor volid modified by the localDelta params\r
   for (int i=3;i--;) t[i] = r[i] = 0.;\r
@@ -858,7 +862,7 @@ void AliITSAlignMille2Module::GetSensVolGlobalParams(UShort_t volid,Double_t* lo
 }\r
 \r
 //-------------------------------------------------------------\r
-void AliITSAlignMille2Module::GetSensVolLocalParams(UShort_t volid,Double_t* loct,Double_t* locr,Double_t *t, Double_t *r)\r
+void AliITSAlignMille2Module::GetSensVolLocalParams(UShort_t volid,const Double_t* loct,const Double_t* locr,Double_t *t, Double_t *r)\r
 {\r
   // return parameters of the sensor volid (modified by the localDelta params) in the current volume\r
   for (int i=3;i--;) t[i] = r[i] = 0.;\r
@@ -876,6 +880,7 @@ void AliITSAlignMille2Module::GetSensVolLocalParams(UShort_t volid,Double_t* loc
 //-------------------------------------------------------------\r
 void AliITSAlignMille2Module::SetParVals(Double_t *vl,Int_t npar)\r
 {\r
+  // set parameters\r
   for (int i=TMath::Min(npar,(Int_t)fNParTot);i--;) fParVals[i] = vl[i];\r
 }\r
 \r