Fix for coverity (AdC)

[u/mrichter/AliRoot.git] / MONITOR / root2date.cxx

diff --git a/MONITOR/root2date.cxx b/MONITOR/root2date.cxx
index 0e2f9238f5979d26e57a0aa78953d2b443097ad9..dca2afa8d8d4e3b8f24fbd4083aec17f6420734f 100644 (file)
--- a/MONITOR/root2date.cxx
+++ b/MONITOR/root2date.cxx
@@ -7,6 +7,8 @@
 
 #include "root2date.h"
 
+using std::ofstream;
+
 int Root2Date(AliRawVEvent *gdcRootEvent, unsigned char *gdcDateEvent, char *ddlDir) {
 
  unsigned char *p=gdcDateEvent;
@@ -19,7 +21,7 @@ int Root2Date(AliRawVEvent *gdcRootEvent, unsigned char *gdcDateEvent, char *ddl
  aliHeader=gdcRootEvent->GetHeader();
 
  char runNbFileName[256];
- sprintf(runNbFileName,"%s/run%u",ddlDir,aliHeader->Get("RunNb"));
+ snprintf(runNbFileName,sizeof(runNbFileName),"%s/run%u",ddlDir,aliHeader->Get("RunNb"));
  ofstream runNbFile(runNbFileName);
  runNbFile.close();
 
@@ -51,12 +53,12 @@ int Root2Date(AliRawVEvent *gdcRootEvent, unsigned char *gdcDateEvent, char *ddl
      Int_t ddlIndex;
      Int_t detId = AliDAQ::DetectorIDFromDdlID(aliEquipmentHeader->GetId(),ddlIndex);
      char ddlFileName[256];
-     sprintf(ddlFileName,"%s/%s",ddlDir,AliDAQ::DdlFileName(detId,ddlIndex));
+     snprintf(ddlFileName,sizeof(ddlFileName),"%s/%s",ddlDir,AliDAQ::DdlFileName(detId,ddlIndex));
      FILE *ddlFile;
      if((ddlFile=fopen(ddlFileName, "wb"))) {
        fwrite(p, chunkSize, 1, ddlFile);
+       fclose(ddlFile);
      }
-     fclose(ddlFile);
    }
    p+=chunkSize;
   }