Fixes for coverity

[u/mrichter/AliRoot.git] / PMD / AliPMDcell.cxx

diff --git a/PMD/AliPMDcell.cxx b/PMD/AliPMDcell.cxx
index b9f5982b30d568edddc194a8ed8c56fc7c90c0f3..b24866cf9675f31c0e39070cc44ea6b127099a35 100644 (file)
--- a/PMD/AliPMDcell.cxx
+++ b/PMD/AliPMDcell.cxx
@@ -27,47 +27,59 @@
 
 ClassImp(AliPMDcell)
 
-AliPMDcell::AliPMDcell()
+AliPMDcell::AliPMDcell():
+  fTrNumber(0),
+  fSMNumber(0),
+  fXpos(0),
+  fYpos(0),
+  fEdep(0.)
 {
   // Standard constructor
-  fTrNumber = 0;
-  fSMNumber = 0;
-  fXpos     = 0;
-  fYpos     = 0;
-  fEdep     = 0.;
 }
 
 AliPMDcell::AliPMDcell(Int_t trnumber, Int_t smnumber, 
-                        Int_t xpos, Int_t ypos, Float_t edep)
+                      Int_t xpos, Int_t ypos, Float_t edep):
+  fTrNumber(trnumber),
+  fSMNumber(smnumber),
+  fXpos(xpos),
+  fYpos(ypos),
+  fEdep(edep)
 {
   // Constructor
-  fTrNumber = trnumber;
-  fSMNumber = smnumber;
-  fXpos     = xpos;
-  fYpos     = ypos;
-  fEdep     = edep;
+}
 
+AliPMDcell::AliPMDcell(AliPMDcell *pmdcell):
+  fTrNumber(0),
+  fSMNumber(0),
+  fXpos(0),
+  fYpos(0),
+  fEdep(0.)
+{
+  *this = *pmdcell;
 }
 
-AliPMDcell::AliPMDcell(const AliPMDcell& source):TObject(source) {
+AliPMDcell::AliPMDcell(const AliPMDcell& source):
+  TObject(source),
+  fTrNumber(source.fTrNumber),
+  fSMNumber(source.fSMNumber),
+  fXpos(source.fXpos),
+  fYpos(source.fYpos),
+  fEdep(source.fEdep)
+{
   //Copy Constructor 
-  if(&source == this) return;
-  this->fTrNumber = source.fTrNumber;
-  this->fSMNumber = source.fSMNumber;
-  this->fXpos = source.fXpos;
-  this->fYpos = source.fYpos;
-  this->fEdep = source.fEdep;
-  return;
 }
 
-AliPMDcell& AliPMDcell::operator=(const AliPMDcell& source) {
+AliPMDcell& AliPMDcell::operator=(const AliPMDcell& source)
+{
   //Copy Constructor 
-  if(&source == this) return *this;
-  this->fTrNumber = source.fTrNumber;
-  this->fSMNumber = source.fSMNumber;
-  this->fXpos = source.fXpos;
-  this->fYpos = source.fYpos;
-  this->fEdep = source.fEdep;
+  if(this != &source)
+    {
+      fTrNumber = source.fTrNumber;
+      fSMNumber = source.fSMNumber;
+      fXpos = source.fXpos;
+      fYpos = source.fYpos;
+      fEdep = source.fEdep;
+    }
   return *this;
 }