]> git.uio.no Git - u/mrichter/AliRoot.git/commit - FMD/CMakelibFMDutil.pkg
Fixed coding convention issues as given by the automatic
authorcholm <cholm@f7af4fe6-9843-0410-8265-dc069ae4e863>
Wed, 16 Mar 2011 12:13:22 +0000 (12:13 +0000)
committercholm <cholm@f7af4fe6-9843-0410-8265-dc069ae4e863>
Wed, 16 Mar 2011 12:13:22 +0000 (12:13 +0000)
commit09b6c8043c3cef03baab361e86fca592262c4f35
treeb38a8294b09f981f969d0c31fec6c92c1fc2fe1e
parente090fd3236a197ff18f374747e962d9844937050
Fixed coding convention issues as given by the automatic
rule checker in a mail from the 3rd of march, 2011.

All issues fixed, except

- FMD/AliFMDParameters.cxx:832
Rule RC19: In parameters of a method, objects that are passed
by pointer or by reference and that are not modified should be
declared const.  Violation: Parameter declaration UShort_t&
det in method AliFMDParameters::Hardware2Detector can be
declared as const type & param

+ This is a false negative - which is obvious from the code

- FMD/AliFMDReconstructor.cxx:332
Rule RC19: In parameters of a method, objects that are passed
by pointer or by reference and that are not modified should be
declared const.  Violation: Parameter declaration AliRawReader
reader in method AliFMDReconstructor::Digitize can be declared
as const type param

+ Again, this is a false negative, since the AliRawReader object _is_
  modified - the state is changed

- FMD/AliFMDHitDigitizer.cxx:213
Rule RC19: In parameters of a method, objects that are passed
by pointer or by reference and that are not modified should be
declared const.  Violation: Parameter declaration AliFMD fmd
in method AliFMDHitDigitizer::AliFMDHitDigitizer can be
declared as const type param

+ Again, false negative.  The member fFMD is assigned to the passed
  parameter and this is indeed modified several times throughout the
  life time of the AliFMDHitDigitizer object.

- FMD/AliFMD3.cxx:123
Rule RC19: In parameters of a method, objects that are passed
by pointer or by reference and that are not modified should be
declared const.  Violation: Parameter declaration Option_t opt
in method AliFMD3::ConeR can be declared as const type param

+ False negative.  Strange actually, since typedef const char Option_t

- FMD/AliFMDBaseDigitizer.cxx:605
Rule RC19: In parameters of a method, objects that are passed
by pointer or by reference and that are not modified should be
declared const.  Violation: Parameter declaration AliLoader
loader in method AliFMDBaseDigitizer::StoreDigits can be
declared as const type param

+ Again, false negative.

- FMD/AliFMDSpectraDisplay.cxx:237
Rule RC19: In parameters of a method, objects that are passed
by pointer or by reference and that are not modified should be
declared const.  Violation: Parameter declaration
TGListTreeItem entry in method
AliFMDSpectraDisplay::AliFMDSpectraDisplayTop::HandleEntry can
be declared as const type param

+ This cannot be changed, since the call back from ROOT does not allow
  that.
96 files changed:
FMD/AliFMDAlignFaker.cxx
FMD/AliFMDAlignFaker.h
FMD/AliFMDAltroMapping.cxx
FMD/AliFMDAltroMapping.h
FMD/AliFMDAnaESD.cxx [deleted file]
FMD/AliFMDAnaESD.h [deleted file]
FMD/AliFMDAnaRing.cxx [deleted file]
FMD/AliFMDAnaRing.h [deleted file]
FMD/AliFMDBackgroundCorrection.cxx [deleted file]
FMD/AliFMDBackgroundCorrection.h [deleted file]
FMD/AliFMDBaseDA.cxx
FMD/AliFMDBaseDA.h
FMD/AliFMDBaseDigit.cxx
FMD/AliFMDBaseDigitizer.cxx
FMD/AliFMDBaseDigitizer.h
FMD/AliFMDCalibFaker.cxx
FMD/AliFMDCalibFaker.h
FMD/AliFMDCalibFwd.h [new file with mode: 0644]
FMD/AliFMDCalibPedestal.cxx
FMD/AliFMDCalibPedestal.h
FMD/AliFMDDigit.cxx
FMD/AliFMDDigit.h
FMD/AliFMDDigitizer.cxx
FMD/AliFMDDigitizer.h
FMD/AliFMDDisplay.cxx
FMD/AliFMDDisplay.h
FMD/AliFMDFancy.cxx
FMD/AliFMDFancy.h
FMD/AliFMDGainDA.cxx
FMD/AliFMDGeometry.cxx
FMD/AliFMDGeometry.h
FMD/AliFMDGeometryBuilder.cxx
FMD/AliFMDGeometryBuilder.h
FMD/AliFMDHitDigitizer.cxx
FMD/AliFMDHitDigitizer.h
FMD/AliFMDParameters.cxx
FMD/AliFMDParameters.h
FMD/AliFMDPattern.cxx
FMD/AliFMDPattern.h
FMD/AliFMDPedestalDA.cxx
FMD/AliFMDPreprocessor.cxx
FMD/AliFMDPreprocessor.h
FMD/AliFMDQADataMakerRec.cxx
FMD/AliFMDQADataMakerRec.h
FMD/AliFMDQADataMakerSim.h
FMD/AliFMDRawReader.cxx
FMD/AliFMDRawReader.h
FMD/AliFMDRawWriter.cxx
FMD/AliFMDRecoParam.cxx
FMD/AliFMDRecoParam.h
FMD/AliFMDReconstructor.cxx
FMD/AliFMDSDigit.cxx
FMD/AliFMDSDigit.h
FMD/AliFMDSpectraDisplay.cxx
FMD/AliFMDSpectraDisplay.h
FMD/AliFMDSurveyToAlignObjs.cxx
FMD/AliFMDSurveyToAlignObjs.h
FMD/CMakelibFMDbase.pkg
FMD/CMakelibFMDflow.pkg [deleted file]
FMD/CMakelibFMDrec.pkg
FMD/CMakelibFMDsim.pkg
FMD/CMakelibFMDutil.pkg
FMD/FMDutilLinkDef.h
FMD/TODO
FMD/flow/AliFMDFlowAxis.cxx [deleted file]
FMD/flow/AliFMDFlowAxis.h [deleted file]
FMD/flow/AliFMDFlowBessel.cxx [deleted file]
FMD/flow/AliFMDFlowBessel.h [deleted file]
FMD/flow/AliFMDFlowBin.cxx [deleted file]
FMD/flow/AliFMDFlowBin.h [deleted file]
FMD/flow/AliFMDFlowBinned1D.cxx [deleted file]
FMD/flow/AliFMDFlowBinned1D.h [deleted file]
FMD/flow/AliFMDFlowBinned2D.cxx [deleted file]
FMD/flow/AliFMDFlowBinned2D.h [deleted file]
FMD/flow/AliFMDFlowEfficiency.cxx [deleted file]
FMD/flow/AliFMDFlowEfficiency.h [deleted file]
FMD/flow/AliFMDFlowEventPlane.cxx [deleted file]
FMD/flow/AliFMDFlowEventPlane.h [deleted file]
FMD/flow/AliFMDFlowHarmonic.cxx [deleted file]
FMD/flow/AliFMDFlowHarmonic.h [deleted file]
FMD/flow/AliFMDFlowResolution.cxx [deleted file]
FMD/flow/AliFMDFlowResolution.h [deleted file]
FMD/flow/AliFMDFlowSplitter.cxx [deleted file]
FMD/flow/AliFMDFlowSplitter.h [deleted file]
FMD/flow/AliFMDFlowStat.h [deleted file]
FMD/flow/AliFMDFlowTrue.cxx [deleted file]
FMD/flow/AliFMDFlowTrue.h [deleted file]
FMD/flow/AliFMDFlowUtil.h [deleted file]
FMD/flow/FMDflowLinkDef.h [deleted file]
FMD/flow/TestBessel.C [deleted file]
FMD/flow/TestFlow.C [deleted file]
FMD/flow/TestFlowSimple.C [deleted file]
FMD/scripts/AliFMDAnaBg.C [deleted file]
FMD/scripts/AliFMDAnaFlow.C [deleted file]
FMD/scripts/AliFMDAnaFlowKine.C [deleted file]
FMD/scripts/AliFMDAnaFlowRing.h [deleted file]