Coding violations

diff --git a/HMPID/AliHMPIDCluster.cxx b/HMPID/AliHMPIDCluster.cxx
index 0d857dc..dfdcce5 100644 (file)
--- a/HMPID/AliHMPIDCluster.cxx
+++ b/HMPID/AliHMPIDCluster.cxx
@@ -76,7 +76,7 @@ void AliHMPIDCluster::Draw(Option_t*)
   TMarker *pMark=new TMarker(X(),Y(),5); pMark->SetUniqueID(fSt);pMark->SetMarkerColor(kBlue); pMark->Draw();
 }
 //++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
-void AliHMPIDCluster::FitFunc(Int_t &iNpars, Double_t* /*deriv*/, Double_t &chi2, Double_t *par, Int_t )
+void AliHMPIDCluster::FitFunc(Int_t &iNpars, Double_t* /*deriv*/, Double_t &chi2, Double_t *par, Int_t /* */)
 {
 // Cluster fit function 
 // par[0]=x par[1]=y par[2]=q for the first Mathieson shape

diff --git a/HMPID/AliHMPIDCluster.h b/HMPID/AliHMPIDCluster.h
index 19f621b..f0b5945 100644 (file)
--- a/HMPID/AliHMPIDCluster.h
+++ b/HMPID/AliHMPIDCluster.h
@@ -3,6 +3,13 @@
 /* Copyright(c) 1998-1999, ALICE Experiment at CERN, All rights reserved. *
  * See cxx source for full Copyright notice                               */
 //
+// Implementation class: AliHMPIDCluster
+//   
+//   class to reconstruct clester in HMPID
+//   it is forseen to Solve (split) the raw cluster in 
+//   several clusters (# local maxima in the raw cluster -> deconvolution
+//   according to a Mathieson profile of the charge 
+//
 #include "AliHMPIDDigit.h"  //DigAdd()
 #include <TObjArray.h>     //DigAdd()      
 class TClonesArray;        //Solve()
@@ -28,7 +35,7 @@ public:
 //framework part                   
          void           Draw   (Option_t *opt=""                                  );                       //overloaded TObject::Print() to draw cluster in current canvas
          void           Print  (Option_t *opt=""                                  )const;                  //overloaded TObject::Print() to print cluster info
-  static void           FitFunc(Int_t &, Double_t *, Double_t &, Double_t *, Int_t);                       //fit function to be used by MINUIT
+  static void           FitFunc(Int_t &iNpars, Double_t* /*deriv*/, Double_t &chi2, Double_t *par, Int_t /* */);//fit function to be used by MINUIT
 //private part  
          Int_t          Box      (                                         )const{return fBox;                                  }
          void           CoG      (                                         );                                                      //calculates center of gravity

diff --git a/HMPID/AliHMPIDDigit.h b/HMPID/AliHMPIDDigit.h
index f539ce7..b9d28be 100644 (file)
--- a/HMPID/AliHMPIDDigit.h
+++ b/HMPID/AliHMPIDDigit.h
@@ -4,13 +4,12 @@
  * See cxx source for full Copyright notice                               */
 
 // Class of HMPID to manage digits ---> pads
-//
-//
-
+//.
+//.
+//.
 
 #include <AliDigit.h>      //base class  
 #include "TMath.h"         //Mathieson()
-#include "TRandom.h"       //IsOverTh()  
 #include <AliBitPacking.h> //Raw()
 
 
@@ -86,11 +85,11 @@ protected:                                                                   //A
   static const Float_t fgkMinPcY[6];                                                                                                   //limits PC
   static const Float_t fgkMaxPcX[6];                                                                                                   //limits PC
   static const Float_t fgkMaxPcY[6];                                                                                                   //limits PC
-  static const Float_t fgk1;                                                 //Mathieson parameters
-  static const Float_t fgk2;                                                 //
-  static const Float_t fgkSqrtK3;                                            //
-  static const Float_t fgk4;                                                 //
-  Int_t    fPad;                                                             //absolute pad number
+  static const Float_t fgk1;                                                                                                           //Mathieson parameters
+  static const Float_t fgk2;                                                                                                           //...
+  static const Float_t fgkSqrtK3;                                                                                                      //...
+  static const Float_t fgk4;                                                                                                           //...
+  Int_t    fPad;                                                                                                                       //absolute pad number
   Float_t  fQ;                                                               //QDC value, fractions are permitted for summable procedure  
   ClassDef(AliHMPIDDigit,4)                                                  //HMPID digit class       
 };//class AliHMPIDDigit

diff --git a/HMPID/AliHMPIDDigitizer.cxx b/HMPID/AliHMPIDDigitizer.cxx
index 56d62b5..ff2be6c 100644 (file)
--- a/HMPID/AliHMPIDDigitizer.cxx
+++ b/HMPID/AliHMPIDDigitizer.cxx
@@ -12,18 +12,21 @@
  * about the suitability of this software for any purpose. It is          *
  * provided "as is" without express or implied warranty.                  *
  **************************************************************************/
-//
-//
-//
-//
-#include "AliHMPIDDigitizer.h"
-#include "AliHMPIDDigit.h"
-#include "AliHMPID.h"
+//.
+//.
+//.
+//.
+//.
+#include <AliRun.h>
 #include <AliRunLoader.h>
 #include "AliRunDigitizer.h"
 #include <AliLoader.h>
 #include <AliLog.h>
+#include "AliHMPIDDigitizer.h"
+#include "AliHMPIDDigit.h"
+#include "AliHMPID.h"
 
+#include <TRandom.h>
 
 ClassImp(AliHMPIDDigitizer)
 
@@ -58,7 +61,8 @@ void AliHMPIDDigitizer::Exec(Option_t*)
   
   AliRunLoader *pOutRunLoader  = AliRunLoader::GetRunLoader(fManager->GetOutputFolderName());    //open output stream (only 1 possible)
   AliLoader    *pOutRichLoader = pOutRunLoader->GetLoader("HMPIDLoader");                         //take output HMPID loader
-  AliHMPID      *pOutRich       = (AliHMPID*)pOutRunLoader->GetAliRun()->GetDetector("HMPID");      //take output HMPID
+  AliRun *pArun = pOutRunLoader->GetAliRun();
+  AliHMPID      *pOutRich       = (AliHMPID*)pArun->GetDetector("HMPID");      //take output HMPID
   pOutRichLoader->MakeTree("D");   pOutRich->MakeBranch("D");                                    //create TreeD in output stream
 
   Sdi2Dig(&sdigs,pOutRich->DigLst());
@@ -78,7 +82,8 @@ void AliHMPIDDigitizer::Sdi2Dig(TClonesArray *pSdiLst,TObjArray *pDigLst)
 //   Returns: none  
   
   TClonesArray *pLst[7]; Int_t iCnt[7];
-  
+
+  TRandom *rnd = new TRandom();  
   for(Int_t i=0;i<7;i++){
     pLst[i]=(TClonesArray*)(*pDigLst)[i];
     iCnt[i]=0; if(pLst[i]->GetEntries()!=0) AliErrorClass("Some of digits lists is not empty");         //in principle those lists should be empty                                                                       
@@ -90,7 +95,7 @@ void AliHMPIDDigitizer::Sdi2Dig(TClonesArray *pSdiLst,TObjArray *pDigLst)
     for (Int_t iCh=AliHMPIDDigit::kMinCh;iCh<=AliHMPIDDigit::kMaxCh;iCh++)
       for (Int_t iPc=AliHMPIDDigit::kMinPc;iPc<=AliHMPIDDigit::kMaxPc;iPc++)
         for(Int_t iPx=AliHMPIDDigit::kMinPx;iPx<=AliHMPIDDigit::kMaxPx;iPx++)
-          for(Int_t iPy=AliHMPIDDigit::kMinPy;iPy<=AliHMPIDDigit::kMaxPy;iPy++) arrNoise[iCh][iPc][iPx][iPy] = gRandom->Gaus(0,1);
+          for(Int_t iPy=AliHMPIDDigit::kMinPy;iPy<=AliHMPIDDigit::kMaxPy;iPy++) arrNoise[iCh][iPc][iPx][iPy] = rnd->Gaus(0,1);
   }  
   
   pSdiLst->Sort();  

diff --git a/HMPID/AliHMPIDDigitizer.h b/HMPID/AliHMPIDDigitizer.h
index 1795dca..68d5451 100644 (file)
--- a/HMPID/AliHMPIDDigitizer.h
+++ b/HMPID/AliHMPIDDigitizer.h
@@ -2,11 +2,12 @@
 #define AliHMPIDDigitizer_h
 /* Copyright(c) 1998-2000, ALICE Experiment at CERN, All rights reserved. *
  * See cxx source for full Copyright notice                               */
-//
+//.
+//.
+//.
 
-#include <AliRun.h>
 #include <AliDigitizer.h>
-class AliRunDigitizer;
+
 class TClonesArray;
 class TObjArray;
 

diff --git a/HMPID/AliHMPIDHit.h b/HMPID/AliHMPIDHit.h
index 225a45a..942a762 100644 (file)
--- a/HMPID/AliHMPIDHit.h
+++ b/HMPID/AliHMPIDHit.h
@@ -5,9 +5,10 @@
 
 #include <AliHit.h>           //base class
 #include <TVector3.h>         //ctor
-#include <TRandom.h>          //QdcTot()
 #include "AliHMPIDDigit.h"    //QdcTot() 
 
+#include <TRandom.h>
+
 class AliHMPIDHit : public AliHit //   TObject-AliHit-AliHMPIDHit
 {
 public: