Coverity fixes etc.
authorcholm <cholm@f7af4fe6-9843-0410-8265-dc069ae4e863>
Tue, 18 Dec 2012 09:58:39 +0000 (09:58 +0000)
committercholm <cholm@f7af4fe6-9843-0410-8265-dc069ae4e863>
Tue, 18 Dec 2012 09:58:39 +0000 (09:58 +0000)
FMD/AliFMDBaseDA.cxx
FMD/AliFMDReconstructor.cxx
FMD/TODO

index 83fb7b4..e37f9ea 100644 (file)
@@ -157,7 +157,10 @@ AliFMDBaseDA::AliFMDBaseDA() :
   fSummaries(0)
 {
   //Constructor
-  fSeenDetectors[0] = fSeenDetectors[1] = fSeenDetectors[2] = kFALSE;
+  for(Int_t i = 0; i< 3;i++) {
+    fSeenDetectors[i] = false;
+    fNEventsPerDetector[i] = 0;
+  }
   fDetectorArray.SetOwner();
   Rotate("conditions.csv", 3);
   fConditionsFile.open("conditions.csv");
@@ -179,12 +182,12 @@ AliFMDBaseDA::AliFMDBaseDA(const AliFMDBaseDA & baseDA) :
   fSummaries(0)
 {
   //Copy constructor
-  fSeenDetectors[0] = baseDA.fSeenDetectors[0];
-  fSeenDetectors[1] = baseDA.fSeenDetectors[1];
-  fSeenDetectors[2] = baseDA.fSeenDetectors[2];
+  for(Int_t i = 0; i< 3;i++) {
+    fSeenDetectors[i] = baseDA.fSeenDetectors[0];
+    fNEventsPerDetector[i] = baseDA.fNEventsPerDetector[i];
+  }
 
-  fDetectorArray.SetOwner();
-  
+  fDetectorArray.SetOwner();  
 }
 
 
index 6cd8065..b898217 100644 (file)
@@ -166,7 +166,7 @@ AliFMDReconstructor::Init()
     fDiagAll    = new TH2F("diagAll",    "Read ADC vs Multiplicity deduced", 
                           1024, -.5, 1023.5, 100, -.1, 19.9);
   }
-  if (!fDiagAll) {
+  if (fDiagAll) {
     fDiagAll->SetDirectory(0);
     fDiagAll->GetXaxis()->SetTitle("ADC (read)");
     fDiagAll->GetYaxis()->SetTitle("Multiplicity");
index 9ee14d7..08f7dc9 100644 (file)
--- a/FMD/TODO
+++ b/FMD/TODO
@@ -1,9 +1,4 @@
        Things to do in the FMD offline code
        ------------------------------------
-* Code clean up 
-- Fix Coverity warnings, errors, ... 
 
-* Alignment
-- Waiting for a fix by Andrei when aligning nodes inside a two nested
-   assemblies