coverity defects

diff --git a/CORRFW/AliCFAcceptanceCuts.cxx b/CORRFW/AliCFAcceptanceCuts.cxx
index c972366..179080c 100644 (file)
--- a/CORRFW/AliCFAcceptanceCuts.cxx
+++ b/CORRFW/AliCFAcceptanceCuts.cxx
@@ -240,10 +240,10 @@ void AliCFAcceptanceCuts::DefineHistograms() {
     fhCutCorrelation->GetYaxis()->SetBinLabel(k,fhCutStatistics->GetXaxis()->GetBinLabel(k));
   }
 
-  Char_t str[256];
+  Char_t str[5];
   for (int i=0; i<kNStepQA; i++) {
-    if (i==0) sprintf(str," ");
-    else sprintf(str,"_cut");
+    if (i==0) snprintf(str,5," ");
+    else snprintf(str,5,"_cut");
     fhQA[kCutHitsITS] [i] = new TH1F(Form("%s_HitsITS%s"  ,GetName(),str),"",10,0,10);
     fhQA[kCutHitsTPC] [i] = new TH1F(Form("%s_HitsTPC%s"  ,GetName(),str),"",5,0,5);
     fhQA[kCutHitsTRD] [i] = new TH1F(Form("%s_HitsTRD%s"  ,GetName(),str),"",20,0,20);
@@ -260,6 +260,10 @@ void AliCFAcceptanceCuts::FillHistograms(TObject* obj, Bool_t afterCuts)
   // fill the QA histograms
   //
   AliMCParticle* part = dynamic_cast<AliMCParticle *>(obj);
+  if (!part) {
+    AliError("casting failed");
+    return;
+  }
 
   Int_t nHitsITS=0, nHitsTPC=0, nHitsTRD=0, nHitsTOF=0, nHitsMUON=0 ;
   for (Int_t iTrackRef=0; iTrackRef<part->GetNumberOfTrackReferences(); iTrackRef++) {

diff --git a/CORRFW/AliCFEventClassCuts.cxx b/CORRFW/AliCFEventClassCuts.cxx
index ed3ee23..f312cfb 100644 (file)
--- a/CORRFW/AliCFEventClassCuts.cxx
+++ b/CORRFW/AliCFEventClassCuts.cxx
@@ -334,10 +334,10 @@ void AliCFEventClassCuts::TriggerBitMap(AliVEvent* ev, TBits *bitmapT ) {
   }  
   
   // book QA histograms
-  Char_t str[256];
+  Char_t str[5];
   for (Int_t i=0; i<kNStepQA; i++) {
-    if (i==0) sprintf(str," ");
-    else sprintf(str,"_cut");
+    if (i==0) snprintf(str,5," ");
+    else snprintf(str,5,"_cut");
 
     fhQA[kTrigger][i]  = new  TH1F(Form("%s_TriggerBits%s",GetName(),str),                     "",23,-0.5,22.5);
     fhQA[kZDCEnergyN1][i]      = new  TH1F(Form("%s_ZDC_Energy_N1%s",GetName(),str),           "",800,-500,7500);

diff --git a/CORRFW/AliCFEventGenCuts.cxx b/CORRFW/AliCFEventGenCuts.cxx
index e26cae9..cddebf5 100644 (file)
--- a/CORRFW/AliCFEventGenCuts.cxx
+++ b/CORRFW/AliCFEventGenCuts.cxx
@@ -235,8 +235,9 @@ Bool_t AliCFEventGenCuts::IsMBProcType(AliMCEvent *ev, PrType iproc){
       if ( process==94)
        return kTRUE;
     }
+  default: return kFALSE;
   }
-
+  
   return kFALSE;     
 }
  //____________________________________________________________________________

diff --git a/CORRFW/AliCFEventRecCuts.cxx b/CORRFW/AliCFEventRecCuts.cxx
index 25daa4b..b0a43cf 100644 (file)
--- a/CORRFW/AliCFEventRecCuts.cxx
+++ b/CORRFW/AliCFEventRecCuts.cxx
@@ -365,10 +365,10 @@ void AliCFEventRecCuts::SetHistogramBins(Int_t index, Int_t nbins, Double_t xmin
   
   // book QA histograms
 
-  Char_t str[256];
+  Char_t str[5];
   for (Int_t i=0; i<kNStepQA; i++) {
-    if (i==0) sprintf(str," ");
-    else sprintf(str,"_cut");
+    if (i==0) snprintf(str,5," ");
+    else snprintf(str,5,"_cut");
 
     fhQA[kNTracks][i]  = new  TH1F(Form("%s_NTracks%s",GetName(),str),                 "",501,-0.5,500.5);
     fhQA[kVtxPosX][i]  = new  TH1F(Form("%s_Vtx_Pos_X%s",GetName(),str),               "",100,-5.,5.);

diff --git a/CORRFW/AliCFPairAcceptanceCuts.cxx b/CORRFW/AliCFPairAcceptanceCuts.cxx
index 6637965..80b01fe 100755 (executable)
--- a/CORRFW/AliCFPairAcceptanceCuts.cxx
+++ b/CORRFW/AliCFPairAcceptanceCuts.cxx
@@ -122,14 +122,16 @@ void AliCFPairAcceptanceCuts::SelectionBitMap(TObject* obj)
 
   for (UInt_t i=0; i<kNCuts; i++) fBitmap->SetBitNumber(i,kFALSE);
 
-  if (!obj) return;
-  TString className(obj->ClassName());
+  AliMCParticle* mcpart = dynamic_cast<AliMCParticle*>(obj) ;
+
+  if (!mcpart) return;
+  TString className(mcpart->ClassName());
   if (className.CompareTo("AliMCParticle") != 0) {
     AliError("obj must point to an AliMCParticle !");
     return ;
   }
 
-  TParticle* part = (dynamic_cast<AliMCParticle*>(obj))->Particle() ;
+  TParticle* part = mcpart->Particle() ;
   if (!part || part->GetNDaughters() !=2) return ;
 
   Int_t lab0 = part->GetDaughter(0);

diff --git a/CORRFW/AliCFPairIsPrimaryCuts.cxx b/CORRFW/AliCFPairIsPrimaryCuts.cxx
index d73a735..fbded3d 100755 (executable)
--- a/CORRFW/AliCFPairIsPrimaryCuts.cxx
+++ b/CORRFW/AliCFPairIsPrimaryCuts.cxx
@@ -76,15 +76,14 @@ Bool_t AliCFPairIsPrimaryCuts::IsSelected(TObject* obj) {
   // loops over decisions of single cuts and returns if the track is accepted
   //
 
-  if (!obj) return kFALSE ;
-  TString className(obj->ClassName());
+  AliCFPair* pair = dynamic_cast<AliCFPair*>(obj);
+  if (!pair) return kFALSE ;
+  TString className(pair->ClassName());
   if (className.CompareTo("AliCFPair") != 0) {
     Error("IsSelected","obj must point to a AliCFPair !");
     return kFALSE ;
   }
 
-  AliCFPair* pair = dynamic_cast<AliCFPair*>(obj);
-
   AliVParticle* tneg = pair->GetNeg();
   AliVParticle* tpos = pair->GetPos();
   if (!tneg || !tpos) return kFALSE ;

diff --git a/CORRFW/AliCFPairPidCut.cxx b/CORRFW/AliCFPairPidCut.cxx
index d18bfd5..a566592 100755 (executable)
--- a/CORRFW/AliCFPairPidCut.cxx
+++ b/CORRFW/AliCFPairPidCut.cxx
@@ -74,15 +74,14 @@ Bool_t AliCFPairPidCut::IsSelected(TObject* obj) {
   // loops over decisions of single cuts and returns if the track is accepted
   //
 
-  if (!obj) return kFALSE ;
-  TString className(obj->ClassName());
+  AliCFPair* pair = dynamic_cast<AliCFPair*>(obj);
+  if (!pair) return kFALSE ;
+  TString className(pair->ClassName());
   if (className.CompareTo("AliCFPair") != 0) {
     Error("IsSelected","obj must point to a AliCFPair !");
     return kFALSE ;
   }
 
-  AliCFPair* pair = dynamic_cast<AliCFPair*>(obj);
-
   AliVParticle* tneg = pair->GetNeg();
   AliVParticle* tpos = pair->GetPos();
 

diff --git a/CORRFW/AliCFPairQualityCuts.cxx b/CORRFW/AliCFPairQualityCuts.cxx
index dbc18bd..c28035d 100755 (executable)
--- a/CORRFW/AliCFPairQualityCuts.cxx
+++ b/CORRFW/AliCFPairQualityCuts.cxx
@@ -75,15 +75,14 @@ Bool_t AliCFPairQualityCuts::IsSelected(TObject* obj) {
   // loops over decisions of single cuts and returns if the track is accepted
   //
 
-  if (!obj) return kFALSE ;
-  TString className(obj->ClassName());
+  AliCFPair* pair = dynamic_cast<AliCFPair*>(obj);
+  if (!pair) return kFALSE ;
+  TString className(pair->ClassName());
   if (className.CompareTo("AliCFPair") != 0) {
     Error("IsSelected","obj must point to a AliCFPair !");
     return kFALSE ;
   }
 
-  AliCFPair* pair = dynamic_cast<AliCFPair*>(obj);
-
   AliVParticle* tneg = pair->GetNeg();
   AliVParticle* tpos = pair->GetPos();
   if (!tneg || !tpos) return kFALSE ;

diff --git a/CORRFW/AliCFParticleGenCuts.cxx b/CORRFW/AliCFParticleGenCuts.cxx
index b66f4e7..3e3a5cc 100644 (file)
--- a/CORRFW/AliCFParticleGenCuts.cxx
+++ b/CORRFW/AliCFParticleGenCuts.cxx
@@ -455,11 +455,25 @@ void AliCFParticleGenCuts::SelectionBitMap(AliAODMCParticle* mcPart)
   Double32_t decayRxy=0.;
 
   AliAODEvent* aod = dynamic_cast<AliAODEvent*>(fMCInfo);
+  
+  if (!aod) {
+    AliError("AOD event casting failed");
+    return;
+  }
+  
   TClonesArray* mcArray = dynamic_cast<TClonesArray*>(aod->FindListObject(AliAODMCParticle::StdBranchName()));
+  if (!mcArray) {
+    AliError("array casting failed");
+    return;
+  }
   AliAODMCParticle* daughter = 0x0 ;
 
   if (mcPart->GetDaughter(0)>0) {
     daughter = dynamic_cast<AliAODMCParticle*>(mcArray->At(mcPart->GetDaughter(0)));
+    if (!daughter) {
+      AliError("daughter casting failed");
+      return;
+    }
 
     decayVx=(Double32_t)daughter->Xv();
     decayVy=(Double32_t)daughter->Yv();
@@ -660,10 +674,10 @@ void AliCFParticleGenCuts::DefineHistograms() {
     fhCutCorrelation->GetYaxis()->SetBinLabel(k,fhCutStatistics->GetXaxis()->GetBinLabel(k));
   }
 
-  Char_t str[256];
+  Char_t str[5];
   for (int i=0; i<kNStepQA; i++) {
-    if (i==0) sprintf(str," ");
-    else sprintf(str,"_cut");
+    if (i==0) snprintf(str,5," ");
+    else snprintf(str,5,"_cut");
     fhQA[kCutCharge]      [i] = new TH1F(Form("%s_charge%s"      ,GetName(),str),"",2,0,2);
     fhQA[kCutPrimSec]     [i] = new TH1F(Form("%s_primSec%s"     ,GetName(),str),"",2,0,2);
     fhQA[kCutPDGCode]     [i] = new TH1F(Form("%s_pdgCode%s"     ,GetName(),str),"",2,0,2);