Changes suggested by Effective C++ (F.Carminati)

diff --git a/CONTAINERS/AliClassInfo.h b/CONTAINERS/AliClassInfo.h
index 5b99901b122bd161de3883e1bd8a21254d73f319..4f0850e6d6b0f257c4cde77588343864b02da78a 100644 (file)
--- a/CONTAINERS/AliClassInfo.h
+++ b/CONTAINERS/AliClassInfo.h
@@ -23,7 +23,7 @@ class TDataType;
 
 class AliClassInfo : public TNamed { 
 public:   
-  AliClassInfo(){;}
+  AliClassInfo() : fSize(0) {}
   virtual ~AliClassInfo(){;}
   virtual void CTORBuffer(void * /*pointer*/, UInt_t /*size=1*/){;}
     //  {return (*ctorbuffer)(p,size);}

diff --git a/CONTAINERS/TArrayOfArray.h b/CONTAINERS/TArrayOfArray.h
index cc98a21a0d3f07db484af7a7177a155b104d1f73..36a664b3b84d4b57693d7de9dcf48cd14260d6fd 100644 (file)
--- a/CONTAINERS/TArrayOfArray.h
+++ b/CONTAINERS/TArrayOfArray.h
@@ -43,6 +43,10 @@ public:
   Int_t ArraySize(){ return fArray->GetSize();}
   virtual Int_t GetSize(){return (fIndex) ?(Int_t)fIndex->GetSize()-1:0;}
 private:
+
+  TArrayOfArrayVStack(const TArrayOfArrayVStack & taa);
+  TArrayOfArrayVStack & operator=(const TArrayOfArrayVStack & taa);
+
   AliObjectArray * fIndex;
   AliObjectArray * fArray;
   ClassDef(TArrayOfArrayVStack,1) 

diff --git a/MUON/AliMUONTransientDigit.cxx b/MUON/AliMUONTransientDigit.cxx
index 5d22b7e3cabfaf291b951abec07bcf4b53b82863..1ae3889d8c4c2bd145e052d4331148528cd9236b 100644 (file)
--- a/MUON/AliMUONTransientDigit.cxx
+++ b/MUON/AliMUONTransientDigit.cxx
@@ -24,18 +24,16 @@
 ClassImp(AliMUONTransientDigit)
 
 //____________________________________________________________________________
-AliMUONTransientDigit::AliMUONTransientDigit()
-  : AliMUONDigit()
+AliMUONTransientDigit::AliMUONTransientDigit() :
+  fChamber(0),
+  fTrackList(0)
 {
-// Constructor
-
-  fTrackList=0;
+  // Default constructor
 }
  
 //____________________________________________________________________________
-
-  AliMUONTransientDigit::AliMUONTransientDigit(const AliMUONTransientDigit& digit)
-    : AliMUONDigit(digit)
+AliMUONTransientDigit::AliMUONTransientDigit(const AliMUONTransientDigit& digit) :
+  AliMUONDigit(digit)
 {
 // Protected copy constructor
 
@@ -43,15 +41,15 @@ AliMUONTransientDigit::AliMUONTransientDigit()
 }
 
 
-AliMUONTransientDigit::AliMUONTransientDigit(Int_t ich, Int_t *digits): 
-    AliMUONDigit(digits)
+AliMUONTransientDigit::AliMUONTransientDigit(Int_t ich, Int_t *digits) : 
+  AliMUONDigit(digits),
+  fChamber(ich),
+  fTrackList(new TObjArray(5))
+  // 5 is arbitrary number, just to decrease default 16
 {
-    //
-    // Creates a MUON digit list object
-    //
-    fChamber     = ich;
-    fTrackList   = new TObjArray(5);   
-    // 5 is arbitrary number, just to decrease default 16
+  //
+  // Creates a MUON digit list object
+  //
 }
 
 ////////////////////////////////////////////////////////////////////////

diff --git a/TPC/AliTPCTrackHits.cxx b/TPC/AliTPCTrackHits.cxx
index ce1576b1e36a0f8f20aa9ab4506d1ed3517b8c29..c7096b30ca8583b58a5ff859a48eb6fdfbae1158 100644 (file)
--- a/TPC/AliTPCTrackHits.cxx
+++ b/TPC/AliTPCTrackHits.cxx
@@ -260,7 +260,35 @@ void   AliTPCTempHitInfo::Fit(AliTrackHitsParam * param)
   
 }
 
+//______________________________________________________________________
+AliTrackHitsInfo::AliTrackHitsInfo() : 
+  fTrackID(0),
+  fVolumeID(0),
+  fHitParamIndex(0)
+{
+  //
+  // Default constructor
+  //
+  fgCounter1++;
+  fgCounter2++;
+}
 
+//______________________________________________________________________
+AliTrackHitsParam::AliTrackHitsParam() :
+  fR(0),
+  fZ(0),
+  fFi(0),
+  fAn(0),
+  fAd(0),
+  fTheta(0),
+  fThetaD(0)
+{
+  //
+  // Default constructor
+  //
+  fgCounter1++;
+  fgCounter2++;
+}
 
 
 AliTPCTrackHits::AliTPCTrackHits()

diff --git a/TPC/AliTPCTrackHits.h b/TPC/AliTPCTrackHits.h
index 071c135f8df232956e4c2b7567e95495d4b39dce..0fb54e91684891b40827d81d308f2a36ea66f6a2 100644 (file)
--- a/TPC/AliTPCTrackHits.h
+++ b/TPC/AliTPCTrackHits.h
@@ -22,10 +22,12 @@ class AliObjectArray;
 class AliTrackHitsInfo   {
   friend  class  AliTPCTrackHits;
   friend class   AliTPC;
+
  public:
-  AliTrackHitsInfo(){fgCounter1++;fgCounter2++;}
+  AliTrackHitsInfo();
   ~AliTrackHitsInfo(){fgCounter1--;}
- private:  
+ 
+private:  
   Int_t   fTrackID;  //track ID
   Int_t   fVolumeID;   //volume ID
   UInt_t   fHitParamIndex; //corresponding index  
@@ -40,7 +42,7 @@ class AliTrackHitsParam {
   friend  class  AliTPCTrackHits;
   friend  class  AliTPCTempHitInfo;
  public:
-  AliTrackHitsParam(){fgCounter1++;fgCounter2++;}
+  AliTrackHitsParam();
   ~AliTrackHitsParam(){fgCounter1--;}
  private:
   Float_t fR;  //radius
@@ -61,7 +63,7 @@ class AliHitInfo {
   friend  class  AliTPCTrackHits;
   friend  class  AliTPCTempHitInfo;
 public:
-  AliHitInfo(){fgCounter1++;fgCounter2++;}
+  AliHitInfo() : fHitDistance(0), fCharge(0) {fgCounter1++;fgCounter2++;}
   ~AliHitInfo(){fgCounter1--;}
  private:
   Short_t fHitDistance; //distance to previous hit