Coding convention

diff --git a/PHOS/AliPHOS.h b/PHOS/AliPHOS.h
index eb915b9f337b420dce7cbe7b26b1cefc4e0ee63d..849bd4a143354787c02ce6045f902f75a93b584c 100644 (file)
--- a/PHOS/AliPHOS.h
+++ b/PHOS/AliPHOS.h
@@ -29,6 +29,11 @@ class AliPHOS : public AliDetector {
   AliPHOS() : AliDetector() {
     // default ctor
   } 
   AliPHOS() : AliDetector() {
     // default ctor
   } 

+  AliPHOS(const AliPHOS & phos) {
+    // cpy ctor: no implementation yet
+    // requested by the Coding Convention
+    assert(0==1) ; 
+  }

   virtual ~AliPHOS() ; 
  
   virtual  void              CreateMaterials() ;                     // defines the material of the detector
   virtual ~AliPHOS() ; 
  
   virtual  void              CreateMaterials() ;                     // defines the material of the detector


@@ -48,8 +53,14 @@ class AliPHOS : public AliDetector {
     return fTrackSegments ;
   }
   virtual TString Version() {return TString(" ") ; } 
     return fTrackSegments ;
   }
   virtual TString Version() {return TString(" ") ; } 

-
-
+ 
+  AliPHOS & operator = (const AliPHOS & rvalue)  {
+    // assignement operator requested by coding convention
+    // but not needed
+    assert(0==1) ;
+    return *this ; 
+  }
+ 

  protected:
   
   AliPHOSRecPoint::RecPointsList * fEmcRecPoints ;         // The RecPoints (clusters) list in EMC 
  protected:
   
   AliPHOSRecPoint::RecPointsList * fEmcRecPoints ;         // The RecPoints (clusters) list in EMC 

diff --git a/PHOS/AliPHOSPIDv1.cxx b/PHOS/AliPHOSPIDv1.cxx
index a82e25989ae038875e5e664f55d7d28d267acec1..8a0d43c0a9e50d15abadf2d7d484c3d0d75ca5c1 100644 (file)
--- a/PHOS/AliPHOSPIDv1.cxx
+++ b/PHOS/AliPHOSPIDv1.cxx
@@ -48,9 +48,9 @@ void  AliPHOSPIDv1::MakeParticles(AliPHOSTrackSegment::TrackSegmentsList * trsl,
   Int_t index = 0 ; 
   AliPHOSRecParticle * rp ; 
   Int_t type ; 
   Int_t index = 0 ; 
   AliPHOSRecParticle * rp ; 
   Int_t type ; 

-  Int_t shower_profile;  // 0 narrow and 1 wide
-  Int_t cpv_detector;  // 1 hit and 0 no hit
-  Int_t pc_detector;  // 1 hit and 0 no hit
+  Int_t showerprofile;  // 0 narrow and 1 wide
+  Int_t cpvdetector;  // 1 hit and 0 no hit
+  Int_t pcdetector;  // 1 hit and 0 no hit

 
   while ( (tracksegment = (AliPHOSTrackSegment *)next()) ) {
     new( (*rpl)[index] ) AliPHOSRecParticle(tracksegment) ;
 
   while ( (tracksegment = (AliPHOSTrackSegment *)next()) ) {
     new( (*rpl)[index] ) AliPHOSRecParticle(tracksegment) ;


@@ -61,18 +61,24 @@ void  AliPHOSPIDv1::MakeParticles(AliPHOSTrackSegment::TrackSegmentsList * trsl,
 
  // Looking at the lateral development of the shower
     if ( ( lambda[0] > fLambda1m && lambda[0] < fLambda1M ) && // shower profile cut
 
  // Looking at the lateral development of the shower
     if ( ( lambda[0] > fLambda1m && lambda[0] < fLambda1M ) && // shower profile cut

-        ( lambda[1] > fLambda2m && lambda[1] < fLambda2M ) )         shower_profile = 0 ;   // NARROW PROFILE   
-    else      shower_profile = 1 ;// WIDE PROFILE
+        ( lambda[1] > fLambda2m && lambda[1] < fLambda2M ) )         
+      showerprofile = 0 ;   // NARROW PROFILE   
+    else      
+      showerprofile = 1 ;// WIDE PROFILE

   
     // Looking at the photon conversion detector
   
     // Looking at the photon conversion detector

-    if( tracksegment->GetPpsdLowRecPoint() == 0 )   pc_detector = 0;  // No hit
-    else      pc_detector = 1;  // hit
+    if( tracksegment->GetPpsdLowRecPoint() == 0 )   
+      pcdetector = 0 ;  // No hit
+    else      
+      pcdetector = 1 ;  // hit

   
     // Looking at the photon conversion detector
   
     // Looking at the photon conversion detector

-    if( tracksegment->GetPpsdUpRecPoint() == 0 )         cpv_detector = 0;  // No hit
-    else      cpv_detector = 1;  // Hit
+    if( tracksegment->GetPpsdUpRecPoint() == 0 )
+      cpvdetector = 0 ;  // No hit
+    else  
+      cpvdetector = 1 ;  // Hit

      
      

-    type = shower_profile + 2*pc_detector + 4*cpv_detector;
+    type = showerprofile + 2 * pcdetector + 4 * cpvdetector ;

     rp->SetType(type) ; 
     index++ ; 
   }
     rp->SetType(type) ; 
     index++ ; 
   }

diff --git a/PHOS/AliPHOSReconstructioner.cxx b/PHOS/AliPHOSReconstructioner.cxx
index 765bf4a4a721135b420136dc72533fc8009af42a..73574f1065ecd50285321cb2df2e3d6fc72752a7 100644 (file)
--- a/PHOS/AliPHOSReconstructioner.cxx
+++ b/PHOS/AliPHOSReconstructioner.cxx
@@ -58,6 +58,8 @@ AliPHOSReconstructioner::AliPHOSReconstructioner(AliPHOSClusterizer * Clusterize
                                                 AliPHOSTrackSegmentMaker * Tracker,
                                                 AliPHOSPID * Pid)
 {
                                                 AliPHOSTrackSegmentMaker * Tracker,
                                                 AliPHOSPID * Pid)
 {

+  // Initialisation
+

   fClusterizer        = Clusterizer ;
   fTrackSegmentMaker  = Tracker ;
   fPID                = Pid ; 
   fClusterizer        = Clusterizer ;
   fTrackSegmentMaker  = Tracker ;
   fPID                = Pid ; 

diff --git a/PHOS/AliPHOSReconstructioner.h b/PHOS/AliPHOSReconstructioner.h
index 95ea469f3ef9f33cae5626658d850657efd8f860..45934e995cf8153a8e0af7a63030846b7b7ecb0c 100644 (file)
--- a/PHOS/AliPHOSReconstructioner.h
+++ b/PHOS/AliPHOSReconstructioner.h
@@ -30,7 +30,13 @@ public:
 
   AliPHOSReconstructioner(){} //ctor            
   AliPHOSReconstructioner(AliPHOSClusterizer * Clusterizer, AliPHOSTrackSegmentMaker * Tracker, 
 
   AliPHOSReconstructioner(){} //ctor            
   AliPHOSReconstructioner(AliPHOSClusterizer * Clusterizer, AliPHOSTrackSegmentMaker * Tracker, 

-                         AliPHOSPID * Identifier); //ctor            
+                         AliPHOSPID * Identifier); //ctor         
+  AliPHOSReconstructioner(const AliPHOSReconstructioner & phos) {
+    // cpy ctor: no implementation yet
+    // requested by the Coding Convention
+    assert(0==1) ; 
+  }
+   

   ~AliPHOSReconstructioner(){} // dtor
 
   AliPHOSClusterizer * GetClusterizer() { return fClusterizer ; }
   ~AliPHOSReconstructioner(){} // dtor
 
   AliPHOSClusterizer * GetClusterizer() { return fClusterizer ; }


@@ -44,6 +50,13 @@ public:
 
   void SetDebugReconstruction(Bool_t deb) { fDebugReconstruction = deb; }
 
 
   void SetDebugReconstruction(Bool_t deb) { fDebugReconstruction = deb; }
 

+  AliPHOSReconstructioner & operator = (const AliPHOSReconstructioner & rvalue)  {
+    // assignement operator requested by coding convention
+    // but not needed
+    assert(0==1) ;
+    return *this ; 
+  }
+  

 
 private:
   
 
 private:
   

diff --git a/PHOS/AliPHOSTrackSegmentMakerv1.h b/PHOS/AliPHOSTrackSegmentMakerv1.h
index 7e4244cd1906e8b2a58db7dc51a56f622db14b1e..15a90faa356b9cc5d516530ba96c2866ba8eeeb4 100644 (file)
--- a/PHOS/AliPHOSTrackSegmentMakerv1.h
+++ b/PHOS/AliPHOSTrackSegmentMakerv1.h
@@ -30,6 +30,12 @@ class  AliPHOSTrackSegmentMakerv1 : public AliPHOSTrackSegmentMaker {
 public:
 
   AliPHOSTrackSegmentMakerv1() ;                     
 public:
 
   AliPHOSTrackSegmentMakerv1() ;                     

+  AliPHOSTrackSegmentMakerv1(const AliPHOSTrackSegmentMakerv1 & tsm) {
+    // cpy ctor: no implementation yet
+    // requested by the Coding Convention
+    assert(0==1) ; 
+  }
+   

   virtual ~ AliPHOSTrackSegmentMakerv1() ; // dtor
   
   Bool_t  FindFit(AliPHOSEmcRecPoint * emcRP, int * MaxAt, Float_t * maxAtEnergy, 
   virtual ~ AliPHOSTrackSegmentMakerv1() ; // dtor
   
   Bool_t  FindFit(AliPHOSEmcRecPoint * emcRP, int * MaxAt, Float_t * maxAtEnergy, 


@@ -68,6 +74,13 @@ public:
                       TObjArray * emclist) ; //Unfolds overlaping clusters using TMinuit package
   virtual void UnsetUnfoldFlag() { fUnfoldFlag = kFALSE ; } 
 
                       TObjArray * emclist) ; //Unfolds overlaping clusters using TMinuit package
   virtual void UnsetUnfoldFlag() { fUnfoldFlag = kFALSE ; } 
 

+  AliPHOSTrackSegmentMakerv1 & operator = (const AliPHOSTrackSegmentMakerv1 & rvalue)  {
+    // assignement operator requested by coding convention
+    // but not needed
+    assert(0==1) ;
+    return *this ; 
+  }
+

 private:
 
   Float_t fDelta ;     // parameter used for sorting
 private:
 
   Float_t fDelta ;     // parameter used for sorting

diff --git a/PHOS/AliPHOSv0.h b/PHOS/AliPHOSv0.h
index 0cdfa0960e8758b548b2e5595f32b0aa4e9307f4..aba2f919662d4c141c0453d8e4e7b8fdb0d9e148 100644 (file)
--- a/PHOS/AliPHOSv0.h
+++ b/PHOS/AliPHOSv0.h
@@ -26,6 +26,12 @@ public:
   AliPHOSv0(void) ;
   AliPHOSv0(const char *name, const char *title="") ;
   AliPHOSv0(AliPHOSReconstructioner * Reconstructioner, const char *name, const char *title="") ;
   AliPHOSv0(void) ;
   AliPHOSv0(const char *name, const char *title="") ;
   AliPHOSv0(AliPHOSReconstructioner * Reconstructioner, const char *name, const char *title="") ;

+  AliPHOSv0(const AliPHOSv0 & phos) {
+    // cpy ctor: no implementation yet
+    // requested by the Coding Convention
+    assert(0==1) ; 
+  }
+ 

   virtual ~AliPHOSv0(void) ;
 
   virtual void   AddHit( Int_t primary, Int_t id, Float_t *hits ) ; // adds a pre-digitilized hit to the hit tree 
   virtual ~AliPHOSv0(void) ;
 
   virtual void   AddHit( Int_t primary, Int_t id, Float_t *hits ) ; // adds a pre-digitilized hit to the hit tree 


@@ -55,6 +61,13 @@ public:
   virtual void   StepManager(void) ;                                // does the tracking through PHOS and a preliminary digitalization
   virtual TString Version(void){ return TString("v0"); }
 
   virtual void   StepManager(void) ;                                // does the tracking through PHOS and a preliminary digitalization
   virtual TString Version(void){ return TString("v0"); }
 

+  AliPHOSv0 & operator = (const AliPHOSv0 & rvalue)  {
+    // assignement operator requested by coding convention
+    // but not needed
+    assert(0==1) ;
+    return *this ; 
+  }
+

 protected:
 
   Float_t fDigitThreshold ;                       // Threshold for the digit registration 
 protected:
 
   Float_t fDigitThreshold ;                       // Threshold for the digit registration 

diff --git a/PHOS/AliPHOSvFast.h b/PHOS/AliPHOSvFast.h
index 56f1c6927833ae1c4bb8122d4d109bbb73ccd3c2..da7a6a5634590007ca00187dac8d3031d051edc3 100644 (file)
--- a/PHOS/AliPHOSvFast.h
+++ b/PHOS/AliPHOSvFast.h
@@ -30,6 +30,11 @@ public:
 
   AliPHOSvFast(void) ;
   AliPHOSvFast(const char *name, const char *title="") ;
 
   AliPHOSvFast(void) ;
   AliPHOSvFast(const char *name, const char *title="") ;

+  AliPHOSvFast(const AliPHOSvFast & fast) {
+    // cpy ctor: no implementation yet
+    // requested by the Coding Convention
+    assert(0==1) ; 
+  }

   virtual ~AliPHOSvFast(void) ;
 
   void           AddRecParticle(const AliPHOSFastRecParticle & rp) ; // adds primary particle to the RecParticles list
   virtual ~AliPHOSvFast(void) ;
 
   void           AddRecParticle(const AliPHOSFastRecParticle & rp) ; // adds primary particle to the RecParticles list


@@ -53,6 +58,13 @@ public:
   Double_t     SigmaE(Double_t energy) ;    // calulates the energy resolution at a given Energy                           
   Double_t     SigmaP(Double_t energy, Int_t inc) ; // calulates the position resolution at a given Energy at a given incidence                           
   virtual void StepManager(void) ;          // does the tracking through PHOS and a preliminary digitalization
   Double_t     SigmaE(Double_t energy) ;    // calulates the energy resolution at a given Energy                           
   Double_t     SigmaP(Double_t energy, Int_t inc) ; // calulates the position resolution at a given Energy at a given incidence                           
   virtual void StepManager(void) ;          // does the tracking through PHOS and a preliminary digitalization

+
+  AliPHOSvFast & operator = (const AliPHOSvFast & rvalue)  {
+    // assignement operator requested by coding convention
+    // but not needed
+    assert(0==1) ;
+    return *this ; 
+  }

   
 private:
   
   
 private: