Coverity

diff --git a/ITS/AliITSAlignMille2Module.cxx b/ITS/AliITSAlignMille2Module.cxx
index 82475bb22ea8979516dd500c06b9592dc5c2223f..9cc63ef6fce1825b8051e26860a00ae9b7de8aab 100644 (file)
--- a/ITS/AliITSAlignMille2Module.cxx
+++ b/ITS/AliITSAlignMille2Module.cxx
@@ -211,7 +211,8 @@ AliITSAlignMille2Module& AliITSAlignMille2Module::operator=(const AliITSAlignMil
   fDetType = m.fDetType;\r
   fVolumeID=m.fVolumeID;\r
   fNParTot  = m.fNParTot;\r
-  fNParFree = m.fNParFree;\r
+  fNParFree = m.fNParFree; \r
+  fNProcPoints = m.fNProcPoints; \r
   delete[] fParVals; fParVals = 0;\r
   delete[] fParErrs; fParErrs = 0;\r
   delete[] fParCstr; fParCstr = 0;\r
@@ -229,7 +230,7 @@ AliITSAlignMille2Module& AliITSAlignMille2Module::operator=(const AliITSAlignMil
   //\r
   fParOffs.Set(fNParTot);\r
   for (int i=0;i<fNParTot;i++) fParOffs[i] = m.fParOffs[i];\r
-  for (int i=3;i--;) fSigmaFactor[i] = m.fSigmaFactor[i];\r
+  for (int i=0;i<3;i++) fSigmaFactor[i] = m.fSigmaFactor[i];\r
   if (fMatrix) delete fMatrix;\r
   fMatrix=new TGeoHMatrix(*m.GetMatrix());\r
   fSensVolIndex = m.fSensVolIndex;\r

diff --git a/ITS/AliITSQASDDChecker.cxx b/ITS/AliITSQASDDChecker.cxx
index b2335db34c18e59ddeb9e7f205203db190b178d5..02f2ce4fad08b2013b392867c6dfbc7897e32666 100644 (file)
--- a/ITS/AliITSQASDDChecker.cxx
+++ b/ITS/AliITSQASDDChecker.cxx
@@ -74,14 +74,6 @@ fSubDetOffset(0),
 }          // ctor
 
 
-//__________________________________________________________________
-AliITSQASDDChecker& AliITSQASDDChecker::operator = (const AliITSQASDDChecker& qac ) 
-{
-  // Equal operator.
-  this->~AliITSQASDDChecker();
-  new(this) AliITSQASDDChecker(qac);
-  return *this;
-}
 
 AliITSQASDDChecker::~AliITSQASDDChecker() 
 {

diff --git a/ITS/AliITSQASDDChecker.h b/ITS/AliITSQASDDChecker.h
index 8f3bcb79b74856ec31fcbcaec6d61925a5c2886b..3f35d46b76283644378035af82e8b5cdfcd07e3f 100644 (file)
--- a/ITS/AliITSQASDDChecker.h
+++ b/ITS/AliITSQASDDChecker.h
@@ -38,7 +38,6 @@ class AliITSQASDDChecker: public TObject{
 public:
 
   AliITSQASDDChecker();  // ctor
-  AliITSQASDDChecker& operator = (const AliITSQASDDChecker& qac) ; //operator =
   virtual ~AliITSQASDDChecker(); // dtor
   virtual Double_t Check(AliQAv1::ALITASK_t index, const TObjArray * list, const AliDetectorRecoParam * recoParam);
   virtual void SetTaskOffset(Int_t taskoffset);
@@ -55,18 +54,8 @@ public:
 
  private:
   
-  AliITSQASDDChecker(const AliITSQASDDChecker& qac):TObject(),
-    fSubDetOffset(qac.fSubDetOffset),
-    fStepBitSDD(qac.fStepBitSDD),
-    fLowSDDValue(qac.fLowSDDValue),
-    fHighSDDValue(qac.fHighSDDValue),
-    fCalibration(qac.fCalibration),
-    fThresholdForRelativeOccupancy(qac.fThresholdForRelativeOccupancy),
-    fThresholdForRecToRawRatio(qac.fThresholdForRecToRawRatio),
-    fImage(qac.fImage),
-    fESforCheck(qac.fESforCheck) 
-      {;} // cpy ctor   
-
+  AliITSQASDDChecker(const AliITSQASDDChecker& qac); 
+  AliITSQASDDChecker& operator = (const AliITSQASDDChecker& qac) ; 
     Int_t fSubDetOffset;            // checking operation starting point
     Double_t *fStepBitSDD;          //step size for each QAbit(kINFO, kWARNING,kERROR,kFATAL)
     Float_t *fLowSDDValue;          //low value of each QA bit range