Coverity fixes

diff --git a/STEER/AliLHCData.cxx b/STEER/AliLHCData.cxx
index 25fa9682aae49403c01d651493d0c25e8aabf55a..9175025ba4f9139231b3aff4dc4737e97aec6f94 100755 (executable)
--- a/STEER/AliLHCData.cxx
+++ b/STEER/AliLHCData.cxx
@@ -349,7 +349,7 @@ Int_t AliLHCData::FillScalarRecord(int refs[2], const char* rec, const char* rec
     dim += 1;\r
   }\r
   //\r
-  Bool_t last = kFALSE;\r
+  // Bool_t last = kFALSE;\r
   while (iFirst<=iLast) {\r
     AliDCSArray *dcsVal = (AliDCSArray*) arr->At(iFirst++);\r
     double tstamp = dcsVal->GetTimeStamp();\r
@@ -377,7 +377,7 @@ Int_t AliLHCData::FillScalarRecord(int refs[2], const char* rec, const char* rec
     //\r
     fData.Add(curValF);\r
     refs[kNStor]++;\r
-    if (last) break;\r
+    // if (last) break;\r
   }\r
   //\r
   if (fFile2Process) {\r

diff --git a/STEER/AliLHCDipValT.h b/STEER/AliLHCDipValT.h
index 439d9eaf65bd5765cbcac71c3ae7d43872c73b86..b2413fc658d3a077a4b1110cd33ed84e6834b38c 100755 (executable)
--- a/STEER/AliLHCDipValT.h
+++ b/STEER/AliLHCDipValT.h
@@ -188,9 +188,9 @@ void AliLHCDipValT<Element>::SetSize(Int_t sz)
   if (sz>0) {
     arr = new Element[sz];
     int nc = GetSizeTotal() > sz ? sz:GetSizeTotal(); // n elems to copy
-    if (nc) memcpy(arr, fArray, nc*sizeof(Element));
+    if (nc && fArray) memcpy(arr, fArray, nc*sizeof(Element));
     if (nc<sz) memset(arr+nc, 0, (sz-nc)*sizeof(Element));
-    if (GetSizeTotal()) delete[] fArray;
+    if (fArray) delete[] fArray;
     fArray = arr;
     fSizeTot = sz;
   }

diff --git a/STEER/AliMagF.cxx b/STEER/AliMagF.cxx
index e709b6ef71f3408e96346e2c1902be93ed86bcd2..b90a5240ea547e467acd84dcb7d68bf38a6d5cc3 100644 (file)
--- a/STEER/AliMagF.cxx
+++ b/STEER/AliMagF.cxx
@@ -524,7 +524,7 @@ AliMagF* AliMagF::CreateFieldMap(Float_t l3Cur, Float_t diCur, Int_t convention,
   else if (btypestr.Contains(protonBeam)) btype = kBeamTypepp;
   else AliInfoGeneral("AliMagF",Form("Assume no LHC magnet field for the beam type %s, ",beamtype));
   char ttl[80];
-  sprintf(ttl,"L3: %+5d Dip: %+4d kA; %s | Polarities in %s convention",(int)TMath::Sign(l3Cur,float(sclL3)),
+  snprintf(ttl,79,"L3: %+5d Dip: %+4d kA; %s | Polarities in %s convention",(int)TMath::Sign(l3Cur,float(sclL3)),
          (int)TMath::Sign(diCur,float(sclDip)),uniform ? " Constant":"",
          convention==kConvLHC ? "LHC":"DCS2008");
   // LHC and DCS08 conventions have opposite dipole polarities

diff --git a/STEER/AliMinResSolve.cxx b/STEER/AliMinResSolve.cxx
index b8a2b8a6f73bf173a7652208fb1f9a78ebf89d6e..49d88eb11ea246b77d0d7b01b21f160bf0d7349c 100644 (file)
--- a/STEER/AliMinResSolve.cxx
+++ b/STEER/AliMinResSolve.cxx
@@ -975,6 +975,7 @@ Int_t  AliMinResSolve::PreconILUKsymb(Int_t lofM)
   delete[] jbuf;
   for(int i=fSize; i--;) if (fMatU->GetRow(i)->GetNElems()) delete[] ulvl[i]; 
   delete[] ulvl; 
+  delete[] iw;
   //
   fMatL->SortIndices();
   fMatU->SortIndices();
@@ -1101,6 +1102,7 @@ Int_t  AliMinResSolve::PreconILUKsymbDense(Int_t lofM)
   delete[] jbuf;
   for(int i=fSize; i--;) if (fMatU->GetRow(i)->GetNElems()) delete[] ulvl[i]; 
   delete[] ulvl; 
+  delete[] iw;
   //
   fMatL->SortIndices();
   fMatU->SortIndices();

diff --git a/STEER/AliMultiplicity.cxx b/STEER/AliMultiplicity.cxx
index 76e62f61749c5a30e12ac15c98dc75783c7350ba..c47bd1744b1d9c131d5cf0a5c8f010a8c7f8a239 100644 (file)
--- a/STEER/AliMultiplicity.cxx
+++ b/STEER/AliMultiplicity.cxx
@@ -273,8 +273,8 @@ void AliMultiplicity::Duplicate(const AliMultiplicity& m){
   }
   fDPhiWindow2   = m.fDPhiWindow2;
   fDThetaWindow2 = m.fDThetaWindow2;
-  fDPhiShift     = fDPhiShift;
-  fNStdDev       = fNStdDev;
+  fDPhiShift     = m.fDPhiShift;
+  fNStdDev       = m.fNStdDev;
   fFastOrFiredChips = m.fFastOrFiredChips;
   fClusterFiredChips = m.fClusterFiredChips;
 }