From: richterm <richterm@f7af4fe6-9843-0410-8265-dc069ae4e863>
Date: Mon, 24 Sep 2007 10:10:24 +0000 (+0000)
Subject: bugfix: calculate correct time bin width after setting of time bin range
X-Git-Url: http://git.uio.no/git/?p=u%2Fmrichter%2FAliRoot.git;a=commitdiff_plain;h=42a3bb889228a0d3eb9d83ab60dd4f790593359e

bugfix: calculate correct time bin width after setting of time bin range
---

diff --git a/HLT/TPCLib/AliHLTTPCTransform.cxx b/HLT/TPCLib/AliHLTTPCTransform.cxx
index 339dda2dafc..bc015fa4cde 100644
--- a/HLT/TPCLib/AliHLTTPCTransform.cxx
+++ b/HLT/TPCLib/AliHLTTPCTransform.cxx
@@ -1823,6 +1823,10 @@ Bool_t AliHLTTPCTransform::Sector2Slice(Int_t & slice, Int_t & slicerow, Int_t s
 Double_t AliHLTTPCTransform::GetMaxY(Int_t slicerow)
 {
   //get maximum y value (for slice 0)
+  if (slicerow>=fgNRow) {
+    LOG(AliHLTTPCLog::kError,"AliHLTTPCTransform::GetMaxY","Slicerow")
+      <<AliHLTTPCLog::kDec<<"slicerow out of range"<<slicerow<<ENDLOG;
+  }
  if(slicerow < fgNRowLow)
      return fgPadPitchWidthLow*fgNPads[slicerow]/2; 
  
@@ -1882,12 +1886,17 @@ void AliHLTTPCTransform::Raw2Local(Float_t *xyz,Int_t sector,Int_t row,Float_t p
   //Transformation from rawdata to local coordinate system
   
   Int_t slice,slicerow;
-  Sector2Slice(slice, slicerow, sector, row);  
+  if (Sector2Slice(slice, slicerow, sector, row)==kFALSE) return;
 
   //X-Value
   xyz[0]=Row2X(slicerow); 
 
   //Y-Value
+  if (slicerow>=fgNRow) {
+    LOG(AliHLTTPCLog::kError,"AliHLTTPCTransform::GetMaxY","Slicerow")
+      <<AliHLTTPCLog::kDec<<"slicerow out of range"<<slicerow<<ENDLOG;
+    return;
+  }
   Int_t npads= fgNPads[slicerow];
 
   if(fgSectorLow[sector])
@@ -1897,9 +1906,9 @@ void AliHLTTPCTransform::Raw2Local(Float_t *xyz,Int_t sector,Int_t row,Float_t p
 
   //Z-Value (remember PULSA Delay)
   if(slice < 18)
-    xyz[2]=fgZLength-fgZWidth*time+fgZOffset;
+    xyz[2]=GetZLength()-GetZWidth()*time+GetZOffset();
   else
-    xyz[2]=fgZWidth*time-fgZOffset-fgZLength;
+    xyz[2]=GetZWidth()*time-GetZOffset()-GetZLength();
 }
 
 void AliHLTTPCTransform::Raw2Local(Float_t *xyz,Int_t sector,Int_t row,Int_t pad,Int_t time)
@@ -1922,9 +1931,9 @@ void AliHLTTPCTransform::Raw2Local(Float_t *xyz,Int_t sector,Int_t row,Int_t pad
 
   //Z-Value (remember PULSA Delay)
   if(slice < 18)
-    xyz[2]=fgZLength-fgZWidth*time+fgZOffset;
+    xyz[2]=GetZLength()-GetZWidth()*time+GetZOffset();
   else
-    xyz[2]=fgZWidth*time-fgZOffset-fgZLength;
+    xyz[2]=GetZWidth()*time-GetZOffset()-GetZLength();
 }
 
 void AliHLTTPCTransform::RawHLT2Local(Float_t *xyz,Int_t slice,
@@ -1944,9 +1953,9 @@ void AliHLTTPCTransform::RawHLT2Local(Float_t *xyz,Int_t slice,
 
   //Z-Value
   if(slice < 18)
-    xyz[2]=fgZLength-fgZWidth*time+fgZOffset;
+    xyz[2]=GetZLength()-GetZWidth()*time+GetZOffset();
   else
-    xyz[2]=fgZWidth*time-fgZOffset-fgZLength;
+    xyz[2]=GetZWidth()*time-GetZOffset()-GetZLength();
 }
 
 void AliHLTTPCTransform::RawHLT2Local(Float_t *xyz,Int_t slice,
@@ -1966,9 +1975,9 @@ void AliHLTTPCTransform::RawHLT2Local(Float_t *xyz,Int_t slice,
 
   //Z-Value
   if(slice < 18)
-    xyz[2]=fgZLength-fgZWidth*time+fgZOffset;
+    xyz[2]=GetZLength()-GetZWidth()*time+GetZOffset();
   else
-    xyz[2]=fgZWidth*time-fgZOffset-fgZLength;
+    xyz[2]=GetZWidth()*time-GetZOffset()-GetZLength();
 }
 
 void AliHLTTPCTransform::Local2Global(Float_t *xyz,Int_t sector,Int_t row)
@@ -2061,9 +2070,9 @@ void AliHLTTPCTransform::Local2Raw(Float_t *xyz,Int_t sector,Int_t row)
     xyz[1]=xyz[1]/fgPadPitchWidthUp+0.5*(fgNPads[slicerow]-1);
 
   if(slice < 18)
-    xyz[2]=(fgZLength-xyz[2]+fgZOffset)/fgZWidth;
+    xyz[2]=(GetZLength()-xyz[2]+GetZOffset())/GetZWidth();
   else
-    xyz[2]=(fgZLength+xyz[2]+fgZOffset)/fgZWidth;
+    xyz[2]=(GetZLength()+xyz[2]+GetZOffset())/GetZWidth();
 }
 
 void AliHLTTPCTransform::LocHLT2Raw(Float_t *xyz,Int_t slice,Int_t slicerow)
@@ -2078,9 +2087,9 @@ void AliHLTTPCTransform::LocHLT2Raw(Float_t *xyz,Int_t slice,Int_t slicerow)
     xyz[1]=xyz[1]/fgPadPitchWidthUp+0.5*(fgNPads[slicerow]-1);
 
   if(slice < 18)
-    xyz[2]=(fgZLength-xyz[2]+fgZOffset)/fgZWidth;
+    xyz[2]=(GetZLength()-xyz[2]+GetZOffset())/GetZWidth();
   else
-    xyz[2]=(fgZLength+xyz[2]+fgZOffset)/fgZWidth;
+    xyz[2]=(GetZLength()+xyz[2]+GetZOffset())/GetZWidth();
 }
 
 void AliHLTTPCTransform::Global2Raw(Float_t *xyz,Int_t sector,Int_t row)
diff --git a/HLT/TPCLib/AliHLTTPCTransform.h b/HLT/TPCLib/AliHLTTPCTransform.h
index d7ecd2c0abd..e6608dcb119 100644
--- a/HLT/TPCLib/AliHLTTPCTransform.h
+++ b/HLT/TPCLib/AliHLTTPCTransform.h
@@ -98,7 +98,7 @@ class AliHLTTPCTransform {
     fgSolenoidBField = f;
     fgBField=fgBFieldFactor*fgSolenoidBField*0.1;
   }
-  static void SetNTimeBins(Int_t i){fgNTimeBins = i;}
+  static void SetNTimeBins(Int_t i){fgNTimeBins = i; if (fgNTimeBins>0) {fgZWidth = fgZLength / (Double_t)fgNTimeBins;}}
   static void SetNRowLow(Int_t i){fgNRowLow = i;}
   static void SetNRowUp(Int_t i){fgNRowUp = i;}
   static void SetNRowUp1(Int_t i){fgNRowUp1 = i;}
@@ -117,7 +117,10 @@ class AliHLTTPCTransform {
   static void SetNSectorUp(Int_t i){fgNSectorUp = i;}
   static void SetPadPitchWidthLow(Double_t f){fgPadPitchWidthLow = f;}
   static void SetPadPitchWidthUp(Double_t f){fgPadPitchWidthUp = f;}
-  static void SetZWidth(Double_t f){fgZWidth = f;}
+  // Matthias 21.09.2007
+  // zwidth is given by zlength and no of timebins and should not be set
+  // otherwise. Was never used
+  //static void SetZWidth(Double_t f){fgZWidth = f;}
   static void SetZSigma(Double_t f){fgZSigma = f;}
   static void SetZLength(Double_t f){fgZLength = f;}
   static void SetZOffset(Double_t f){fgZOffset = f;}