From: alla <alla@f7af4fe6-9843-0410-8265-dc069ae4e863>
Date: Fri, 19 Sep 2008 11:31:39 +0000 (+0000)
Subject: QA Checker improved
X-Git-Url: http://git.uio.no/git/?p=u%2Fmrichter%2FAliRoot.git;a=commitdiff_plain;h=c4b97145f6c4f7e083651a362dfc082b5ba2a2d8

QA Checker improved
---

diff --git a/T0/AliT0QAChecker.cxx b/T0/AliT0QAChecker.cxx
index 48c5da9e47c..02991e84e8a 100644
--- a/T0/AliT0QAChecker.cxx
+++ b/T0/AliT0QAChecker.cxx
@@ -65,12 +65,12 @@ const Double_t AliT0QAChecker::Check(AliQA::ALITASK_t index,TObjArray * list)
   Double_t test = 10.0  ;
    
   Int_t count = 0 ;
-  Double_t nent[200], nentraw[200];
-  TString hname[200];
+  Double_t nent[250], nentraw[250];
+  TString hname[250];
   const char *cname;
-  memset(nent,0,200*sizeof(Double_t));
-  Double_t w[200];
-  memset(w,1,200*sizeof(Double_t));
+  memset(nent,0,250*sizeof(Double_t));
+  Double_t w[250];
+  memset(w,1,250*sizeof(Double_t));
   TH1 *fhRecLEDAmp[24];  TH1 * fhRecQTC[24];
   TH1 *fhOnlineMean = 0x0;  
   TH1 * fhRecMean = 0x0;
@@ -89,6 +89,7 @@ const Double_t AliT0QAChecker::Check(AliQA::ALITASK_t index,TObjArray * list)
     count = 0 ;
     while ( (hdata = dynamic_cast<TH1 *>(next())) ) {
       if (hdata) {
+	//     if (count>199) continue;
 	nent[count] = hdata->GetEntries();
 	cname = hdata->GetName();
 	hname[count] = cname;
@@ -131,8 +132,9 @@ const Double_t AliT0QAChecker::Check(AliQA::ALITASK_t index,TObjArray * list)
       else {
 	if(index == 2){
 	  //rec points
-	  if ( TMath::Abs(fhRecMean->GetMean() - fhOnlineMean->GetMean()) > 5) 
-	    AliDebug(10,Form("rec mean %f -> online mean %f",fhRecMean->GetMean(), fhOnlineMean->GetMean())) ;
+	  //	    printf("rec mean %f -> online mean %f",fhRecMean->GetMean(), fhOnlineMean->GetMean()) ;
+	   if ( TMath::Abs(fhRecMean->GetMean() - fhOnlineMean->GetMean()) > 5) 
+	     AliDebug(1,Form("rec mean %f -> online mean %f",fhRecMean->GetMean(), fhOnlineMean->GetMean())) ;
 	  Double_t meanLED, meanQTC;
 	  for (Int_t idet=0; idet<24; idet++) {
 	    meanLED = fhRecLEDAmp[idet]->GetMean();
@@ -145,12 +147,10 @@ const Double_t AliT0QAChecker::Check(AliQA::ALITASK_t index,TObjArray * list)
 	
 	if (index == 0) {
 	  //raw data
-	  Float_t realNumber = Float_t(nent[0]);
-	  for (Int_t i=77; i<count; i++) 
+	  for (Int_t i=0; i<count; i++) 
 	    {
-	      Double_t diff = TMath::Abs(nent[i]-realNumber);
-	      if (diff > 0.1*realNumber )
-		AliDebug(1,Form("Problem in Number of entried in hist %s  is %f number of RefPoints %f\n",hname[i].Data() , nent[i],realNumber )) ; 
+	      if( nent[i] == 0)
+		AliDebug(1,Form("Histogram %s is empty  \n",hname[i].Data()  )) ; 
 	    }
 	}
  	if (index == 3) {
diff --git a/T0/AliT0QAChecker.h b/T0/AliT0QAChecker.h
index 9452fa9951f..6387c78efd8 100644
--- a/T0/AliT0QAChecker.h
+++ b/T0/AliT0QAChecker.h
@@ -26,13 +26,12 @@ class AliT0QAChecker: public AliQACheckerBase {
 
 public:
   AliT0QAChecker() : AliQACheckerBase("T0","T0 Quality Assurance Data Checker") {;}          // ctor
-  AliT0QAChecker(const AliT0QAChecker& qac) : AliQACheckerBase(qac.GetName(), qac.GetTitle()) {;} // ctor   
+  AliT0QAChecker(const AliT0QAChecker& qac) : AliQACheckerBase(qac.GetName(), qac.GetTitle()) {;} // cpy ctor   
+  AliT0QAChecker& operator = (const AliT0QAChecker& qac) ;
   virtual ~AliT0QAChecker() {;} // dtor
 
 private:
-  //  virtual const Double_t Check(TObjArray * list) ;
-  virtual const Double_t Check(AliQA::ALITASK_t index, TObjArray * list) ;
-  virtual const Double_t Check(AliQA::ALITASK_t ) {return 0.;} 
+  virtual const Double_t Check(AliQA::ALITASK_t,TObjArray * list) ;
   virtual const Double_t Check() {return 0.;} ;
   
 
diff --git a/T0/AliT0QADataMakerRec.cxx b/T0/AliT0QADataMakerRec.cxx
index 190adf1674f..437ecc89a39 100644
--- a/T0/AliT0QADataMakerRec.cxx
+++ b/T0/AliT0QADataMakerRec.cxx
@@ -76,7 +76,7 @@ void AliT0QADataMakerRec::EndOfDetectorCycle(AliQA::TASKINDEX_t task, TObjArray
 {
   //Detector specific actions at end of cycle
   // do the QA checking
-  //  AliQAChecker::Instance()->Run(AliQA::kT0, task, list) ;
+  AliQAChecker::Instance()->Run(AliQA::kT0, task, list) ;
   Char_t *triggers[6] = {"mean", "vertex","ORA","ORC","central","semi-central"};
   for (Int_t itr=0; itr<6; itr++) {
     GetRawsData(197)->Fill(triggers[itr],fNumTriggersCal[itr]);
@@ -164,7 +164,7 @@ void AliT0QADataMakerRec::InitRaws()
     }
 
   TH1F* fhRawTriggerCal = new TH1F("hRawTriggerCal"," laser triggers",6,0,6);
-  Add2RawsList(fhRawTriggerCal ,197 );
+  Add2RawsList(fhRawTriggerCal ,197 ,saveForCorr);
 
   TH1F* fhRawMeanCal = new TH1F("hRawMeanCal","online mean signal, calibration event",
 				10000,0,10000);
@@ -187,13 +187,13 @@ void AliT0QADataMakerRec::InitRaws()
 
   TH2F* fhEffCFD = new TH2F("hEffCFD"," CFD time",24, 0 ,24, 
 			      100,-500,500);
-  Add2RawsList( fhEffCFD,205);
+  Add2RawsList( fhEffCFD,205, saveForCorr);
   TH2F* fhEffLED = new TH2F("hEffLED","LED time",24, 0 ,24, 
 			      100,-500,500);
-  Add2RawsList( fhEffLED,206);
+  Add2RawsList( fhEffLED,206, saveForCorr);
   TH2F* fhEffQTC = new TH2F("hEffQTC","QTC amplitude",24, 0 ,24, 
 			      100,0,7000);
-  Add2RawsList( fhEffQTC,207);
+  Add2RawsList( fhEffQTC,207, saveForCorr);
 }
 
 //____________________________________________________________________________