u/mrichter/AliRoot.git
9 years ago This is a backward incompatible change in AliRoot. The following methods have been...
fca [Tue, 23 Mar 2010 10:56:12 +0000]
 This is a backward incompatible change in AliRoot. The following methods have been removed

-   const char*   AliRun:: GetTriggerDescriptor() const {return fTriggerDescriptor.Data();}
-   void                AliRun::SetTriggerDescriptor(const char *name) {fTriggerDescriptor = name;}

as their only function was to store temporarily the beam type in AliRun to be transferred to AliSimulation. This information is used for the trigger configuration. Instead, we have introduced the two methods

+  void                   AliSimulation::SetTriggerConfig(TString conf) {fTriggerConfig=conf;}
+  const Char_t*  AliSimulation::GetTriggerConfig() const {return fTriggerConfig.Data();}

To store and get directly this info from the AliSimulation class. This change is completely transparent, however what is NOT transparent is the setting of the beam type which is done in the Config.C. Typically the change is the following

-    gAlice->SetTriggerDescriptor("Pb-Pb");
+    AliSimulation::Instance()->SetTriggerConfig("Pb-Pb");

All the macros in AliRoot have been changed, but also all private macros will have to be changed. The symptom will be very easy to detect, as CINT will complain that there is no method SetTriggerConfig in AliRun.

One subtle point here is that with this change Config.C will require the presence of AliSimulation. If it is not there, it will be created by the Instance() call. This is not a problem in normal usage, but if Config.C is not used for simulation, it will create an instance of AliSimulation, that will not be used. Again, this should not be a problem, but users might as well be aware o fit.

9 years agobugfix for an issue with recent autoconf versions on Ubuntu 10
richterm [Tue, 23 Mar 2010 10:55:17 +0000]
bugfix for an issue with recent autoconf versions on Ubuntu 10
with autoconf 2.64 AC_CHECK_HEADERS behaves undefined if the first parameter is empty
it looks like some arbitrary content is taken from somewhere resulting in wrong checks
for include files 'dummy' and 'rootcint'. Added a check and calling the macro only if
there is something to check.

9 years ago- adding temporary fix for problems with including PHOS PID class
odjuvsla [Tue, 23 Mar 2010 10:36:41 +0000]
- adding temporary fix for problems with including PHOS PID class

9 years ago- adding EMCAL reco param handler to build system
odjuvsla [Tue, 23 Mar 2010 10:36:39 +0000]
- adding EMCAL reco param handler to build system

9 years ago- moved some functionality from the detector reco param handlers to the CALO one
odjuvsla [Tue, 23 Mar 2010 10:36:38 +0000]
- moved some functionality from the detector reco param handlers to the CALO one
- cosmetics

9 years agoCoding Conventions
fca [Tue, 23 Mar 2010 10:16:03 +0000]
Coding Conventions

9 years agotrying to fix memory leaks
gconesab [Tue, 23 Mar 2010 10:04:10 +0000]
trying to fix memory leaks

9 years agoUpdated test script and added macros for running with Geant4.
ivana [Tue, 23 Mar 2010 09:53:14 +0000]
Updated test script and added macros for running with Geant4.

9 years agocoding conventions
richterm [Tue, 23 Mar 2010 08:59:54 +0000]
coding conventions

9 years agocoding violation fixes
jgrosseo [Tue, 23 Mar 2010 08:29:21 +0000]
coding violation fixes

9 years agoBugfix to take care of runloader in HLT (Theo)
cblume [Tue, 23 Mar 2010 08:22:27 +0000]
Bugfix to take care of runloader in HLT (Theo)

9 years agodelete iterator (mem leak)
kleinb [Tue, 23 Mar 2010 07:04:46 +0000]
delete iterator (mem leak)

9 years agoDelete fPathName in the d'tor
kleinb [Tue, 23 Mar 2010 07:03:47 +0000]
Delete fPathName in the d'tor

9 years agoupdate from D. Peressounko
gconesab [Mon, 22 Mar 2010 22:22:31 +0000]
update from D. Peressounko

9 years agoPHOS and TRD geometry as installed. Transparent TRD volumes added to online display.
cvetan [Mon, 22 Mar 2010 21:01:06 +0000]
PHOS and TRD geometry as installed. Transparent TRD volumes added to online display.

9 years agoupdating macros (Theo)
richterm [Mon, 22 Mar 2010 17:39:18 +0000]
updating macros (Theo)
- no necessity to circumvent the reconstruction problem anymore, as it was solved
- add possibility to use disableHLTflag without adding custom arguments

9 years agoadding compatibility code for AliTRDrawStream r39608 and removing old compatibility...
richterm [Mon, 22 Mar 2010 17:35:28 +0000]
adding compatibility code for AliTRDrawStream r39608 and removing old compatibility code for AliTRDrecoParam r34995 (Theo)

9 years agoupdating build checks for the HLT TRD (Theo)
richterm [Mon, 22 Mar 2010 17:33:49 +0000]
updating build checks for the HLT TRD (Theo)
- adding check for the availibility of improved AliTRDrawStream (r39608)
- removing check for AliTRDrecoParam r34995
- requirering v4-18-Release

9 years agoVersion number increased.
morsch [Mon, 22 Mar 2010 17:05:38 +0000]
Version number increased.

9 years agofixing coding violations
richterm [Mon, 22 Mar 2010 16:45:22 +0000]
fixing coding violations

9 years agowriting in T0.RecPoints calibrated time
alla [Mon, 22 Mar 2010 16:27:46 +0000]
writing in T0.RecPoints calibrated time

9 years agochange GetRadius(...) to GetPt(...) and use configurable magnetic field
cblume [Mon, 22 Mar 2010 16:26:38 +0000]
change GetRadius(...) to GetPt(...) and use configurable magnetic field

9 years agonew plot w/wo TRD contribution for pt @ vertex
abercuci [Mon, 22 Mar 2010 14:17:20 +0000]
new plot w/wo TRD contribution for pt @ vertex

9 years agoUseful macros for the shifter
coppedis [Mon, 22 Mar 2010 13:24:50 +0000]
Useful macros for the shifter

9 years agoUseful macros for the shifter
coppedis [Mon, 22 Mar 2010 13:23:25 +0000]
Useful macros for the shifter

9 years agoUseful macros for the shifter
coppedis [Mon, 22 Mar 2010 13:22:59 +0000]
Useful macros for the shifter

9 years agoAvoid extrusion by HALL.
morsch [Mon, 22 Mar 2010 13:14:08 +0000]
Avoid extrusion by HALL.

9 years agoCoding rule violations corrected.
morsch [Mon, 22 Mar 2010 12:56:31 +0000]
Coding rule violations corrected.

9 years agoIn AliMUONSDigitizerV2:
ivana [Mon, 22 Mar 2010 11:48:16 +0000]
In AliMUONSDigitizerV2:
For the event interaction time, SDigitizer now gets the interaction time stored in the event header instead of loading the stack
(Mercedes L.N.)

9 years agoadd debugging messages for collision event/track selection
abercuci [Mon, 22 Mar 2010 11:05:12 +0000]
add debugging messages for collision event/track selection

9 years agoSOD updated
coppedis [Mon, 22 Mar 2010 11:02:06 +0000]
SOD updated

9 years agoUpdated preprocessor
coppedis [Mon, 22 Mar 2010 10:58:11 +0000]
Updated preprocessor

9 years agoFix compiler warnings
cblume [Mon, 22 Mar 2010 10:08:55 +0000]
Fix compiler warnings

9 years agoDo not stream event by event pointers and variables, avoid errors when writing the...
kleinb [Mon, 22 Mar 2010 10:06:31 +0000]
Do not stream event by event pointers and variables, avoid errors when writing the object with the AnalysisManager
E-TStreamerInfo::Build:: AliCdfJetFinder: varContainer** has no streamer or dictionary, data member fVectParticle will not be saved (etc.)

9 years agouse trigger selection only for real data
abercuci [Mon, 22 Mar 2010 09:01:29 +0000]
use trigger selection only for real data

9 years agoAdd contact mail for responsibles
gconesab [Mon, 22 Mar 2010 08:18:47 +0000]
Add contact mail for responsibles

9 years agoAdding the name of the responsible person
belikov [Mon, 22 Mar 2010 08:01:52 +0000]
Adding the name of the responsible person

9 years agoRemoving lines committed by mistake
hristov [Mon, 22 Mar 2010 06:26:31 +0000]
Removing lines committed by mistake

9 years agoChanges to avoid multiple initializations (Melinda)
masera [Sun, 21 Mar 2010 21:56:26 +0000]
Changes to avoid multiple initializations (Melinda)

9 years agoCoding conventions fixed for AliACORDEDataDCS class
mrodrigu [Sun, 21 Mar 2010 18:47:32 +0000]
Coding conventions fixed for AliACORDEDataDCS class

9 years agoanalysis task with event mixing
misko [Sun, 21 Mar 2010 17:48:07 +0000]
analysis task with event mixing

9 years agoAliUnicorAnalGlobal: histogram cemu added
misko [Sun, 21 Mar 2010 17:39:33 +0000]
AliUnicorAnalGlobal:    histogram cemu added
AliUnicorAnalCorrel:    modified binning, added histogram bimo, pair frame.
AliUnicorEventAliceESD: event, track, and pair cuts updated; Nch definition.
AliAnalysisTaskUnicor:  pi+pi- added

9 years agoTypo corected
cvetan [Sat, 20 Mar 2010 23:26:22 +0000]
Typo corected

9 years agoAdding example to make summary log
marian [Sat, 20 Mar 2010 22:00:16 +0000]
Adding example to make summary log

9 years agoCoding convention violations fixes (Matevz)
cvetan [Sat, 20 Mar 2010 20:11:24 +0000]
Coding convention violations fixes (Matevz)

9 years agoMacros for PWG1 train running/validation/certification
marian [Sat, 20 Mar 2010 20:04:54 +0000]
Macros for PWG1 train running/validation/certification
Each Add*.C certified separatelly

9 years agoProtection against uninitialized variables
kharlov [Sat, 20 Mar 2010 17:27:59 +0000]
Protection against uninitialized variables

9 years agoadd a histogram counting the analyzed number of events
gconesab [Sat, 20 Mar 2010 10:13:37 +0000]
add a histogram counting the analyzed number of events

9 years agocalib par update
rpreghen [Sat, 20 Mar 2010 09:37:56 +0000]
calib par update

9 years agoCoding Conventions
fca [Sat, 20 Mar 2010 07:25:02 +0000]
Coding Conventions

9 years agoMissing protection in case of not present Space points
marian [Fri, 19 Mar 2010 21:59:35 +0000]
Missing protection in case of not present Space points
Marian

9 years agoProtection against zerro pointer
marian [Fri, 19 Mar 2010 21:38:41 +0000]
Protection against zerro pointer
GetTriggerClass()

Marian

9 years agoFatal changed to Error
morsch [Fri, 19 Mar 2010 21:18:33 +0000]
Fatal changed to Error
(M. Ivanov)

9 years agoFixed missing class
marian [Fri, 19 Mar 2010 20:56:35 +0000]
Fixed missing class
Marian

9 years agoFollowing advices of A.Maire and A.Gheata for Tasks CheckV0 and Strange (B.Hippolyte)
bhippoly [Fri, 19 Mar 2010 19:07:03 +0000]
Following advices of A.Maire and A.Gheata for Tasks CheckV0 and Strange (B.Hippolyte)

9 years agoAdding special reconstruction macro for pass0 (taken from $ALICE_ROOT/ANALYSIS/macros)
zampolli [Fri, 19 Mar 2010 18:43:02 +0000]
Adding special reconstruction macro for pass0 (taken from $ALICE_ROOT/ANALYSIS/macros)

(Chiara + Marian)

9 years agoCommitting macros/scripts/jdl for pass0/passX
zampolli [Fri, 19 Mar 2010 18:33:38 +0000]
Committing macros/scripts/jdl for pass0/passX
(Chiara + Marian)

***************************************

Content:

General load macro:
LoadLibraries.C

Reconstruction/calibration:
CalibJob.jdl               -  jdl
runPassX.sh                -  shell script to be exectueted inside jdl - calls the following macros
rec.C                      -  reconstruction macro
runCalibTrain.C            -  calibration macro
tag.C                      -  tag creation macro
validation.sh              -  script to validate results ..

Merging:

MergeJob.jdl               -  jdl job
mergeCalibObjects.sh       -  merging script
merge.C                    -  merging macro alien
mergeCalibObjects.C        -  general merging macro
validationMerging.sh       -  merging validation script

Calibration macros:
ConfigCalibTrain.C              -  Instantiate AliCDBManager, SetRun, Load Geometry and Magnetic field

AddTaskAddObject.C              -  dummy histogram - as a template
AddTaskFilterFriend.C           -  dummy filtering -
AddTaskFilterFriendSecond.C     -  dummy filtering -

Detector specific calibration macros (each detector should have only one macro)

AddTaskTPCCalib.C               -  TPC calibration

9 years ago- temporary fix
odjuvsla [Fri, 19 Mar 2010 17:26:00 +0000]
- temporary fix

9 years agoTypo fixed.
zampolli [Fri, 19 Mar 2010 17:20:14 +0000]
Typo fixed.

9 years agoSUMMARY = CFContainer improvement + step towards bookkeeping
bhippoly [Fri, 19 Mar 2010 17:16:57 +0000]
SUMMARY = CFContainer improvement + step towards bookkeeping
-------
1. CheckCascade :
* Andrei's advice : 1. implementation of a destructor /2. TList::SetOwner /3. PostData in UserCreateOutputObjects /4. PostData in accordance with return wihtin UserExec;
* Settings related to (quality) analysis cuts now as data members (needed for bookkeeping);
* Step towards bookkeeping with a TPaveText (commented ! not supported by the framework);
* Introduction of new TH1F or change of name :
    - fHistCascadeMultiplicityBeforeTrigSel,
    - fHistCascadeMultiplicity       becomes fHistCascadeMultiplicityForTrigEvt,
    - fHistTrackMultiplicity         becomes fHistTrackMultiplicityForTrigEvt,
    - fHistTPCrefitTrackMultiplicity becomes fHistTPCrefitTrackMultiplicityForTrigEvt,
    - fHistCascadeMultiplicityForSelEvt,          - fHistPosBestPrimaryVtx(X,Y,Z)ForSelEvt,
    - fHistPosTrkgPrimaryVtx(X,Y,Z)  become fHistPosTrkgPrimaryVtx(X,Y,Z)ForCascadeEvt,
    - fHistPosBestPrimaryVtx(X,Y,Z)  become  fHistPosBestPrimaryVtx(X,Y,Z)ForCascadeEvt;
* fCFContCascadeCuts reshuffled : 1. 20 dimensions [+Y(Xi) +Y(Omega)] / 2. 1 step = 1 species.

2. CheckPerformanceCascade :
* Andrei's advice : 1. implementation of a destructor /2. TList::SetOwner /3. PostData in UserCreateOutputObjects /4. PostData in accordance with return wihtin UserExec;
* Settings related to (quality) analysis cuts now as data members (needed for bookkeeping);
* Step towards bookkeeping with a TPaveText (commented ! not supported by the framework);
* AliCFContainer: Introduction of fCFCont*As*CascadeCuts = like fCFContCascadeCuts but for associated-to-MC particles
3. AddTaskCheckCascade + AddTaskCheckPerformanceCascade
* Settings corresponding to the new features above (choices hard-coded into each macro, != arguments)
(A.Maire)

9 years ago- fixed wrong constant
odjuvsla [Fri, 19 Mar 2010 16:45:37 +0000]
- fixed wrong constant
- cosmetics

9 years ago- reconstruction classes no using the reco param handlers to get the reconstruction...
odjuvsla [Fri, 19 Mar 2010 16:45:35 +0000]
- reconstruction classes no using the reco param handlers to get the reconstruction parameters

9 years ago- adding reco param handlers to build system
odjuvsla [Fri, 19 Mar 2010 16:45:33 +0000]
- adding reco param handlers to build system

9 years ago- added handlers for reconstruction parameters
odjuvsla [Fri, 19 Mar 2010 16:45:29 +0000]
- added handlers for reconstruction parameters

9 years agoFix for https://savannah.cern.ch/bugs/?64530
morsch [Fri, 19 Mar 2010 16:27:54 +0000]
Fix for https://savannah.cern.ch/bugs/?64530

9 years agoMerge branch 'devel'
slindal [Fri, 19 Mar 2010 15:47:01 +0000]
Merge branch 'devel'

* devel:
  compilation warning

9 years agoMerge branch 'devel'
slindal [Fri, 19 Mar 2010 15:39:19 +0000]
Merge branch 'devel'

* devel:
  bugfix TRD
  bugfix

9 years agobugfix
slindal [Fri, 19 Mar 2010 15:38:04 +0000]
bugfix

9 years agofixing coding violations from FC
hdalsgaa [Fri, 19 Mar 2010 14:56:35 +0000]
fixing coding violations from FC

9 years agoUpdates for SPD QA
morsch [Fri, 19 Mar 2010 14:34:36 +0000]
Updates for SPD QA
I have modified the SPD task for the QA train for two reasons :
- revisiting included histograms
- getting rid of all the online-offline numbering conventions in the task.

For the second item I have created another class, AliSPDUtils, which makes the all the conversions (it is made up of static methods only).

I attached my modified runPilot.C macro which I used to test everything locally (basically I removed the loading of libraries and I commented
out the setcollisioncandidates for my task).

(A. Mastroserio)

9 years agoaccomodate 'x' for missing DCS point in DDL status string (MakeDeadMap)
haavard [Fri, 19 Mar 2010 14:33:23 +0000]
accomodate 'x' for missing DCS point in DDL status string (MakeDeadMap)

9 years agoWarning corrected.
morsch [Fri, 19 Mar 2010 14:21:50 +0000]
Warning corrected.

9 years agoUpdate reco param object (Markus)
cblume [Fri, 19 Mar 2010 14:16:42 +0000]
Update reco param object (Markus)

9 years agoUpdate reco param object (Markus)
cblume [Fri, 19 Mar 2010 14:15:21 +0000]
Update reco param object (Markus)

9 years agoUpdates for event replication.
morsch [Fri, 19 Mar 2010 13:45:01 +0000]
Updates for event replication.
(R. Arnalidi)

9 years agoCoding violation fixes
agheata [Fri, 19 Mar 2010 12:58:29 +0000]
Coding violation fixes

9 years agoAdding TDC channel delays to the calib object.
cvetan [Fri, 19 Mar 2010 12:29:33 +0000]
Adding TDC channel delays to the calib object.

9 years agoMerge branch 'devel'
slindal [Fri, 19 Mar 2010 12:13:46 +0000]
Merge branch 'devel'

* devel:
  Set trackDx, trackDz in the HLT ESD

9 years agoMerge branch 'devel'
slindal [Fri, 19 Mar 2010 11:51:34 +0000]
Merge branch 'devel'

* devel:
  forgot the header file
  compilation warning

9 years agoMerge branch 'devel'
slindal [Fri, 19 Mar 2010 11:34:24 +0000]
Merge branch 'devel'

* devel:
  Fixed the TRD histogram processing

9 years agoPossibility to have a software trigger on multiplicity.
morsch [Fri, 19 Mar 2010 11:03:55 +0000]
Possibility to have a software trigger on multiplicity.

9 years agoAdding variable comments
akisiel [Fri, 19 Mar 2010 11:00:14 +0000]
Adding variable comments

9 years agoAdd SPD multiplicity selection and monitoring
akisiel [Fri, 19 Mar 2010 10:55:10 +0000]
Add SPD multiplicity selection and monitoring

9 years agoFix coding convention violations
akisiel [Fri, 19 Mar 2010 10:54:34 +0000]
Fix coding convention violations

9 years agoset by default collision selection
abercuci [Fri, 19 Mar 2010 10:28:16 +0000]
set by default collision selection

9 years agoMacro to plot OCDB pedestal behaviour vs. run no.
coppedis [Fri, 19 Mar 2010 10:27:59 +0000]
Macro to plot OCDB pedestal behaviour vs. run no.

9 years agoMerge branch 'devel'
slindal [Fri, 19 Mar 2010 10:16:35 +0000]
Merge branch 'devel'

* devel:
  bugfix in AliHLTEveTRD.cxx

9 years agoadding option to skip some of the std content of the ESD, by default
richterm [Fri, 19 Mar 2010 10:10:50 +0000]
adding option to skip some of the std content of the ESD, by default
AliESDZDC,AliESDFMD,Cascades,Kinks,AliRawDataErrorLogs,AliESDACORDE are skipped
component argument '-skipobject=name1,name2' can be used the change the list of
objects, names refer to the ESD std object identifiers.

Speedup for pp min bias 2.5, for Hijing 1000 PbPb 1.4

9 years agoadded a protection for missing raw reader instance (Gaute)
richterm [Fri, 19 Mar 2010 09:35:29 +0000]
added a protection for missing raw reader instance (Gaute)

9 years agoProtection against uninitialized array of bad channels.
kharlov [Fri, 19 Mar 2010 09:00:38 +0000]
Protection against uninitialized array of bad channels.

9 years agofixes coding violations
snelling [Fri, 19 Mar 2010 08:55:21 +0000]
fixes coding violations

9 years agoIncreased cluster histogram binnin
slindal [Fri, 19 Mar 2010 08:21:32 +0000]
Increased cluster histogram binnin

9 years agoCleanup and changing of cuts (Ana)
kaamodt [Fri, 19 Mar 2010 01:39:46 +0000]
Cleanup and changing of cuts (Ana)

9 years agomore standardizing of result return codes + always return tmax info + loose parameter...
dsilverm [Fri, 19 Mar 2010 00:34:32 +0000]
more standardizing of result return codes + always return tmax info + loose parameter limits and consistency checks + ADC smearing for no fits + try-catch for possible minuit exceptions

9 years agoJetCorrel correction of coding violations, and other style and memory consumption...
gconesab [Thu, 18 Mar 2010 20:55:22 +0000]
JetCorrel correction of coding violations, and other style and memory consumption fixes(Paul Constantin)

9 years agoAllow fixing of local parameters for solver
shahoian [Thu, 18 Mar 2010 19:20:20 +0000]
Allow fixing of local parameters for solver

9 years agoMore detailed sys. info
hristov [Thu, 18 Mar 2010 19:16:38 +0000]
More detailed sys. info

9 years agoUsing TMath::Abs instead of fabs
hristov [Thu, 18 Mar 2010 19:15:31 +0000]
Using TMath::Abs instead of fabs

9 years agoFix tru index calculation (Nicola and Rachid)
gconesab [Thu, 18 Mar 2010 18:30:51 +0000]
Fix tru index calculation (Nicola and Rachid)

9 years agoTechnical hotfixes for the event display in ACR.
cvetan [Thu, 18 Mar 2010 17:21:08 +0000]
Technical hotfixes for the event display in ACR.