u/mrichter/AliRoot.git
9 years agoFixing bugs.
aszostak [Thu, 25 Mar 2010 13:57:52 +0000]
Fixing bugs.
A crash was being caused by incorrect checking of pointers in AliHLTMUONDecision.
AliHLTMUONRootifierComponent was incorrectly making duplicate track objects if they were not found.
The deep copy of AliHLTMUONEvent was not maintaining the cross reference pointers correctly.
Fixing documentation for AliHLTMUONMansoTrack.
Improving checking for MUON module in AliHLTMUONAgent.

9 years agoFix for bug https://savannah.cern.ch/bugs/?64829
aszostak [Thu, 25 Mar 2010 13:50:46 +0000]
Fix for bug https://savannah.cern.ch/bugs/?64829

9 years agoProtection against division by 0
morsch [Thu, 25 Mar 2010 13:24:59 +0000]
Protection against division by 0

9 years agoUpgrades and fixes of warnings from FC
hdalsgaa [Thu, 25 Mar 2010 13:14:25 +0000]
Upgrades and fixes of warnings from FC

9 years agofixes code viols
snelling [Thu, 25 Mar 2010 13:12:46 +0000]
fixes code viols

9 years agoTechnical fix: possibility to use partial EMCAL geometry
hristov [Thu, 25 Mar 2010 13:02:42 +0000]
Technical fix: possibility to use partial EMCAL geometry

9 years agoFixing warnings
martinez [Thu, 25 Mar 2010 12:52:01 +0000]
Fixing warnings

9 years ago- fixing compilation warning
odjuvsla [Thu, 25 Mar 2010 11:19:56 +0000]
- fixing compilation warning

9 years ago- complete modification of the creation of AliTPCseed objects from HLT tracks (now...
kkanaki [Thu, 25 Mar 2010 11:10:31 +0000]
- complete modification of the creation of AliTPCseed objects from HLT tracks (now method from AliHLTTPCdEdxComponent is used)
- added MC labels on the seeds for comparison between HLT and offline results
- dEdx information present (histogram)

This component is not used in the calibration any more. At the moment it will serve more as a means of comparison with offline. After optimization and correct placement
of the process on the HLT cluster, it can be used for providing the dEdx online.

- testing macro based on AliSimulation producing a TObjArray of AliTPCseed objects per event

9 years agoFixing coding conventions violations
masera [Thu, 25 Mar 2010 11:00:32 +0000]
Fixing coding conventions violations

9 years agoFurther 3% more speed for pp (Theo)
cblume [Thu, 25 Mar 2010 10:23:02 +0000]
Further 3% more speed for pp (Theo)

9 years agoSpeedup up clusterizer (Theo)
cblume [Thu, 25 Mar 2010 10:20:13 +0000]
Speedup up clusterizer (Theo)

9 years agoadding the date to the comment and other updates
rgrosso [Thu, 25 Mar 2010 09:49:31 +0000]
adding the date to the comment and other updates

9 years agoBug fix for the case HLT is running but no track found in the TRD (Raphaelle)
cblume [Thu, 25 Mar 2010 09:45:32 +0000]
Bug fix for the case HLT is running but no track found in the TRD (Raphaelle)

9 years agocoding conventions
rpreghen [Thu, 25 Mar 2010 09:09:49 +0000]
coding conventions

9 years agoAdding time delays (channel-by-channel) as an OCDB entry. Measured only once since...
cvetan [Thu, 25 Mar 2010 09:03:08 +0000]
Adding time delays (channel-by-channel) as an OCDB entry. Measured only once since it is determined by the length of the optical fibers and cables.

9 years agoAdded the method AddDateToComment, adding the current date to the comment datamember.
rgrosso [Thu, 25 Mar 2010 08:56:32 +0000]
Added the method AddDateToComment, adding the current date to the comment datamember.
This method is supposed to be useful if called at the time when the object
is created, so that later it can more easily be tracked, in particular
when the date of the file can be lost or when one is interested in the
date of creation, irrespective of a later copy of it

9 years ago- new resolution picture for track resolution vs MC
abercuci [Thu, 25 Mar 2010 08:12:46 +0000]
- new resolution picture for track resolution vs MC
- fix no. of clusters/track picture

9 years agoMake data members static for speed (Theo)
cblume [Thu, 25 Mar 2010 08:05:23 +0000]
Make data members static for speed (Theo)

9 years agoMake operator= private, modified copy c'tor (Gustavo)
kleinb [Thu, 25 Mar 2010 06:53:59 +0000]
Make operator= private, modified copy c'tor (Gustavo)

9 years agoBug fixed
decaro [Wed, 24 Mar 2010 23:44:45 +0000]
Bug fixed

9 years agoFixing coding rule violations
akisiel [Wed, 24 Mar 2010 22:03:40 +0000]
Fixing coding rule violations

9 years agoCoding convention violations: fixed
decaro [Wed, 24 Mar 2010 21:30:03 +0000]
Coding convention violations: fixed

9 years ago- dimuon Dalitz included
morsch [Wed, 24 Mar 2010 21:11:57 +0000]
- dimuon Dalitz included
Ralf Averbeck

9 years agoAdding more histograms
dainese [Wed, 24 Mar 2010 20:54:41 +0000]
Adding more histograms

9 years agoWarnings corrected.
morsch [Wed, 24 Mar 2010 20:08:50 +0000]
Warnings corrected.

9 years agoWarning corrected.
morsch [Wed, 24 Mar 2010 20:06:10 +0000]
Warning corrected.

9 years agoWarnings corrected.
morsch [Wed, 24 Mar 2010 19:59:59 +0000]
Warnings corrected.

9 years agoCoding rule violations corrected.
morsch [Wed, 24 Mar 2010 19:47:50 +0000]
Coding rule violations corrected.

9 years agoadded comments to satisfy coding conventions
shahoian [Wed, 24 Mar 2010 18:50:06 +0000]
added comments to satisfy coding conventions

9 years agoJetCorrel fixes for mini train (Paul Constantin)
gconesab [Wed, 24 Mar 2010 18:32:16 +0000]
JetCorrel fixes for mini train (Paul Constantin)

9 years ago******** From the discussion at the Offline Week, 19 March 2010
zampolli [Wed, 24 Mar 2010 17:40:59 +0000]
******** From the discussion at the Offline Week, 19 March 2010

-Not filling the GRP object with the energy and beam type from the DAQ logbook (reading them, but not using them).

9 years agoUpdate sign of SDD correction map (S. Beole)
prino [Wed, 24 Mar 2010 17:30:05 +0000]
Update sign of SDD correction map (S. Beole)

9 years agocoding violation fixes
jgrosseo [Wed, 24 Mar 2010 17:28:39 +0000]
coding violation fixes

9 years agofixed warning
jgrosseo [Wed, 24 Mar 2010 16:21:39 +0000]
fixed warning

9 years agofixes for coding violations
mikolaj [Wed, 24 Mar 2010 15:47:41 +0000]
fixes for coding violations

9 years agoremoving obsolete code, for propagation of TPC only track
kleinb [Wed, 24 Mar 2010 15:22:08 +0000]
removing obsolete code, for propagation of TPC only track

9 years agoMemory leak initialize AODJet to 0
kleinb [Wed, 24 Mar 2010 15:03:40 +0000]
Memory leak initialize AODJet to 0

9 years agoCompilation warnings
dainese [Wed, 24 Mar 2010 14:55:25 +0000]
Compilation warnings

9 years agoFixing coding violations from FC
hdalsgaa [Wed, 24 Mar 2010 13:56:35 +0000]
Fixing coding violations from FC

9 years agoDo not Dump the track info for high p_T just print out
kleinb [Wed, 24 Mar 2010 13:42:53 +0000]
Do not Dump the track info for high p_T just print out

9 years agoadd configurable segmentation for y resolution/residual plots
abercuci [Wed, 24 Mar 2010 13:10:48 +0000]
add configurable segmentation for y resolution/residual plots

9 years agoupdates requested by HLT
abercuci [Wed, 24 Mar 2010 12:20:31 +0000]
updates requested by HLT
- cache calibration params at tracking chamber level
- recalculate cluster error parameterization for HLT during tracking
  chamber building
- do a vertex constrained fit in case of HLT before leaving MakeSeeds

9 years agoCorrected default values.
cvetan [Wed, 24 Mar 2010 11:46:36 +0000]
Corrected default values.

9 years agofixing compilation in HLT build system
jthaeder [Wed, 24 Mar 2010 11:35:37 +0000]
fixing compilation in HLT build system

9 years agonew short-cut macro to merge performance files
abercuci [Wed, 24 Mar 2010 11:17:25 +0000]
new short-cut macro to merge performance files

9 years agoadded documentation
abercuci [Wed, 24 Mar 2010 10:51:43 +0000]
added documentation

9 years agoFederico: Adding special rec point for EMCAL
odjuvsla [Wed, 24 Mar 2010 10:35:49 +0000]
Federico: Adding special rec point for EMCAL

9 years agoFederico: AliHLTEMCALGeometry handles transformation from local to global coordinates
odjuvsla [Wed, 24 Mar 2010 10:35:47 +0000]
Federico: AliHLTEMCALGeometry handles transformation from local to global coordinates

9 years ago- added energy correction from AliPHOSPIDv1
odjuvsla [Wed, 24 Mar 2010 10:35:46 +0000]
- added energy correction from AliPHOSPIDv1

9 years ago- dummy implementation of CDB interface functions.
odjuvsla [Wed, 24 Mar 2010 10:35:44 +0000]
- dummy implementation of CDB interface functions.

9 years agoCoding conv viols fixed.
cvetan [Wed, 24 Mar 2010 10:15:46 +0000]
Coding conv viols fixed.

9 years agonew resolution plots
abercuci [Wed, 24 Mar 2010 10:05:51 +0000]
new resolution plots
remove left-over print statment

9 years agoUpdates from Paul Constantin
gconesab [Wed, 24 Mar 2010 09:17:27 +0000]
Updates from Paul Constantin

9 years agoMore stable numerical calculation of combined mass
fca [Wed, 24 Mar 2010 09:04:03 +0000]
More stable numerical calculation of combined mass

9 years agoFixes for report #64730 High virtual memory consumption in the ITS standalone tracker
hristov [Wed, 24 Mar 2010 08:40:40 +0000]
Fixes for report #64730 High virtual memory consumption in the ITS standalone tracker

9 years agoAvoid numerical problems in calc. if eff. mass.
morsch [Wed, 24 Mar 2010 08:05:46 +0000]
Avoid numerical problems in calc. if eff. mass.
(suggested by Matus Kalisky)

9 years agoFix a shadowed variable
agheata [Wed, 24 Mar 2010 07:16:30 +0000]
Fix a shadowed variable

9 years agoforward declaration of TString
kleinb [Wed, 24 Mar 2010 06:31:05 +0000]
forward declaration of TString

9 years agoDelete TRefArray before placement new, avoid mem leak
kleinb [Wed, 24 Mar 2010 06:26:51 +0000]
Delete TRefArray before placement new, avoid mem leak

9 years agoFix warnings
akisiel [Tue, 23 Mar 2010 21:31:55 +0000]
Fix warnings

9 years agonew method added for the Mean threshold scan (A. Mastroserio)
masera [Tue, 23 Mar 2010 21:12:26 +0000]
new method added for the Mean threshold scan (A. Mastroserio)

9 years agoCoding conventions fixes
masera [Tue, 23 Mar 2010 21:11:55 +0000]
Coding conventions fixes

9 years agoadding cmake setup for HLT TRD macros, update of macro (Theo)
richterm [Tue, 23 Mar 2010 20:46:41 +0000]
adding cmake setup for HLT TRD macros, update of macro (Theo)

9 years agoFix for report #64208 Missing OCDB (GRP/Calib/MeanVertex) object in GRP
hristov [Tue, 23 Mar 2010 20:41:45 +0000]
Fix for report #64208 Missing OCDB (GRP/Calib/MeanVertex) object in GRP

9 years agotrigger algorithms parameter names changed according to PIT names (A. Mastroserio)
masera [Tue, 23 Mar 2010 20:23:36 +0000]
trigger algorithms parameter names changed according to PIT names (A. Mastroserio)

9 years agoCorrect memory leak when using PHOS geometry, remove the TObjStrings from the histogr...
gconesab [Tue, 23 Mar 2010 18:45:08 +0000]
Correct memory leak when using PHOS geometry, remove the TObjStrings from the histogram output container, to be used in the cuts container later

9 years agoKeep track of missing DCS points in DDL maps (flagged by 'x')
haavard [Tue, 23 Mar 2010 17:42:09 +0000]
Keep track of missing DCS points in DDL maps (flagged by 'x')
Compress HighVoltage maps  - delete new point if less than 1e-4 different from previous one.

9 years ago********** Following discussion at Offline Week, 19 March 2010
zampolli [Tue, 23 Mar 2010 16:34:31 +0000]
********** Following discussion at Offline Week, 19 March 2010

- Implementing aliases:
energy -> LHC_Beam_Energy
machine mode -> LHC_MachineMode
beam mode -> LHC_BeamMode
beam types 1/2 -> not yet defined
- Implementing check on the time stamps for machine mode and beam mode
- Updating test files (local + nightly shuttle tests)

9 years agoFixed size array.
morsch [Tue, 23 Mar 2010 16:25:48 +0000]
Fixed size array.

9 years agoMinor changes in a macro
coppedis [Tue, 23 Mar 2010 16:17:20 +0000]
Minor changes in a macro

9 years agoDisable the retrieval of dead modules in SDD and SSD. To be replaced by new code...
cvetan [Tue, 23 Mar 2010 16:09:00 +0000]
Disable the retrieval of dead modules in SDD and SSD. To be replaced by new code from Enrico and Francesco (bug#64752)

9 years agoExtrusion corrected.
morsch [Tue, 23 Mar 2010 15:20:42 +0000]
Extrusion corrected.

9 years agoRemoving fRandome
fca [Tue, 23 Mar 2010 14:39:09 +0000]
Removing fRandome

9 years agoMaking Instance() create the class
fca [Tue, 23 Mar 2010 14:38:43 +0000]
Making Instance() create the class

9 years agoOne more macro for ZDC shifters
coppedis [Tue, 23 Mar 2010 14:10:09 +0000]
One more macro for ZDC shifters

9 years agoVZEROQA from library.
morsch [Tue, 23 Mar 2010 13:54:33 +0000]
VZEROQA from library.

9 years agoCoding rule violations corrected :-)
morsch [Tue, 23 Mar 2010 13:53:53 +0000]
Coding rule violations corrected :-)

9 years agoProtection needed in case of kinematics-only-analysis.
morsch [Tue, 23 Mar 2010 13:44:04 +0000]
Protection needed in case of kinematics-only-analysis.

9 years agoAdd a new variable, that is the radial position of the track at the end
hristov [Tue, 23 Mar 2010 13:14:08 +0000]
Add a new variable, that is the radial position of the track at the end
of the muon absorber, both in ESD and AOD. This variable has proven to
be extremely useful to better understand the effects of the absorber in
the data taken by the muon spectrometer.
(Philippe P.)

9 years ago This is a backward incompatible change in AliRoot. The following methods have been...
fca [Tue, 23 Mar 2010 10:56:12 +0000]
 This is a backward incompatible change in AliRoot. The following methods have been removed

-   const char*   AliRun:: GetTriggerDescriptor() const {return fTriggerDescriptor.Data();}
-   void                AliRun::SetTriggerDescriptor(const char *name) {fTriggerDescriptor = name;}

as their only function was to store temporarily the beam type in AliRun to be transferred to AliSimulation. This information is used for the trigger configuration. Instead, we have introduced the two methods

+  void                   AliSimulation::SetTriggerConfig(TString conf) {fTriggerConfig=conf;}
+  const Char_t*  AliSimulation::GetTriggerConfig() const {return fTriggerConfig.Data();}

To store and get directly this info from the AliSimulation class. This change is completely transparent, however what is NOT transparent is the setting of the beam type which is done in the Config.C. Typically the change is the following

-    gAlice->SetTriggerDescriptor("Pb-Pb");
+    AliSimulation::Instance()->SetTriggerConfig("Pb-Pb");

All the macros in AliRoot have been changed, but also all private macros will have to be changed. The symptom will be very easy to detect, as CINT will complain that there is no method SetTriggerConfig in AliRun.

One subtle point here is that with this change Config.C will require the presence of AliSimulation. If it is not there, it will be created by the Instance() call. This is not a problem in normal usage, but if Config.C is not used for simulation, it will create an instance of AliSimulation, that will not be used. Again, this should not be a problem, but users might as well be aware o fit.

9 years agobugfix for an issue with recent autoconf versions on Ubuntu 10
richterm [Tue, 23 Mar 2010 10:55:17 +0000]
bugfix for an issue with recent autoconf versions on Ubuntu 10
with autoconf 2.64 AC_CHECK_HEADERS behaves undefined if the first parameter is empty
it looks like some arbitrary content is taken from somewhere resulting in wrong checks
for include files 'dummy' and 'rootcint'. Added a check and calling the macro only if
there is something to check.

9 years ago- adding temporary fix for problems with including PHOS PID class
odjuvsla [Tue, 23 Mar 2010 10:36:41 +0000]
- adding temporary fix for problems with including PHOS PID class

9 years ago- adding EMCAL reco param handler to build system
odjuvsla [Tue, 23 Mar 2010 10:36:39 +0000]
- adding EMCAL reco param handler to build system

9 years ago- moved some functionality from the detector reco param handlers to the CALO one
odjuvsla [Tue, 23 Mar 2010 10:36:38 +0000]
- moved some functionality from the detector reco param handlers to the CALO one
- cosmetics

9 years agoCoding Conventions
fca [Tue, 23 Mar 2010 10:16:03 +0000]
Coding Conventions

9 years agotrying to fix memory leaks
gconesab [Tue, 23 Mar 2010 10:04:10 +0000]
trying to fix memory leaks

9 years agoUpdated test script and added macros for running with Geant4.
ivana [Tue, 23 Mar 2010 09:53:14 +0000]
Updated test script and added macros for running with Geant4.

9 years agocoding conventions
richterm [Tue, 23 Mar 2010 08:59:54 +0000]
coding conventions

9 years agocoding violation fixes
jgrosseo [Tue, 23 Mar 2010 08:29:21 +0000]
coding violation fixes

9 years agoBugfix to take care of runloader in HLT (Theo)
cblume [Tue, 23 Mar 2010 08:22:27 +0000]
Bugfix to take care of runloader in HLT (Theo)

9 years agodelete iterator (mem leak)
kleinb [Tue, 23 Mar 2010 07:04:46 +0000]
delete iterator (mem leak)

9 years agoDelete fPathName in the d'tor
kleinb [Tue, 23 Mar 2010 07:03:47 +0000]
Delete fPathName in the d'tor

9 years agoupdate from D. Peressounko
gconesab [Mon, 22 Mar 2010 22:22:31 +0000]
update from D. Peressounko

9 years agoPHOS and TRD geometry as installed. Transparent TRD volumes added to online display.
cvetan [Mon, 22 Mar 2010 21:01:06 +0000]
PHOS and TRD geometry as installed. Transparent TRD volumes added to online display.

9 years agoupdating macros (Theo)
richterm [Mon, 22 Mar 2010 17:39:18 +0000]
updating macros (Theo)
- no necessity to circumvent the reconstruction problem anymore, as it was solved
- add possibility to use disableHLTflag without adding custom arguments

9 years agoadding compatibility code for AliTRDrawStream r39608 and removing old compatibility...
richterm [Mon, 22 Mar 2010 17:35:28 +0000]
adding compatibility code for AliTRDrawStream r39608 and removing old compatibility code for AliTRDrecoParam r34995 (Theo)

9 years agoupdating build checks for the HLT TRD (Theo)
richterm [Mon, 22 Mar 2010 17:33:49 +0000]
updating build checks for the HLT TRD (Theo)
- adding check for the availibility of improved AliTRDrawStream (r39608)
- removing check for AliTRDrecoParam r34995
- requirering v4-18-Release

9 years agoVersion number increased.
morsch [Mon, 22 Mar 2010 17:05:38 +0000]
Version number increased.

9 years agofixing coding violations
richterm [Mon, 22 Mar 2010 16:45:22 +0000]
fixing coding violations