]> git.uio.no Git - u/mrichter/AliRoot.git/log
u/mrichter/AliRoot.git
14 years ago- fixes for bug 63765 - see for details the post
abercuci [Tue, 16 Mar 2010 11:55:05 +0000 (11:55 +0000)]
- fixes for bug 63765 - see for details the post
- heavy modifications to the algorithms of track seeding
- fully tested against simulations

14 years agoRemove class AliPtMothFromPtDaugh, which introduced unwanted dependency on libSTEER
dainese [Tue, 16 Mar 2010 10:22:17 +0000 (10:22 +0000)]
Remove class AliPtMothFromPtDaugh, which introduced unwanted dependency on libSTEER

14 years agoFix coding convention violations 2
akisiel [Tue, 16 Mar 2010 09:56:54 +0000 (09:56 +0000)]
Fix coding convention violations 2

14 years agoFix coding convention violations
akisiel [Tue, 16 Mar 2010 09:56:41 +0000 (09:56 +0000)]
Fix coding convention violations

14 years agoChanges for #64259 Request for including the new class AliTRDresponse in STEER and...
hristov [Tue, 16 Mar 2010 09:48:11 +0000 (09:48 +0000)]
Changes for #64259 Request for including the new class AliTRDresponse in STEER and porting this to the release

14 years agoMerge branch 'devel'
slindal [Tue, 16 Mar 2010 09:15:20 +0000 (09:15 +0000)]
Merge branch 'devel'

* devel:
  enbable calo clusters display

14 years agoMethod to set the friend file name added.
morsch [Tue, 16 Mar 2010 09:04:59 +0000 (09:04 +0000)]
Method to set the friend file name added.

14 years ago- something went wrong with previous commit...
odjuvsla [Tue, 16 Mar 2010 08:54:36 +0000 (08:54 +0000)]
- something went wrong with previous commit...

14 years ago- adding module to the internal calo cluster struct
odjuvsla [Tue, 16 Mar 2010 08:50:23 +0000 (08:50 +0000)]
- adding module to the internal calo cluster struct

14 years agoAdding AliHLTMUONTrack object to store ROOTified internal dHLT track data in new...
aszostak [Tue, 16 Mar 2010 00:39:49 +0000 (00:39 +0000)]
Adding AliHLTMUONTrack object to store ROOTified internal dHLT track data in new format.

14 years agoMinor fixes to documentation and printed messages.
aszostak [Tue, 16 Mar 2010 00:37:57 +0000 (00:37 +0000)]
Minor fixes to documentation and printed messages.

14 years agoCoding conventions
dainese [Mon, 15 Mar 2010 23:03:28 +0000 (23:03 +0000)]
Coding conventions

14 years ago- small changes to macro
odjuvsla [Mon, 15 Mar 2010 22:38:37 +0000 (22:38 +0000)]
- small changes to macro

14 years ago- fixing bug in resizing of array/buffer in clusterizer
odjuvsla [Mon, 15 Mar 2010 22:38:35 +0000 (22:38 +0000)]
- fixing bug in resizing of array/buffer in clusterizer

14 years ago- adding cell info to ESDs
odjuvsla [Mon, 15 Mar 2010 22:38:33 +0000 (22:38 +0000)]
- adding cell info to ESDs

14 years ago- small change
odjuvsla [Mon, 15 Mar 2010 22:38:30 +0000 (22:38 +0000)]
- small change

14 years agoreconstruction vertex using calculated calble and electronics delays for both sides
alla [Mon, 15 Mar 2010 21:24:55 +0000 (21:24 +0000)]
reconstruction vertex using calculated calble and electronics delays for both sides

14 years agoIn the clusterizer and rawData the creation of the tracklet loader and
cblume [Mon, 15 Mar 2010 20:40:51 +0000 (20:40 +0000)]
In the clusterizer and rawData the creation of the tracklet loader and
tree creation was changed, making the methods
AliTRDclusterizer::OpenTrackletOutput, AliTRDrawData::OpenOutput
obsolete. Thus, they have to be removed from the TRDReconstructor.

14 years agoFriend reading can be switched off.
morsch [Mon, 15 Mar 2010 19:10:22 +0000 (19:10 +0000)]
Friend reading can be switched off.

14 years agobug fixes
dsilverm [Mon, 15 Mar 2010 18:33:49 +0000 (18:33 +0000)]
bug fixes

14 years agovoid SetBin0CallbackViaPointer( Bin0Callback_t cb)
morsch [Mon, 15 Mar 2010 18:33:02 +0000 (18:33 +0000)]
void SetBin0CallbackViaPointer( Bin0Callback_t cb)
added

(M. Floris)

14 years agoremove assignment operator, not needed and could caus problems due to the TLists
gconesab [Mon, 15 Mar 2010 18:17:07 +0000 (18:17 +0000)]
remove assignment operator, not needed and could caus problems due to the TLists

14 years agoMerge branch 'devel'
slindal [Mon, 15 Mar 2010 17:26:53 +0000 (17:26 +0000)]
Merge branch 'devel'

* devel:
  Fixed bug with the tcp qa canvases
  Added esd track qa histograms

14 years ago- corrected casting of the block iterator from TObjArray to TClonesArray
kkanaki [Mon, 15 Mar 2010 16:08:08 +0000 (16:08 +0000)]
- corrected casting of the block iterator from TObjArray to TClonesArray

14 years ago- removed TObjArray for the storing of clusters
kkanaki [Mon, 15 Mar 2010 15:31:24 +0000 (15:31 +0000)]
- removed TObjArray for the storing of clusters

14 years agoUpdates (M. Gheata)
morsch [Mon, 15 Mar 2010 15:22:22 +0000 (15:22 +0000)]
Updates (M. Gheata)

14 years agocorrect copy and = constructor call to data member pointers
gconesab [Mon, 15 Mar 2010 14:34:26 +0000 (14:34 +0000)]
correct copy and = constructor call to data member pointers

14 years agoUse new profiling tools in local mode, set proper name for tasks when running with...
kleinb [Mon, 15 Mar 2010 13:18:44 +0000 (13:18 +0000)]
Use new profiling tools in local mode, set proper name for tasks when running with different seetings

14 years agoproper includes and forward declarations for tstring
kleinb [Mon, 15 Mar 2010 13:16:50 +0000 (13:16 +0000)]
proper includes and forward declarations for tstring

14 years agoFixed some memory leaks, deletes before returning from eventloop, properly reset...
kleinb [Mon, 15 Mar 2010 13:05:17 +0000 (13:05 +0000)]
Fixed some memory leaks, deletes before returning from eventloop, properly reset objects in arrays of pointers to pointers, set deleted pointers to 0, cosmetic change to TaskJets (forward declare TString)

14 years agoNew class to extract pt distribution of given particle from pt distribution of a...
dainese [Mon, 15 Mar 2010 12:23:10 +0000 (12:23 +0000)]
New class to extract pt distribution of given particle from pt distribution of a daughter particle, e.g. B from J/psi (F. Fionda)

14 years agoFix for:
morsch [Mon, 15 Mar 2010 11:57:53 +0000 (11:57 +0000)]
Fix for:
bug #64332: AliAODVertex::GetNContributors gives wrong result

14 years agoMerge branch 'devel'
slindal [Mon, 15 Mar 2010 11:49:11 +0000 (11:49 +0000)]
Merge branch 'devel'

* devel:
  bugfix
  Fixing rule violations: commented out everything

14 years agocompiler dependent bug fix
jotwinow [Mon, 15 Mar 2010 11:32:06 +0000 (11:32 +0000)]
compiler dependent bug fix

14 years agoMerge branch 'devel'
slindal [Mon, 15 Mar 2010 11:24:30 +0000 (11:24 +0000)]
Merge branch 'devel'

* devel:
  Added reconnect button
  Bugfixes enabling buffer navigation

14 years agoFixing rule violations: commented out everything
slindal [Mon, 15 Mar 2010 11:12:26 +0000 (11:12 +0000)]
Fixing rule violations: commented out everything

14 years agocoding violations corrected
gconesab [Mon, 15 Mar 2010 11:01:04 +0000 (11:01 +0000)]
coding violations corrected

14 years agorevert changes
jotwinow [Mon, 15 Mar 2010 10:56:28 +0000 (10:56 +0000)]
revert changes

14 years agoFrom Mihaela: added PartCorr QA wagon (Gustavo) and enabled dimuon CF container ...
agheata [Mon, 15 Mar 2010 10:42:51 +0000 (10:42 +0000)]
From Mihaela: added PartCorr QA wagon (Gustavo) and enabled dimuon CF container (Roberta)

14 years agoImproving handling of error state.
aszostak [Mon, 15 Mar 2010 10:25:58 +0000 (10:25 +0000)]
Improving handling of error state.

14 years agodNdPt analysis update for preliminary spectra
jotwinow [Mon, 15 Mar 2010 09:57:11 +0000 (09:57 +0000)]
dNdPt analysis update for preliminary spectra

14 years ago- fixed ownership of arrays
kkanaki [Mon, 15 Mar 2010 09:42:40 +0000 (09:42 +0000)]
- fixed ownership of arrays
- cleanup of debug messages

14 years agobug in support structure fixed
alla [Mon, 15 Mar 2010 09:39:58 +0000 (09:39 +0000)]
bug in support structure fixed

14 years agocorrecting library load error: function implementation was missing
richterm [Mon, 15 Mar 2010 08:52:49 +0000 (08:52 +0000)]
correcting library load error: function implementation was missing

14 years agoBugfixes enabling buffer navigation
slindal [Mon, 15 Mar 2010 08:47:23 +0000 (08:47 +0000)]
Bugfixes enabling buffer navigation

14 years agoadding first sketch of a DCS publisher component for global HLT data points
richterm [Mon, 15 Mar 2010 08:34:14 +0000 (08:34 +0000)]
adding first sketch of a DCS publisher component for global HLT data points
not yet activated, needs to be finalized

14 years agoadding base class for a DIM server. The implemented interface loads the libdim dynami...
richterm [Mon, 15 Mar 2010 08:26:39 +0000 (08:26 +0000)]
adding base class for a DIM server. The implemented interface loads the libdim dynamically and
uses the functions without introducing new dependencies for the libHLTbase

14 years agoFrom Indra: Bug fix to display the reconstructed hits for di-muon tracking chambers
slindal [Mon, 15 Mar 2010 07:42:42 +0000 (07:42 +0000)]
From Indra: Bug fix to display the reconstructed hits for di-muon tracking chambers

14 years agofixed aod mc assignment and use of jet header (B. Bathen)
kleinb [Mon, 15 Mar 2010 06:57:06 +0000 (06:57 +0000)]
fixed aod mc assignment and use of jet header (B. Bathen)

14 years agoAdding optimisations to the global trigger.
aszostak [Mon, 15 Mar 2010 03:40:18 +0000 (03:40 +0000)]
Adding optimisations to the global trigger.
- Trigger symbols with empty assignment expressions derive their values from the default expression and are effectively contant. They do not need to have their values
computed for every event, so they are now computed in the AliHLTGlobalTrigger::FillFromMenu method rather than the AliHLTGlobalTrigger::NewEvent method.
- Moving masking of CTP readout list to AliHLTTrigger::TriggerEvent so that the relatively expensive AliHLTTriggerDomain::operator AliHLTReadoutList () call is only
performed once.
- Avoiding expensive TFormula evaluations in AliHLTGlobalTriggerComponent::AddCTPDecisions.
- The global trigger logic will now properly handle all sub-classes of AliHLTTriggerDecision.
- Some minor improvements to AliHLTTriggerDomain and AliHLTDomainEntry.

14 years agoFixing warning.
aszostak [Mon, 15 Mar 2010 01:49:59 +0000 (01:49 +0000)]
Fixing warning.

14 years agoBug fix for potencial memory leak.
aszostak [Mon, 15 Mar 2010 01:49:23 +0000 (01:49 +0000)]
Bug fix for potencial memory leak.

14 years agoFixing memory leaks.
aszostak [Mon, 15 Mar 2010 01:46:39 +0000 (01:46 +0000)]
Fixing memory leaks.

14 years agoskip unused TGraph + add access to TF1
dsilverm [Sun, 14 Mar 2010 23:52:47 +0000 (23:52 +0000)]
skip unused TGraph + add access to TF1

14 years agouse new raw fitters in QA
dsilverm [Sun, 14 Mar 2010 23:51:24 +0000 (23:51 +0000)]
use new raw fitters in QA

14 years agoupdating histogram names (Theo)
richterm [Sun, 14 Mar 2010 13:57:27 +0000 (13:57 +0000)]
updating histogram names (Theo)

14 years agoincluding just added files into build
richterm [Sun, 14 Mar 2010 13:39:32 +0000 (13:39 +0000)]
including just added files into build

14 years agoadding module agent for HLTqadm library. The agent is supposed to return the list...
richterm [Sun, 14 Mar 2010 13:38:27 +0000 (13:38 +0000)]
adding module agent for HLTqadm library. The agent is supposed to return the list of available HLT QA pluins, currently AliHLTTPCQADataMaker
adding the AliHLTQADataMakerRec steering class implementation for HLT QA plugins

14 years agomoving the current implementation of the HLT QA data maker to a detector plugin ...
richterm [Sun, 14 Mar 2010 13:05:37 +0000 (13:05 +0000)]
moving the current implementation of the HLT QA data maker to a detector plugin (TPC)

14 years agoadding base class for HLT detector QA plugins
richterm [Sun, 14 Mar 2010 13:02:38 +0000 (13:02 +0000)]
adding base class for HLT detector QA plugins

14 years agoextending interface of the ModuleAgent
richterm [Sun, 14 Mar 2010 12:53:31 +0000 (12:53 +0000)]
extending interface of the ModuleAgent
GetQAPlugins can return blank separated list of QA plugin class names

14 years agoextending LoadInstance, can be used without library argument now to create instance...
richterm [Sun, 14 Mar 2010 12:51:09 +0000 (12:51 +0000)]
extending LoadInstance, can be used without library argument now to create instance of already existing class

14 years agoviolations were fixed
alla [Sun, 14 Mar 2010 11:36:06 +0000 (11:36 +0000)]
violations were fixed

14 years agoM AliTPCDistortionFun.C - Make more fun(ction)
marian [Sun, 14 Mar 2010 11:29:16 +0000 (11:29 +0000)]
M      AliTPCDistortionFun.C - Make more fun(ction)
                             - Some default pictures defined
M      AliTPCDistortions.cxx - Bug fix in constructor - Default parameters

14 years agoImplemented possibility to add global objects (like general parameters or cuts) in...
agheata [Sun, 14 Mar 2010 11:12:17 +0000 (11:12 +0000)]
Implemented possibility to add global objects (like general parameters or cuts) in the output file(s) of an analysis task. The objects do not need to be mergeable and have to be created in methods running on the local client (ctor, LocalInit()). Typical usage:

header: if needed in UserExec, make sure the cuts/param object is a STREAMABLE data member so it can end up on workers, in case you need to use it for UserExec selections (i.e. no //! comment)
        if the object is not used in the analysis add a //! comment for its data member
steering macro: pC = mgr->CreateContainer(name, TList::Class(), AliAnalysisDataContainer::kParamContainer, FILENAME)
                mgr->ConnectOutput(myTask, n, pC);
NOTE: may be anything else, not only a TList; FILENAME may match the file for other output containers.

MyTask::MyTask(const char *name) : AliAnalysisTaskSE(name)
{
   DefineOutput(1, TList::Class);  // normal output slots
   ...
   DefineOutput(n, TList::Class);  // will contain cuts or local params
}

MyTask::LocalInit()
{
   // Create cuts/param objects and publish to slot
   fCuts = new TList();
   myCutsObj = new ...
   // Configure myCutsObj
   ...
   // Add to list
   fCuts->Add(myCutsObj);
   // Do the same for other param/cuts
   ...
   // Post Data (!!!)
   PostData(n, myCuts);
}

MyTask::UserCreateOutputObjects()
{
// DO NOT CREATE CUTS/PARAM OBJECTS HERE
}

MyTask::UserExec()
{
// DO NOT POST DATA FOR CUTS OBJECT SLOTS
// You MAY use fCuts object if this is streamable
}

MyTask::Terminate()
{
   // Get objects from output slots post-process them
   ...
   // Update or add objects to fCuts if needed
   fCuts->Add(some_other_object);
}

END:
This param/cuts object will end-up in the file:folder you requested when defining the container. Voila...

14 years agoFilling in ESD SM geomatry matrix: path of matrix existance was checked but the...
gconesab [Sun, 14 Mar 2010 11:10:15 +0000 (11:10 +0000)]
Filling in  ESD SM geomatry matrix: path of matrix existance was checked but the matrix was not recovered, just the default, now fixed. Change hardcoded number of SuperModules by the actual number set in the geometry.

14 years agoNew analysis profiling implementation. Triggering collection of system info works...
agheata [Sun, 14 Mar 2010 09:43:01 +0000 (09:43 +0000)]
New analysis profiling implementation. Triggering collection of system info works only in "local" modeis done as usual via:
   mgr->SetNSysInfo(nevents); // Dump info in sysinfo.txt each nevents
A final displayed canvas contains: alocated VM[kB] per event for each top task (plot includes all subtasks), alocated VM for all tasks in CreateOutputObjects, alocated VM for all tasks in Terminate, VM profile for full analysis.

The memory profile is stored in a tree in a file sysinfo.root. One can investigate his task via:
   mgr->ProfileTask(const char *taskname); or:
   mgr->ProfileTask(Int_t itask)
where: taskname is the task name and itask is the task index in the list of top level tasks.
This will produce a canvas with memory alocation in CreateOutputObjects(), Exec() and Terminate() methods + CPU time spent per event

14 years agostyle violation fixes: added comments
dsilverm [Sat, 13 Mar 2010 20:50:35 +0000 (20:50 +0000)]
style violation fixes: added comments

14 years agoFix coding rule violations
cblume [Sat, 13 Mar 2010 16:43:47 +0000 (16:43 +0000)]
Fix coding rule violations

14 years agoDistortion macros - very preliminary version
marian [Sat, 13 Mar 2010 11:18:35 +0000 (11:18 +0000)]
Distortion macros - very preliminary version
Once fully debugged - will be moved to the compiled part of the code
(Magnus, Jim)

14 years ago Simple compiled macro for declaration of static distortion function
marian [Sat, 13 Mar 2010 11:09:32 +0000 (11:09 +0000)]
  Simple compiled macro for declaration of static distortion function
  on top of the AliTPCDistortion class.
  Why:
  1. Use static function in the fitting procedure
  2. Usage in TFormual, TF1, Tf2 ... for visualization.
  3. Usage in  tree->Draw() for visualization
  4. Simple visualization of fit residuals in multidemension - using tree Draw functionality

14 years agocoding violations
slindal [Sat, 13 Mar 2010 08:48:59 +0000 (08:48 +0000)]
coding violations

14 years agocoding violations
slindal [Sat, 13 Mar 2010 08:36:42 +0000 (08:36 +0000)]
coding violations

14 years agoFixes to obey coding conventions
masera [Fri, 12 Mar 2010 21:15:47 +0000 (21:15 +0000)]
Fixes to obey coding conventions

14 years ago- Reading of packed TRAP config from raw data for full half-chamber
cblume [Fri, 12 Mar 2010 20:29:33 +0000 (20:29 +0000)]
- Reading of packed TRAP config from raw data for full half-chamber
- Storage of DMEM content in separate blocks according to
  different granularities, incl. PID LUT (Uwe)

14 years agoImprovements (Jens Wiechula); AliDielectronCFdraw still produces a warning.
andronic [Fri, 12 Mar 2010 18:39:09 +0000 (18:39 +0000)]
Improvements (Jens Wiechula); AliDielectronCFdraw still produces a warning.

14 years agoMajor changes in AliPhysicsSelection (Michele)
jgrosseo [Fri, 12 Mar 2010 17:55:13 +0000 (17:55 +0000)]
Major changes in AliPhysicsSelection (Michele)
-- Default trigger is now MB1
-- You can calculate the background in your sample by providing a special function in your task,
see docu of AliPhysicsSelection

14 years agoAdd online raw reader by Jochen as default version
cblume [Fri, 12 Mar 2010 16:58:26 +0000 (16:58 +0000)]
Add online raw reader by Jochen as default version

14 years agoRemoving obsolete file
hristov [Fri, 12 Mar 2010 16:41:21 +0000 (16:41 +0000)]
Removing obsolete file

14 years agoITS services on side A (M. Sitta)
masera [Fri, 12 Mar 2010 16:20:43 +0000 (16:20 +0000)]
ITS services on side A (M. Sitta)

14 years agoBugs squashed.
policheh [Fri, 12 Mar 2010 15:38:14 +0000 (15:38 +0000)]
Bugs squashed.

14 years agoI implemented the possibility
morsch [Fri, 12 Mar 2010 15:07:03 +0000 (15:07 +0000)]
I implemented the possibility
- to reject all tracks that have shared TPC clusters:
� void SetAcceptSharedTPCClusters(Bool_t b=kTRUE){fCutAcceptSharedTPCClusters=b;}

Marta Verweij <marta.verweij@cern.ch>

14 years agoUpdate for AliAODHeader. (R. Arnaldi)
morsch [Fri, 12 Mar 2010 14:54:03 +0000 (14:54 +0000)]
Update for AliAODHeader. (R. Arnaldi)

14 years agoUpdates for dimuons (R. Arnaldi)
morsch [Fri, 12 Mar 2010 14:51:33 +0000 (14:51 +0000)]
Updates for dimuons (R. Arnaldi)

14 years agoSome fixes for memory leaks
kleinb [Fri, 12 Mar 2010 13:35:57 +0000 (13:35 +0000)]
Some fixes for memory leaks

14 years agoMoving AliTRDCalPID to libTRDbase.pkg since it is used by AliTRDcalibDB (loadlibs.C)
hristov [Fri, 12 Mar 2010 12:31:58 +0000 (12:31 +0000)]
Moving AliTRDCalPID to libTRDbase.pkg since it is used by AliTRDcalibDB (loadlibs.C)

14 years agocorrecting the RecoParam once more. It turned out that it is not possible to use...
richterm [Fri, 12 Mar 2010 11:53:57 +0000 (11:53 +0000)]
correcting the RecoParam once more. It turned out that it is not possible to use one default AliDetectorRecoParam object for all event species. Using
now a TObjArray with 4 entries of specie 3(!), 4, 8, 16 like all the other detectors. However it is not clear why it is 3 and not 2.

14 years agoClass for Omega Dalitz Decays (R. Averbeck, AM)
morsch [Fri, 12 Mar 2010 11:38:21 +0000 (11:38 +0000)]
Class for Omega Dalitz Decays (R. Averbeck, AM)

14 years agoSet output slot 0 of task
esicking [Fri, 12 Mar 2010 10:54:51 +0000 (10:54 +0000)]
Set output slot 0 of task

14 years agoprimary track and eta cuts for TRD influence on pt resolution @ vertex
abercuci [Fri, 12 Mar 2010 10:46:45 +0000 (10:46 +0000)]
primary track and eta cuts for TRD influence on pt resolution @ vertex

14 years agoRemoving obsolete calls
hristov [Fri, 12 Mar 2010 10:46:13 +0000 (10:46 +0000)]
Removing obsolete calls

14 years agoDetector Algorithm for pedestal runs.
policheh [Fri, 12 Mar 2010 10:30:59 +0000 (10:30 +0000)]
Detector Algorithm for pedestal runs.

14 years agoNew version.
agheata [Fri, 12 Mar 2010 10:28:03 +0000 (10:28 +0000)]
New version.

14 years agoPlot rather virtual memory usage per process than total memory.
agheata [Fri, 12 Mar 2010 10:27:32 +0000 (10:27 +0000)]
Plot rather virtual memory usage per process than total memory.

14 years agoFix usage of fFillAODRun flag
agheata [Fri, 12 Mar 2010 10:25:20 +0000 (10:25 +0000)]
Fix usage of fFillAODRun flag

14 years agoFix for report #63691: Update the PHOS section in Config.C for MC production
hristov [Fri, 12 Mar 2010 10:24:26 +0000 (10:24 +0000)]
Fix for report #63691: Update the PHOS section in Config.C for MC production

14 years agoM makeCalibTree.sh - use standard halloWorld.sh script
marian [Fri, 12 Mar 2010 10:19:57 +0000 (10:19 +0000)]
M      makeCalibTree.sh    - use standard halloWorld.sh script
M      guiTime             - use standard startGUItime.sh

14 years agoFix for report #63895: Request new reconstruction step (the track length must be...
hristov [Fri, 12 Mar 2010 08:41:44 +0000 (08:41 +0000)]
Fix for report #63895: Request new reconstruction step (the track length must be calculated between two points in the _same_ local coordinate system)

14 years agoforgotten commit
marian [Fri, 12 Mar 2010 08:27:19 +0000 (08:27 +0000)]
forgotten commit

14 years agofixed rule violations
slindal [Fri, 12 Mar 2010 06:06:12 +0000 (06:06 +0000)]
fixed rule violations