From bae6da3c7b4d4f090f8f86b78afeaa9ca71ad825 Mon Sep 17 00:00:00 2001 From: morsch Date: Sat, 29 Jan 2011 19:31:22 +0000 Subject: [PATCH] Coverity fixes. --- FASTSIM/AliFastGlauber.cxx | 26 ++++++++--------- FASTSIM/AliFastMuonTriggerEff.cxx | 20 ++++++------- FASTSIM/AliMUONFastTracking.cxx | 48 +++++++++++++++---------------- 3 files changed, 47 insertions(+), 47 deletions(-) diff --git a/FASTSIM/AliFastGlauber.cxx b/FASTSIM/AliFastGlauber.cxx index 88089cb9443..13699f14730 100644 --- a/FASTSIM/AliFastGlauber.cxx +++ b/FASTSIM/AliFastGlauber.cxx @@ -284,7 +284,7 @@ void AliFastGlauber::Init(Int_t mode) Char_t almondName[100]; TFile* ff = new TFile(fName.Data()); for(Int_t k=0; k<40; k++) { - sprintf(almondName,"WAlmondFixedB%d",k); + snprintf(almondName,100, "WAlmondFixedB%d",k); fgWAlmondCurrent = (TF2*)ff->Get(almondName); fgWAlmondFixedB[k] = fgWAlmondCurrent; } @@ -350,13 +350,13 @@ void AliFastGlauber::DrawWSb() const l1a->SetFillStyle(0); l1a->SetBorderSize(0); Char_t label[100]; - sprintf(label,"r_{0} = %.2f fm",fWSr0); + snprintf(label,100, "r_{0} = %.2f fm",fWSr0); l1a->AddEntry(fgWSb,label,""); - sprintf(label,"d = %.2f fm",fWSd); + snprintf(label,100, "d = %.2f fm",fWSd); l1a->AddEntry(fgWSb,label,""); - sprintf(label,"n = %.2e fm^{-3}",fWSn); + snprintf(label,100, "n = %.2e fm^{-3}",fWSn); l1a->AddEntry(fgWSb,label,""); - sprintf(label,"#omega = %.2f",fWSw); + snprintf(label,100, "#omega = %.2f",fWSw); l1a->AddEntry(fgWSb,label,""); l1a->Draw(); c1->Update(); @@ -396,7 +396,7 @@ void AliFastGlauber::DrawParticipants() const l1a->SetFillStyle(0); l1a->SetBorderSize(0); Char_t label[100]; - sprintf(label,"#sigma^{inel.}_{NN} = %.1f mbarn",fSigmaNN); + snprintf(label,100, "#sigma^{inel.}_{NN} = %.1f mbarn",fSigmaNN); l1a->AddEntry(fgWParticipants,label,""); l1a->Draw(); c3->Update(); @@ -436,7 +436,7 @@ void AliFastGlauber::DrawGeo() const l1a->SetFillStyle(0); l1a->SetBorderSize(0); Char_t label[100]; - sprintf(label,"#sigma_{NN}^{inel.} = %.1f mbarn",fSigmaNN); + snprintf(label,100, "#sigma_{NN}^{inel.} = %.1f mbarn",fSigmaNN); l1a->AddEntry(fgWSgeo,label,""); l1a->Draw(); c5->Update(); @@ -460,7 +460,7 @@ void AliFastGlauber::DrawBinary() const l1a->SetFillStyle(0); l1a->SetBorderSize(0); Char_t label[100]; - sprintf(label,"#sigma_{NN}^{hard} = %.1f mbarn",fSigmaHard); + snprintf(label,100, "#sigma_{NN}^{hard} = %.1f mbarn",fSigmaHard); l1a->AddEntry(fgWSb,label,""); l1a->Draw(); c6->Update(); @@ -484,9 +484,9 @@ void AliFastGlauber::DrawN() const l1a->SetFillStyle(0); l1a->SetBorderSize(0); Char_t label[100]; - sprintf(label,"#sigma^{hard}_{NN} = %.1f mbarn",fSigmaHard); + snprintf(label,100, "#sigma^{hard}_{NN} = %.1f mbarn",fSigmaHard); l1a->AddEntry(fgWSN,label,""); - sprintf(label,"#sigma^{inel.}_{NN} = %.1f mbarn",fSigmaNN); + snprintf(label,100, "#sigma^{inel.}_{NN} = %.1f mbarn",fSigmaNN); l1a->AddEntry(fgWSN,label,""); l1a->Draw(); c7->Update(); @@ -510,7 +510,7 @@ void AliFastGlauber::DrawKernel(Double_t b) const l1a->SetFillStyle(0); l1a->SetBorderSize(0); Char_t label[100]; - sprintf(label,"b = %.1f fm",b); + snprintf(label, 100, "b = %.1f fm",b); l1a->AddEntry(fgWStarfi,label,""); l1a->Draw(); c8->Update(); @@ -534,7 +534,7 @@ void AliFastGlauber::DrawAlmond(Double_t b) const l1a->SetFillStyle(0); l1a->SetBorderSize(0); Char_t label[100]; - sprintf(label,"b = %.1f fm",b); + snprintf(label, 100, "b = %.1f fm",b); l1a->AddEntry(fgWAlmond,label,""); l1a->Draw(); c9->Update(); @@ -1246,7 +1246,7 @@ void AliFastGlauber::StoreAlmonds() const Char_t almondName[100]; TFile* ff = new TFile(fName.Data(),"update"); for(Int_t k=0; k<40; k++) { - sprintf(almondName,"WAlmondFixedB%d",k); + snprintf(almondName, 100, "WAlmondFixedB%d",k); Double_t b = 0.25+k*0.5; Info("StoreAlmonds"," b = %f\n",b); fgWAlmond->SetParameter(0,b); diff --git a/FASTSIM/AliFastMuonTriggerEff.cxx b/FASTSIM/AliFastMuonTriggerEff.cxx index a8bb733d41a..29a8e841db7 100644 --- a/FASTSIM/AliFastMuonTriggerEff.cxx +++ b/FASTSIM/AliFastMuonTriggerEff.cxx @@ -207,9 +207,9 @@ Int_t AliFastMuonTriggerEff::LoadTables(Char_t *namet=""){ // Load the trigger tables // Char_t hNameA[100],hNameL[100],hNameH[100]; - sprintf(hNameA,"hEffAPt%s",namet); - sprintf(hNameL,"hEffLPt%s",namet); - sprintf(hNameH,"hEffHPt%s",namet); + snprintf(hNameA, 100, "hEffAPt%s",namet); + snprintf(hNameL, 100, "hEffLPt%s",namet); + snprintf(hNameH, 100, "hEffHPt%s",namet); fhEffAPt = (TH3F*)gDirectory->Get(hNameA); fhEffLPt = (TH3F*)gDirectory->Get(hNameL); fhEffHPt = (TH3F*)gDirectory->Get(hNameH); @@ -247,11 +247,11 @@ void AliFastMuonTriggerEff::Init() Int_t intb=0; Char_t namet[10]; if(TMath::Abs(fBkg)<0.00001){ - sprintf(namet,"00"); + snprintf(namet, 10, "00"); }else if(TMath::Abs(fBkg-0.5)<0.00001){ - sprintf(namet,"05"); + snprintf(namet, 10, "05"); }else if(TMath::Abs(fBkg-1.0)<0.00001){ - sprintf(namet,"10"); + snprintf(namet, 10, "10"); }else{ PLIN; printf("A table for Bkg level: %f does not exists\n",fBkg); intb=1; @@ -261,13 +261,13 @@ void AliFastMuonTriggerEff::Init() TH3F* ha1,*hl1,*hh1,*ha2,*hl2,*hh2,*ha0,*hl0,*hh0; Char_t name1[10],name2[10]; Float_t b1,b2; if(fBkg>0&&fBkg<0.5){ - sprintf(name1,"00"); - sprintf(name2,"05"); + snprintf(name1,10, "00"); + snprintf(name2,10, "05"); b1=0.; b2=0.5; }else if(fBkg>0.5){ - sprintf(name1,"05"); - sprintf(name2,"10"); + snprintf(name1, 10, "05"); + snprintf(name2, 10, "10"); b1=0.5; b2=1.0; if(fBkg>1.0){ diff --git a/FASTSIM/AliMUONFastTracking.cxx b/FASTSIM/AliMUONFastTracking.cxx index 943e5837d4f..2b4f90dceef 100644 --- a/FASTSIM/AliMUONFastTracking.cxx +++ b/FASTSIM/AliMUONFastTracking.cxx @@ -143,8 +143,8 @@ void AliMUONFastTracking::Init(Float_t bkg) } char filename [100]; - if (fClusterFinder==kOld) sprintf (filename,"$(ALICE_ROOT)/FASTSIM/data/MUONtrackLUT.root"); - else sprintf (filename,"$(ALICE_ROOT)/FASTSIM/data/MUONtrackLUT-AZ.root"); + if (fClusterFinder==kOld) snprintf (filename, 100, "$(ALICE_ROOT)/FASTSIM/data/MUONtrackLUT.root"); + else snprintf (filename, 100, "$(ALICE_ROOT)/FASTSIM/data/MUONtrackLUT-AZ.root"); TFile *file = new TFile(filename); ReadLUT(file); @@ -167,13 +167,13 @@ void AliMUONFastTracking::ReadLUT(TFile* file) const Float_t kBkg[4] = {0, 0.5, 1, 2}; for (Int_t ibkg=0; ibkg<4; ibkg++) { - sprintf (tag,"BKG%g",kBkg[ibkg]); + snprintf (tag, 40, "BKG%g",kBkg[ibkg]); file->cd(tag); for (Int_t isplp = 0; isplpGet(tag2); - sprintf (tag2,"hacc[%d][%d]",isplp,ispltheta); + snprintf (tag2, 40, "hacc[%d][%d]",isplp,ispltheta); hacc[isplp][ispltheta] = (TH3F*)gDirectory->Get(tag2); } } @@ -618,17 +618,17 @@ void AliMUONFastTracking::SetSpline(){ ysigmaphi[ip] = fCurrentEntry[ip][itheta][iphi]->GetSigmaphi(); } if (fPrintLevel>3) cout << " creating new spline " << splname << endl; - sprintf (splname,"fSplineEff[%d][%d]",ispline,ivar); + snprintf (splname, 40, "fSplineEff[%d][%d]",ispline,ivar); fSplineEff[ispline][ivar] = new TSpline3(splname,xsp2,yeff,5 * nbins[ivar]); - sprintf (splname,"fSplineAcc[%d][%d]",ispline,ivar); + snprintf (splname, 40, "fSplineAcc[%d][%d]",ispline,ivar); fSplineAcc[ispline][ivar] = new TSpline3(splname,xsp2,yacc,5 * nbins[ivar]); - sprintf (splname,"fSplineSigmap[%d][%d]",ispline,ivar); + snprintf (splname, 40, "fSplineSigmap[%d][%d]",ispline,ivar); fSplineSigmap[ispline][ivar] = new TSpline3(splname,xspl,ysigmap,nbins[ivar]); - sprintf (splname,"fSplineSigma1p[%d][%d]",ispline,ivar); + snprintf (splname, 40, "fSplineSigma1p[%d][%d]",ispline,ivar); fSplineSigma1p[ispline][ivar] = new TSpline3(splname,xspl,ysigma1p,nbins[ivar]); - sprintf (splname,"fSplineSigmatheta[%d][%d]",ispline,ivar); + snprintf (splname, 40, "fSplineSigmatheta[%d][%d]",ispline,ivar); fSplineSigmatheta[ispline][ivar] = new TSpline3(splname,xspl,ysigmatheta,nbins[ivar]); - sprintf (splname,"fSplineSigmaphi[%d][%d]",ispline,ivar); + snprintf (splname, 40, "fSplineSigmaphi[%d][%d]",ispline,ivar); fSplineSigmaphi[ispline][ivar] = new TSpline3(splname,xspl,ysigmaphi,nbins[ivar]); ispline++; } @@ -647,17 +647,17 @@ void AliMUONFastTracking::SetSpline(){ ysigmaphi[itheta] = fCurrentEntry[ip][itheta][iphi]->GetSigmaphi(); } if (fPrintLevel>3) cout << " creating new spline " << splname << endl; - sprintf (splname,"fSplineEff[%d][%d]",ispline,ivar); + snprintf (splname, 40, "fSplineEff[%d][%d]",ispline,ivar); fSplineEff[ispline][ivar] = new TSpline3(splname,xspl,yeff, nbins[ivar]); - sprintf (splname,"fSplineAcc[%d][%d]",ispline,ivar); + snprintf (splname, 40, "fSplineAcc[%d][%d]",ispline,ivar); fSplineAcc[ispline][ivar] = new TSpline3(splname,xspl,yacc, nbins[ivar]); - sprintf (splname,"fSplineSigmap[%d][%d]",ispline,ivar); + snprintf (splname, 40, "fSplineSigmap[%d][%d]",ispline,ivar); fSplineSigmap[ispline][ivar] = new TSpline3(splname,xspl,ysigmap,nbins[ivar]); - sprintf (splname,"fSplineSigma1p[%d][%d]",ispline,ivar); + snprintf (splname, 40, "fSplineSigma1p[%d][%d]",ispline,ivar); fSplineSigma1p[ispline][ivar] = new TSpline3(splname,xspl,ysigma1p,nbins[ivar]); - sprintf (splname,"fSplineSigmatheta[%d][%d]",ispline,ivar); + snprintf (splname, 40, "fSplineSigmatheta[%d][%d]",ispline,ivar); fSplineSigmatheta[ispline][ivar] = new TSpline3(splname,xspl,ysigmatheta,nbins[ivar]); - sprintf (splname,"fSplineSigmaphi[%d][%d]",ispline,ivar); + snprintf (splname, 40, "fSplineSigmaphi[%d][%d]",ispline,ivar); fSplineSigmaphi[ispline][ivar] = new TSpline3(splname,xspl,ysigmaphi,nbins[ivar]); ispline++; } @@ -676,17 +676,17 @@ void AliMUONFastTracking::SetSpline(){ ysigmaphi[iphi] = fCurrentEntry[ip][itheta][iphi]->GetSigmaphi(); } if (fPrintLevel>3) cout << " creating new spline " << splname << endl; - sprintf (splname,"fSplineEff[%d][%d]",ispline,ivar); + snprintf (splname, 40, "fSplineEff[%d][%d]",ispline,ivar); fSplineEff[ispline][ivar] = new TSpline3(splname,xspl,yeff, nbins[ivar]); - sprintf (splname,"fSplineAcc[%d][%d]",ispline,ivar); + snprintf (splname, 40, "fSplineAcc[%d][%d]",ispline,ivar); fSplineAcc[ispline][ivar] = new TSpline3(splname,xspl,yacc, nbins[ivar]); - sprintf (splname,"fSplineSigmap[%d][%d]",ispline,ivar); + snprintf (splname, 40, "fSplineSigmap[%d][%d]",ispline,ivar); fSplineSigmap[ispline][ivar] = new TSpline3(splname,xspl,ysigmap,nbins[ivar]); - sprintf (splname,"fSplineSigma1p[%d][%d]",ispline,ivar); + snprintf (splname, 40, "fSplineSigma1p[%d][%d]",ispline,ivar); fSplineSigma1p[ispline][ivar] = new TSpline3(splname,xspl,ysigma1p,nbins[ivar]); - sprintf (splname,"fSplineSigmatheta[%d][%d]",ispline,ivar); + snprintf (splname, 40, "fSplineSigmatheta[%d][%d]",ispline,ivar); fSplineSigmatheta[ispline][ivar] = new TSpline3(splname,xspl,ysigmatheta,nbins[ivar]); - sprintf (splname,"fSplineSigmaphi[%d][%d]",ispline,ivar); + snprintf (splname, 40, "fSplineSigmaphi[%d][%d]",ispline,ivar); fSplineSigmaphi[ispline][ivar] = new TSpline3(splname,xspl,ysigmaphi,nbins[ivar]); ispline++; } @@ -773,7 +773,7 @@ TF1* AliMUONFastTracking::GetFitP(Int_t ip,Int_t itheta,Int_t iphi) { // gets the correct prec-pgen distribution for a given LUT cell if (!fFitp[ip][itheta][iphi]) { char name[256]; - sprintf(name, "fit_%d_%d_%d", ip, itheta, iphi); + snprintf(name, 256, "fit_%d_%d_%d", ip, itheta, iphi); fFitp[ip][itheta][iphi] = new TF1(name ,FitP,-20.,20.,6); fFitp[ip][itheta][iphi]->SetNpx(500); fFitp[ip][itheta][iphi]->SetParameters(0.,0.,0.,0.,0.,0.); -- 2.39.3