From f3652e39c9be480f57dd506132ce8674e2ccc681 Mon Sep 17 00:00:00 2001
From: haavard <haavard@f7af4fe6-9843-0410-8265-dc069ae4e863>
Date: Mon, 21 Mar 2011 15:58:42 +0000
Subject: [PATCH 1/1] coverity fixes

---
 TPC/AliTPCPreprocessor.cxx | 64 ++++++++++++++++++++++++++++++++------
 1 file changed, 54 insertions(+), 10 deletions(-)

diff --git a/TPC/AliTPCPreprocessor.cxx b/TPC/AliTPCPreprocessor.cxx
index a3e411bdfa6..501ed83575b 100644
--- a/TPC/AliTPCPreprocessor.cxx
+++ b/TPC/AliTPCPreprocessor.cxx
@@ -738,23 +738,63 @@ UInt_t AliTPCPreprocessor::ExtractPedestals(Int_t sourceFXS)
 // inner sectors
     for (Int_t sector=0; sector<nSectors/2; sector++) {
        if (foundSectorsPed[sector] < 1 ) {
-          AliTPCCalROC *rocOCDB=calPadPedOCDB->GetCalROC(sector);
-	  calPadPed->SetCalROC(rocOCDB,sector);
+          if (calPadPedOCDB) {
+            AliTPCCalROC *rocOCDB=calPadPedOCDB->GetCalROC(sector);
+	    calPadPed->SetCalROC(rocOCDB,sector);
+	  } else {
+	    const int mess_length=100;
+            char message[mess_length];
+	    snprintf(message,mess_length,"Missing pedestals for sector %d - also not available from previous OCDB entry.\n",
+	             sector);
+	    Log (message);
+	    result = 2;
+	  }
        }
        if (foundSectorsRMS[sector] < 1 ) {
-          AliTPCCalROC *rocOCDB=calPadRMSOCDB->GetCalROC(sector);
-	  calPadRMS->SetCalROC(rocOCDB,sector);
+          if (calPadRMSOCDB) {
+            AliTPCCalROC *rocOCDB=calPadRMSOCDB->GetCalROC(sector);
+	    calPadRMS->SetCalROC(rocOCDB,sector);
+	  } else {
+	    const int mess_length=100;
+            char message[mess_length];
+	    snprintf(message,mess_length,"Missing pedestal RMS for sector %d - also not available from previous OCDB entry.\n",
+	             sector);
+	    Log (message);
+	    result = 2;
+	  }       
        }
     }
+
 // outer sectors -- two updates needed
+
     for (Int_t sector=nSectors/2; sector<nSectors; sector++) {
        if (foundSectorsPed[sector] < 2 ) {
-          AliTPCCalROC *rocOCDB=calPadPedOCDB->GetCalROC(sector);
-	  calPadPed->SetCalROC(rocOCDB,sector);
+          if (calPadPedOCDB) {
+            AliTPCCalROC *rocOCDB=calPadPedOCDB->GetCalROC(sector);
+	    calPadPed->SetCalROC(rocOCDB,sector);
+	  } else {
+	    const int mess_length=100;
+            char message[mess_length];
+	    snprintf(message,mess_length,"Missing pedestals for sector %d - also not available from previous OCDB entry.\n",
+	             sector);
+	    Log (message);
+	    result = 2;
+	  }
+
        }
        if (foundSectorsRMS[sector] < 2 ) {
-          AliTPCCalROC *rocOCDB=calPadRMSOCDB->GetCalROC(sector);
-	  calPadRMS->SetCalROC(rocOCDB,sector);
+          if (calPadRMSOCDB) {
+            AliTPCCalROC *rocOCDB=calPadRMSOCDB->GetCalROC(sector);
+	    calPadRMS->SetCalROC(rocOCDB,sector);
+	  } else {
+	    const int mess_length=100;
+            char message[mess_length];
+	    snprintf(message,mess_length,"Missing pedestal RMS for sector %d - also not available from previous OCDB entry.\n",
+	             sector);
+	    Log (message);
+	    result = 2;
+	  }       
+
        }       
     }
 
@@ -961,7 +1001,7 @@ if (pulserObjectsOCDB) {
   }
   pulserObjects->Delete();
   delete pulserObjects;
-  pulserObjectsOCDB->Delete();
+  if (pulserObjectsOCDB) pulserObjectsOCDB->Delete();
   delete pulserObjectsOCDB;
 
   return result;
@@ -1383,6 +1423,7 @@ UInt_t AliTPCPreprocessor::ExtractAltro(Int_t sourceFXS, TMap* dcsMap)
 
 // extract list of active DDLs
 
+ if (dcsMap) {
   Bool_t found; 
   TString arrDDL(kNumDDL);
   arrDDL.Append('x',kNumDDL);
@@ -1413,7 +1454,10 @@ UInt_t AliTPCPreprocessor::ExtractAltro(Int_t sourceFXS, TMap* dcsMap)
   activeDDL->Add(key,ddlArray);
   altroObjects->Add(activeDDL);
   changed=true;
-  
+ } else {
+   Log ("ExtractAltro: No DCS map available. Active DDL list cannot be obtained.");
+   result = 3;
+ }        
 
 // extract Altro configuration files
 
-- 
2.39.3