-\documentclass[USenglish]{ifimaster}
+\documentclass[USenglish,11pt]{ifimaster}
\usepackage{import}
\usepackage[utf8]{inputenc}
\usepackage[T1]{fontenc,url}
\usepackage{lmodern} % using Latin Modern to be able to use bold typewriter font
+%\usepackage{mathpazo}
\urlstyle{sf}
\usepackage{listings}
\usepackage{tabularx}
\usepackage{tikz}
\usepackage{tikz-qtree}
\usetikzlibrary{shapes,snakes,trees,arrows,shadows,positioning,calc}
-\usepackage{babel,textcomp,csquotes,ifimasterforside,varioref}
+\usepackage{babel,textcomp,csquotes,ifimasterforside}
+
+\usepackage{varioref}
\usepackage[hidelinks]{hyperref}
\usepackage{cleveref}
-\usepackage[style=alphabetic,backend=bibtex]{biblatex}
+\usepackage[xindy]{glossaries}
+
+\usepackage[style=alphabetic,backend=biber]{biblatex}
\usepackage{amsthm}
+\usepackage{mathtools}
\usepackage{graphicx}
% use 'disable' before printing:
\usepackage[]{todonotes}
\theoremstyle{definition}
\newtheorem*{wordDef}{Definition}
+\newtheorem*{theorem}{Theorem}
\graphicspath{ {./figures/} }
\newcommand{\citing}[1]{~\cite{#1}}
-\newcommand{\myref}[1]{\cref{#1} on \cpageref{#1}}
+%\newcommand{\myref}[1]{\cref{#1} on \cpageref{#1}}
+\newcommand{\myref}[1]{\vref{#1}}
+\newcommand{\Myref}[1]{\Vref{#1}}
+
+%\newcommand{\glossref}[1]{\textsuperscript{(\glsrefentry{#1})}}
+%\newcommand{\gloss}[1]{\gls{#1}\glossref{#1}}
+%\newcommand{\glosspl}[1]{\glspl{#1}\glossref{#1}}
+\newcommand{\gloss}[1]{\gls{#1}}
+\newcommand{\glosspl}[1]{\glspl{#1}}
\newcommand{\definition}[1]{\begin{wordDef}#1\end{wordDef}}
\newcommand{\see}[1]{(see \myref{#1})}
-\newcommand{\See}[1]{(See \myref{#1}.)}
\newcommand{\explanation}[3]{\noindent\textbf{\textit{#1}}\\*\emph{When:}
#2\\*\emph{How:} #3\\*[-7px]}
\newcommand{\methodwithref}[2]{\method{#2}\footnote{\type{#1}\method{\##2()}}}
\newcommand{\var}[1]{\type{#1}}
-\newcommand{\refactoring}[1]{\emph{#1}}
-\newcommand{\ExtractMethod}{\refactoring{Extract Method}\xspace}
-\newcommand{\MoveMethod}{\refactoring{Move Method}\xspace}
-\newcommand{\ExtractAndMoveMethod}{\refactoring{Extract and Move Method}\xspace}
+\newcommand{\name}[1]{#1}
+\newcommand{\tit}[1]{\emph{#1}}
+\newcommand{\refa}[1]{\emph{#1}}
+\newcommand{\pattern}[1]{\emph{#1}}
+\newcommand{\metr}[1]{\emph{#1}}
+\newcommand{\ExtractMethod}{\refa{Extract Method}\xspace}
+\newcommand{\MoveMethod}{\refa{Move Method}\xspace}
+\newcommand{\ExtractAndMoveMethod}{\refa{Extract and Move Method}\xspace}
+
+\newcommand{\m}[1]{$#1$}
\newcommand\todoin[2][]{\todo[inline, caption={#2}, #1]{
\begin{minipage}{\textwidth-4pt}#2\end{minipage}}}
\subtitle{Composing the Extract and Move Method refactorings in Eclipse}
\author{Erlend Kristiansen}
+\makeglossaries
+\newglossaryentry{profiling}
+{
+ name=profiling,
+ description={is to run a computer program through a profiler/with a profiler
+ attached}
+}
+\newglossaryentry{profiler}
+{
+ name=profiler,
+ description={A profiler is a program for analyzing performance within an
+ application. It is used to analyze memory consumption, processing time and
+frequency of procedure calls and such}
+}
+\newglossaryentry{xUnit}
+{
+ name={xUnit framework},
+ description={An xUnit framework is a framework for writing unit tests for a
+ computer program. It follows the patterns known from the JUnit framework for
+ Java\citing{fowlerXunit}
+ },
+ plural={xUnit frameworks}
+}
+\newglossaryentry{softwareObfuscation}
+{
+ name={software obfuscation},
+ description={makes source code harder to read and analyze, while preserving
+ its semantics}
+}
+\newglossaryentry{extractClass}
+{
+ name=\refa{Extract Class},
+ description={The \refa{Extract Class} refactoring works by creating a class,
+for then to move members from another class to that class and access them from
+the old class via a reference to the new class}
+}
+\newglossaryentry{designPattern}
+{
+ name={design pattern},
+ description={A design pattern is a named abstraction, that is meant to solve a
+ general design problem. It describes the key aspects of a common problem and
+identifies its participators and how they collaborate},
+ plural={design patterns}
+}
+\newglossaryentry{enclosingClass}
+{
+ name={enclosing class},
+ description={An enclosing class is the class that surrounds any specific piece
+ of code that is written in the inner scope of this class},
+}
+\newglossaryentry{mementoPattern}
+{
+ name={memento pattern},
+ description={The memento pattern is a software design pattern that is used to
+ capture an object's internal state so that it can be restored to this state
+ later\citing{designPatterns}},
+}
+%\newglossaryentry{extractMethod}
+%{
+% name=\refa{Extract Method},
+% description={The \refa{Extract Method} refactoring is used to extract a
+%fragment of code from its context and into a new method. A call to the new
+%method is inlined where the fragment was before. It is used to break code into
+%logical units, with names that explain their purpose}
+%}
+%\newglossaryentry{moveMethod}
+%{
+% name=\refa{Move Method},
+% description={The \refa{Move Method} refactoring is used to move a method from
+% one class to another. This is useful if the method is using more features of
+% another class than of the class which it is currently defined. Then all calls
+% to this method must be updated, or the method must be copied, with the old
+%method delegating to the new method}
+%}
+
\bibliography{bibliography/master-thesis-erlenkr-bibliography}
- % UML comment in TikZ:
- % ref: https://tex.stackexchange.com/questions/103688/folded-paper-shape-tikz
+% UML comment in TikZ:
+% ref: https://tex.stackexchange.com/questions/103688/folded-paper-shape-tikz
\makeatletter
\pgfdeclareshape{umlcomment}{
\inheritsavedanchors[from=rectangle] % this is nearly a rectangle
font=\ttfamily,
]
+%\interfootnotelinepenalty=10000
+
\begin{document}
+\pagenumbering{roman}
\ififorside
\frontmatter{}
on the performance of a program could make the program behave differently after
a refactoring.
-In the extreme case one could argue that such a thing as \emph{software
-obfuscation} is refactoring. Software obfuscation is to make source code harder
-to read and analyze, while preserving its semantics. It could be done composing
-many, more or less randomly chosen, refactorings. Then the question arise
-whether it can be called a \emph{composite refactoring}
-\see{compositeRefactorings} or not? The answer is not obvious. First, there is
-no way to describe \emph{the} mechanics of software obfuscation, beacause there
-are infinitely many ways to do that. Second, \emph{obfuscation} can be thought
-of as \emph{one operation}: Either the code is obfuscated, or it is not. Third,
-it makes no sense to call software obfuscation \emph{a} refactoring, since it
-holds different meaning to different people. The last point is important, since
-one of the motivations behind defining different refactorings is to build up a
-vocabulary for software professionals to reason and discuss about programs,
-similar to the motivation behind design patterns\citing{designPatterns}. So for
-describing \emph{software obfuscation}, it might be more appropriate to define
-what you do when performing it rather than precisely defining its mechanics in
-terms of other refactorings.
+In the extreme case one could argue that \gloss{softwareObfuscation} is
+refactoring. It is often used to protect proprietary software. It restrains
+uninvited viewers, so they have a hard time analyzing code that they are not
+supposed to know how works. This could be a problem when using a language that
+is possible to decompile, such as Java.
+
+Obfuscation could be done composing many, more or less randomly chosen,
+refactorings. Then the question arises whether it can be called a
+\emph{composite refactoring} or not \see{compositeRefactorings}? The answer is
+not obvious. First, there is no way to describe the mechanics of software
+obfuscation, because there are infinitely many ways to do that. Second,
+obfuscation can be thought of as \emph{one operation}: Either the code is
+obfuscated, or it is not. Third, it makes no sense to call software obfuscation
+\emph{a refactoring}, since it holds different meaning to different people.
+
+This last point is important, since one of the motivations behind defining
+different refactorings, is to establish a \emph{vocabulary} for software
+professionals to use when reasoning about and discussing programs, similar to
+the motivation behind \glosspl{designPattern}\citing{designPatterns}.
+\begin{comment}
+So for describing \emph{software obfuscation}, it might be more appropriate to
+define what you do when performing it rather than precisely defining its
+mechanics in terms of other refactorings.
+\end{comment}
\section{The etymology of 'refactoring'}
It is a little difficult to pinpoint the exact origin of the word
According to Martin Fowler\citing{etymology-refactoring}, there may also be more
than one origin of the word. The most well-known source, when it comes to the
-origin of \emph{refactoring}, is the Smalltalk\footnote{\emph{Smalltalk},
-object-oriented, dynamically typed, reflective programming language. See
-\url{http://www.smalltalk.org}} community and their infamous \emph{Refactoring
+origin of \emph{refactoring}, is the
+Smalltalk\footnote{\label{footNote}Programming language} community and their
+infamous \name{Refactoring
Browser}\footnote{\url{http://st-www.cs.illinois.edu/users/brant/Refactory/RefactoringBrowser.html}}
-described in the article \emph{A Refactoring Tool for
+described in the article \tit{A Refactoring Tool for
Smalltalk}\citing{refactoringBrowser1997}, published in 1997.
Allegedly\citing{etymology-refactoring}, the metaphor of factoring programs was
-also present in the Forth\footnote{\emph{Forth} -- stack-based, extensible
-programming language, without type-checking. See \url{http://www.forth.org}}
-community, and the word ``refactoring'' is mentioned in a book by Leo Brodie,
-called \emph{Thinking Forth}\citing{brodie2004}, first published in
-1984\footnote{\emph{Thinking Forth} was first published in 1984 by the
-\emph{Forth Interest Group}. Then it was reprinted in 1994 with minor
-typographical corrections, before it was transcribed into an electronic edition
-typeset in \LaTeX\ and published under a Creative Commons licence in 2004. The
-edition cited here is the 2004 edition, but the content should essentially be as
-in 1984.}. The exact word is only printed one place~\cite[p.~232]{brodie2004},
-but the term \emph{factoring} is prominent in the book, that also contains a
-whole chapter dedicated to (re)factoring, and how to keep the (Forth) code clean
-and maintainable.
+also present in the Forth\textsuperscript{\ref{footNote}} community, and the
+word ``refactoring'' is mentioned in a book by Leo Brodie, called \tit{Thinking
+Forth}\citing{brodie2004}, first published in 1984\footnote{\tit{Thinking Forth}
+was first published in 1984 by the \name{Forth Interest Group}. Then it was
+reprinted in 1994 with minor typographical corrections, before it was
+transcribed into an electronic edition typeset in \LaTeX\ and published under a
+Creative Commons licence in
+2004. The edition cited here is the 2004 edition, but the content should
+essentially be as in 1984.}. The exact word is only printed one
+place~\cite[p.~232]{brodie2004}, but the term \emph{factoring} is prominent in
+the book, that also contains a whole chapter dedicated to (re)factoring, and how
+to keep the (Forth) code clean and maintainable.
\begin{quote}
\ldots good factoring technique is perhaps the most important skill for a
\end{quote}
Fowler claims that the usage of the word \emph{refactoring} did not pass between
-the \emph{Forth} and \emph{Smalltalk} communities, but that it emerged
+the \name{Forth} and \name{Smalltalk} communities, but that it emerged
independently in each of the communities.
\section{Motivation -- Why people refactor}
There are many reasons why people want to refactor their programs. They can for
instance do it to remove duplication, break up long methods or to introduce
-design patterns\citing{designPatterns} into their software systems. The shared
-trait for all these are that peoples intentions are to make their programs
-\emph{better}, in some sense. But what aspects of their programs are becoming
-improved?
-
-As already mentioned, people often refactor to get rid of duplication. Moving
-identical or similar code into methods, and maybe pushing methods up or down in
-their class hierarchies. Making template methods for overlapping
-algorithms/functionality and so on. It is all about gathering what belongs
-together and putting it all in one place. The resulting code is then easier to
-maintain. When removing the implicit coupling\footnote{When duplicating code,
-the code might not be coupled in other ways than that it is supposed to
-represent the same functionality. So if this functionality is going to change,
-it might need to change in more than one place, thus creating an implicit
-coupling between the multiple pieces of code.} between code snippets, the
+design patterns into their software systems. The shared trait for all these are
+that peoples' intentions are to make their programs \emph{better}, in some
+sense. But what aspects of their programs are becoming improved?
+
+As just mentioned, people often refactor to get rid of duplication. They are
+moving identical or similar code into methods, and are pushing methods up or
+down in their class hierarchies. They are making template methods for
+overlapping algorithms/functionality, and so on. It is all about gathering what
+belongs together and putting it all in one place. The resulting code is then
+easier to maintain. When removing the implicit coupling\footnote{When
+ duplicating code, the duplicate pieces of code might not be coupled, apart
+from representing the same functionality. So if this functionality is going to
+change, it might need to change in more than one place, thus creating an
+implicit coupling between multiple pieces of code.} between code snippets, the
location of a bug is limited to only one place, and new functionality need only
to be added to this one place, instead of a number of places people might not
even remember.
A problem you often encounter when programming, is that a program contains a lot
of long and hard-to-grasp methods. It can then help to break the methods into
-smaller ones, using the \ExtractMethod refactoring\citing{refactoring}. Then you
-may discover something about a program that you were not aware of before;
+smaller ones, using the \ExtractMethod refactoring\citing{refactoring}. Then
+you may discover something about a program that you were not aware of before;
revealing bugs you did not know about or could not find due to the complex
structure of your program. \todo{Proof?} Making the methods smaller and giving
good names to the new ones clarifies the algorithms and enhances the
refactoring an excellent method for exploring unknown program code, or code that
you had forgotten that you wrote.
-Most primitive refactorings are simple. Their true power is first revealed when
-they are combined into larger --- higher level --- refactorings, called
+Most primitive refactorings are simple, and usually involves moving code
+around\citing{kerievsky2005}. The motivation behind them may first be revealed
+when they are combined into larger --- higher level --- refactorings, called
\emph{composite refactorings} \see{compositeRefactorings}. Often the goal of
-such a series of refactorings is a design pattern. Thus the \emph{design} can be
-evolved throughout the lifetime of a program, as opposed to designing up-front.
-It is all about being structured and taking small steps to improve a program's
-design.
+such a series of refactorings is a design pattern. Thus the design can
+\emph{evolve} throughout the lifetime of a program, as opposed to designing
+up-front. It is all about being structured and taking small steps to improve a
+program's design.
Many software design pattern are aimed at lowering the coupling between
different classes and different layers of logic. One of the most famous is
-perhaps the \emph{Model-View-Controller}\citing{designPatterns} pattern. It is
-aimed at lowering the coupling between the user interface and the business logic
-and data representation of a program. This also has the added benefit that the
-business logic could much easier be the target of automated tests, increasing
-the productivity in the software development process. Refactoring is an
-important tool on the way to something greater.
+perhaps the \pattern{Model-View-Controller}\citing{designPatterns} pattern. It
+is aimed at lowering the coupling between the user interface, the business logic
+and the data representation of a program. This also has the added benefit that
+the business logic could much easier be the target of automated tests, thus
+increasing the productivity in the software development process.
Another effect of refactoring is that with the increased separation of concerns
coming out of many refactorings, the \emph{performance} can be improved. When
profiling programs, the problematic parts are narrowed down to smaller parts of
the code, which are easier to tune, and optimization can be performed only where
-needed and in a more effective way.
+needed and in a more effective way\citing{refactoring}.
Last, but not least, and this should probably be the best reason to refactor, is
to refactor to \emph{facilitate a program change}. If one has managed to keep
that seldom see beyond the next milestone.
\section{The magical number seven}\label{magic_number_seven}
-The article \emph{The magical number seven, plus or minus two: some limits on
-our capacity for processing information}\citing{miller1956} by George A.
-Miller, was published in the journal \emph{Psychological Review} in 1956. It
-presents evidence that support that the capacity of the number of objects a
-human being can hold in its working memory is roughly seven, plus or minus two
-objects. This number varies a bit depending on the nature and complexity of the
-objects, but is according to Miller ``\ldots never changing so much as to be
+The article \tit{The magical number seven, plus or minus two: some limits on our
+capacity for processing information}\citing{miller1956} by George A. Miller,
+was published in the journal \name{Psychological Review} in 1956. It presents
+evidence that support that the capacity of the number of objects a human being
+can hold in its working memory is roughly seven, plus or minus two objects. This
+number varies a bit depending on the nature and complexity of the objects, but
+is according to Miller ``\ldots never changing so much as to be
unrecognizable.''
Miller's article culminates in the section called \emph{Recoding}, a term he
borrows from communication theory. The central result in this section is that by
recoding information, the capacity of the amount of information that a human can
process at a time is increased. By \emph{recoding}, Miller means to group
-objects together in chunks and give each chunk a new name that it can be
-remembered by. By organizing objects into patterns of ever growing depth, one
-can memorize and process a much larger amount of data than if it were to be
-represented as its basic pieces. This grouping and renaming is analogous to how
-many refactorings work, by grouping pieces of code and give them a new name.
-Examples are the fundamental \ExtractMethod and \refactoring{Extract Class}
-refactorings\citing{refactoring}.
+objects together in chunks, and give each chunk a new name that it can be
+remembered by.
\begin{quote}
\ldots recoding is an extremely powerful weapon for increasing the amount of
information that we can deal with.~\cite[p.~95]{miller1956}
\end{quote}
+By organizing objects into patterns of ever growing depth, one can memorize and
+process a much larger amount of data than if it were to be represented as its
+basic pieces. This grouping and renaming is analogous to how many refactorings
+work, by grouping pieces of code and give them a new name. Examples are the
+fundamental \ExtractMethod and \refa{Extract Class}
+refactorings\citing{refactoring}.
+
An example from the article addresses the problem of memorizing a sequence of
-binary digits. Let us say we have the following sequence\footnote{The example
- presented here is slightly modified (and shortened) from what is presented in
- the original article\citing{miller1956}, but it is essentially the same.} of
+binary digits. The example presented here is a slightly modified version of the
+one presented in the original article\citing{miller1956}, but it preserves the
+essence of it. Let us say we have the following sequence of
16 binary digits: ``1010001001110011''. Most of us will have a hard time
memorizing this sequence by only reading it once or twice. Imagine if we instead
translate it to this sequence: ``A273''. If you have a background from computer
-science, it will be obvious that the latest sequence is the first sequence
-recoded to be represented by digits with base 16. Most people should be able to
+science, it will be obvious that the latter sequence is the first sequence
+recoded to be represented by digits in base 16. Most people should be able to
memorize this last sequence by only looking at it once.
Another result from the Miller article is that when the amount of information a
Then they can learn distinct words, and later read sequences of words that form
whole sentences. Eventually, most of them will be able to read whole books and
briefly retell the important parts of its content. This suggest that the use of
-design patterns\citing{designPatterns} is a good idea when reasoning about
-computer programs. With extensive use of design patterns when creating complex
-program structures, one does not always have to read whole classes of code to
-comprehend how they function, it may be sufficient to only see the name of a
-class to almost fully understand its responsibilities.
+design patterns is a good idea when reasoning about computer programs. With
+extensive use of design patterns when creating complex program structures, one
+does not always have to read whole classes of code to comprehend how they
+function, it may be sufficient to only see the name of a class to almost fully
+understand its responsibilities.
\begin{quote}
Our language is tremendously useful for repackaging material into a few chunks
Without further evidence, these results at least indicate that refactoring
source code into smaller units with higher cohesion and, when needed,
introducing appropriate design patterns, should aid in the cause of creating
-computer programs that are easier to maintain and has code that is easier (and
+computer programs that are easier to maintain and have code that is easier (and
better) understood.
\section{Notable contributions to the refactoring literature}
-\todoin{Update with more contributions}
+\todoin{Thinking Forth?}
\begin{description}
\item[1992] William F. Opdyke submits his doctoral dissertation called
- \emph{Refactoring Object-Oriented Frameworks}\citing{opdyke1992}. This
- work defines a set of refactorings, that are behavior preserving given that
- their preconditions are met. The dissertation is focused on the automation
- of refactorings.
- \item[1999] Martin Fowler et al.: \emph{Refactoring: Improving the Design of
+ \tit{Refactoring Object-Oriented Frameworks}\citing{opdyke1992}. This work
+ defines a set of refactorings, that are behavior preserving given that their
+ preconditions are met. The dissertation is focused on the automation of
+ refactorings.
+ \item[1999] Martin Fowler et al.: \tit{Refactoring: Improving the Design of
Existing Code}\citing{refactoring}. This is maybe the most influential text
on refactoring. It bares similarities with Opdykes thesis\citing{opdyke1992}
in the way that it provides a catalog of refactorings. But Fowler's book is
more about the craft of refactoring, as he focuses on establishing a
vocabulary for refactoring, together with the mechanics of different
refactorings and when to perform them. His methodology is also founded on
- the principles of test-driven development.
- \item[2005] Joshua Kerievsky: \emph{Refactoring to
+ the principles of test-driven development.
+ \item[2005] Joshua Kerievsky: \tit{Refactoring to
Patterns}\citing{kerievsky2005}. This book is heavily influenced by Fowler's
- \emph{Refactoring}\citing{refactoring} and the ``Gang of Four'' \emph{Design
+ \tit{Refactoring}\citing{refactoring} and the ``Gang of Four'' \tit{Design
Patterns}\citing{designPatterns}. It is building on the refactoring
catalogue from Fowler's book, but is trying to bridge the gap between
\emph{refactoring} and \emph{design patterns} by providing a series of
higher-level composite refactorings, that makes code evolve toward or away
- from certain design patterns. The book is trying to build up the readers
+ from certain design patterns. The book is trying to build up the reader's
intuition around \emph{why} one would want to use a particular design
pattern, and not just \emph{how}. The book is encouraging evolutionary
- design. \See{relationToDesignPatterns}
+ design \see{relationToDesignPatterns}.
\end{description}
\section{Tool support (for Java)}\label{toolSupport}
-This section will briefly compare the refatoring support of the three IDEs
-\emph{Eclipse}\footnote{\url{http://www.eclipse.org/}}, \emph{IntelliJ
-IDEA}\footnote{The IDE under comparison is the \emph{Community Edition},
+This section will briefly compare the refactoring support of the three IDEs
+\name{Eclipse}\footnote{\url{http://www.eclipse.org/}}, \name{IntelliJ
+IDEA}\footnote{The IDE under comparison is the \name{Community Edition},
\url{http://www.jetbrains.com/idea/}} and
-\emph{NetBeans}\footnote{\url{https://netbeans.org/}}. These are the most
+\name{NetBeans}\footnote{\url{https://netbeans.org/}}. These are the most
popular Java IDEs\citing{javaReport2011}.
All three IDEs provide support for the most useful refactorings, like the
surprise.
The IDEs seem to have excellent support for the \ExtractMethod refactoring, so
-at least they have all passed the first refactoring
-rubicon\citing{fowlerRubicon2001,secondRubicon2012}.
+at least they have all passed the first ``refactoring
+rubicon''\citing{fowlerRubicon2001,secondRubicon2012}.
-Regarding the \MoveMethod refactoring, the \emph{Eclipse} and \emph{IntelliJ}
+Regarding the \MoveMethod refactoring, the \name{Eclipse} and \name{IntelliJ}
IDEs do the job in very similar manners. In most situations they both do a
satisfying job by producing the expected outcome. But they do nothing to check
that the result does not break the semantics of the program \see{correctness}.
-The \emph{NetBeans} IDE implements this refactoring in a somewhat
-unsophisticated way. For starters, its default destination for the move is
-itself, although it refuses to perform the refactoring if chosen. But the worst
-part is, that if moving the method \method{f} of the class \type{C} to the class
-\type{X}, it will break the code. The result is shown in
-\myref{lst:moveMethod_NetBeans}.
+The \name{NetBeans} IDE implements this refactoring in a somewhat
+unsophisticated way. For starters, the refactoring's default destination for the
+move, is the same class as the method already resides in, although it refuses to
+perform the refactoring if chosen. But the worst part is, that if moving the
+method \method{f} of the class \type{C} to the class \type{X}, it will break the
+code. The result is shown in \myref{lst:moveMethod_NetBeans}.
\begin{listing}
\begin{multicols}{2}
\label{lst:moveMethod_NetBeans}
\end{listing}
-NetBeans will try to make code that call the methods \method{m} and \method{n}
+\name{NetBeans} will try to create code that call the methods \method{m} and \method{n}
of \type{X} by accessing them through \var{c.x}, where \var{c} is a parameter of
type \type{C} that is added the method \method{f} when it is moved. (This is
seldom the desired outcome of this refactoring, but ironically, this ``feature''
-keeps NetBeans from breaking the code in the example from \myref{correctness}.)
+keeps \name{NetBeans} from breaking the code in the example from \myref{correctness}.)
If \var{c.x} for some reason is inaccessible to \type{X}, as in this case, the
-refactoring breaks the code, and it will not compile. NetBeans presents a
+refactoring breaks the code, and it will not compile. \name{NetBeans} presents a
preview of the refactoring outcome, but the preview does not catch it if the IDE
is about break the program.
-The IDEs under investigation seems to have fairly good support for primitive
-refactorings, but what about more complex ones, such as the \refactoring{Extract
-Class}\citing{refactoring}? The \refactoring{Extract Class} refactoring works by
-creating a class, for then to move members to that class and access them from
-the old class via a reference to the new class. \emph{IntelliJ} handles this in
-a fairly good manner, although, in the case of private methods, it leaves unused
+The IDEs under investigation seem to have fairly good support for primitive
+refactorings, but what about more complex ones, such as
+\gloss{extractClass}\citing{refactoring}? \name{IntelliJ} handles this in a
+fairly good manner, although, in the case of private methods, it leaves unused
methods behind. These are methods that delegate to a field with the type of the
-new class, but are not used anywhere. \emph{Eclipse} has added (or withdrawn)
-its own quirk to the Extract Class refactoring, and only allows for
-\emph{fields} to be moved to a new class, \emph{not methods}. This makes it
-effectively only extracting a data structure, and calling it
-\refactoring{Extract Class} is a little misleading. One would often be better
-off with textual extract and paste than using the Extract Class refactoring in
-Eclipse. When it comes to \emph{NetBeans}, it does not even seem to have made an
-attempt on providing this refactoring. (Well, it probably has, but it does not
-show in the IDE.)
-
-\todoin{Visual Studio (C++/C\#), Smalltalk refactoring browser?,
-second refactoring rubicon?}
+new class, but are not used anywhere. \name{Eclipse} has added its own quirk to
+the \refa{Extract Class} refactoring, and only allows for \emph{fields} to be
+moved to a new class, \emph{not methods}. This makes it effectively only
+extracting a data structure, and calling it \refa{Extract Class} is a little
+misleading. One would often be better off with textual extract and paste than
+using the \refa{Extract Class} refactoring in \name{Eclipse}. When it comes to
+\name{NetBeans}, it does not even show an attempt on providing this refactoring.
\section{The relation to design patterns}\label{relationToDesignPatterns}
-\emph{Refactoring} and \emph{design patterns} have at least one thing in common,
-they are both promoted by advocates of \emph{clean code}\citing{cleanCode} as
-fundamental tools on the road to more maintanable and extendable source code.
+Refactoring and design patterns have at least one thing in common, they are both
+promoted by advocates of \emph{clean code}\citing{cleanCode} as fundamental
+tools on the road to more maintainable and extendable source code.
\begin{quote}
Design patterns help you determine how to reorganize a design, and they can
time and money into a design that inevitably is going to change. By relying on
continuously refactoring a system, its design can be made simpler without
sacrificing flexibility. To be able to fully rely on this approach, it is of
-utter importance to have a reliable suit of tests to lean on. \See{testing} This
+utter importance to have a reliable suit of tests to lean on \see{testing}. This
makes the design process more natural and less characterized by difficult
decisions that has to be made before proceeding in the process, and that is
going to define a project for all of its unforeseeable future.
\noindent So, although an increased amount of method calls could potentially
slow down programs, one should avoid premature optimization and sacrificing good
-design, leaving the performance tuning until after profiling\footnote{For and
- example of a Java profiler, check out VisualVM:
- \url{http://visualvm.java.net/}} the software and having isolated the actual
- problem areas.
+design, leaving the performance tuning until after \gloss{profiling} the
+software and having isolated the actual problem areas.
\section{Composite refactorings}\label{compositeRefactorings}
\todo{motivation, examples, manual vs automated?, what about refactoring in a
\definition{A \emph{primitive refactoring} is a refactoring that cannot be
expressed in terms of other refactorings.}
-\noindent Examples are the \refactoring{Pull Up Field} and \refactoring{Pull Up
+\noindent Examples are the \refa{Pull Up Field} and \refa{Pull Up
Method} refactorings\citing{refactoring}, that move members up in their class
hierarchies.
\definition{A \emph{composite refactoring} is a refactoring that can be
expressed in terms of two or more other refactorings.}
-\noindent An example of a composite refactoring is the \refactoring{Extract
+\noindent An example of a composite refactoring is the \refa{Extract
Superclass} refactoring\citing{refactoring}. In its simplest form, it is composed
of the previously described primitive refactorings, in addition to the
-\refactoring{Pull Up Constructor Body} refactoring\citing{refactoring}. It works
+\refa{Pull Up Constructor Body} refactoring\citing{refactoring}. It works
by creating an abstract superclass that the target class(es) inherits from, then
-by applying \refactoring{Pull Up Field}, \refactoring{Pull Up Method} and
-\refactoring{Pull Up Constructor Body} on the members that are to be members of
-the new superclass. For an overview of the \refactoring{Extract Superclass}
+by applying \refa{Pull Up Field}, \refa{Pull Up Method} and
+\refa{Pull Up Constructor Body} on the members that are to be members of
+the new superclass. If there are multiple classes in play, their interfaces may
+need to be united with the help of some rename refactorings, before extracting
+the superclass. For an overview of the \refa{Extract Superclass}
refactoring, see \myref{fig:extractSuperclass}.
\begin{figure}[h]
\centering
\includegraphics[angle=270,width=\linewidth]{extractSuperclassItalic.pdf}
- \caption{The Extract Superclass refactoring}
+ \caption{The Extract Superclass refactoring, with united interfaces.}
\label{fig:extractSuperclass}
\end{figure}
to errors. Getting it right the first time is not easy, considering the method
signature and all the other aspects of the refactoring that has to be in place.
-Take for instance the renaming of classes, methods and fields. For complex
-programs these refactorings are almost impossible to get right. Attacking them
-with textual search and replace, or even regular expressions, will fall short on
-these tasks. Then it is crucial to have proper tool support that can perform
-them automatically. Tools that can parse source code and thus have semantic
-knowledge about which occurrences of which names belong to what construct in the
-program. For even trying to perform one of these complex task manually, one
-would have to be very confident on the existing test suite \see{testing}.
+Consider the renaming of classes, methods and fields. For complex programs these
+refactorings are almost impossible to get right. Attacking them with textual
+search and replace, or even regular expressions, will fall short on these tasks.
+Then it is crucial to have proper tool support that can perform them
+automatically. Tools that can parse source code and thus have semantic knowledge
+about which occurrences of which names belong to what construct in the program.
+For even trying to perform one of these complex task manually, one would have to
+be very confident on the existing test suite \see{testing}.
\section{Correctness of refactorings}\label{correctness}
For automated refactorings to be truly useful, they must show a high degree of
-behavior preservation. This last sentence might seem obvious, but there are
-examples of refactorings in existing tools that break programs. I will now
-present an example of an \ExtractMethod refactoring followed by a \MoveMethod
-refactoring that breaks a program in both the \emph{Eclipse} and \emph{IntelliJ}
-IDEs\footnote{The NetBeans IDE handles this particular situation without
- altering the program's beavior, mainly because its Move Method refactoring
- implementation is a bit flawed in other ways \see{toolSupport}.}. The
- following piece of code shows the target for the composed refactoring:
-
-\begin{minted}[linenos,samepage]{java}
+behavior preservation. This last sentence might seem obvious, but there are
+examples of refactorings in existing tools that break programs. In an ideal
+world, every automated refactoring would be ``complete'', in the sense that it
+would never break a program. In an ideal world, every program would also be free
+from bugs. In modern IDEs the implemented automated refactorings are working for
+\emph{most} cases, that is enough for making them useful.
+
+I will now present an example of a \emph{corner case} where a program breaks
+when a refactoring is applied. The example shows an \ExtractMethod refactoring
+followed by a \MoveMethod refactoring that breaks a program in both the
+\name{Eclipse} and \name{IntelliJ} IDEs\footnote{The \name{NetBeans} IDE handles this
+ particular situation without altering the program's behavior, mainly because
+ its \refa{Move Method} refactoring implementation is a bit flawed in other ways
+ \see{toolSupport}.}. The target and the destination for the composed
+ refactoring is shown in \myref{lst:correctnessExtractAndMove}. Note that the
+ method \method{m(C c)} of class \type{X} assigns to the field \var{x} of the
+ argument \var{c} that has type \type{C}.
+
+\begin{listing}[h]
+\begin{multicols}{2}
+\begin{minted}[linenos]{java}
+// Refactoring target
public class C {
- public X x = new X();
+ public X x = new X();
- public void f() {
- x.m(this);
- x.n();
- }
+ public void f() {
+ x.m(this);
+ // Not the same x
+ x.n();
+ }
}
\end{minted}
-\noindent The next piece of code shows the destination of the refactoring. Note
-that the method \method{m(C c)} of class \type{C} assigns to the field \var{x}
-of the argument \var{c} that has type \type{C}:
+\columnbreak
-\begin{minted}[samepage]{java}
+\begin{minted}[]{java}
+// Method destination
public class X {
- public void m(C c) {
- c.x = new X();
- }
- public void n() {}
+ public void m(C c) {
+ c.x = new X();
+ // If m is called from
+ // c, then c.x no longer
+ // equals 'this'
+ }
+ public void n() {}
}
\end{minted}
+\end{multicols}
+\caption{The target and the destination for the composition of the Extract
+Method and \refa{Move Method} refactorings.}
+\label{lst:correctnessExtractAndMove}
+\end{listing}
-The refactoring sequence works by extracting line 5 and 6 from the original
+
+The refactoring sequence works by extracting line 6 through 8 from the original
class \type{C} into a method \method{f} with the statements from those lines as
-its method body. The method is then moved to the class \type{X}. The result is
-shown in the following two pieces of code:
+its method body (but with the comment left out, since it will no longer hold any
+meaning). The method is then moved to the class \type{X}. The result is shown
+in \myref{lst:correctnessExtractAndMoveResult}.
+
+Before the refactoring, the methods \method{m} and \method{n} of class \type{X}
+are called on different object instances (see line 6 and 8 of the original class
+\type{C} in \cref{lst:correctnessExtractAndMove}). After the refactoring, they
+are called on the same object, and the statement on line
+3 of class \type{X} (in \cref{lst:correctnessExtractAndMoveResult}) no longer
+ has the desired effect in our example. The method \method{f} of class \type{C}
+ is now calling the method \method{f} of class \type{X} (see line 5 of class
+ \type{C} in \cref{lst:correctnessExtractAndMoveResult}), and the program now
+ behaves different than before.
-\begin{minted}[linenos,samepage]{java}
+\begin{listing}[h]
+\begin{multicols}{2}
+\begin{minted}[linenos]{java}
public class C {
public X x = new X();
}
\end{minted}
-\begin{minted}[linenos,samepage]{java}
+\columnbreak
+
+\begin{minted}[linenos]{java}
public class X {
public void m(C c) {
c.x = new X();
}
public void n() {}
+ // Extracted and
+ // moved method
public void f(C c) {
m(c);
n();
}
}
\end{minted}
-
-After the refactoring, the method \method{f} of class \type{C} is calling the
-method \method{f} of class \type{X}, and the program now behaves different than
-before. (See line 5 of the version of class \type{C} after the refactoring.)
-Before the refactoring, the methods \method{m} and \method{n} of class \type{X}
-are called on different object instances (see line 5 and 6 of the original class
-\type{C}). After, they are called on the same object, and the statement on line
-3 of class \type{X} (the version after the refactoring) no longer have any
- effect in our example.
+\end{multicols}
+\caption{The result of the composed refactoring.}
+\label{lst:correctnessExtractAndMoveResult}
+\end{listing}
The bug introduced in the previous example is of such a nature\footnote{Caused
by aliasing. See \url{https://en.wikipedia.org/wiki/Aliasing_(computing)}}
kind of errors does not reveal themselves.
Unit testing is not a way to \emph{prove} that a program is correct, but it is a
-way to make you confindent that it \emph{probably} works as desired. In the
-context of test driven development (commonly known as TDD), the tests are even a
+way to make you confident that it \emph{probably} works as desired. In the
+context of test-driven development (commonly known as TDD), the tests are even a
way to define how the program is \emph{supposed} to work. It is then, by
definition, working if the tests are passing.
that it is not clear how to create automated tests for it, without changing it
in intrusive ways.
-Unit tests, as they are known from the different xUnit frameworks around, are
+Unit tests, as they are known from the different \glosspl{xUnit} around, are
only suitable to test the \emph{result} of isolated operations. They can not
easily (if at all) observe the \emph{history} of a program.
This problem is still open.
-\todoin{Write?}
\begin{comment}
Assuming a sequential (non-concurrent) program:
%\end{minted}
\end{comment}
-\section{The project}
-The aim of this master project will be to investigate the relationship between a
-composite refactoring composed of the \ExtractMethod and \MoveMethod
-refactorings, and its impact on one or more software metrics.
+
+\chapter{The Project}
+
+\section{Project description}
+The aim of this master's project will be to explore the relationship between the
+\ExtractMethod and the \MoveMethod refactorings. This will be done by composing
+the two into a composite refactoring. The refactoring will be called the
+\ExtractAndMoveMethod refactoring.
+
+The two primitive \ExtractMethod and \MoveMethod refactorings must already be
+implemented in a tool, so the \ExtractAndMoveMethod refactoring is going to be
+built on top of those.
The composition of the \ExtractMethod and \MoveMethod refactorings springs
naturally out of the need to move procedures closer to the data they manipulate.
This composed refactoring is not well described in the literature, but it is
implemented in at least one tool called
-\emph{CodeRush}\footnote{\url{https://help.devexpress.com/\#CodeRush/CustomDocument3519}},
-that is an extension for \emph{MS Visual
+\name{CodeRush}\footnote{\url{https://help.devexpress.com/\#CodeRush/CustomDocument3519}},
+that is an extension for \name{MS Visual
Studio}\footnote{\url{http://www.visualstudio.com/}}. In CodeRush it is called
-\emph{Extract Method to
+\refa{Extract Method to
Type}\footnote{\url{https://help.devexpress.com/\#CodeRush/CustomDocument6710}},
-but I choose to call it \ExtractAndMoveMethod, since I feel it better
+but I choose to call it \ExtractAndMoveMethod, since I feel this better
communicates which primitive refactorings it is composed of.
-For the metrics, I will at least measure the \emph{Coupling between object
-classes} (CBO) metric that is described by Chidamber and Kemerer in their
-article \emph{A Metrics Suite for Object Oriented
-Design}\citing{metricsSuite1994}.
+The project will consist of implementing the \ExtractAndMoveMethod refactoring,
+as well as executing it over a larger code base, as a case study. To be able to
+execute the refactoring automatically, I have to make it analyze code to
+determine the best selections to extract into new methods.
-The project will then consist in implementing the \ExtractAndMoveMethod
-refactoring, as well as executing it over a larger code base. Then the effect of
-the change must be measured by calculating the chosen software metrics both
-before and after the execution. To be able to execute the refactoring
-automatically I have to make it analyze code to determine the best selections to
-extract into new methods.
+\section{The primitive refactorings}
+The refactorings presented here are the primitive refactorings used in this
+project. They are the abstract building blocks used by the \ExtractAndMoveMethod
+refactoring.
+\subsection{The Extract Method refactoring}
+The \refa{Extract Method} refactoring is used to extract a fragment of code
+from its context and into a new method. A call to the new method is inlined
+where the fragment was before. It is used to break code into logical units, with
+names that explain their purpose.
-%\part{The project}
-%\chapter{Planning the project}
-%\part{Conclusion}
-%\chapter{Results}
+An example of an \ExtractMethod refactoring is shown in
+\myref{lst:extractMethodRefactoring}. It shows a method containing calls to the
+methods \method{foo} and \method{bar} of a type \type{X}. These statements are
+then extracted into the new method \method{fooBar}.
+\begin{listing}[h]
+ \begin{multicols}{2}
+ \begin{minted}[samepage]{java}
+ // Before
+ class C {
+ void method() {
+ X x = new X();
+ x.foo(); x.bar();
+ }
+ }
+ \end{minted}
+ \columnbreak
-\chapter{The Project}
+ \begin{minted}[samepage]{java}
+ // After
+ class C {
+ void method() {
+ X x = new X();
+ fooBar(x);
+ }
+ void fooBar(X x) {
+ x.foo(); x.bar();
+ }
+ }
+ \end{minted}
+ \end{multicols}
+ \caption{An example of an \ExtractMethod refactoring.}
+ \label{lst:extractMethodRefactoring}
+\end{listing}
+
+\subsection{The Move Method refactoring}
+The \refa{Move Method} refactoring is used to move a method from one class to
+another. This can be appropriate if the method is using more features of another
+class than of the class which it is currently defined.
+
+\Myref{lst:moveMethodRefactoring} shows an example of this refactoring. Here a
+method \method{fooBar} is moved from the class \type{C} to the class \type{X}.
+
+\begin{listing}[h]
+ \begin{multicols}{2}
+ \begin{minted}[samepage]{java}
+ // Before
+ class C {
+ void method() {
+ X x = new X();
+ fooBar(x);
+ }
+ void fooBar(X x) {
+ x.foo(); x.bar();
+ }
+ }
+
+ class X {
+ void foo(){/*...*/}
+ void bar(){/*...*/}
+ }
+ \end{minted}
+
+ \columnbreak
+
+ \begin{minted}[samepage]{java}
+ // After
+ class C {
+ void method() {
+ X x = new X();
+ x.fooBar();
+ }
+ }
+
+ class X {
+ void fooBar() {
+ foo(); bar();
+ }
+ void foo(){/*...*/}
+ void bar(){/*...*/}
+ }
+ \end{minted}
+ \end{multicols}
+ \caption{An example of a \MoveMethod refactoring.}
+ \label{lst:moveMethodRefactoring}
+\end{listing}
+
+\section{The Extract and Move Method refactoring}
+The \ExtractAndMoveMethod refactoring is a composite refactoring composed of the
+primitive \ExtractMethod and \MoveMethod refactorings. The effect of this
+refactoring on source code is the same as when extracting a method and moving it
+to another class. Conseptually, this is done without an intermediate step. In
+practice, as we shall see later, an intermediate step may be necessary.
+
+An example of this composite refactoring is shown in
+\myref{lst:extractAndMoveMethodRefactoring}. The example joins the examples from
+\cref{lst:extractMethodRefactoring} and \cref{lst:moveMethodRefactoring}. This
+means that the selection consisting of the consecutive calls to the methods
+\method{foo} and \method{bar}, is extracted into a new method \method{fooBar}
+located in the class \type{X}.
+
+\begin{listing}[h]
+ \begin{multicols}{2}
+ \begin{minted}[samepage]{java}
+ // Before
+ class C {
+ void method() {
+ X x = new X();
+ x.foo(); x.bar();
+ }
+ }
+
+ class X {
+ void foo(){/*...*/}
+ void bar(){/*...*/}
+ }
+ \end{minted}
+
+ \columnbreak
+
+ \begin{minted}[samepage]{java}
+ // After
+ class C {
+ void method() {
+ X x = new X();
+ x.fooBar();
+ }
+ }
+
+ class X {
+ void fooBar() {
+ foo(); bar();
+ }
+ void foo(){/*...*/}
+ void bar(){/*...*/}
+ }
+ \end{minted}
+ \end{multicols}
+ \caption{An example of the \ExtractAndMoveMethod refactoring.}
+ \label{lst:extractAndMoveMethodRefactoring}
+\end{listing}
+
+\section{Research questions}
+The main question that I seek an answer to in this thesis is:
+
+\begin{quote}
+ Is it possible to automate the analysis and execution of the
+ \ExtractAndMoveMethod refactoring, and do so for all of the code of a larger
+ project?
+\end{quote}
+
+\noindent The secondary questions will then be:
+
+\paragraph{Can we do this efficiently?} Can we automate the analysis and
+execution of the refactoring so it can be run in a reasonable amount of time?
+And what does \emph{reasonable} mean in this context?
+
+And, assuming the refactoring does in fact improve the quality of source code:
-\section{The problem statement}
-\todoin{write/move}
+\paragraph{How can the automation of the refactoring be helpful?} What is the
+usefullness of the refactoring in a software development setting? In what parts
+of the development process can the refactoring play a role?
\section{Choosing the target language}
Choosing which programming language the code that shall be manipulated shall be
object-oriented programming. In addition, the language must have existing tool
support for refactoring.
-The \emph{Java} programming language\footnote{\url{https://www.java.com/}} is
+The \name{Java} programming language\footnote{\url{https://www.java.com/}} is
the dominating language when it comes to example code in the literature of
refactoring, and is thus a natural choice. Java is perhaps, currently the most
-influential programming language in the world, with its \emph{Java Virtual
+influential programming language in the world, with its \name{Java Virtual
Machine} that runs on all of the most popular architectures and also supports
dozens of other programming languages\footnote{They compile to java bytecode.},
-with \emph{Scala}, \emph{Clojure} and \emph{Groovy} as the most prominent ones.
+with \name{Scala}, \name{Clojure} and \name{Groovy} as the most prominent ones.
Java is currently the language that every other programming language is compared
against. It is also the primary programming language for the author of this
thesis.
\section{Choosing the tools}
-When choosing a tool for manipulating Java, there are certain criterias that
+When choosing a tool for manipulating Java, there are certain criteria that
have to be met. First of all, the tool should have some existing refactoring
support that this thesis can build upon. Secondly it should provide some kind of
framework for parsing and analyzing Java source code. Third, it should itself be
the existing refactorings that is contained in the tool, and also because open
source projects hold value in them selves. Another important aspect to consider
is that open source projects of a certain size, usually has large communities of
-people connected to them, that are commited to answering questions regarding the
-use and misuse of the products, that to a large degree is made by the cummunity
+people connected to them, that are committed to answering questions regarding the
+use and misuse of the products, that to a large degree is made by the community
itself.
-There is a certain class of tools that meet these criterias, namely the class of
+There is a certain class of tools that meet these criteria, namely the class of
\emph{IDEs}\footnote{\emph{Integrated Development Environment}}. These are
-proagrams that is ment to support the whole production cycle of a cumputer
+programs that is meant to support the whole production cycle of a computer
program, and the most popular IDEs that support Java, generally have quite good
refactoring support.
-The main contenders for this thesis is the \emph{Eclipse IDE}, with the
-\emph{Java development tools} (JDT), the \emph{IntelliJ IDEA Community Edition}
-and the \emph{NetBeans IDE}. \See{toolSupport} Eclipse and NetBeans are both
-free, open source and community driven, while the IntelliJ IDEA has an open
-sourced community edition that is free of charge, but also offer an
-\emph{Ultimate Edition} with an extended set of features, at additional cost.
-All three IDEs supports adding plugins to extend their functionality and tools
-that can be used to parse and analyze Java source code. But one of the IDEs
-stand out as a favorite, and that is the \emph{Eclipse IDE}. This is the most
-popular\citing{javaReport2011} among them and seems to be de facto standard IDE
-for Java development regardless of platform.
-
-\section{Organizing the project}
-All the parts of this master project is under version control with
-\emph{Git}\footnote{\url{http://git-scm.com/}}.
-
-The software written is organized as some Eclipse plugins. Writing a plugin is
-the natural way to utilize the API of Eclipse. This also makes it possible to
-provide a user interface to manually run operations on selections in program
-source code or whole projects/packages.
+The main contenders for this thesis is the \name{Eclipse IDE}, with the
+\name{Java development tools} (JDT), the \name{IntelliJ IDEA Community Edition}
+and the \name{NetBeans IDE} \see{toolSupport}. \name{Eclipse} and
+\name{NetBeans} are both free, open source and community driven, while the
+\name{IntelliJ IDEA} has an open sourced community edition that is free of
+charge, but also offer an \name{Ultimate Edition} with an extended set of
+features, at additional cost. All three IDEs supports adding plugins to extend
+their functionality and tools that can be used to parse and analyze Java source
+code. But one of the IDEs stand out as a favorite, and that is the \name{Eclipse
+IDE}. This is the most popular\citing{javaReport2011} among them and seems to be
+de facto standard IDE for Java development regardless of platform.
+
+
+\chapter{Semantics}
+\todoin{Rename chapter?}
+
+\section{The inputs to the refactoring}
+For executing an \ExtractAndMoveMethod refactoring, there are two simple
+requirements. The first thing the refactoring need is a text selection, telling
+it what to extract. Its second requirement is a target for the subsequent move
+operation.
+
+The extracted method must be called instead of the selection that makes up its
+body. Also, the method call has to be performed via a variable, since the method
+is not static. \todo{Explain why static methods are not considered} Therefore,
+the move target must be a variable in the scope of the extracted selection. The
+actual new location for the extracted method will be the class representing the
+type of the move target variable. But, since the method also must be called
+through a variable, it makes sense to define the move target to be either a
+local variable or a field in the scope of the text selection.
+
+\section{Finding a move target}
+In the analysis needed to perform the \ExtractAndMoveMethod refactoring
+automatically, the selection we choose is found among all the selections that
+has a possible move target. Therefore, the best possible move target must be
+found for all the candidate selections, so that we are able to sort out the
+selection that is best suited for the refactoring.
+
+To find the best move target for a specific text selection, we first need to
+find all the possible targets. Since the target must be a local variable or a
+field, we are basically looking for names within the selection; names that
+represents references to variables.
+
+The names we are looking for, we call prefixes. This is because we are not
+interested in names that occur in the middle of a dot-separated sequence of
+names. We are only interested in names that constitutes prefixes of other names,
+possibly themselves. The reason for this, is that two lexically equal names need
+not be referencing the same variable, if they themselves are not referenced via
+the same prefix. Consider the two method calls \code{a.x.foo()} and
+\code{b.x.foo()}. Here, the two references to \code{x}, in the middle of the
+qualified names both preceding \code{foo()}, are not referencing the same
+variable. Even though the variables may share the type, and the method
+\method{foo} thus is the same for both, we would not know through which of the
+variables \var{a} or \var{b} we should call the extracted method.
+
+The possible move targets are then the prefixes that are not among a subset of
+the prefixes that are not valid move targets \see{s:unfixes}. Also, prefixes
+that are just simple names, and have only one occurrence, are left out. This is
+because they are not going to have any positive effect on coupling between
+classes.
-When writing a plugin in Eclipse, one has access to resources such as the
-current workspace, the open editor and the current selection.
+For finding the best move target among these safe prefixes, a simple heuristic
+is used. It is as simple as choosing the prefix that is most frequently
+referenced within the selection.
-\section{Continuous integration}
-The continuous integration server
-\emph{Jenkins}\footnote{\url{http://jenkins-ci.org/}} has been set up for the
-project\footnote{A work mostly done by the supervisor.}. It is used as a way to
-run tests and perform code coverage analysis.
+\section{Unfixes}\label{s:unfixes}
+The prefixes that are not valid as move targets are called unfixes.
-To be able to build the Eclipse plugins and run tests for them with Jenkins, the
-component assembly project
-\emph{Buckminster}\footnote{\url{http://www.eclipse.org/buckminster/}} is used,
-through its plugin for Jenkins. Buckminster provides for a way to specify the
-resources needed for building a project and where and how to find them.
-Buckminster also handles the setup of a target environment to run the tests in.
-All this is needed because the code to build depends on an Eclipse installation
-with various plugins.
+An unfix can be a name that is assigned to within a selection. The reason that
+this cannot be allowed, is that the result would be an assignment to the
+\type{this} keyword, which is not valid in Java \see{eclipse_bug_420726}.
-\subsection{Problems with AspectJ}
-The Buckminster build worked fine until introducing AspectJ into the project.
-When building projects using AspectJ, there are some additional steps that needs
-to be performed. First of all, the aspects themselves must be compiled. Then the
-aspects needs to be woven with the classes they affect. This demands a process
-that does multiple passes over the source code.
+Prefixes that originates from variable declarations within the same selection
+are also considered unfixes. This is because when a method is moved, it needs to
+be called through a variable. If this variable is also declared within the
+method that is to be moved, this obviously cannot be done.
-When using AspectJ with Eclipse, the specialized compilation and the weaving can
-be handled by the \emph{AspectJ Development
-Tools}\footnote{\url{https://www.eclipse.org/ajdt/}}. This works all fine, but
-it complicates things when trying to build a project depending on Eclipse
-plugins outside of Eclipse. There is supposed to be a way to specify a compiler
-adapter for javac, together with the file extensions for the file types it shall
-operate. The AspectJ compiler adapter is called
-\typewithref{org.aspectj.tools.ant.taskdefs}{Ajc11CompilerAdapter}, and it works
-with files that has the extensions \code{*.java} and \code{*.aj}. I tried to
-setup this in the build properties file for the project containing the aspects,
-but to no avail. The project containing the aspects does not seem to be built at
-all, and the projects that depends on it complains that they cannot find certain
-classes.
+Also considered as unfixes are variable references that are of types that are
+not suitable for moving methods to. This can either be because it is not
+physically possible to move a method to the desired class or that it will cause
+compilation errors by doing so.
-I then managed to write an \emph{Ant}\footnote{\url{https://ant.apache.org/}}
-build file that utilizes the AspectJ compiler adapter, for the
-\code{no.uio.ifi.refaktor} plugin. The problem was then that it could no longer
-take advantage of the environment set up by Buckminster. The solution to this
-particular problem was of a ``hacky'' nature. It involves exporting the plugin
-dependencies for the project to an Ant build file, and copy the exported path
-into the existing build script. But then the Ant script needs to know where the
-local Eclipse installation is located. This is no problem when building on a
-local machine, but to utilize the setup done by Buckminster is a problem still
-unsolved. To get the classpath for the build setup correctly, and here comes the
-most ``hacky'' part of the solution, the Ant script has a target for copying the
-classpath elements into a directory relative to the project directory and
-checking it into Git. When no \code{ECLIPSE\_HOME} property is set while running
-Ant, the script uses the copied plugins instead of the ones provided by the
-Eclipse installation when building the project. This obviously creates some
-problems with maintaining the list of dependencies in the Ant file, as well as
-remembering to copy the plugins every time the list of dependencies change.
+If the type binding for a name is not resolved it is considered and unfix. The
+same applies to types that is only found in compiled code, so they have no
+underlying source that is accessible to us. (E.g. the \type{java.lang.String}
+class.)
-The Ant script described above is run by Jenkins before the Buckminster setup
-and build. When setup like this, the Buckminster build succeeds for the projects
-not using AspectJ, and the tests are run as normal. This is all good, but it
-feels a little scary, since the reason for Buckminster not working with AspectJ
-is still unknown.
+Interfaces types are not suitable as targets. This is simply because interfaces
+in Java cannot contain methods with bodies. (This thesis does not deal with
+features of Java versions later than Java 7. Java 8 has interfaces with default
+implementations of methods.)
+
+Neither are local types allowed. This accounts for both local and anonymous
+classes. Anonymous classes are effectively the same as interface types with
+respect to unfixes. Local classes could in theory be used as targets, but this
+is not possible due to limitations of the way the \refa{Extract and Move Method}
+refactoring has to be implemented. The problem is that the refactoring is done
+in two steps, so the intermediate state between the two refactorings would not
+be legal Java code. In the intermediate step for the case where a local class is
+the move target, the extracted method would need to take the local class as a
+parameter. This new method would need to live in the scope of the declaring
+class of the originating method. The local class would then not be in the scope
+of the extracted method, thus bringing the source code into an illegal state.
+One could imagine that the method was extracted and moved in one operation,
+without an intermediate state. Then it would make sense to include variables
+with types of local classes in the set of legal targets, since the local classes
+would then be in the scopes of the method calls. If this makes any difference
+for software metrics that measure coupling would be a different discussion.
-The problems with building with AspectJ on the Jenkins server lasted for a
-while, before they were solved. This is reflected in the ``Test Result Trend''
-and ``Code Coverage Trend'' reported by Jenkins.
+\begin{listing}
+\begin{multicols}{2}
+\begin{minted}[]{java}
+// Before
+void declaresLocalClass() {
+ class LocalClass {
+ void foo() {}
+ void bar() {}
+ }
+
+ LocalClass inst =
+ new LocalClass();
+ inst.foo();
+ inst.bar();
+}
+\end{minted}
+
+\columnbreak
+
+\begin{minted}[]{java}
+// After Extract Method
+void declaresLocalClass() {
+ class LocalClass {
+ void foo() {}
+ void bar() {}
+ }
+
+ LocalClass inst =
+ new LocalClass();
+ fooBar(inst);
+}
+
+// Intermediate step
+void fooBar(LocalClass inst) {
+ inst.foo();
+ inst.bar();
+}
+\end{minted}
+\end{multicols}
+\caption{When the \refa{Extract and Move Method} tries to use a variable with a
+local type as the move target, an intermediate step is performed that is not
+allowed. Here: \type{LocalClass} is not in the scope of \method{fooBar} in its
+intermediate location.}
+\label{lst:extractMethod_LocalClass}
+\end{listing}
+
+The last class of names that are considered unfixes are names used in null
+tests. These are tests that reads like this: if \texttt{<name>} equals
+\var{null} then do something. If allowing variables used in those kinds of
+expressions as targets for moving methods, we would end up with code containing
+boolean expressions like \texttt{this == null}, which would not be meaningful,
+since \var{this} would never be \var{null}.
+
+\todoin{Describe what a text selection is?}
+
+\section{Choosing the selection}
+When choosing a selection between the text selections that have possible move
+targets, the selections need to be ordered. The criteria below are presented in
+the order they are prioritized. If not one selection is favored over the other
+for a concrete criterion, the selections are evaluated by the next criterion.
+
+\begin{enumerate}
+ \item The first criterion that is evaluated is whether a selection contains
+ any unfixes or not. If selection \m{A} contains no unfixes, while
+ selection \m{B} does, selection \m{A} is favored over selection
+ \m{B}. This is done under the assumption that, if possible, avoiding
+ selections containing unfixes will make the code moved a little
+ cleaner.\todoin{more arguments?}
+
+ \item The second criterion that is evaluated is how many possible targets a
+ selection contains. If selection \m{A} has only one possible target, and
+ selection \m{B} has multiple, selection \m{A} is favored. If both
+ selections have multiple possible targets, they are considered equal with
+ respect to this criterion. The rationale for this heuristic is that we would
+ prefer not to introduce new couplings between classes when performing the
+ \ExtractAndMoveMethod refactoring.
+
+ \item When evaluating the last criterion, this is with the knowledge that
+ selection \m{A} and \m{B} both have one possible target. Then, if
+ the move target candidate of selection \m{A} has a higher reference count
+ than the target candidate of selection \m{B}, selection \m{A} is
+ favored. The reason for this is that we would like to move the selection that
+ gets rid of the most references to another class.
+
+\end{enumerate}
+
+If none of the above mentioned criteria favors one selection over another, the
+selections are considered to be equally good candidates for the
+\ExtractAndMoveMethod refactoring.
+
+\section{Disqualifying a selection}
+Certain text selections would lead to broken code if used as input to the
+\ExtractAndMoveMethod refactoring. To avoid this, we have to check all text
+selections for such conditions before they are further analyzed. This sections
+is therefore going to present some properties that makes a selection unsuitable
+for our refactoring.
+
+\subsection{A call to a protected or package-private method}
+If a text selection contains a call to a protected or package-private method, it
+would not be safe to move it to another class. The reason for this, is that we
+cannot know if the called method is being overridden by some subclass of the
+\gloss{enclosingClass}, or not.
+
+Imagine that the protected method \method{foo} is declared in class \m{A},
+and overridden in class \m{B}. The method \method{foo} is called from within a
+selection done to a method in \m{A}. We want to extract and move this selection
+to another class. The method \method{foo} is not public, so the \MoveMethod
+refactoring must make it public, making the extracted method able to call it
+from the extracted method's new location. The problem is that the, now public,
+method \method{foo} is overridden in a subclass, where it has a protected
+status. This makes the compiler complain that the subclass \m{B} is trying to
+reduce the visibility of a method declared in its superclass \m{A}. This is not
+allowed in Java, and for good reasons. It would make it possible to make a
+subclass that could not be a substitute for its superclass.
+\todoin{Code example?}
+
+The problem this check helps to avoid, is a little subtle. The problem does not
+arise in the class where the change is done, but in a class derived from it.
+This shows that classes acting as superclasses are especially fragile to
+introducing errors in the context of automated refactoring. This is also shown
+in bug\ldots \todoin{File Eclipse bug report}
+
+\subsection{A double class instance creation}
+The following is a problem caused solely by the underlying \MoveMethod
+refactoring. The problem occurs if two classes are instantiated such that the
+first constructor invocation is an argument to a second, and that the first
+constructor invocation takes an argument that is built up using a field. As an
+example, say that \var{name} is a field of the enclosing class, and we have the
+expression \code{new A(new B(name))}. If this expression is located in a
+selection that is moved to another class, \var{name} will be left untouched,
+instead of being prefixed with a variable of the same type as it is declared in.
+If \var{name} is the destination for the move, it is not replaced by
+\code{this}, or removed if it is a prefix to a member access
+(\code{name.member}), but it is still left by itself.
+
+Situations like this would lead to code that will not compile. Therefore, we
+have to avoid them by not allowing selections to contain such double class
+instance creations that also contains references to fields.
+\todoin{File Eclipse bug report}
+
+\subsection{Instantiation of non-static inner class}
+When a non-static inner class is instantiated, this must happen in the scope of
+its declaring class. This is because it must have access to the members of the
+declaring class. If the inner class is public, it is possible to instantiate it
+through an instance of its declaring class, but this is not handled by the
+underlying \MoveMethod refactoring.
+
+Performing a move on a method that instantiates a non-static inner class, will
+break the code if the instantiation is not handled properly. For this reason,
+selections that contains instantiations of non-static inner classes are deemed
+unsuitable for the \ExtractAndMoveMethod refactoring.
+
+\subsection{References to enclosing instances of the enclosing class}
+The title of this section may be a little hard to grasp at first. What it means
+is that there is a (non-static) class \m{C} that is declared in the scope of
+possibly multiple other classes. And there is a statement in the body of a
+method declared in class \m{C}, that contains a reference to one or more
+instances of these enclosing classes of \m{C}.
+
+The problem with this, is that these references may not be valid if they are
+moved to another class. Theoretically, some situations could easily be solved by
+passing, to the moved method, a reference to the instance where the problematic
+referenced member is declared. This should work in the case where this member is
+publicly accessible. This is not done in the underlying \MoveMethod refactoring,
+so it cannot be allowed in the \ExtractAndMoveMethod refactoring either.
+
+\subsection{Inconsistent return statements}
+To verify that a text selection is consistent with respect to return statements,
+we must check that if a selection contains a return statement, then every
+possible execution path within the selection ends in either a return or a throw
+statement. This property is important regarding the \ExtractMethod refactoring.
+If it holds, it means that a method could be extracted from the selection, and a
+call to it could be substituted for the selection. If the method has a non-void
+return type, then a call to it would also be a valid return point for the
+calling method. If its return value is of the void type, then the \ExtractMethod
+refactoring will append an empty return statement to the back of the method
+call. Therefore, the analysis does not discriminate on either kinds of return
+statements, with or without a return value.
+
+A throw statement is accepted anywhere a return statement is required. This is
+because a throw statement causes an immediate exit from the current block,
+together with all outer blocks in its control flow that does not catch the
+thrown exception.
+
+Return statements can be either explicit or implicit. An \emph{explicit} return
+statement is formed by using the \code{return} keyword, while an \emph{implicit}
+return statement is a statement that is not formed using \code{return}, but must
+be the last statement of a method that can have any side effects. This can
+happen in methods with a void return type. An example is a statement that is
+inside one or more blocks. The last statement of a method could for instance be
+a synchronized statement, but the last statement that is executed in the method,
+and that can have any side effects, may be located inside the body of the
+synchronized statement.
+
+We can start the check for this property by looking at the last statement of a
+selection to see if it is a return statement (explicit or implicit) or a throw
+statement. If this is the case, then the property holds, assuming the selected
+code does not contain any compilation errors. All execution paths within the
+selection should end in either this, or another, return or throw statement.
+\todoin{State somewhere that we assume no compilation errors?}
+
+If the last statement of the selection is not a return or throw, the execution
+of it must eventually end in one for the selection to be legal. This means that
+all branches of the last statement of every branch must end in a return or
+throw. Given this recursive definition, there are only five types of statements
+that are guaranteed to end in a return or throw if their child branches does.
+All other statements would have to be considered illegal. The first three:
+Block-statements, labeled statements and do-statements are all kinds of
+fall-through statements that always gets their body executed. Do-statements
+would not make much sense if written such that they
+always ends after the first round of execution of their body, but that is not
+our concern. The remaining two statements that can end in a return or throw are
+if-statements and try-statements.
+
+For an if-statement, the rule is that if its then-part does not contain any
+return or throw statements, this is considered illegal. If the then-part does
+contain a return or throw, the else-part is checked. If its else-part is
+non-existent, or it does not contain any return or throw statements, the
+statement is considered illegal. If an if-statement is not considered illegal,
+the bodies of its two parts must be checked.
+
+Try-statements are handled much the same way as if-statements. The body of a
+try-statement must contain a return or throw. The same applies to its catch
+clauses and finally body.
+
+\subsection{Ambiguous return values}
+The problem with ambiguous return values arise when a selection is chosen to be
+extracted into a new method, but it needs to return more than one value from
+that method.
+
+This problem occurs in two situations. The first situation arise when there is
+more than one local variable that is both assigned to within a selection and
+also referenced after the selection. The other situation occur when there is
+only one such assignment, but the selection also contain return statements.
+
+Therefore we must examine the selection for assignments to local variables that
+are referenced after the text selection. Then we must verify that not more than
+one such reference is done, or zero if any return statements are found.
+
+\subsection{Illegal statements}
+An illegal statement may be a statement that is of a type that is never allowed,
+or it may be a statement of a type that is only allowed if certain conditions
+are true.
+
+Any use of the \var{super} keyword is prohibited, since its meaning is altered
+when moving a method to another class.
+
+For a \emph{break} statement, there are two situations to consider: A break
+statement with or without a label. If the break statement has a label, it is
+checked that whole of the labeled statement is inside the selection. If the
+break statement does not have a label attached to it, it is checked that its
+innermost enclosing loop or switch statement also is inside the selection.
+
+The situation for a \emph{continue} statement is the same as for a break
+statement, except that it is not allowed inside switch statements.
+
+Regarding \emph{assignments}, two types of assignments are allowed: Assignments
+to non-final variables and assignments to array access. All other assignments
+are regarded illegal.
+\todoin{Expand with more illegal statements and/or conclude that I did not have
+time to analyze all statements types.}
-\chapter{Refactorings in Eclipse JDT: Design, Shortcomings and Wishful
-Thinking}\label{ch:jdt_refactorings}
+\subsection{Grand example}
+\todoin{Change title?}
+
+\begin{listing}
+ \begin{minted}[linenos]{java}
+ public class C {
+ public void foo() {
+
+ }
+ }
+
+\end{minted}
+\caption{The grand example}
+\label{lst:grandExample}
+\end{listing}
+
+
+
+
+\chapter{Refactorings in Eclipse JDT: Design and
+Shortcomings}\label{ch:jdt_refactorings}
This chapter will deal with some of the design behind refactoring support in
-Eclipse, and the JDT in specific. After which it will follow a section about
+\name{Eclipse}, and the JDT in specific. After which it will follow a section about
shortcomings of the refactoring API in terms of composition of refactorings. The
chapter will be concluded with a section telling some of the ways the
implementation of refactorings in the JDT could have worked to facilitate
composition of refactorings.
\section{Design}
-The refactoring world of Eclipse can in general be separated into two parts: The
+The refactoring world of \name{Eclipse} can in general be separated into two parts: The
language independent part and the part written for a specific programming
language -- the language that is the target of the supported refactorings.
\todo{What about the language specific part?}
\url{https://www.eclipse.org/articles/Article-LTK/ltk.html} and
\url{http://www.eclipse.org/articles/article.php?file=Article-Unleashing-the-Power-of-Refactoring/index.html},
the LTK source code and my own memory.}, or LTK for short, is the framework that
-is used to implement refactorings in Eclipse. It is language independent and
+is used to implement refactorings in \name{Eclipse}. It is language independent and
provides the abstractions of a refactoring and the change it generates, in the
form of the classes \typewithref{org.eclipse.ltk.core.refactoring}{Refactoring}
and \typewithref{org.eclipse.ltk.core.refactoring}{Change}.
\subsection{Absence of Generics in Eclipse Source Code}
This section is not only concerning the JDT refactoring API, but also large
-quantities of the Eclipse source code. The code shows a striking absence of the
+quantities of the \name{Eclipse} source code. The code shows a striking absence of the
Java language feature of generics. It is hard to read a class' interface when
methods return objects or takes parameters of raw types such as \type{List} or
\type{Map}. This sometimes results in having to read a lot of source code to
the refactoring in a single step. This is not the way it appears when a sequence
of JDT refactorings is executed. It leaves the undo history filled up with
individual undo actions corresponding to every single JDT refactoring in the
-sequence. This problem is not trivial to handle in Eclipse.
-\See{hacking_undo_history}
+sequence. This problem is not trivial to handle in \name{Eclipse}
+\see{hacking_undo_history}.
+
-\section{Wishful Thinking}
-\todoin{???}
\chapter{Composite Refactorings in Eclipse}
\section{A Simple Ad Hoc Model}
-As pointed out in \myref{ch:jdt_refactorings}, the Eclipse JDT refactoring model
+As pointed out in \myref{ch:jdt_refactorings}, the \name{Eclipse} JDT refactoring model
is not very well suited for making composite refactorings. Therefore a simple
model using changer objects (of type \type{RefaktorChanger}) is used as an
-abstraction layer on top of the existing Eclipse refactorings, instead of
+abstraction layer on top of the existing \name{Eclipse} refactorings, instead of
extending the \typewithref{org.eclipse.ltk.core.refactoring}{Refactoring} class.
The use of an additional abstraction layer is a deliberate choice. It is due to
This is a composite refactoring, and hence is built up using several primitive
refactorings. These basic building blocks are, as its name implies, the
\ExtractMethod refactoring\citing{refactoring} and the \MoveMethod
-refactoring\citing{refactoring}. In Eclipse, the implementations of these
+refactoring\citing{refactoring}. In \name{Eclipse}, the implementations of these
refactorings are found in the classes
\typewithref{org.eclipse.jdt.internal.corext.refactoring.code}{ExtractMethodRefactoring}
and
its visibility and some not so interesting parameters.
\subsubsection{The MoveInstanceMethodProcessor Class}
-For the Move Method, the processor requires a little more advanced input than
-the class for the Extract Method. For construction it requires a method
+For the \refa{Move Method}, the processor requires a little more advanced input than
+the class for the \refa{Extract Method}. For construction it requires a method
handle\typeref{org.eclipse.jdt.core.IMethod} for the method that is to be moved.
Then the target for the move have to be supplied as the variable binding from a
chosen variable declaration. In addition to this, one have to set some
class is a subclass of the class
\typewithref{no.uio.ifi.refaktor.changers}{RefaktorChanger}. It is responsible
for analyzing and finding the best target for, and also executing, a composition
-of the Extract Method and Move Method refactorings. This particular changer is
+of the \refa{Extract Method} and \refa{Move Method} refactorings. This particular changer is
the one of my changers that is closest to being a true LTK refactoring. It can
be reworked to be one if the problems with overlapping changes are resolved. The
changer requires a text selection and the name of the new method, or else a
basic offset, length and similar methods, also carry an instance of the
underlying compilation unit handle for the selection.
-\subsubsection{The \type{ExtractAndMoveMethodAnalyzer}}
+\subsubsection{The
+ \type{ExtractAndMoveMethodAnalyzer}}\label{extractAndMoveMethodAnalyzer}
The analysis and precondition checking is done by the
\typewithref{no.uio.ifi.refaktor.analyze.analyzers}{ExtractAnd\-MoveMethodAnalyzer}.
First is check whether the selection is a valid selection or not, with respect
For finding the best suitable target the analyzer is using a
\typewithref{no.uio.ifi.refaktor.analyze.collectors}{PrefixesCollector} that
-collects all the possible candidates for the refactoring. All the non-candidates
-is found by an
+collects all the possible candidate targets for the refactoring. All the
+non-candidates is found by an
\typewithref{no.uio.ifi.refaktor.analyze.collectors}{UnfixesCollector} that
collects all the targets that will give some kind of error if used. (For
-details about the property collectors, se \myref{propertyCollectors}.) All
+details about the property collectors, see \myref{propertyCollectors}.) All
prefixes (and unfixes) are represented by a
\typewithref{no.uio.ifi.refaktor.extractors}{Prefix}, and they are collected
into sets of prefixes. The safe prefixes is found by subtracting from the set of
\todoin{Clean up sections/subsections.}
-\subsubsection{The \type{ExtractAndMoveMethodExecutor}}
+\subsubsection{The
+ \type{ExtractAndMoveMethodExecutor}}\label{extractAndMoveMethodExecutor}
If the analysis finds a possible target for the composite refactoring, it is
executed by an
\typewithref{no.uio.ifi.refaktor.change.executors}{ExtractAndMoveMethodExecutor}.
\typewithref{no.uio.ifi.refaktor.change.executors}{MoveMethodRefactoringExecutor}.
The \type{ExtractAndMoveMethodExecutor} is responsible for gluing the two
together by feeding the \type{MoveMethod\-RefactoringExecutor} with the
-resources needed after executing the extract method refactoring.
-\See{postExtractExecution}
+resources needed after executing the extract method refactoring.
+%\see{postExtractExecution}.
\subsubsection{The \type{ExtractMethodRefactoringExecutor}}
This executor is responsible for creating and executing an instance of the
\subsubsection{The \type{MoveMethodRefactoringExecutor}}
This executor is responsible for creating and executing an instance of the
\type{MoveRefactoring}. The move refactoring is a processor-based refactoring,
-and for the Move Method refactoring it is the \type{MoveInstanceMethodProcessor}
+and for the \refa{Move Method} refactoring it is the \type{MoveInstanceMethodProcessor}
that is used.
The handle for the method to be moved is found on the basis of the information
-gathered after the execution of the Extract Method refactoring. The only
+gathered after the execution of the \refa{Extract Method} refactoring. The only
information the \type{ExtractMethodRefactoring} is sharing after its execution,
regarding find the method handle, is the textual representation of the new
method signature. Therefore it must be parsed, the strings for types of the
selection, since an extracted method must end up in the same type as the
originating method.
-When analyzing a selection prior to performing the Extract Method refactoring, a
+When analyzing a selection prior to performing the \refa{Extract Method} refactoring, a
target is chosen. It has to be a variable binding, so it is either a field or a
local variable/parameter. If the target is a field, it can be used with the
\type{MoveInstanceMethodProcessor} as it is, since the extracted method still is
\subsection{The
SearchBasedExtractAndMoveMethodChanger}\label{searchBasedExtractAndMoveMethodChanger}
-\todoin{Write\ldots}
+The
+\typewithref{no.uio.ifi.refaktor.change.changers}{SearchBasedExtractAndMoveMethodChanger}
+is a changer whose purpose is to automatically analyze a method, and execute the
+\ExtractAndMoveMethod refactoring on it if it is a suitable candidate for the
+refactoring.
+
+First, the \typewithref{no.uio.ifi.refaktor.analyze.analyzers}{SearchBasedExtractAndMoveMethodAnalyzer} is used
+to analyze the method. If the method is found to be a candidate, the result from
+the analysis is fed to the \type{ExtractAndMoveMethodExecutor}, whose job is to
+execute the refactoring \see{extractAndMoveMethodExecutor}.
+
+\subsubsection{The SearchBasedExtractAndMoveMethodAnalyzer}
+This analyzer is responsible for analyzing all the possible text selections of a
+method and then choose the best result out of the analysis results that is, by
+the analyzer, considered to be the potential candidates for the Extract and Move
+Method refactoring.
+
+Before the analyzer is able to work with the text selections of a method, it
+needs to generate them. To do this, it parses the method to obtain a
+\type{MethodDeclaration} for it \see{astEclipse}. Then there is a statement
+lists creator that creates statements lists of the different groups of
+statements in the body of the method declaration. A text selections generator
+generates text selections of all the statement lists for the analyzer to work
+with.
+
+\paragraph{The statement lists creator}
+is responsible for generating lists of statements for all the possible nesting
+levels of statements in the method. The statement lists creator is implemented
+as an AST visitor \see{astVisitor}. It generates lists of statements by visiting
+all the blocks in the method declaration and stores their statements in a
+collection of statement lists. In addition, it visits all of the other
+statements that can have a statement as a child, such as the different control
+structures and the labeled statement.
+
+The switch statement is the only kind of statement that is not straight forward
+to obtain the child statements from. It stores all of its children in a flat
+list. Its switch case statements are included in this list. This means that
+there are potential statement lists between all of these case statements. The
+list of statements from a switch statement is therefore traversed, and the
+statements between the case statements are grouped as separate lists.
+
+\Myref{lst:statementListsExample} shows an example of how the statement lists
+creator would generate lists for a simple method.
+
+\begin{listing}[h]
+\def\charwidth{5.7pt}
+\def\indent{4*\charwidth}
+\def\lineheight{\baselineskip}
+\def\mintedtop{\lineheight}
+
+\begin{tikzpicture}[overlay, yscale=-1]
+ \tikzstyle{overlaybox}=[fill=lightgray,opacity=0.2]
+ \draw[overlaybox] (0,\mintedtop+\lineheight) rectangle
+ +(22*\charwidth,10*\lineheight);
+ \draw[overlaybox] (\indent,\mintedtop+2*\lineheight) rectangle
+ +(13*\charwidth,\lineheight);
+ \draw[overlaybox] (2*\indent,\mintedtop+6*\lineheight) rectangle
+ +(13*\charwidth,2*\lineheight);
+ \draw[overlaybox] (2*\indent,\mintedtop+9*\lineheight) rectangle
+ +(13*\charwidth,\lineheight);
+\end{tikzpicture}
+\begin{minted}{java}
+void method() {
+ if (bool)
+ b.bar();
+
+ switch (val) {
+ case 1:
+ b.foo();
+ c.foo();
+ default:
+ c.foo();
+ }
+}
+\end{minted}
+\caption{Example of how the statement lists creator would group a simple method
+into lists of statements. Each highlighted rectangle represents a list.}
+\label{lst:statementListsExample}
+\end{listing}
+
+\paragraph{The text selections generator} generates text selections for each
+list of statements from the statement lists creator. The generator generates a
+text selection for every sub-sequence of statements in a list. For a sequence of
+statements, the first statement and the last statement span out a text
+selection.
+
+In practice, the text selections are calculated by only one traversal of the
+statement list. There is a set of generated text selections. For each statement,
+there is created a temporary set of selections, in addition to a text selection
+based on the offset and length of the statement. This text selection is added to
+the temporary set. Then the new selection is added with every selection from the
+set of generated text selections. These new selections are added to the
+temporary set. Then the temporary set of selections is added to the set of
+generated text selections. The result of adding two text selections is a new
+text selection spanned out by the two addends.
+
+\begin{listing}[h]
+\def\charwidth{5.7pt}
+\def\indent{4*\charwidth}
+\def\lineheight{\baselineskip}
+\def\mintedtop{\lineheight}
+
+\begin{tikzpicture}[overlay, yscale=-1]
+ \tikzstyle{overlaybox}=[fill=lightgray,opacity=0.2]
+ \draw[overlaybox] (2*\charwidth,\mintedtop) rectangle
+ +(18*\charwidth,\lineheight);
+
+ \draw[overlaybox] (2*\charwidth,\mintedtop+\lineheight) rectangle
+ +(18*\charwidth,\lineheight);
+
+ \draw[overlaybox] (2*\charwidth,\mintedtop+3*\lineheight) rectangle
+ +(18*\charwidth,\lineheight);
+
+ \draw[overlaybox] (\indent-3*\charwidth,\mintedtop) rectangle
+ +(20*\charwidth,2*\lineheight);
+
+ \draw[overlaybox] (3*\charwidth,\mintedtop+\lineheight) rectangle
+ +(16*\charwidth,3*\lineheight);
+
+ \draw[overlaybox] (\indent,\mintedtop) rectangle
+ +(14*\charwidth,4*\lineheight);
+\end{tikzpicture}
+\begin{minted}{java}
+ statement one;
+ statement two;
+ ...
+ statement k;
+\end{minted}
+\caption{Example of how the text selections generator would generate text
+ selections based on a lists of statements. Each highlighted rectangle
+represents a text selection.}
+\label{lst:textSelectionsExample}
+\end{listing}
+\todoin{fix \myref{lst:textSelectionsExample}? Text only? All
+sub-sequences\ldots}
+
+\paragraph{Finding the candidate} for the refactoring is done by analyzing all
+the generated text selection with the \type{ExtractAndMoveMethodAnalyzer}
+\see{extractAndMoveMethodAnalyzer}. If the analyzer generates a useful result,
+an \type{ExtractAndMoveMethodCandidate} is created from it, that is kept in a
+list of potential candidates. If no candidates are found, the
+\type{NoTargetFoundException} is thrown.
+
+Since only one of the candidates can be chosen, the analyzer must sort out which
+candidate to choose. The sorting is done by the static \method{sort} method of
+\type{Collections}. The comparison in this sorting is done by an
+\type{ExtractAndMoveMethodCandidateComparator}.
+\todoin{Write about the
+ExtractAndMoveMethodCandidateComparator/FavorNoUnfixesCandidateComparator}
+
+\paragraph{The complexity} of how many text selections that needs to be analyzed
+for a total of $n$ statements is bounded by $O(n^2)$.
+
+\begin{theorem}
+The number of text selections that need to be analyzed for each list of
+statements of length $n$, is exactly
+
+\begin{equation*}
+ \sum_{i=1}^{n} i = \frac{n(n+1)}{2}
+ \label{eq:complexityStatementList}
+\end{equation*}
+\label{thm:numberOfTextSelection}
+\end{theorem}
+
+\begin{proof}
+ For $n=1$ this is trivial: $\frac{1(1+1)}{2} = \frac{2}{2} = 1$. One statement
+ equals one selection.
+
+ For $n=2$, you get one text selection for the first statement, one selection
+ for the second statement, and one selection for the two of them combined.
+ This equals three selections. $\frac{2(2+1)}{2} = \frac{6}{2} = 3$.
+
+ For $n=3$, you get 3 selections for the two first statements, as in the case
+ where $n=2$. In addition you get one selection for the third statement itself,
+ and two more statements for the combinations of it with the two previous
+ statements. This equals six selections. $\frac{3(3+1)}{2} = \frac{12}{2} = 6$.
+
+ Assume that for $n=k$ there exists $\frac{k(k+1)}{2}$ text selections. Then we
+ want to add selections for another statement, following the previous $k$
+ statements. So, for $n=k+1$, we get one additional selection for the statement
+ itself. Then we get one selection for each pair of the new selection and the
+ previous $k$ statements. So the total number of selections will be the number
+ of already generated selections, plus $k$ for every pair, plus one for the
+ statement itself: $\frac{k(k+1)}{2} + k +
+ 1 = \frac{k(k+1)+2k+2}{2} = \frac{k(k+1)+2(k+1)}{2} = \frac{(k+1)(k+2)}{2} =
+ \frac{(k+1)((k+1)+1)}{2} = \sum_{i=1}^{k+1} i$
+\end{proof}
+
+%\definition{A \emph{body of statements} is a sequence of statements where every
+%statement may have sub-statements.}
+\todoin{Define ``body of statements''?}
+
+\begin{theorem}
+ The number of text selections for a body of statements is maximized if all the
+ statements are at the same level.
+ \label{thm:textSelectionsMaximized}
+\end{theorem}
+
+\begin{proof}
+ Assume we have a body of, in total, $k$ statements. Then, the sum of the
+ lengths of all the lists of statements in the body, is also $k$. Let
+ $\{l,\ldots,m,(k-l-\ldots-m)\}$ be the lengths of the lists of statements in
+ the body, with $l+\ldots+m<k \Rightarrow \forall i \in \{l,\ldots,m\} : i < k$.
+
+ Then, the number of text selections that are generated for the $k$ statements
+ is
+
+ {
+ \small
+ \begin{align*}
+ \frac{l(l+1)}{2} + \ldots + \frac{m(m+1)}{2} +
+ \frac{(k-l-\ldots-m)((k-l-\ldots-m)+ 1)}{2} = \\
+ \frac{l^2+l}{2} + \ldots + \frac{m^2+m}{2} + \frac{k^2 - 2kl - \ldots - 2km +
+ l^2 + \ldots + m^2 + k - l - \ldots - m}{2} = \\
+ \frac{2l^2 - 2kl + \ldots + 2m^2 - 2km + k^2 + k}{2}
+ \end{align*}
+ }
+
+ \noindent It then remains to show that this inequality holds:
+
+ \begin{align*}
+ \frac{2l^2 - 2kl + \ldots + 2m^2 - 2km + k^2 + k}{2} < \frac{k(k+1)}{2} =
+ \frac{k^2 + k}{2}
+ \end{align*}
+
+ \noindent By multiplication by $2$ on both sides, and by removing the equal
+ parts, we get
+
+ \begin{align*}
+ 2l^2 - 2kl + \ldots + 2m^2 - 2km < 0
+ \end{align*}
+
+ Since $\forall i \in \{l,\ldots,m\} : i < k$, we have that $\forall i \in
+ \{l,\ldots,m\} : 2ki > 2i^2$, so all the pairs of parts on the form $2i^2-2ki$
+ are negative. In sum, the inequality holds.
+
+\end{proof}
+
+Therefore, the complexity for the number of selections that needs to be analyzed
+for a body of $n$ statements is $O\bigl(\frac{n(n+1)}{2}\bigr) = O(n^2)$.
+
+
+\begin{comment}
\subsection{Finding the IMethod}\label{postExtractExecution}
\todoin{Rename section. Write??}
+\end{comment}
\subsection{The Prefix Class}
My first impulse was to remove the, in this case, last two undo changes from the
undo manager\typeref{org.eclipse.ltk.core.refactoring.IUndoManager} for the
-Eclipse refactorings, and then add them to a composite
+\name{Eclipse} refactorings, and then add them to a composite
change\typeref{org.eclipse.ltk.core.refactoring.CompositeChange} that could be
added back to the manager. The interface of the undo manager does not offer a
way to remove/pop the last added undo change, so a possible solution could be to
There is a technical challenge with this approach, and it relates to the undo
manager, and the concrete implementation
-UndoManager2\typeref{org.eclipse.ltk.internal.core.refactoring.UndoManager2}.
-This implementation is designed in a way that it is not possible to just add an
-undo change, you have to do it in the context of an active
+\typewithref{org.eclipse.ltk.internal.core.refactoring}{UndoManager2}. This
+implementation is designed in a way that it is not possible to just add an undo
+change, you have to do it in the context of an active
operation\typeref{org.eclipse.core.commands.operations.TriggeredOperations}.
One could imagine that it might be possible to trick the undo manager into
believing that you are doing a real change, by executing a refactoring that is
returning a kind of null change that is returning our composite change of undo
-refactorings when it is performed.
+refactorings when it is performed. But this is not the way to go.
Apart from the technical problems with this solution, there is a functional
problem: If it all had worked out as planned, this would leave the undo history
\chapter{Analyzing Source Code in Eclipse}
\section{The Java model}\label{javaModel}
-The Java model of Eclipse is its internal representation of a Java project. It
+The Java model of \name{Eclipse} is its internal representation of a Java project. It
is light-weight, and has only limited possibilities for manipulating source
-code. It is typically used as a basis for the Package Explorer in Eclipse.
+code. It is typically used as a basis for the Package Explorer in \name{Eclipse}.
The elements of the Java model is only handles to the underlying elements. This
means that the underlying element of a handle does not need to actually exist.
child { node {\type{\{ IPackageFragmentRoot \}*}}}
;
\end{tikzpicture}
- \caption{The Java model of Eclipse. ``\type{\{ SomeElement \}*}'' means
+ \caption{The Java model of \name{Eclipse}. ``\type{\{ SomeElement \}*}'' means
\type{SomeElement} zero or more times. For recursive structures,
``\type{\ldots}'' is used.}
\label{fig:javaModel}
\end{figure}
-\section{The Abstract Synax Tree}
-Eclipse is following the common paradigm of using an abstract syntaxt tree for
+\section{The Abstract Syntax Tree}
+\name{Eclipse} is following the common paradigm of using an abstract syntax tree for
source code analysis and manipulation.
When parsing program source code into something that can be used as a foundation
for analysis, the start of the process follows the same steps as in a compiler.
-This is all natural, because the way a compiler anayzes code is no different
+This is all natural, because the way a compiler analyzes code is no different
from how source manipulation programs would do it, except for some properties of
code that is analyzed in the parser, and that they may be differing in what
kinds of properties they analyze. Thus the process of translation source code
read the source code and divide it into tokens for the parser. Therefore, it is
also sometimes called a tokenizer. A token is a logical unit, defined in the
language specification, consisting of one or more consecutive characters. In
-the java language the tokens can for instance be the \var{this} keyword, a curly
+the Java language the tokens can for instance be the \var{this} keyword, a curly
bracket \var{\{} or a \var{nameToken}. It is recognized by the scanner on the
-basis of something eqivalent of a regular expression. This part of the process
+basis of something equivalent of a regular expression. This part of the process
is often implemented with the use of a finite automata. In fact, it is common to
specify the tokens in regular expressions, that in turn is translated into a
finite automata lexer. This process can be automated.
-The program component used to translate a a stream of tokens into something
+The program component used to translate a stream of tokens into something
meaningful, is called a parser. A parser is fed tokens from the scanner and
performs an analysis of the structure of a program. It verifies that the syntax
is correct according to the grammar rules of a language, that is usually
specified in a context-free grammar, and often in a variant of the
-\emph{Backus--Naur
+\name{Backus--Naur
Form}\footnote{\url{https://en.wikipedia.org/wiki/Backus-Naur\_Form}}. The
result coming from the parser is in the form of an \emph{Abstract Syntax Tree},
AST for short. It is called \emph{abstract}, because the structure does not
semantic analysis of the code.
As an example we can think of the expression \code{(5 + 7) * 2}. The root of
-this tree would in Eclipse be an \type{InfixExpression} with the operator
+this tree would in \name{Eclipse} be an \type{InfixExpression} with the operator
\var{TIMES}, and a left operand that is also an \type{InfixExpression} with the
operator \var{PLUS}. The left operand \type{InfixExpression}, has in turn a left
operand of type \type{NumberLiteral} with the value \var{``5''} and a right
right operand of type \type{NumberLiteral} and value \var{``2''}. The AST for
this expression is illustrated in \myref{fig:astInfixExpression}.
-Contrary to the Java Model, an abstract syntaxt tree is a heavy-weight
-representation of source code. It contains information about propertes like type
-bindings for variables and variable bindings for names.
+Contrary to the Java Model, an abstract syntax tree is a heavy-weight
+representation of source code. It contains information about properties like
+type bindings for variables and variable bindings for names.
\begin{figure}[h]
\label{fig:astInfixExpression}
\end{figure}
-\subsection{The AST in Eclipse}
-In Eclipse, every node in the AST is a child of the abstract superclass
+\subsection{The AST in Eclipse}\label{astEclipse}
+In \name{Eclipse}, every node in the AST is a child of the abstract superclass
\typewithref{org.eclipse.jdt.core.dom}{ASTNode}. Every \type{ASTNode}, among a
lot of other things, provides information about its position and length in the
source code, as well as a reference to its parent and to the root of the tree.
as an operand in compound expressions, as well as for names in type declarations
and such.
-There is an overview of some of the structure of an Eclipse AST in
+There is an overview of some of the structure of an \name{Eclipse} AST in
\myref{fig:astEclipse}.
\begin{figure}[h]
\draw (root.south) -- (body);
\end{tikzpicture}
- \caption{The format of the abstract syntax tree in Eclipse.}
+ \caption{The format of the abstract syntax tree in \name{Eclipse}.}
\label{fig:astEclipse}
\end{figure}
\todoin{Add more to the AST format tree? \myref{fig:astEclipse}}
\section{The ASTVisitor}\label{astVisitor}
-So far, the only thing that has been adressed is how the the data that is going
-to be the basis for our analysis is structured. Another aspect of it is how we
-are going to traverse the AST to gather the information we need, so we can
-conclude about the properties we are analysing. It is of course possible to
-start at the top of the tree, and manually search through its nodes for the ones
-we are looking for, but that is a bit inconvenient. To be able to efficiently
-utilize such an approach, we would need to make our own framework for traversing
-the tree and visiting only the types of nodes we are after. Luckily, this
-functionality is already provided in Eclipse, by its
+So far, the only thing that has been addressed is how the data that is going to
+be the basis for our analysis is structured. Another aspect of it is how we are
+going to traverse the AST to gather the information we need, so we can conclude
+about the properties we are analysing. It is of course possible to start at the
+top of the tree, and manually search through its nodes for the ones we are
+looking for, but that is a bit inconvenient. To be able to efficiently utilize
+such an approach, we would need to make our own framework for traversing the
+tree and visiting only the types of nodes we are after. Luckily, this
+functionality is already provided in \name{Eclipse}, by its
\typewithref{org.eclipse.jdt.core.dom}{ASTVisitor}.
-The Eclipse AST, together with its \type{ASTVisitor}, follows the \emph{Visitor}
-pattern\citing{designPatterns}. The intent of this design pattern is to
-facilitate extending the functionality of classes without touching the classes
-themselves.
+The \name{Eclipse} AST, together with its \type{ASTVisitor}, follows the
+\pattern{Visitor} pattern\citing{designPatterns}. The intent of this design
+pattern is to facilitate extending the functionality of classes without touching
+the classes themselves.
-Let us say that there is a class hierarchy of \emph{Elements}. These elements
-all have a method \method{accept(Visitor visitor)}. In its simplest form, the
+Let us say that there is a class hierarchy of elements. These elements all have
+a method \method{accept(Visitor visitor)}. In its simplest form, the
\method{accept} method just calls the \method{visit} method of the visitor with
itself as an argument, like this: \code{visitor.visit(this)}. For the visitors
to be able to extend the functionality of all the classes in the elements
The use of the visitor pattern can be appropriate when the hierarchy of elements
is mostly stable, but the family of operations over its elements is constantly
-growing. This is clearly the cas for the Eclipse AST, since the hierarchy of
+growing. This is clearly the case for the \name{Eclipse} AST, since the hierarchy of
type \type{ASTNode} is very stable, but the functionality of its elements is
extended every time someone needs to operate on the AST. Another aspect of the
-Eclipse implementation is that it is a public API, and the visitor pattern is an
+\name{Eclipse} implementation is that it is a public API, and the visitor pattern is an
easy way to provide access to the nodes in the tree.
-The version of the visitor pattern implemented for the AST nodes in Eclipse also
+The version of the visitor pattern implemented for the AST nodes in \name{Eclipse} also
provides an elegant way to traverse the tree. It does so by following the
convention that every node in the tree first let the visitor visit itself,
before it also makes all its children accept the visitor. The children are only
\subsection{The PrefixesCollector}
The \typewithref{no.uio.ifi.refaktor.extractors.collectors}{PrefixesCollector}
finds prefixes that makes up the basis for calculating move targets for the
-Extract and Move Method refactoring. It visits expression
+\refa{Extract and Move Method} refactoring. It visits expression
statements\typeref{org.eclipse.jdt.core.dom.ExpressionStatement} and creates
prefixes from its expressions in the case of method invocations. The prefixes
found is registered with a prefix set, together with all its sub-prefixes.
\subsection{The UnfixesCollector}\label{unfixes}
The \typewithref{no.uio.ifi.refaktor.extractors.collectors}{UnfixesCollector}
-finds unfixes within a selection. That is prefixes that cannot be used as a
-basis for finding a move target in a refactoring.
-
-An unfix can be a name that is assigned to within a selection. The reason that
-this cannot be allowed, is that the result would be an assignment to the
-\type{this} keyword, which is not valid in Java \see{eclipse_bug_420726}.
-
-Prefixes that originates from variable declarations within the same selection
-are also considered unfixes. This is because when a method is moved, it needs to
-be called through a variable. If this variable is also within the method that is
-to be moved, this obviously cannot be done.
-
-Also considered as unfixes are variable references that are of types that is not
-suitable for moving a methods to. This can be either because it is not
-physically possible to move the method to the desired class or that it will
-cause compilation errors by doing so.
-
-If the type binding for a name is not resolved it is considered and unfix. The
-same applies to types that is only found in compiled code, so they have no
-underlying source that is accessible to us. (E.g. the \type{java.lang.String}
-class.)
-
-Interfaces types are not suitable as targets. This is simply because interfaces
-in java cannot contain methods with bodies. (This thesis does not deal with
-features of Java versions later than Java 7. Java 8 has interfaces with default
-implementations of methods.) Neither are local types allowed. This accounts for
-both local and anonymous classes. Anonymous classes are effectively the same as
-interface types with respect to unfixes. Local classes could in theory be used
-as targets, but this is not possible due to limitations of the implementation of
-the Extract and Move Method refactoring. The problem is that the refactoring is
-done in two steps, so the intermediate state between the two refactorings would
-not be legal Java code. In the case of local classes, the problem is that, in
-the intermediate step, a selection referencing a local class would need to take
-the local class as a parameter if it were to be extracted to a new method. This
-new method would need to live in the scope of the declaring class of the
-originating method. The local class would then not be in the scope of the
-extracted method, thus bringing the source code into an illegal state. One could
-imagine that the method was extracted and moved in one operation, without an
-intermediate state. Then it would make sense to include variables with types of
-local classes in the set of legal targets, since the local classes would then be
-in the scopes of the method calls. If this makes any difference for software
-metrics that measure coupling would be a different discussion.
-
-\begin{listing}
-\begin{multicols}{2}
-\begin{minted}[]{java}
-// Before
-void declaresLocalClass() {
- class LocalClass {
- void foo() {}
- void bar() {}
- }
+finds unfixes within a selection.
+\todoin{Give more technical detail?}
- LocalClass inst =
- new LocalClass();
- inst.foo();
- inst.bar();
-}
-\end{minted}
-
-\columnbreak
-
-\begin{minted}[]{java}
-// After Extract Method
-void declaresLocalClass() {
- class LocalClass {
- void foo() {}
- void bar() {}
- }
-
- LocalClass inst =
- new LocalClass();
- fooBar(inst);
-}
-
-// Intermediate step
-void fooBar(LocalClass inst) {
- inst.foo();
- inst.bar();
-}
-\end{minted}
-\end{multicols}
-\caption{When Extract and Move Method tries to use a variable with a local type
-as the move target, an intermediate step is taken that is not allowed. Here:
-\type{LocalClass} is not in the scope of \method{fooBar} in its intermediate
-location.}
-\label{lst:extractMethod_LocalClass}
-\end{listing}
-
-The last class of names that are considered unfixes is names used in null tests.
-These are tests that reads like this: if \texttt{<name>} equals \var{null} then
-do something. If allowing variables used in those kinds of expressions as
-targets for moving methods, we would end up with code containing boolean
-expressions like \texttt{this == null}, which would not be meaningful, since
-\var{this} would never be \var{null}.
\subsection{The ContainsReturnStatementCollector}
+\todoin{Remove section?}
The
\typewithref{no.uio.ifi.refaktor.analyze.collectors}{ContainsReturnStatementCollector}
is a very simple property collector. It only visits the return statements within
The \typewithref{no.uio.ifi.refaktor.analyze.collectors}{LastStatementCollector}
collects the last statement of a selection. It does so by only visiting the top
level statements of the selection, and compares the textual end offset of each
-encuntered statement with the end offset of the previous statement found.
+encountered statement with the end offset of the previous statement found.
\section{Checkers}\label{checkers}
-The checkers are a range of classes that checks that selections complies with
-certian criterias. If a
+\todoin{Check out ExtractMethodAnalyzer from ExtractMethodRefactoring}
+The checkers are a range of classes that checks that text selections complies
+with certain criteria. All checkers operates under the assumption that the code
+they check is free from compilation errors. If a
\typewithref{no.uio.ifi.refaktor.analyze.analyzers}{Checker} fails, it throws a
\type{CheckerException}. The checkers are managed by the
\type{LegalStatementsChecker}, which does not, in fact, implement the
it, and reports that all statements are considered legal if no
\type{CheckerException} is thrown. Many of the checkers either extends the
\type{PropertyCollector} or utilizes one or more property collectors to verify
-some criterias. The checkers registered with the \type{LegalStatementsChecker}
+some criteria. The checkers registered with the \type{LegalStatementsChecker}
are described next. They are run in the order presented below.
+\subsection{The CallToProtectedOrPackagePrivateMethodChecker}
+This checker is used to check that at selection does not contain a call to a
+method that is protected or package-private. Such a method either has the access
+modifier \code{protected} or it has no access modifier.
+
+The workings of the \type{CallToProtectedOrPackagePrivateMethod\-Checker} is
+very simple. It looks for calls to methods that are either protected or
+package-private within the selection, and throws an
+\type{IllegalExpressionFoundException} if one is found.
+
+\subsection{The DoubleClassInstanceCreationChecker}
+The \type{DoubleClassInstanceCreationChecker} checks that there are no double
+class instance creations where the inner constructor call take and argument that
+is built up using field references.
+
+The checker visits all nodes of type \type{ClassInstanceCreation} within a
+selection. For all of these nodes, if its parent also is a class instance
+creation, it accepts a visitor that throws a
+\type{IllegalExpressionFoundException} if it enclounters a name that is a field
+reference.
+
+\subsection{The InstantiationOfNonStaticInnerClassChecker}
+The \type{InstantiationOfNonStaticInnerClassChecker} checks that selections
+does not contain instantiations of non-static inner classes. The
+\type{MoveInstanceMethodProcessor} in Eclipse does not handle such
+instantiations gracefully when moving a method. This problem is also related to
+bug\ldots \todoin{File Eclipse bug report}
+
\subsection{The EnclosingInstanceReferenceChecker}
-The purpose of this checker is to verify that the names in a selection is not
-referencing any enclosing instances. This is for making sure that all references
-is legal in a method that is to be moved. Theoretically, some situations could
-be easily solved my passing a reference to the referenced class with the moved
-method (e.g. when calling public methods), but the dependency on the
+The purpose of this checker is to verify that the names in a text selection are
+not referencing any enclosing instances. In theory, the underlying problem could
+be solved in some situations, but our dependency on the
\type{MoveInstanceMethodProcessor} prevents this.
The
\typewithref{no.uio.ifi.refaktor.analyze.analyzers}{EnclosingInstanceReferenceChecker}
is a modified version of the
-\typewithref{org.eclipse.jdt.internal.corext.refactoring.structure.MoveInstanceMethodProcessor}{EnclosingInstanceReferenceFinder}
+\typewithref{org.eclipse.jdt.internal.corext.refactoring.structure.MoveInstanceMethod\-Processor}{EnclosingInstanceReferenceFinder}
from the \type{MoveInstanceMethodProcessor}. Wherever the
-\type{EnclosingInstanceReferenceFinder} would create a fatal error status, the
-checker throws a \type{CheckerException}.
+\type{EnclosingInstanceReferenceFinder} would create a fatal error status, the
+checker will throw a \type{CheckerException}.
-It works by first finding all of the enclosing types of a selection. Thereafter
-it visits all its simple names to check that they are not references to
-variables or methods declared in any of the enclosing types. In addition the
-checker visits \var{this}-expressions to verify that no such expressions is
-qualified with any name.
+The checker works by first finding all of the enclosing types of a selection.
+Thereafter, it visits all the simple names of the selection to check that they
+are not references to variables or methods declared in any of the enclosing
+types. In addition, the checker visits \var{this}-expressions to verify that no
+such expressions are qualified with any name.
\subsection{The ReturnStatementsChecker}\label{returnStatementsChecker}
-\todoin{Write\ldots/change implementation/use control flow graph?}
+The checker for return statements is meant to verify that a text selection is
+consistent regarding return statements.
+
+If the selection is free from return statements, then the checker validates. So
+this is the first thing the checker investigates.
+
+If the checker proceedes any further, it is because the selection contains one
+or more return statements. The next test is therefore to check if the last
+statement of the selection ends in either a return or a throw statement. The
+responsibility for checking that the last statement of the selection eventually
+ends in a return or throw statement, is put on the
+\type{LastStatementOfSelectionEndsInReturnOrThrowChecker}. For every node
+visited, if the node is a statement, it does a test to see if the statement is a
+return, a throw or if it is an implicit return statement. If this is the case,
+no further checking is done. This checking is done in the \code{preVisit2}
+method \see{astVisitor}. If the node is not of a type that is being handled by
+its type-specific visit method, the checker performs a simple test. If the node
+being visited is not the last statement of its parent that is also enclosed by
+the selection, an \type{IllegalStatementFoundException} is thrown. This ensures
+that all statements are taken care of, one way or the other. It also ensures
+that the checker is conservative in the way it checks for legality of the
+selection.
+
+To examine if a statement is an implicit return statement, the checker first
+finds the last statement declared in its enclosing method. If this statement is
+the same as the one under investigation, it is considered an implicit return
+statement. If the statements are not the same, the checker does a search to see
+if the statement examined is also the last statement of the method that can be
+reached. This includes the last statement of a block statement, a labeled
+statement, a synchronized statement or a try statement, that in turn is the last
+statement enclosed by one of the statement types listed. This search goes
+through all the parents of a statement until a statement is found that is not
+one of the mentioned acceptable parent statements. If the search ends in a
+method declaration, then the statement is considered to be the last reachable
+statement of the method, and thus it is an implicit return statement.
+
+There are two kinds of statements that are handled explicitly: If-statements and
+try-statements. Block, labeled and do-statements are handled by fall-through to
+the other two.
+
+If-statements are handled explicitly by overriding their type-specific visit
+method. If the then-part does not contain any return or throw statements an
+\type{IllegalStatementFoundException} is thrown. If it does contain a return or
+throw, its else-part is checked. If the else-part is non-existent, or it does
+not contain any return or throw statements an exception is thrown. If no
+exception is thrown while visiting the if-statement, its children are visited.
+
+A try-statement is checked very similar to an if-statement. Its body must
+contain a return or throw. The same applies to its catch clauses and finally
+body. Failure to validate produces an \type{IllegalStatementFoundException}.
+
+If the checker does not complain at any point, the selection is considered valid
+with respect to return statements.
\subsection{The AmbiguousReturnValueChecker}
-This checker verifies that there are no \emph{ambiguous return statements} in a
-selection. The problem with ambiguous return statements arise when a selection
-is chosen to be extracted into a new method, but it needs to return more than
-one value from that method. This problem occurs in two situations. The first
-situation arise when there is more than one local variable that is both assigned
-to within a selection and also referenced after the selection. The other
-situation occur when there is only one such assignment, but there is also one or
-more return statements in the selection.
-
-First the checker needs to collect some data. Those data are the binding keys
+This checker verifies that there are no ambiguous return values in a selection.
+
+First, the checker needs to collect some data. Those data are the binding keys
for all simple names that are assigned to within the selection, including
variable declarations, but excluding fields. The checker also collects whether
there exists a return statement in the selection or not. No further checks of
After the binding keys of the assignees are collected, the checker searches the
part of the enclosing method that is after the selection for references whose
-binding keys are among the the collected keys. If more than one unique referral
-is found, or only one referral is found, but the selection also contains a
-return statement, we have a situation with an ambiguous return value, and an
-exception is thrown.
+binding keys are among the collected keys. If more than one unique referral is
+found, or only one referral is found, but the selection also contains a return
+statement, we have a situation with an ambiguous return value, and an exception
+is thrown.
%\todoin{Explain why we do not need to consider variables assigned inside
%local/anonymous classes. (The referenced variables need to be final and so
\subsection{The IllegalStatementsChecker}
This checker is designed to check for illegal statements.
-Any use of the \var{super} keyword is prohibited, since its meaning is altered
-when moving a method to another class.
+Notice that labels in break and continue statements needs some special
+treatment. Since a label does not have any binding information, we have to
+search upwards in the AST to find the \type{LabeledStatement} that corresponds
+to the label from the break or continue statement, and check that it is
+contained in the selection. If the break or continue statement does not have a
+label attached to it, it is checked that its innermost enclosing loop or switch
+statement (break statements only) also is contained in the selection.
-For a \emph{break} statement, there is two situations to consider: A break
-statement with or without a label. If the break statement has a label, it is
-checked that whole of the labeled statement is inside the selection. Since a
-label does not have any binding information, we have to search upwards in the
-AST to find the \type{LabeledStatement} that corresponds to the label from the
-break statement, and check that it is contained in the selection. If the break
-statement does not have a label attached to it, it is checked that its innermost
-enclosing loop or switch statement also is inside the selection.
-
-The situation for a \emph{continue} statement is the same as for a break
-statement, except that it is not allowed inside switch statements.
-
-Regarding \emph{assignments}, two types of assignments is allowed: Assignment to
-a non-final variable and assignment to an array access. All other assignments is
-regarded illegal.
-
-\todoin{Finish\ldots}
+\todoin{Follow the development in the semantics section\ldots}
\chapter{Benchmarking}
\todoin{Better name than ``benchmarking''?}
-This part of the master project is located in the Eclipse project
+This part of the master's project is located in the \name{Eclipse} project
\code{no.uio.ifi.refaktor.benchmark}. The purpose of it is to run the equivalent
of the \type{SearchBasedExtractAndMoveMethodChanger}
\see{searchBasedExtractAndMoveMethodChanger} over a larger software project,
-both to test its roubustness but also its effect on different software metrics.
+both to test its robustness but also its effect on different software metrics.
\section{The benchmark setup}
-The benchmark itself is set up as a \emph{JUnit} test case. This is a convenient
-setup, and utilizes the \emph{JUnit Plugin Test Launcher}. This provides us a
-with a fully functional Eclipse workbench. Most importantly, this gives us
-access to the Java Model of Eclipse \see{javaModel}.
+The benchmark itself is set up as a \name{JUnit} test case. This is a convenient
+setup, and utilizes the \name{JUnit Plugin Test Launcher}. This provides us with
+a fully functional \name{Eclipse} workbench. Most importantly, this gives us
+access to the Java Model of \name{Eclipse} \see{javaModel}.
\subsection{The ProjectImporter}
The Java project that is going to be used as the data for the benchmark, must be
import operation is run to perform the import.
I have found no simple API call to accomplish what the importer does, which
-tells me that it may not be too many people performing this particular action.
-The solution to the problem was found on \emph{Stack
+tells me that it may not be too many people performing this particular action.
+The solution to the problem was found on \name{Stack
Overflow}\footnote{\url{https://stackoverflow.com/questions/12401297}}. It
-contains enough dirty details to be considered unconvenient to use, if not
+contains enough dirty details to be considered inconvenient to use, if not
wrapping it in a class like my \type{ProjectImporter}. One would probably have
to delve into the source code for the import wizard to find out how the import
operation works, if no one had already done it.
\section{Statistics}
Statistics for the analysis and changes is captured by the
\typewithref{no.uio.ifi.refaktor.aspects}{StatisticsAspect}. This an
-\emph{aspect} written in \emph{AspectJ}.
+\emph{aspect} written in \name{AspectJ}.
\subsection{AspectJ}
-\emph{AspectJ}\footnote{\url{http://eclipse.org/aspectj/}} is an extension to
+\name{AspectJ}\footnote{\url{http://eclipse.org/aspectj/}} is an extension to
the Java language, and facilitates combining aspect-oriented programming with
the object-oriented programming in Java.
\myref{lst:aspectjExample}.
\begin{listing}[h]
-\begin{minted}{java}
+\begin{minted}{aspectj}
pointcut methodAnalyze(
SearchBasedExtractAndMoveMethodAnalyzer analyzer) :
call(* SearchBasedExtractAndMoveMethodAnalyzer.analyze())
analyzed and the number of methods, types, compilation units and packages
analyzed. There are also advices that counts for how many of the methods there
is found a selection that is a candidate for the refactoring, and for how many
-ethods there is not.
+methods there is not.
There exists advices for counting both the successful and unsuccessful
executions of all the refactorings. Both for the \ExtractMethod and \MoveMethod
\section{Optimizations}
When looking for optimizations to make for the benchmarking process, I used the
-\emph{VisualVM}\footnote{\url{http://visualvm.java.net/}} for the Java Virtual
-Machine to both profile the application and also to make memory dumps of its
-heap.
+\name{VisualVM}\footnote{\url{http://visualvm.java.net/}} \gloss{profiler} for
+the Java Virtual Machine to both profile the application and also to make memory
+dumps of its heap.
\subsection{Caching}
-When profiling the benchmark process before making any optimizations, it early
-became apparent that the parsing of source code was a place to direct attention
-towards. This discovery was done when only \emph{analyzing} source code, before
-trying to do any \emph{manipulation} of it. Caching of the parsed ASTs seemed
-like the best way to save some time, as expected. With only a simple cache of
-the most recently used AST, the analysis time was speeded up by a factor of
-around
-20. This number depends a little upon which type of system the analysis was
-run.
+When \gloss{profiling} the benchmark process before making any optimizations, it
+early became apparent that the parsing of source code was a place to direct
+attention towards. This discovery was done when only \emph{analyzing} source
+code, before trying to do any \emph{manipulation} of it. Caching of the parsed
+ASTs seemed like the best way to save some time, as expected. With only a simple
+cache of the most recently used AST, the analysis time was speeded up by a
+factor of around 20. This number depends a little upon which type of system the
+analysis is run.
The caching is managed by a cache manager, that now, by default, utilizes the
not so well known feature of Java called a \emph{soft reference}. Soft
The cache based on soft references has no limit for how many ASTs it caches. It
is generally not advisable to keep references to ASTs for prolonged periods of
time, since they are expensive structures to hold on to. For regular plugin
-development, Eclipse recommends not creating more than one AST at a time to
+development, \name{Eclipse} recommends not creating more than one AST at a time to
limit memory consumption. Since the benchmarking has nothing to do with user
experience, and throughput is everything, these advices are intentionally
-ignored. This means that during the benchmarking process, the target Eclipse
+ignored. This means that during the benchmarking process, the target \name{Eclipse}
application may very well work close to its memory limit for the heap space for
long periods during the benchmark.
-\subsection{Memento}
+\subsection{Candidates stored as mementos}
+When performing large scale analysis of source code for finding candidates to
+the \ExtractAndMoveMethod refactoring, memory is an issue. One of the inputs to
+the refactoring is a variable binding. This variable binding indirectly retains
+a whole AST. Since ASTs are large structures, this quickly leads to an
+\type{OutOfMemoryError} if trying to analyze a large project without optimizing
+how we store the candidates data. This means that the JVM cannot allocate more
+memory for out benchmark, and it exists disgracefully.
+
+A possible solution could be to just allow the JVM to allocate even more memory,
+but this is not a dependable solution. The allocated memory could easily
+supersede the physical memory of a machine, and that would make the benchmark go
+really slow.
+
+Thus, the candidates data must be stored in another format. Therefore, we use
+the \gloss{mementoPattern} to store the variable binding information. This is
+done in a way that makes it possible to retrieve the variable binding at a later
+point. The data that is stored to achieve this, is the key to the original
+variable binding. In addition to the key, we know which method and text
+selection the variable is referenced in, so that we can find it by parsing the
+source code and search for it when it is needed.
+
+
+\chapter{Technicalities}
+
+\section{Source code organization}
+All the parts of this master's project is under version control with
+\name{Git}\footnote{\url{http://git-scm.com/}}.
+
+The software written is organized as some \name{Eclipse} plugins. Writing a plugin is
+the natural way to utilize the API of \name{Eclipse}. This also makes it possible to
+provide a user interface to manually run operations on selections in program
+source code or whole projects/packages.
+
+When writing a plugin in \name{Eclipse}, one has access to resources such as the
+current workspace, the open editor and the current selection.
+
+The thesis work is contained in the following Eclipse projects:
+
+\begin{description}
+ \item[no.uio.ifi.refaktor] \hfill \\ This is the main Eclipse plugin
+ project, and contains all of the business logic for the plugin.
+
+ \item[no.uio.ifi.refaktor.tests] \hfill \\
+ This project contains the tests for the main plugin.
+
+ \item[no.uio.ifi.refaktor.examples] \hfill \\
+ Contains example code used in testing. It also contains code for managing
+ this example code, such as creating an Eclipse project from it before a test
+ run.
+
+ \item[no.uio.ifi.refaktor.benchmark] \hfill \\
+ This project contains code for running search based versions of the
+ composite refactoring over selected Eclipse projects.
+
+ \item[no.uio.ifi.refaktor.releng] \hfill \\
+ Contains the rmap, queries and target definitions needed by by Buckminster
+ on the Jenkins continuous integration server.
+
+\end{description}
+
+\subsection{The no.uio.ifi.refaktor project}
+
+\subsubsection{no.uio.ifi.refaktor.analyze}
+This package, and its subpackages, contains code that is used for analyzing Java
+source code. The most important subpackages are presented below.
+
+\begin{description}
+ \item[no.uio.ifi.refaktor.analyze.analyzers] \hfill \\
+ This package contains source code analyzers. These are usually responsible
+ for analyzing text selections or running specialized analyzers for different
+ kinds of entities. Their structure are often hierarchical. This means that
+ you have an analyzer for text selections, that in turn is utilized by an
+ analyzer that analyzes all the selections of a method. Then there are
+ analyzers for analyzing all the methods of a type, all the types of a
+ compilation unit, all the compilation units of a package, and, at last, all
+ of the packages in a project.
+
+ \item[no.uio.ifi.refaktor.analyze.checkers] \hfill \\
+ A package containing checkers. The checkers are classes used to validate
+ that a selection can be further analyzed and chosen as a candidate for a
+ refactoring. Invalidating properties can be such as usage of inner classes
+ or the need for multiple return values.
+
+ \item[no.uio.ifi.refaktor.analyze.collectors] \hfill \\
+ This package contains the property collectors. Collectors are used to gather
+ properties from a text selection. This is mostly properties regarding
+ referenced names and their occurrences. It is these properties that makes up
+ the basis for finding the best candidates for a refactoring.
+\end{description}
+
+\subsubsection{no.uio.ifi.refaktor.change}
+This package, and its subpackages, contains functionality for manipulate source
+code.
+
+\begin{description}
+ \item[no.uio.ifi.refaktor.change.changers] \hfill \\
+ This package contains source code changers. They are used to glue together
+ the analysis of source code and the actual execution of the changes.
+
+ \item[no.uio.ifi.refaktor.change.executors] \hfill \\
+ The executors that are responsible for making concrete changes are found in
+ this package. They are mostly used to create and execute one or more Eclipse
+ refactorings.
+
+ \item[no.uio.ifi.refaktor.change.processors] \hfill \\
+ Contains a refactoring processor for the \MoveMethod refactoring. The code
+ is stolen and modified to fix a bug. The related bug is described in
+ \myref{eclipse_bug_429416}.
+
+\end{description}
+
+\subsubsection{no.uio.ifi.refaktor.handlers}
+This package contains handlers for the commands defined in the plugin manifest.
+
+\subsubsection{no.uio.ifi.refaktor.prefix}
+This package contains the \type{Prefix} type that is the data representation of
+the prefixes found by the \type{PrefixesCollector}. It also contains the prefix
+set for storing and working with prefixes.
+
+\subsubsection{no.uio.ifi.refaktor.statistics}
+The package contains statistics functionality. Its heart is the statistics
+aspect that is responsible for gathering statistics during the execution of the
+\ExtractAndMoveMethod refactoring.
+
+\begin{description}
+ \item[no.uio.ifi.refaktor.statistics.reports] \hfill \\
+ This package contains a simple framework for generating reports from the
+ statistics data generated by the aspect. Currently, the only available
+ report type is a simple text report.
+
+\end{description}
+
+
+\subsubsection{no.uio.ifi.refaktor.textselection}
+This package contains the two custom text selections that are used extensively
+throughout the project. One of them is just a subclass of the other, to support
+the use of the memento pattern to optimize the memory usage during benchmarking.
+
+\subsubsection{no.uio.ifi.refaktor.debugging}
+The package contains a debug utility class. I addition to this, the package
+\code{no.uio.ifi.refaktor.utils.aspects} contains a couple of aspects used for
+debugging purposes.
+
+\subsubsection{no.uio.ifi.refaktor.utils}
+Utility package that contains all the functionality that has to do with parsing
+of source code. It also has utility classes for looking up handles to methods
+and types et cetera.
+
+\begin{description}
+ \item[no.uio.ifi.refaktor.utils.caching] \hfill \\
+ This package contains the caching manager for compilation units, along with
+ classes for different caching strategies.
+
+ \item[no.uio.ifi.refaktor.utils.nullobjects] \hfill \\
+ Contains classes for creating different null objects. Most of the classes is
+ used to represent null objects of different handle types. These null objects
+ are returned from various utility classes instead of returning a \var{null}
+ value when other values are not available.
+
+\end{description}
+
+\section{Continuous integration}
+The continuous integration server
+\name{Jenkins}\footnote{\url{http://jenkins-ci.org/}} has been set up for the
+project\footnote{A work mostly done by the supervisor.}. It is used as a way to
+run tests and perform code coverage analysis.
+
+To be able to build the \name{Eclipse} plugins and run tests for them with Jenkins, the
+component assembly project
+\name{Buckminster}\footnote{\url{http://www.eclipse.org/buckminster/}} is used,
+through its plugin for Jenkins. Buckminster provides for a way to specify the
+resources needed for building a project and where and how to find them.
+Buckminster also handles the setup of a target environment to run the tests in.
+All this is needed because the code to build depends on an \name{Eclipse}
+installation with various plugins.
+
+\subsection{Problems with AspectJ}
+The Buckminster build worked fine until introducing AspectJ into the project.
+When building projects using AspectJ, there are some additional steps that needs
+to be performed. First of all, the aspects themselves must be compiled. Then the
+aspects needs to be woven with the classes they affect. This demands a process
+that does multiple passes over the source code.
+
+When using AspectJ with \name{Eclipse}, the specialized compilation and the
+weaving can be handled by the \name{AspectJ Development
+Tools}\footnote{\url{https://www.eclipse.org/ajdt/}}. This works all fine, but
+it complicates things when trying to build a project depending on \name{Eclipse}
+plugins outside of \name{Eclipse}. There is supposed to be a way to specify a
+compiler adapter for javac, together with the file extensions for the file types
+it shall operate. The AspectJ compiler adapter is called
+\typewithref{org.aspectj.tools.ant.taskdefs}{Ajc11CompilerAdapter}, and it works
+with files that has the extensions \code{*.java} and \code{*.aj}. I tried to
+setup this in the build properties file for the project containing the aspects,
+but to no avail. The project containing the aspects does not seem to be built at
+all, and the projects that depends on it complains that they cannot find certain
+classes.
+
+I then managed to write an \name{Ant}\footnote{\url{https://ant.apache.org/}}
+build file that utilizes the AspectJ compiler adapter, for the
+\code{no.uio.ifi.refaktor} plugin. The problem was then that it could no longer
+take advantage of the environment set up by Buckminster. The solution to this
+particular problem was of a ``hacky'' nature. It involves exporting the plugin
+dependencies for the project to an Ant build file, and copy the exported path
+into the existing build script. But then the Ant script needs to know where the
+local \name{Eclipse} installation is located. This is no problem when building
+on a local machine, but to utilize the setup done by Buckminster is a problem
+still unsolved. To get the classpath for the build setup correctly, and here
+comes the most ``hacky'' part of the solution, the Ant script has a target for
+copying the classpath elements into a directory relative to the project
+directory and checking it into Git. When no \code{ECLIPSE\_HOME} property is set
+while running Ant, the script uses the copied plugins instead of the ones
+provided by the \name{Eclipse} installation when building the project. This
+obviously creates some problems with maintaining the list of dependencies in the
+Ant file, as well as remembering to copy the plugins every time the list of
+dependencies change.
+
+The Ant script described above is run by Jenkins before the Buckminster setup
+and build. When setup like this, the Buckminster build succeeds for the projects
+not using AspectJ, and the tests are run as normal. This is all good, but it
+feels a little scary, since the reason for Buckminster not working with AspectJ
+is still unknown.
+
+The problems with building with AspectJ on the Jenkins server lasted for a
+while, before they were solved. This is reflected in the ``Test Result Trend''
+and ``Code Coverage Trend'' reported by Jenkins.
+
+
+\chapter{Methodology}
+
+\section{Evolutionary design}
+In the programming work for this project, it have tried to use a design strategy
+called evolutionary design, also known as continuous or incremental
+design\citing{wiki_continuous_2014}. It is a software design strategy
+advocated by the Extreme Programming community. The essence of the strategy is
+that you should let the design of your program evolve naturally as your
+requirements change. This is seen in contrast with up-front design, where
+design decisions are made early in the process.
+
+The motivation behind evolutionary design is to keep the design of software as
+simple as possible. This means not introducing unneeded functionality into a
+program. You should defer introducing flexibility into your software, until it
+is needed to be able to add functionality in a clean way.
+
+Holding up design decisions, implies that the time will eventually come when
+decisions have to be made. The flexibility of the design then relies on the
+programmer's abilities to perform the necessary refactoring, and \his confidence
+in those abilities. From my experience working on this project, I can say that
+this confidence is greatly enhanced by having automated tests to rely on
+\see{tdd}.
+
+The choice of going for evolutionary design developed naturally. As Fowler
+points out in his article \tit{Is Design Dead?}, evolutionary design much
+resembles the ``code and fix'' development strategy\citing{fowler_design_2004}.
+A strategy that most of us have practiced in school. This was also the case when
+I first started this work. I had to learn the inner workings of Eclipse and its
+refactoring-related plugins. That meant a lot of fumbling around with code I did
+not know, in a trial and error fashion. Eventually I started writing tests for
+my code, and my design began to evolve.
+
+\section{Test-driven development}\label{tdd}
+As mentioned before, the project started out as a classic code and fix
+developmen process. My focus was aimed at getting something to work, rather than
+doing so according to best practice. This resulted in a project that got out of
+its starting blocks, but it was not accompanied by any tests. Hence it was soon
+difficult to make any code changes with the confidence that the program was
+still correct afterwards (assuming it was so before changing it). I always knew
+that I had to introduce some tests at one point, but this experience accelerated
+the process of leading me onto the path of testing.
+
+I then wrote tests for the core functionality of the plugin, and thus gained
+more confidence in the correctness of my code. I could now perform quite drastic
+changes without ``wetting my pants``. After this, nearly all of the semantic
+changes done to the business logic of the project, or the addition of new
+functionality, was made in a test-driven manner. This means that before
+performing any changes, I would define the desired functionality through a set
+of tests. I would then run the tests to check that they were run and that they
+did not pass. Then I would do any code changes necessary to make the tests
+pass. The definition of how the program is supposed to operate is then captured
+by the tests. However, this does not prove the correctness of the analysis
+leading to the test definitions.
+
+\section{Continuous integration}
+\todoin{???}
+
\chapter{Eclipse Bugs Found}
-\todoin{Add other things and change headline?}
+\newcommand{\submittedBugReport}[1]{The submitted bug report can be found on
+ \url{#1}.}
\section{Eclipse bug 420726: Code is broken when moving a method that is
assigning to the parameter that is also the move
destination}\label{eclipse_bug_420726}
-This bug\footnote{\url{https://bugs.eclipse.org/bugs/show\_bug.cgi?id=420726}}
+This bug
was found when analyzing what kinds of names that was to be considered as
\emph{unfixes} \see{unfixes}.
\subsection{The bug}
The bug emerges when trying to move a method from one class to another, and when
the target for the move (must be a variable, local or field) is both a parameter
-variable and also is assigned to within the method body. Eclipse allows this to
+variable and also is assigned to within the method body. \name{Eclipse} allows this to
happen, although it is the sure path to a compilation error. This is because we
would then have an assignment to a \var{this} expression, which is not allowed
-in Java.
+in Java.
+\submittedBugReport{https://bugs.eclipse.org/bugs/show\_bug.cgi?id=420726}
\subsection{The solution}
The solution to this problem is to add all simple names that are assigned to in
a method body to the set of unfixes.
-\section{Eclipse bug 429416: IAE when moving method from anonymous class}
-I
-discovered\footnote{\url{https://bugs.eclipse.org/bugs/show\_bug.cgi?id=429416}}
+\section{Eclipse bug 429416: IAE when moving method from anonymous
+class}\label{eclipse_bug_429416}
+I discovered
this bug during a batch change on the \type{org.eclipse.jdt.ui} project.
\subsection{The bug}
-This bug surfaces when trying to use the Move Method refactoring to move a
+This bug surfaces when trying to use the \refa{Move Method} refactoring to move a
method from an anonymous class to another class. This happens both for my
-simulation as well as in Eclipse, through the user interface. It only occurs
-when Eclipse analyzes the program and finds it necessary to pass an instance of
+simulation as well as in \name{Eclipse}, through the user interface. It only occurs
+when \name{Eclipse} analyzes the program and finds it necessary to pass an instance of
the originating class as a parameter to the moved method. I.e. it want to pass a
\var{this} expression. The execution ends in an
\typewithref{java.lang}{IllegalArgumentException} in
invocation where the previous invocation to the method that was moved was. From
its code it can be read that when a \var{this} expression is going to be passed
in to the invocation, it shall be qualified with the name of the original
-method's declaring class, if the declaring class is either an anonymous clas or
+method's declaring class, if the declaring class is either an anonymous class or
a member class. The problem with this, is that an anonymous class does not have
a name, hence the term \emph{anonymous} class! Therefore, when its name, an
empty string, is passed into
\methodwithref{org.eclipse.jdt.core.dom.AST}{newSimpleName} it all ends in an
-\type{IllegalArgumentException}.
+\type{IllegalArgumentException}.
+\submittedBugReport{https://bugs.eclipse.org/bugs/show\_bug.cgi?id=429416}
\subsection{How I solved the problem}
Since the \type{MoveInstanceMethodProcessor} is instantiated in the
\typewithref{org.eclipse.ltk.core.refactoring.participants}{MoveProcessor}, I
was able to copy the code for the original move processor and modify it so that
it works better for me. It is now called
-\typewithref{no.uio.ifi.refaktor.refactorings.processors}{ModifiedMoveInstanceMethodProcessor}.
+\typewithref{no.uio.ifi.refaktor.change.processors}{ModifiedMoveInstanceMethodProcessor}.
The only modification done (in addition to some imports and suppression of
warnings), is in the \method{createInlinedMethodInvocation}. When the declaring
class of the method to move is anonymous, the \var{this} expression in the
\section{Eclipse bug 429954: Extracting statement with reference to local type
breaks code}\label{eclipse_bug_429954}
-The bug\footnote{\url{https://bugs.eclipse.org/bugs/show\_bug.cgi?id=429954}}
+The bug
was discovered when doing some changes to the way unfixes is computed.
\subsection{The bug}
-The problem is that Eclipse is allowing selections that references variables of
+The problem is that \name{Eclipse} is allowing selections that references variables of
local types to be extracted. When this happens the code is broken, since the
extracted method must take a parameter of a local type that is not in the
methods scope. The problem is illustrated in
-\myref{lst:extractMethod_LocalClass}, but there in another setting.
+\myref{lst:extractMethod_LocalClass}, but there in another setting.
+\submittedBugReport{https://bugs.eclipse.org/bugs/show\_bug.cgi?id=429954}
\subsection{Actions taken}
There are no actions directly springing out of this bug, since the Extract
Method refactoring cannot be meant to be this way. This is handled on the
-analysis stage of our Extract and Move Method refactoring. So names representing
+analysis stage of our \refa{Extract and Move Method} refactoring. So names representing
variables of local types is considered unfixes \see{unfixes}.
\todoin{write more when fixing this in legal statements checker}
+\chapter{Conclusions and Future Work}
+\todoin{Write}
+
+\section{Future work}
+\todoin{Copied from introduction:}
+For the metrics, I will at least measure the \metr{Coupling between object
+classes} (CBO) metric that is described by Chidamber and Kemerer in their
+article \tit{A Metrics Suite for Object Oriented
+Design}\citing{metricsSuite1994}.
+
+\ldots
+
+Then the effect of the change must be measured by calculating the chosen
+software metrics both before and after the execution.
+\todoin{Metrics, \ldots}
+
\chapter{Related Work}
\section{The compositional paradigm of refactoring}
This paradigm builds upon the observation of Vakilian et
al.\citing{vakilian2012}, that of the many automated refactorings existing in
modern IDEs, the simplest ones are dominating the usage statistics. The report
-mainly focuses on \emph{Eclipse} as the tool under investigation.
+mainly focuses on \name{Eclipse} as the tool under investigation.
The paradigm is described almost as the opposite of automated composition of
refactorings \see{compositeRefactorings}. It works by providing the programmer
with easily accessible primitive refactorings. These refactorings shall be
accessed via keyboard shortcuts or quick-assist menus\footnote{Think
-quick-assist with Ctrl+1 in Eclipse} and be promptly executed, opposed to in the
-currently dominating wizard-based refactoring paradigm. They are ment to
+quick-assist with Ctrl+1 in \name{Eclipse}} and be promptly executed, opposed to in the
+currently dominating wizard-based refactoring paradigm. They are meant to
stimulate composing smaller refactorings into more complex changes, rather than
doing a large upfront configuration of a wizard-based refactoring, before
previewing and executing it. The compositional paradigm of refactoring is
\backmatter{}
+\printglossaries
\printbibliography
\listoftodos
\end{document}
git://git.uio.no / ifi-stolz-refaktor.git / blobdiff