Getting rid of trivial warnings.

diff --git a/HLT/PHOS/AliHLTPHOSBaseline.h b/HLT/PHOS/AliHLTPHOSBaseline.h
index 0274b8cee5318fdb834c21e395fe6c26c347613d..14d26a5f43f71cbb1f32090907b4f96e058df341 100644 (file)
--- a/HLT/PHOS/AliHLTPHOSBaseline.h
+++ b/HLT/PHOS/AliHLTPHOSBaseline.h
@@ -46,7 +46,7 @@ public:
   void SetX(Int_t x) { fX = x; }
   void SetZ(Int_t z) { fZ = z; }
   void SetGain(Int_t gain) { fGain = gain; }
-  void SetEntries(Int_t entries) { fEntries = 0; }
+  void SetEntries(Int_t /*entries*/) { fEntries = 0; }  //TODO: should we not set fEntries to entries? is this a bug?
 
   Float_t GetBaseline() { return fBaseline; }  
   Int_t GetX() { return fX; }

diff --git a/HLT/PHOS/AliHLTPHOSBaselineAnalyzer.cxx b/HLT/PHOS/AliHLTPHOSBaselineAnalyzer.cxx
index 0760df9d70f02f9bbc013d70bb54adadabd3cdf9..e0406dfd2e000ba33fac11eb20ce1514a2f41096 100644 (file)
--- a/HLT/PHOS/AliHLTPHOSBaselineAnalyzer.cxx
+++ b/HLT/PHOS/AliHLTPHOSBaselineAnalyzer.cxx
@@ -34,8 +34,8 @@ ClassImp(AliHLTPHOSBaselineAnalyzer);
 AliHLTPHOSBaselineAnalyzer::AliHLTPHOSBaselineAnalyzer() : 
   AliHLTPHOSBase(),
   fSampleStart(5),
-  fMaxSignal(0),
-  fMaxCrazyDifference(0),          
+  fMaxCrazyDifference(0),      
+  fMaxSignal(0),    
   fTreePtr(0),
   fSanityInspector(0)     
 {  
@@ -44,11 +44,11 @@ AliHLTPHOSBaselineAnalyzer::AliHLTPHOSBaselineAnalyzer() :
   
   char histName[128];
   char histTitle[128];
-  for(Int_t x = 0; x < N_XCOLUMNS_MOD; x++)
+  for(UInt_t x = 0; x < N_XCOLUMNS_MOD; x++)
   {
-    for(Int_t z = 0; z < N_ZROWS_MOD; z++)
+    for(UInt_t z = 0; z < N_ZROWS_MOD; z++)
     {
-      for(Int_t gain = 0; gain < N_GAINS; gain++)
+      for(UInt_t gain = 0; gain < N_GAINS; gain++)
       { 
        sprintf(histName, "sample_value_channel_x_col_%d_z_row_%d_gain_%d", x, z, gain);
        sprintf(histTitle, "Distribution of Sample Values for Channel X: %d - Z: %d - Gain: %d", x, z, gain);
@@ -159,11 +159,11 @@ void
 AliHLTPHOSBaselineAnalyzer::CalculateChannelsBaselineRMS()
 {
   //comment
-  for(Int_t x = 0; x < N_XCOLUMNS_MOD; x++)
+  for(UInt_t x = 0; x < N_XCOLUMNS_MOD; x++)
   {
-    for(Int_t z = 0; z < N_ZROWS_MOD; z++)
+    for(UInt_t z = 0; z < N_ZROWS_MOD; z++)
     {
-      for(Int_t gain = 0; gain < N_GAINS; gain++)
+      for(UInt_t gain = 0; gain < N_GAINS; gain++)
       {
        fRMSHistogramPtr->Fill(fChannelHistogramsPtr[x][z][gain]->GetRMS());  
        if(gain == 1)
@@ -199,11 +199,11 @@ AliHLTPHOSBaselineAnalyzer::FillTree()
   AliHLTPHOSBaseline *baseline;
   Int_t n = 0;
 
-  for(Int_t x = 0; x < N_XCOLUMNS_MOD; x++)
+  for(UInt_t x = 0; x < N_XCOLUMNS_MOD; x++)
     {
-      for(Int_t z = 0; z < N_ZROWS_MOD; z++)
+      for(UInt_t z = 0; z < N_ZROWS_MOD; z++)
        {
-         for(Int_t gain = 0; gain < N_GAINS; gain++)
+         for(UInt_t gain = 0; gain < N_GAINS; gain++)
            {
              baseline = (AliHLTPHOSBaseline*)fBaselineArrayPtr->New(n);
              baseline->SetX(x);
@@ -234,11 +234,11 @@ AliHLTPHOSBaselineAnalyzer::WriteChannelHistograms(const Char_t* filename)
   //comment
   TFile *file = TFile::Open(filename, "recreate");
   
-  for(Int_t x = 0; x < N_XCOLUMNS_MOD; x++)
+  for(UInt_t x = 0; x < N_XCOLUMNS_MOD; x++)
   {
-    for(Int_t z = 0; z < N_ZROWS_MOD; z++)
+    for(UInt_t z = 0; z < N_ZROWS_MOD; z++)
     {
-      for(Int_t gain = 0; gain < N_GAINS; gain++)
+      for(UInt_t gain = 0; gain < N_GAINS; gain++)
       {
        fChannelHistogramsPtr[x][z][gain]->Write();
       }
@@ -268,11 +268,11 @@ void
 AliHLTPHOSBaselineAnalyzer::ResetBaselines()
 {
   //comment
-   for(Int_t x = 0; x < N_XCOLUMNS_MOD; x++)
+   for(UInt_t x = 0; x < N_XCOLUMNS_MOD; x++)
     {
-      for(Int_t z = 0; z < N_ZROWS_MOD; z++)
+      for(UInt_t z = 0; z < N_ZROWS_MOD; z++)
        {
-         for(Int_t gain = 0; gain < N_GAINS; gain++)
+         for(UInt_t gain = 0; gain < N_GAINS; gain++)
            {
              fBaselines[x][z][gain] = 0;    
            }
@@ -290,11 +290,11 @@ AliHLTPHOSBaselineAnalyzer::ResetChannelCount()
 void 
 AliHLTPHOSBaselineAnalyzer::ResetAccumulatedBaselines()
 {
-   for(Int_t x = 0; x < N_XCOLUMNS_MOD; x++)
+   for(UInt_t x = 0; x < N_XCOLUMNS_MOD; x++)
     {
-      for(Int_t z = 0; z < N_ZROWS_MOD; z++)
+      for(UInt_t z = 0; z < N_ZROWS_MOD; z++)
        {
-         for(Int_t gain = 0; gain < N_GAINS; gain++)
+         for(UInt_t gain = 0; gain < N_GAINS; gain++)
            {
             fAccumulatedBaselines[x][z][gain][0] = 0;
             fAccumulatedBaselines[x][z][gain][1] = 0;
@@ -317,11 +317,11 @@ AliHLTPHOSBaselineAnalyzer::SetMaxCrazyDifference(Int_t diff)
 void 
 AliHLTPHOSBaselineAnalyzer::SetChannelsHistograms(TH1F *channelLowGainHistArray[N_XCOLUMNS_MOD][N_ZROWS_MOD], TH1F *channelHighGainHistArray[N_XCOLUMNS_MOD][N_ZROWS_MOD])
 { 
-  for(Int_t x = 0; x < N_XCOLUMNS_MOD; x++)
+  for(UInt_t x = 0; x < N_XCOLUMNS_MOD; x++)
   {
-    for(Int_t z = 0; z < N_ZROWS_MOD; z++)
+    for(UInt_t z = 0; z < N_ZROWS_MOD; z++)
     {
-      for(Int_t gain = 0; gain < N_GAINS; gain++)
+      for(UInt_t gain = 0; gain < N_GAINS; gain++)
       { 
        fChannelLowGainHistogramsPtr[x][z][gain] = channelLowGainHistArray[x][z][gain];
        fChannelHighGainHistogramsPtr[x][z][gain] = channelHighGainHistArray[x][z][gain];

diff --git a/HLT/PHOS/AliHLTPHOSBaselineAnalyzerComponent.cxx b/HLT/PHOS/AliHLTPHOSBaselineAnalyzerComponent.cxx
index 9c67a0e489744c9aad8b945551d6b20ae55e12c2..b434f72bb4e201fa7399a4bdd58f70de3393582b 100644 (file)
--- a/HLT/PHOS/AliHLTPHOSBaselineAnalyzerComponent.cxx
+++ b/HLT/PHOS/AliHLTPHOSBaselineAnalyzerComponent.cxx
@@ -126,19 +126,19 @@ AliHLTPHOSBaselineAnalyzerComponent::GetOutputDataSize(unsigned long& constBase,
 
 int 
 AliHLTPHOSBaselineAnalyzerComponent::DoEvent(const AliHLTComponentEventData& evtData, const AliHLTComponentBlockData* blocks,
-                                       AliHLTComponentTriggerData& /*trigData*/, AliHLTUInt8_t* outputPtr, AliHLTUInt32_t& size,
-                                       std::vector<AliHLTComponentBlockData>& outputBlocks)
+                                       AliHLTComponentTriggerData& /*trigData*/, AliHLTUInt8_t* outputPtr, AliHLTUInt32_t& /*size*/,  //TODO: I think that not setting the size explicitly to zero when returning from this method may be a subtle bug in this component. Please check.
+                                       std::vector<AliHLTComponentBlockData>& /*outputBlocks*/)
 {
    //Do event
      
-  UInt_t tSize            = 0;
-  UInt_t offset           = 0; 
-  UInt_t mysize           = 0;
-  Int_t index             = 0;
+  //UInt_t tSize            = 0;
+  //UInt_t offset           = 0; 
+  //UInt_t mysize           = 0;
+  //Int_t index             = 0;
   
-  Int_t fileCount = 0;
-  Int_t digitCount = 0;
-  char filename [50];
+  //Int_t fileCount = 0;
+  //Int_t digitCount = 0;
+  //char filename [50];
 
 
   AliHLTUInt8_t* outBPtr;
@@ -206,7 +206,7 @@ AliHLTPHOSBaselineAnalyzerComponent::DoInit(int argc, const char** argv )
   fstream runNbFile;
   //char dir [10];
   
-  Int_t newRunNb;
+  //Int_t newRunNb;
   runNbFile.open("/opt/HLT-public/rundir/runNumber.txt");
   runNbFile >> fRunNb;
   runNbFile.close();
@@ -289,13 +289,13 @@ AliHLTPHOSBaselineAnalyzerComponent::CalculateAll()
 
   Float_t tmpBaselines[N_XCOLUMNS_MOD][N_ZROWS_MOD][N_GAINS][2];
   
-  for(Int_t x = 0; x < N_XCOLUMNS_MOD; x++)
+  for(UInt_t x = 0; x < N_XCOLUMNS_MOD; x++)
     {
-      for(Int_t z = 0; z < N_ZROWS_MOD; z++)
+      for(UInt_t z = 0; z < N_ZROWS_MOD; z++)
        {
-         for(Int_t gain = 0; gain < N_GAINS; gain++)
+         for(UInt_t gain = 0; gain < N_GAINS; gain++)
            {
-             for(Int_t d = 0; d < 2; d++)
+             for(UInt_t d = 0; d < 2; d++)
                {
                  tmpBaselines[x][z][gain][d] = 0;
                }
@@ -341,11 +341,11 @@ AliHLTPHOSBaselineAnalyzerComponent::CalculateAll()
 
   Int_t n = 0;
   
-  for(x = 0; x < N_XCOLUMNS_MOD; x++)
+  for(x = 0; x < (Int_t)N_XCOLUMNS_MOD; x++)
     {
-      for(z = 0; z < N_ZROWS_MOD; z++)
+      for(z = 0; z < (Int_t)N_ZROWS_MOD; z++)
        {
-         for(gain = 0; gain < N_GAINS; gain++)
+         for(gain = 0; gain < (Int_t)N_GAINS; gain++)
            {
              baselineObject = (AliHLTPHOSBaseline*)totalBaselineArray->New(n);
              baselineObject->SetBaseline(tmpBaselines[x][z][gain][0]);
@@ -364,7 +364,7 @@ AliHLTPHOSBaselineAnalyzerComponent::CalculateAll()
                cout << "Warning! Number of entries for x: " << x << " - z: " << z << " - gain: " << gain << " = " 
                     << tmpBaselines[x][z][gain][1] << endl;
              }
-             baselineObject->SetEntries(tmpBaselines[x][z][gain][1]);
+             baselineObject->SetEntries( Int_t(tmpBaselines[x][z][gain][1]) );
              n++;
            }
        }

diff --git a/HLT/PHOS/AliHLTPHOSBaselineAnalyzerComponent.h b/HLT/PHOS/AliHLTPHOSBaselineAnalyzerComponent.h
index b790f19c7fc57f8762a80a9551c43c644944db2d..06e6e1e9679fed875f47391d34611d859d2d60ef 100644 (file)
--- a/HLT/PHOS/AliHLTPHOSBaselineAnalyzerComponent.h
+++ b/HLT/PHOS/AliHLTPHOSBaselineAnalyzerComponent.h
@@ -41,6 +41,7 @@ public:
   AliHLTComponent* Spawn();
   
 protected:
+  using AliHLTPHOSProcessor::DoEvent;
   int DoInit(int argc, const char** argv);
   virtual int Deinit(); ////////// PTH WARNING you should Define a class AliHLTPHOSModuleProcessor
   

diff --git a/HLT/PHOS/AliHLTPHOSChannelCounter.cxx b/HLT/PHOS/AliHLTPHOSChannelCounter.cxx
index b5479bf7866444280d9f47cf1bfdafa92cb4e5f1..20f2720a4ffe5a5362ccfb157e67fced22afab1d 100644 (file)
--- a/HLT/PHOS/AliHLTPHOSChannelCounter.cxx
+++ b/HLT/PHOS/AliHLTPHOSChannelCounter.cxx
@@ -45,11 +45,11 @@ AliHLTPHOSChannelCounter::AliHLTPHOSChannelCounter() :
   fHistLowRatioPtr = new TH2F("lowoutofsync", "Low gain channel count divided by number of events", 
                             64, 0, 63, 56, 0, 56); 
   
-   for(Int_t x = 0; x < N_XCOLUMNS_MOD; x++)
+   for(UInt_t x = 0; x < N_XCOLUMNS_MOD; x++)
      {
-       for(Int_t z = 0; z < N_ZROWS_MOD; z++)
+       for(UInt_t z = 0; z < N_ZROWS_MOD; z++)
         {
-          for(Int_t gain = 0; gain < 2; gain++)
+          for(UInt_t gain = 0; gain < 2; gain++)
             {
               fChannelArrayPtr[x][z][gain] = 0;
             }
@@ -67,11 +67,11 @@ AliHLTPHOSChannelCounter::CountChannels(AliHLTPHOSRcuCellEnergyDataStruct* chann
 {
   //comment
   Int_t tmp[N_XCOLUMNS_MOD][N_ZROWS_MOD][N_GAINS];
-  for(Int_t x = 0; x < N_XCOLUMNS_MOD; x++)
+  for(UInt_t x = 0; x < N_XCOLUMNS_MOD; x++)
   {
-    for(Int_t z = 0; z < N_ZROWS_MOD; z++)
+    for(UInt_t z = 0; z < N_ZROWS_MOD; z++)
     {
-      for(Int_t gain = 0; gain < 2; gain++)
+      for(UInt_t gain = 0; gain < 2; gain++)
       {
        tmp[x][z][gain] = 0;
       }
@@ -85,11 +85,11 @@ AliHLTPHOSChannelCounter::CountChannels(AliHLTPHOSRcuCellEnergyDataStruct* chann
          [validDataPtr->fZ + channelDataPtr->fRcuZ*N_ZROWS_RCU]
          [validDataPtr->fGain]++;
     }
-  for(Int_t x = 0; x < N_XCOLUMNS_MOD; x++)
+  for(UInt_t x = 0; x < N_XCOLUMNS_MOD; x++)
     {
-       for(Int_t z = 0; z < N_ZROWS_MOD; z++)
+       for(UInt_t z = 0; z < N_ZROWS_MOD; z++)
        {
-         for(Int_t gain = 0; gain < N_ZROWS_MOD; gain++)
+         for(UInt_t gain = 0; gain < N_ZROWS_MOD; gain++)
          {
            if(tmp[x][z][gain] > 1)
              fChannelArrayPtr[x][z][gain] = fChannelArrayPtr[x][z][gain] + 1;
@@ -103,14 +103,14 @@ AliHLTPHOSChannelCounter::PrintOutOfSyncChannels(Int_t nEvents)
 {
   //comment
   printf("After %d events:\n", nEvents);
-  for(Int_t x = 0; x < N_XCOLUMNS_MOD; x++)
-  //for(Int_t x = 0; x < 63; x++)
+  for(UInt_t x = 0; x < N_XCOLUMNS_MOD; x++)
+  //for(UInt_t x = 0; x < 63; x++)
     {
-      for(Int_t z = 0; z < N_ZROWS_MOD; z++)
-      //for(Int_t z = 0; z < 55; z++)
+      for(UInt_t z = 0; z < N_ZROWS_MOD; z++)
+      //for(UInt_t z = 0; z < 55; z++)
        {
-         for(Int_t gain = 0; gain < N_GAINS; gain++)
-         //for(Int_t gain = 0; gain < 2; gain++)
+         for(UInt_t gain = 0; gain < N_GAINS; gain++)
+         //for(UInt_t gain = 0; gain < 2; gain++)
            {
              printf("x = %d -- z = %d -- gain = %d:   %d\n", x, z, gain, (fChannelArrayPtr[x][z][gain]));
            }
@@ -133,7 +133,7 @@ AliHLTPHOSChannelCounter::FillHistograms(Int_t nEvents)
          for(Int_t gain = 0; gain < 2; gain++)
            {
              
-             if(gain = 0)
+             if(gain == 0)  //TODO: this line was "if(gain = 0)" I presume that was a bug. Please check.
                {
                  fHistHighGainPtr->SetBinContent(x, z, fChannelArrayPtr[x][z][gain]);
                  fHistHighRatioPtr->SetBinContent(x, z, fChannelArrayPtr[x][z][gain]/(float)nEvents);

diff --git a/HLT/PHOS/AliHLTPHOSClusterizer.cxx b/HLT/PHOS/AliHLTPHOSClusterizer.cxx
index bc43971e57d133de08b24da380de14cd15bb424a..e961e132b7bb363cfc6579c35ce702cbd6e923bb 100644 (file)
--- a/HLT/PHOS/AliHLTPHOSClusterizer.cxx
+++ b/HLT/PHOS/AliHLTPHOSClusterizer.cxx
@@ -2,7 +2,7 @@
  * This file is property of and copyright by the ALICE HLT Project        * 
  * All rights reserved.                                                   *
  *                                                                        *
- * Primary Authors: Oystein Djuvsland                                                      *
+ * Primary Authors: Oystein Djuvsland                                     *
  *                                                                        *
  * Permission to use, copy, modify and distribute this software and its   *
  * documentation strictly for non-commercial purposes is hereby granted   *
@@ -55,7 +55,7 @@ AliHLTPHOSClusterizer::AliHLTPHOSClusterizer():
 }//end
 
 
-AliHLTPHOSClusterizer::AliHLTPHOSClusterizer(const AliHLTPHOSClusterizer &)
+AliHLTPHOSClusterizer::AliHLTPHOSClusterizer(const AliHLTPHOSClusterizer &) : AliHLTPHOSBase()
 {
   //Copy constructor, not implemented
 }//end
@@ -223,7 +223,7 @@ AliHLTPHOSClusterizer::CalculateCenterOfGravity()
   // Calculates the center of gravity in the local PHOS-module coordinates 
   Float_t wtot = 0.;
  
-  Int_t relid[4];
+  //Int_t relid[4];
 
   Float_t x = 0.;
   Float_t z = 0.;
@@ -233,10 +233,10 @@ AliHLTPHOSClusterizer::CalculateCenterOfGravity()
   AliHLTPHOSRecPointDataStruct *recPoint = 0;
   AliHLTPHOSDigitDataStruct *digit = 0;
 
-  AliPHOSGeometry * phosgeom =  AliPHOSGeometry::GetInstance() ;
+  //AliPHOSGeometry * phosgeom =  AliPHOSGeometry::GetInstance() ;
 
-  Int_t iDigit = 0;
-  Int_t iRecPoint = 0;
+  UInt_t iDigit = 0;
+  UInt_t iRecPoint = 0;
 
   for(iRecPoint=0; iRecPoint<fRecPointContainerPtr->fNRecPoints; iRecPoint++) 
     {

diff --git a/HLT/PHOS/AliHLTPHOSClusterizer.h b/HLT/PHOS/AliHLTPHOSClusterizer.h
index d91d65b17f03062d46d12559e85fe4f98782fbe5..30e4b72c71b2647246445ec3c489a77aaa525816 100644 (file)
--- a/HLT/PHOS/AliHLTPHOSClusterizer.h
+++ b/HLT/PHOS/AliHLTPHOSClusterizer.h
@@ -2,7 +2,7 @@
  * This file is property of and copyright by the ALICE HLT Project        * 
  * All rights reserved.                                                   *
  *                                                                        *
- * Primary Authors: Oystein Djuvsland                                                      *
+ * Primary Authors: Oystein Djuvsland                                     *
  *                                                                        *
  * Permission to use, copy, modify and distribute this software and its   *
  * documentation strictly for non-commercial purposes is hereby granted   *
@@ -19,12 +19,12 @@
 #include "AliHLTPHOSBase.h"
 #include "AliPHOSGetter.h"
 
-#include "AliHLTPHOSRecPointContainerStruct.h";
-#include "AliHLTPHOSRecPointDataStruct.h";
-#include "AliHLTPHOSDigitContainerDataStruct.h";
-#include "AliHLTPHOSDigitDataStruct.h";
+#include "AliHLTPHOSRecPointContainerStruct.h"
+#include "AliHLTPHOSRecPointDataStruct.h"
+#include "AliHLTPHOSDigitContainerDataStruct.h"
+#include "AliHLTPHOSDigitDataStruct.h"
 
-#include "AliPHOSGeometry.h";
+#include "AliPHOSGeometry.h"
 
 class TClonesArray;
 class AliPHOSDigit;

diff --git a/HLT/PHOS/AliHLTPHOSClusterizerComponent.cxx b/HLT/PHOS/AliHLTPHOSClusterizerComponent.cxx
index 0ba2da303d5cf79f7f46577830a8e80e74688e56..1b67a86e8f1a5e123ef34545d516d565b9cb70d4 100644 (file)
--- a/HLT/PHOS/AliHLTPHOSClusterizerComponent.cxx
+++ b/HLT/PHOS/AliHLTPHOSClusterizerComponent.cxx
@@ -178,7 +178,7 @@ AliHLTPHOSClusterizerComponent::DoEvent(const AliHLTComponentEventData& evtData,
   UInt_t mysize           = 0;
   Int_t nRecPoints        = 0;
   Int_t nDigits           = 0;
-  Int_t index             = 0;
+  //Int_t index             = 0;
   Int_t j =0;
 
   AliHLTUInt8_t* outBPtr;
@@ -199,7 +199,7 @@ AliHLTPHOSClusterizerComponent::DoEvent(const AliHLTComponentEventData& evtData,
           //     cout << "Warning: data type is not fgkAliHLTDigitDataType " << endl;
           continue;
         }
-      for (Int_t i = 0; i < digitContainerPtr->fNDigits; i++)
+      for (UInt_t i = 0; i < digitContainerPtr->fNDigits; i++)
         {
          if(fNoCrazyness && digitContainerPtr->fDigitDataStruct[i].fCrazyness)
            continue;

diff --git a/HLT/PHOS/AliHLTPHOSClusterizerComponent.h b/HLT/PHOS/AliHLTPHOSClusterizerComponent.h
index adaf729e0ec3558473c94d313dc8bf136996fb32..3ace2936ea8fce02c27a19634d0511d152df5940 100644 (file)
--- a/HLT/PHOS/AliHLTPHOSClusterizerComponent.h
+++ b/HLT/PHOS/AliHLTPHOSClusterizerComponent.h
@@ -67,6 +67,7 @@ class AliHLTPHOSClusterizerComponent: public AliHLTPHOSProcessor
 
  protected:
 
+  using AliHLTPHOSProcessor::DoEvent;
 
   int DoInit(int argc, const char** argv);
   virtual int Deinit(); ////////// PTH WARNING you should Define a class AliHLTPHOSModuleProcessor

diff --git a/HLT/PHOS/AliHLTPHOSDDLDecoderComponent.cxx b/HLT/PHOS/AliHLTPHOSDDLDecoderComponent.cxx
index 2b541c437d834d7ce7bd858dcdf458828d493c09..e21a63884961a75c413ba846fb2ad9a487ab2957 100644 (file)
--- a/HLT/PHOS/AliHLTPHOSDDLDecoderComponent.cxx
+++ b/HLT/PHOS/AliHLTPHOSDDLDecoderComponent.cxx
@@ -35,7 +35,7 @@ AliHLTPHOSDDLDecoderComponent  gAliHLTPHOSDDLDecoderComponent;
 
 
 AliHLTPHOSDDLDecoderComponent::AliHLTPHOSDDLDecoderComponent():AliHLTPHOSRcuProcessor(), 
-                                                              fOutPtr(0), fDataCorruptorPtr(0), fDecoderPtr(0), fAltroDataPtr(0), fMapperPtr(0)
+                                                              fDataCorruptorPtr(0), fOutPtr(0), fDecoderPtr(0), fAltroDataPtr(0), fMapperPtr(0)
 {
   //Default constructor
   fDataCorruptorPtr = new AliHLTPHOSDataCorruptor();
@@ -98,14 +98,14 @@ AliHLTPHOSDDLDecoderComponent::GetOutputDataSize(unsigned long& constBase, doubl
 
 int
 AliHLTPHOSDDLDecoderComponent::DoEvent( const AliHLTComponentEventData& evtData, const AliHLTComponentBlockData* blocks, 
-                                             AliHLTComponentTriggerData& trigData, AliHLTUInt8_t* outputPtr, 
+                                             AliHLTComponentTriggerData& /*trigData*/, AliHLTUInt8_t* outputPtr, 
                                              AliHLTUInt32_t& size, vector<AliHLTComponentBlockData>& outputBlocks )
 {
   //comment
   cout <<"AliHLTPHOSDDLDecoderComponent::DoEvent()" << endl;
 
-  Int_t sampleCnt         = 0;
-  Int_t processedChannels = 0;
+  //Int_t sampleCnt         = 0;
+  //Int_t processedChannels = 0;
   UInt_t offset           = 0; 
   UInt_t mysize           = 0;
   UInt_t tSize            = 0;
@@ -199,7 +199,7 @@ AliHLTPHOSDDLDecoderComponent::DoEvent( const AliHLTComponentEventData& evtData,
       fOutPtr->fNValidChannels = tmpChannelCnt-1;
       //      cout <<  "AliHLTPHOSDDLDecoderComponent::DoEven: setting  fOutPtr->fNValidChannels ="  << tmpChannelCnt-1<<endl;
 
-      int tmpSampleCnt=0;
+      //int tmpSampleCnt=0;
       AliHLTComponentBlockData bd;
       FillBlockData( bd );
       bd.fOffset = offset;

diff --git a/HLT/PHOS/AliHLTPHOSDDLDecoderComponent.h b/HLT/PHOS/AliHLTPHOSDDLDecoderComponent.h
index f2923f009adab6ff58495407c64516cc4d5a2978..ce8d84f6655901d8da72b89fea32b9cdd85876b9 100644 (file)
--- a/HLT/PHOS/AliHLTPHOSDDLDecoderComponent.h
+++ b/HLT/PHOS/AliHLTPHOSDDLDecoderComponent.h
@@ -40,6 +40,8 @@ class AliHLTPHOSDDLDecoderComponent:public AliHLTPHOSRcuProcessor
                     AliHLTComponentTriggerData& trigData, AliHLTUInt8_t* outputPtr, 
                     AliHLTUInt32_t& size, vector<AliHLTComponentBlockData>& outputBlocks ); 
 
+ protected:
+  using AliHLTPHOSRcuProcessor::DoEvent;
 
  private:
   AliHLTPHOSDataCorruptor *fDataCorruptorPtr;                  /**<Pointer to data corruptor*/

diff --git a/HLT/PHOS/AliHLTPHOSDDLPackedFileWriter.cxx b/HLT/PHOS/AliHLTPHOSDDLPackedFileWriter.cxx
index d817ac5b623fae5faba078cdcdd5143f3b0e2c40..a4832d65a3211e6ee08b209e0bc014a25761257f 100644 (file)
--- a/HLT/PHOS/AliHLTPHOSDDLPackedFileWriter.cxx
+++ b/HLT/PHOS/AliHLTPHOSDDLPackedFileWriter.cxx
@@ -32,8 +32,8 @@ AliHLTPHOSDDLPackedFileWriter::~AliHLTPHOSDDLPackedFileWriter()
 
 //_________________________________________________________________________________________________
 const int 
-AliHLTPHOSDDLPackedFileWriter::WriteFile(const AliHLTComponentEventData& evtData, 
-                       const AliHLTComponentBlockData* blocks, AliHLTComponentTriggerData& trigData, int evntCnt) const
+AliHLTPHOSDDLPackedFileWriter::WriteFile(const AliHLTComponentEventData& /*evtData*/, 
+                       const AliHLTComponentBlockData* /*blocks*/, AliHLTComponentTriggerData& /*trigData*/, int /*evntCnt*/) const
 {
   return 0;
 }

diff --git a/HLT/PHOS/AliHLTPHOSDataCorruptor.cxx b/HLT/PHOS/AliHLTPHOSDataCorruptor.cxx
index 2ee19873eccb1bd45cabbc42444096e8faf35071..b54894e919d19e13def05073fc6e94daff37e0d4 100644 (file)
--- a/HLT/PHOS/AliHLTPHOSDataCorruptor.cxx
+++ b/HLT/PHOS/AliHLTPHOSDataCorruptor.cxx
@@ -51,7 +51,7 @@ AliHLTPHOSDataCorruptor::~AliHLTPHOSDataCorruptor()
  * @param N  the number of samples in the array
  */
 void
-AliHLTPHOSDataCorruptor::MakeCorruptedData(Double_t *dataArray, int N)
+AliHLTPHOSDataCorruptor::MakeCorruptedData(Double_t * /*dataArray*/, int /*N*/)
 {
   
 

diff --git a/HLT/PHOS/AliHLTPHOSDigitMaker.cxx b/HLT/PHOS/AliHLTPHOSDigitMaker.cxx
index 56943a593ec53e19d4b2a7538a079d520ec277df..2c44fc96af94d1cb677efe2d043d5325f05ad6fd 100644 (file)
--- a/HLT/PHOS/AliHLTPHOSDigitMaker.cxx
+++ b/HLT/PHOS/AliHLTPHOSDigitMaker.cxx
@@ -27,8 +27,8 @@ AliHLTPHOSDigitMaker::AliHLTPHOSDigitMaker() :
   fDigitPtr(0),
   // fDigitStructPtr(0),
   fDigitCount(0), 
-  fDigitThreshold(0),
-  fNrPresamples(10)
+  fNrPresamples(10),
+  fDigitThreshold(0)
 {
  
 }

diff --git a/HLT/PHOS/AliHLTPHOSDigitMakerComponent.cxx b/HLT/PHOS/AliHLTPHOSDigitMakerComponent.cxx
index db719fa621560cc039b821047c7b77c877b77a1b..e31eb5991795ca1e8699b5ee162d940615d8e17f 100644 (file)
--- a/HLT/PHOS/AliHLTPHOSDigitMakerComponent.cxx
+++ b/HLT/PHOS/AliHLTPHOSDigitMakerComponent.cxx
@@ -98,12 +98,12 @@ AliHLTPHOSDigitMakerComponent::DoEvent(const AliHLTComponentEventData& evtData,
   UInt_t tSize            = 0;
   UInt_t offset           = 0; 
   UInt_t mysize           = 0;
-  Int_t nRecPoints        = 0;
-  Int_t index             = 0;
+  //Int_t nRecPoints        = 0;
+  //Int_t index             = 0;
   
-  Int_t fileCount = 0;
+  //Int_t fileCount = 0;
   Int_t digitCount = 0;
-  char filename [50];
+  //char filename [50];
 
 
   AliHLTUInt8_t* outBPtr;

diff --git a/HLT/PHOS/AliHLTPHOSDigitMakerComponent.h b/HLT/PHOS/AliHLTPHOSDigitMakerComponent.h
index 69692ee9f8162df423a40ae5b8634fc6686667f4..7143e5b93013f40f9dd3ff5c21937942ae0ca698 100644 (file)
--- a/HLT/PHOS/AliHLTPHOSDigitMakerComponent.h
+++ b/HLT/PHOS/AliHLTPHOSDigitMakerComponent.h
@@ -49,6 +49,7 @@ public:
   AliHLTComponent* Spawn();
   
 protected:
+  using AliHLTPHOSProcessor::DoEvent;
   int DoInit(int argc, const char** argv);
   virtual int Deinit(); ////////// PTH WARNING you should Define a class AliHLTPHOSModuleProcessor
   

diff --git a/HLT/PHOS/AliHLTPHOSEmcCalibData.cxx b/HLT/PHOS/AliHLTPHOSEmcCalibData.cxx
index b4d393393fc33988f8adfbe216ebc7fc210eff41..b2d01f6434880ccd8def6f0e806636cc33d1ca20 100644 (file)
--- a/HLT/PHOS/AliHLTPHOSEmcCalibData.cxx
+++ b/HLT/PHOS/AliHLTPHOSEmcCalibData.cxx
@@ -59,10 +59,10 @@ AliHLTPHOSEmcCalibData::AliHLTPHOSEmcCalibData(const AliHLTPHOSEmcCalibData& cal
 
 
   //  for(Int_t gain = 0; gain < N_GAINS; gain ++){
-  for(Int_t module=0; module<N_MODULES; module++) {
-    for(Int_t column=0; column< N_XCOLUMNS_MOD; column++) {
-      for(Int_t row=0; row<N_ZROWS_MOD; row++) {
-       for(Int_t gain = 0; gain < N_GAINS; gain ++){
+  for(UInt_t module=0; module<N_MODULES; module++) {
+    for(UInt_t column=0; column< N_XCOLUMNS_MOD; column++) {
+      for(UInt_t row=0; row<N_ZROWS_MOD; row++) {
+       for(UInt_t gain = 0; gain < N_GAINS; gain ++){
          fADCchannelEnergy[module][column][row][gain] =  calibda.fADCchannelEnergy[module][column][row][gain];
          fADCpedestalEmcMeasured[module][column][row][gain] = calibda.fADCpedestalEmcMeasured[module][column][row][gain];
        }
@@ -81,10 +81,10 @@ AliHLTPHOSEmcCalibData &AliHLTPHOSEmcCalibData::operator =(const AliHLTPHOSEmcCa
     SetName(calibda.GetName());
     SetTitle(calibda.GetName());
     //    for(Int_t gain = 0; gain < N_GAINS; gain ++){
-    for(Int_t module=0; module<N_MODULES; module++) {
-      for(Int_t column=0; column< N_XCOLUMNS_MOD; column++) {
-       for(Int_t row=0; row<N_ZROWS_MOD; row++) {
-         for(Int_t gain = 0; gain < N_GAINS; gain ++){
+    for(UInt_t module=0; module<N_MODULES; module++) {
+      for(UInt_t column=0; column< N_XCOLUMNS_MOD; column++) {
+       for(UInt_t row=0; row<N_ZROWS_MOD; row++) {
+         for(UInt_t gain = 0; gain < N_GAINS; gain ++){
            fADCchannelEnergy[module][column][row][gain] = calibda.fADCchannelEnergy[module][column][row][gain];
            fADCpedestalEmcMeasured[module][column][row][gain] = calibda.fADCpedestalEmcMeasured[module][column][row][gain];
          }
@@ -107,10 +107,10 @@ void AliHLTPHOSEmcCalibData::Reset()
   // Set all pedestals and all ADC channels to its ideal values = 1.
 
   //  for(Int_t gain = 0; gain < PHOS_GAINS; gain ++){
-    for (Int_t module=0; module<N_MODULES; module++){
-      for (Int_t column=0; column< N_XCOLUMNS_MOD; column++){
-       for (Int_t row=0; row<N_ZROWS_MOD; row++){
-         for(Int_t gain = 0; gain < N_GAINS; gain ++){
+    for (UInt_t module=0; module<N_MODULES; module++){
+      for (UInt_t column=0; column< N_XCOLUMNS_MOD; column++){
+       for (UInt_t row=0; row<N_ZROWS_MOD; row++){
+         for(UInt_t gain = 0; gain < N_GAINS; gain ++){
          fADCpedestalEmcMeasured[module][column][row][gain] = 0.;
          fADCchannelEnergy[module][column][row][gain]  = 1.;
        }
@@ -127,11 +127,11 @@ void  AliHLTPHOSEmcCalibData::Print(Option_t *option) const
   if (strstr(option,"ped")) {
     printf("\n ----    EMC Pedestal values     ----\n\n");
     //    for(Int_t gain = 0; gain < N_GAINS; gain ++){
-      for (Int_t module=0; module<N_MODULES; module++){
+      for (UInt_t module=0; module<N_MODULES; module++){
        printf("============== Module %d\n",module+1);
-       for (Int_t column=0; column< N_XCOLUMNS_MOD; column++){
-         for (Int_t row=0; row<N_ZROWS_MOD; row++){
-           for(Int_t gain = 0; gain < N_GAINS; gain ++){
+       for (UInt_t column=0; column< N_XCOLUMNS_MOD; column++){
+         for (UInt_t row=0; row<N_ZROWS_MOD; row++){
+           for(UInt_t gain = 0; gain < N_GAINS; gain ++){
            printf("%4.1f",fADCpedestalEmcMeasured[module][column][row][gain]);
          }
          printf("\n");
@@ -143,11 +143,11 @@ void  AliHLTPHOSEmcCalibData::Print(Option_t *option) const
   if (strstr(option,"gain")) {
     printf("\n ----    EMC ADC channel values  ----\n\n");
     //   for(Int_t gain = 0; gain < N_GAINS; gain ++){ 
-    for (Int_t module=0; module<N_MODULES; module++){
+    for (UInt_t module=0; module<N_MODULES; module++){
       printf("============== Module %d\n",module+1);
-      for (Int_t column=0; column< N_XCOLUMNS_MOD; column++){
-       for (Int_t row=0; row<N_ZROWS_MOD; row++){
-         for(Int_t gain = 0; gain < N_GAINS; gain ++){ 
+      for (UInt_t column=0; column< N_XCOLUMNS_MOD; column++){
+       for (UInt_t row=0; row<N_ZROWS_MOD; row++){
+         for(UInt_t gain = 0; gain < N_GAINS; gain ++){ 
            printf("%4.1f",fADCchannelEnergy[module][column][row][gain]);
          }
          printf("\n");
@@ -161,11 +161,11 @@ void  AliHLTPHOSEmcCalibData::Print(Option_t *option) const
 void  
 AliHLTPHOSEmcCalibData::MakeADCpedestalCorrectionTable()
 {
-  for (Int_t module=0; module<N_MODULES; module++){
+  for (UInt_t module=0; module<N_MODULES; module++){
     printf("============== Module %d\n",module+1);
-    for (Int_t column=0; column< N_XCOLUMNS_MOD; column++){
-      for (Int_t row=0; row<N_ZROWS_MOD; row++){
-       for(Int_t gain = 0; gain < N_GAINS; gain ++){ 
+    for (UInt_t column=0; column< N_XCOLUMNS_MOD; column++){
+      for (UInt_t row=0; row<N_ZROWS_MOD; row++){
+       for(UInt_t gain = 0; gain < N_GAINS; gain ++){ 
          fADCpedestalCorrectionTable[module][column][row][gain] = fADCpedestalEmcMeasured[module][column][row][gain] - fADCpedestalAltroReg[module][column][row][gain];
          //      printf("%4.1f",fADCchannelEnergy[module][column][row][gain]);
          //

diff --git a/HLT/PHOS/AliHLTPHOSFileWriter.cxx b/HLT/PHOS/AliHLTPHOSFileWriter.cxx
index 91c798cec897e628acbada055650ff2539dea5e6..51b84550a69a54e34179f3d68774605f5c5757ab 100644 (file)
--- a/HLT/PHOS/AliHLTPHOSFileWriter.cxx
+++ b/HLT/PHOS/AliHLTPHOSFileWriter.cxx
@@ -20,7 +20,7 @@ AliHLTPHOSFileWriter::~AliHLTPHOSFileWriter()
 
 //_________________________________________________________________________________________________
 void
-AliHLTPHOSFileWriter::SetDirectory(string& directory)
+AliHLTPHOSFileWriter::SetDirectory(string& /*directory*/)
 {
 
 }

diff --git a/HLT/PHOS/AliHLTPHOSFileWriterComponent.cxx b/HLT/PHOS/AliHLTPHOSFileWriterComponent.cxx
index cb17705e10e36c7428233931b149ff82eb5dcf78..208b4b8566dc106e34497cceb1780cb737f75abd 100644 (file)
--- a/HLT/PHOS/AliHLTPHOSFileWriterComponent.cxx
+++ b/HLT/PHOS/AliHLTPHOSFileWriterComponent.cxx
@@ -41,7 +41,7 @@ AliHLTPHOSFileWriterComponent::AliHLTPHOSFileWriterComponent():  AliHLTFileWrite
   /* 
    *Default constructor
    */
-  for(int i=0; i<N_DATATYPES; i++)
+  for(unsigned int i=0; i<N_DATATYPES; i++)
     {
       fDataTypesToFile[i] = kAliHLTVoidDataType;
     }
@@ -75,7 +75,7 @@ AliHLTPHOSFileWriterComponent::AddDataType(string dataType)
   //comment
   int ret = -1;
   int tmpCnt = 0;
-  for(int i=0; i< N_DATATYPES; i++)
+  for(unsigned int i=0; i< N_DATATYPES; i++)
     {
       if( fDataTypesToFile[i] != kAliHLTVoidDataType)
        {
@@ -171,7 +171,7 @@ AliHLTPHOSFileWriterComponent::IsRegisteredDataType(const AliHLTComponentDataTyp
 {
   // see header file for documentation
   Bool_t tmp = kFALSE;
-  for(int i =0; i<N_DATATYPES; i++)
+  for(unsigned int i =0; i<N_DATATYPES; i++)
     {
       if((fDataTypesToFile[i] == dataType) && (dataType !=  kAliHLTVoidDataType))
        {

diff --git a/HLT/PHOS/AliHLTPHOSMIPCounter.cxx b/HLT/PHOS/AliHLTPHOSMIPCounter.cxx
index 6382c593130a5662052c1362ca9e5dfa349d560a..be243c0aff06cfd6e6da6c4443d7e46e657b4071 100644 (file)
--- a/HLT/PHOS/AliHLTPHOSMIPCounter.cxx
+++ b/HLT/PHOS/AliHLTPHOSMIPCounter.cxx
@@ -44,7 +44,7 @@ AliHLTPHOSMIPCounter::CountMIPs(AliHLTPHOSDigitContainerDataStruct* digitContain
   Bool_t IsMIP = true;
   Int_t *dataPtr = 0;
   AliHLTPHOSDigitDataStruct *digitPtr;
-  for(Int_t i = 0; i < digitContainerPtr->fNDigits; i++)
+  for(UInt_t i = 0; i < digitContainerPtr->fNDigits; i++)
   {
     digitPtr = &(digitContainerPtr->fDigitDataStruct[i]);
     dataPtr = digitPtr->fData;

diff --git a/HLT/PHOS/AliHLTPHOSMIPCounterComponent.cxx b/HLT/PHOS/AliHLTPHOSMIPCounterComponent.cxx
index 308594852781a3218ec01e295ec46d6d8c0f0765..e5e5eda6e67f07e55d7c053ae5c20454ca99f7bd 100644 (file)
--- a/HLT/PHOS/AliHLTPHOSMIPCounterComponent.cxx
+++ b/HLT/PHOS/AliHLTPHOSMIPCounterComponent.cxx
@@ -102,8 +102,8 @@ void
 
 int 
 AliHLTPHOSMIPCounterComponent::DoEvent(const AliHLTComponentEventData& evtData, const AliHLTComponentBlockData* blocks,
-                                       AliHLTComponentTriggerData& /*trigData*/, AliHLTUInt8_t* outputPtr, AliHLTUInt32_t& size,
-                                       vector<AliHLTComponentBlockData>& outputBlocks)
+                                       AliHLTComponentTriggerData& /*trigData*/, AliHLTUInt8_t* /*outputPtr*/, AliHLTUInt32_t& /*size*/, //TODO: I think size should be set to zero when returning from this method if not data was written to the output buffer.
+                                       vector<AliHLTComponentBlockData>& /*outputBlocks*/)
 {
    //Do event
   int digitCount = 0;
@@ -131,7 +131,7 @@ AliHLTPHOSMIPCounterComponent::DoEvent(const AliHLTComponentEventData& evtData,
   if(fEvtCnt % fInterval == 0)
   {
     printf("Event #: %d -- Number of MIPs the last %d events: %d -- Which gives a rate of: %f\n",
-          fInterval, fMIPCountInterval, (Float_t)fMIPCountInterval/(Float_t)fInterval);   
+          fEvtCnt, fInterval, Int_t(fMIPCountInterval), ((Float_t)fMIPCountInterval/(Float_t)fInterval));   //TODO: check that the proper things are being written to screen.
     fIntervalHistPtr->Fill(fMIPCountInterval);
     fRateHistPtr->Fill((Float_t)fMIPCountInterval/(Float_t)fInterval);
     fMIPCountInterval = 0;

diff --git a/HLT/PHOS/AliHLTPHOSMIPCounterComponent.h b/HLT/PHOS/AliHLTPHOSMIPCounterComponent.h
index 90132e779399da475b03e9211d4d5fc72eb9f7ce..d01f508dc8bb62c03f8920d18f6c7d4b2a773b15 100644 (file)
--- a/HLT/PHOS/AliHLTPHOSMIPCounterComponent.h
+++ b/HLT/PHOS/AliHLTPHOSMIPCounterComponent.h
@@ -48,7 +48,8 @@ public:
 
     AliHLTComponent* Spawn();
   
-  protected:
+protected:
+    using AliHLTPHOSProcessor::DoEvent;
     int DoInit(int argc, const char** argv);
     virtual int Deinit(); ////////// PTH WARNING you should Define a class AliHLTPHOSModuleProcessor
 

diff --git a/HLT/PHOS/AliHLTPHOSPhysicsAnalyzer.cxx b/HLT/PHOS/AliHLTPHOSPhysicsAnalyzer.cxx
index 07f5b31c050a6ea3d405f93394f780bfcd625276..3465e7ac721d6a8b52e67622f94d64fbe8f7c54e 100644 (file)
--- a/HLT/PHOS/AliHLTPHOSPhysicsAnalyzer.cxx
+++ b/HLT/PHOS/AliHLTPHOSPhysicsAnalyzer.cxx
@@ -37,7 +37,7 @@ AliHLTPHOSPhysicsAnalyzer::AliHLTPHOSPhysicsAnalyzer():fClustersPtr(0), fRootHis
 
   fPHOSRadius = geom->GetIPtoCrystalSurface();
   
-  for(Int_t i = 0; i < N_MODULES; i++)
+  for(UInt_t i = 0; i < N_MODULES; i++)
     {
       fRotParametersCos[i] = cos((geom->GetPHOSAngle(i+1))*2*TMath::Pi()/360);
 
@@ -54,7 +54,7 @@ AliHLTPHOSPhysicsAnalyzer::AliHLTPHOSPhysicsAnalyzer(const AliHLTPHOSPhysicsAnal
 
   fPHOSRadius = geom->GetIPtoCrystalSurface();
   
-  for(Int_t i = 0; i < N_MODULES; i++)
+  for(UInt_t i = 0; i < N_MODULES; i++)
     {
       fRotParametersCos[i] = cos((geom->GetPHOSAngle(i+1))*2*TMath::Pi()/360);
       

diff --git a/HLT/PHOS/AliHLTPHOSPhysicsAnalyzerSpectrumComponent.h b/HLT/PHOS/AliHLTPHOSPhysicsAnalyzerSpectrumComponent.h
index 92cff20ad01fd93c8df85a26892fcf60c8fe3baa..900d580324d085e953f290120c6bd3b6275bcdf2 100644 (file)
--- a/HLT/PHOS/AliHLTPHOSPhysicsAnalyzerSpectrumComponent.h
+++ b/HLT/PHOS/AliHLTPHOSPhysicsAnalyzerSpectrumComponent.h
@@ -53,6 +53,7 @@ class AliHLTPHOSPhysicsAnalyzerSpectrumComponent: public AliHLTPHOSProcessor //
   Int_t DoInit(int argc, const char** argv);
   Int_t Deinit();
   Int_t DoDeinit();
+  using AliHLTPHOSProcessor::DoEvent;
   
  private:
   

diff --git a/HLT/PHOS/AliHLTPHOSPulseGenerator.cxx b/HLT/PHOS/AliHLTPHOSPulseGenerator.cxx
index 549099f384921a403faecc05be57448535a858df..bc6ce8d61d6e153f6b293ee091792bebe35df38b 100644 (file)
--- a/HLT/PHOS/AliHLTPHOSPulseGenerator.cxx
+++ b/HLT/PHOS/AliHLTPHOSPulseGenerator.cxx
@@ -98,7 +98,7 @@ AliHLTPHOSPulseGenerator::AddPretriggerSamples(double baselineLevel, double *sam
 
 
 double *
-AliHLTPHOSPulseGenerator::GetPulse(double a, double t0)
+AliHLTPHOSPulseGenerator::GetPulse(double /*a*/, double /*t0*/)
 {
   //See header file for documentation
   return fDataPtr;

diff --git a/HLT/PHOS/AliHLTPHOSRawAnalyzer.cxx b/HLT/PHOS/AliHLTPHOSRawAnalyzer.cxx
index cff9cafebfb9596387832307e9a0011311542b01..e65b9e0461ced5ffaa35eb7acbd0d1f65226ceb6 100644 (file)
--- a/HLT/PHOS/AliHLTPHOSRawAnalyzer.cxx
+++ b/HLT/PHOS/AliHLTPHOSRawAnalyzer.cxx
@@ -36,7 +36,7 @@ AliHLTPHOSRawAnalyzer::~AliHLTPHOSRawAnalyzer()
 * @param dtaPtr Data array for wich a subarray will be taken to perform the fit
 * @param fs the sampling frequency in entities of MHz. Needed in order to calculate physical time
 **/
-AliHLTPHOSRawAnalyzer::AliHLTPHOSRawAnalyzer(double *dtaPtr, double fs): AliHLTPHOSBase(), fIntDataPtr(0), fSampleFrequency(10), fTau(2), fDTof(99999), fDAmpl(99999), fStartIndex(0)
+AliHLTPHOSRawAnalyzer::AliHLTPHOSRawAnalyzer(double * /*dtaPtr*/, double fs): AliHLTPHOSBase(), fIntDataPtr(0), fSampleFrequency(10), fTau(2), fDTof(99999), fDAmpl(99999), fStartIndex(0)
 {
   fSampleFrequency = fs;
 } //end  
@@ -51,7 +51,7 @@ AliHLTPHOSRawAnalyzer::AliHLTPHOSRawAnalyzer(double *dtaPtr, double fs): AliHLTP
 * @param N the number of pretrigger samples used to calculate the baseline.
 **/
 void 
-AliHLTPHOSRawAnalyzer::BaselineCorrection(double *dataPtr, int N)
+AliHLTPHOSRawAnalyzer::BaselineCorrection(double * /*dataPtr*/, int /*N*/)
 {
   cout << "Baseline correction not yet implemeted" << endl;
 } //end BaselineCorrection
@@ -64,7 +64,7 @@ AliHLTPHOSRawAnalyzer::BaselineCorrection(double *dataPtr, int N)
 * @param baselineValue the basline value to subtract..
 **/
 void 
-AliHLTPHOSRawAnalyzer::BaselineCorrection(double *dataPtr, double baselineValue)
+AliHLTPHOSRawAnalyzer::BaselineCorrection(double * /*dataPtr*/, double baselineValue)
 {
   printf("\nbaselineValue = %f\n", baselineValue);
   cout << "Baseline correction not yet implemeted" << endl;
@@ -120,7 +120,7 @@ AliHLTPHOSRawAnalyzer::SetSampleFreq(double freq)
 }
 
 int 
-AliHLTPHOSRawAnalyzer::FindStartIndex(double treshold)
+AliHLTPHOSRawAnalyzer::FindStartIndex(double /*treshold*/)
 {
   cout << "Find Start index not yet implemented" << endl;
   return 0;
@@ -144,7 +144,7 @@ AliHLTPHOSRawAnalyzer::MakeInitialGuess()
  * @param treshold The index of the first value above treshold is ntaken to be the first value.
  **/
 void 
-AliHLTPHOSRawAnalyzer::MakeInitialGuess(int treshold)
+AliHLTPHOSRawAnalyzer::MakeInitialGuess(int /*treshold*/)
 {
   cout << "Make initial guess not yet implemeted" << endl;  
 }
@@ -159,7 +159,7 @@ AliHLTPHOSRawAnalyzer::SetStartIndex(int index)
 
 
 void 
-AliHLTPHOSRawAnalyzer::SetTVector(Double_t *tVector, Int_t size)
+AliHLTPHOSRawAnalyzer::SetTVector(Double_t * /*tVector*/, Int_t /*size*/)
 {
   cout <<"ERROR: AliHLTPHOSRawAnalyzer::SetTVector:  You cannot set the peakfindervector here, must be set in derived class peakfinder"<<endl;
 }
@@ -167,7 +167,7 @@ AliHLTPHOSRawAnalyzer::SetTVector(Double_t *tVector, Int_t size)
 
 
 void
-AliHLTPHOSRawAnalyzer::SetAVector(Double_t *aVector, Int_t size)
+AliHLTPHOSRawAnalyzer::SetAVector(Double_t * /*aVector*/, Int_t /*size*/)
 {
  cout <<"ERROR: AliHLTPHOSRawAnalyzer::SetAVector:  You cannot set the peakfindervector here, must be set in derived class peakfinder"<<endl;
 }

diff --git a/HLT/PHOS/AliHLTPHOSRawAnalyzerChiSquareFit.cxx b/HLT/PHOS/AliHLTPHOSRawAnalyzerChiSquareFit.cxx
index 25f6d13363394153039d3e7f97318c7ef0ce900d..92f98241a98c7cde72c2327f17638e93f8062dae 100644 (file)
--- a/HLT/PHOS/AliHLTPHOSRawAnalyzerChiSquareFit.cxx
+++ b/HLT/PHOS/AliHLTPHOSRawAnalyzerChiSquareFit.cxx
@@ -57,7 +57,7 @@ AliHLTPHOSRawAnalyzerChiSquareFit::~AliHLTPHOSRawAnalyzerChiSquareFit()
 * @param length the number of samples to use starting from index 
 **/
 void 
-AliHLTPHOSRawAnalyzerChiSquareFit::Evaluate(int start, int length)
+AliHLTPHOSRawAnalyzerChiSquareFit::Evaluate(int /*start*/, int /*length*/)
 {
   /*
 

diff --git a/HLT/PHOS/AliHLTPHOSRawAnalyzerComponent.cxx b/HLT/PHOS/AliHLTPHOSRawAnalyzerComponent.cxx
index 19b4011945097dc151f0d94c3cd484d0fb93d3eb..901c10a7e066251ca3781a86ad9d37075b93aaaa 100644 (file)
--- a/HLT/PHOS/AliHLTPHOSRawAnalyzerComponent.cxx
+++ b/HLT/PHOS/AliHLTPHOSRawAnalyzerComponent.cxx
@@ -99,7 +99,7 @@ AliHLTPHOSRawAnalyzerComponent::GetOutputDataSize(unsigned long& constBase, doub
 //AliHLTPHOSRawAnalyzerComponent::DoEvent( const AliHLTComponentEventD  //  AliHLTPHOSRcuCellEnergyDebugDataStruct* fOutPtr;ata& evtData, const AliHLTComponentBlockData* blocks, AliHLTComponentTriggerData& trigData, 
 //                                      AliHLTUInt8_t* outputPtr, AliHLTUInt32_t& size, vector<AliHLTComponentBlockData>& outputBlocks )
 int 
-AliHLTPHOSRawAnalyzerComponent::DoEvent( const AliHLTComponentEventData& evtData, const AliHLTComponentBlockData* blocks, AliHLTComponentTriggerData& trigData, 
+AliHLTPHOSRawAnalyzerComponent::DoEvent( const AliHLTComponentEventData& evtData, const AliHLTComponentBlockData* blocks, AliHLTComponentTriggerData& /*trigData*/, 
                                         AliHLTUInt8_t* outputPtr, AliHLTUInt32_t& size, vector<AliHLTComponentBlockData>& outputBlocks )
 {
   //comment
@@ -108,7 +108,7 @@ AliHLTPHOSRawAnalyzerComponent::DoEvent( const AliHLTComponentEventData& evtData
   UInt_t tSize            = 0;
   Float_t baseline = 0;
   AliHLTUInt8_t* outBPtr;
-  AliHLTAltroBunch *bunchPtr;
+  //AliHLTAltroBunch *bunchPtr;
   outBPtr = outputPtr;
   const AliHLTComponentBlockData* iter = NULL; 
   unsigned long ndx;
@@ -130,7 +130,7 @@ AliHLTPHOSRawAnalyzerComponent::DoEvent( const AliHLTComponentEventData& evtData
       mysize = 0;
       offset = tSize;
       //      cout <<"TP1"<< endl;
-      Int_t *dt = (Int_t*)(reinterpret_cast<UChar_t*>( iter->fPtr ));
+      //Int_t *dt = (Int_t*)(reinterpret_cast<UChar_t*>( iter->fPtr ));
       //      cout <<"TP2"<< endl;
       Int_t crazyness = 0;
 
@@ -308,13 +308,13 @@ void
 AliHLTPHOSRawAnalyzerComponent::Reset()
 {
   //comment
-  for(int mod = 0; mod < N_MODULES; mod ++)
+  for(unsigned int mod = 0; mod < N_MODULES; mod ++)
     {
-      for(int row = 0; row < N_ZROWS_MOD; row ++)
+      for(unsigned int row = 0; row < N_ZROWS_MOD; row ++)
        {
-         for(int col = 0; col < N_XCOLUMNS_MOD; col ++)
+         for(unsigned int col = 0; col < N_XCOLUMNS_MOD; col ++)
            {
-             for(int gain = 0; gain < N_GAINS; gain ++ )
+             for(unsigned int gain = 0; gain < N_GAINS; gain ++ )
                {
                  fMaxValues[mod][row][col][gain] = 0;
                }
@@ -351,9 +351,9 @@ AliHLTPHOSRawAnalyzerComponent::SetBaselines(const char* file)
   for(Int_t i = 0; i < baselineArray->GetEntriesFast(); i++)
     {
       baseline = (AliHLTPHOSBaseline*)baselineArray->At(i);
-      if((baseline->GetX() < ((fRcuX + 1)*N_XCOLUMNS_RCU)) && (baseline->GetX() >= fRcuX*N_XCOLUMNS_RCU))
+      if((baseline->GetX() < (Int_t)((fRcuX + 1)*N_XCOLUMNS_RCU)) && (baseline->GetX() >= (Int_t)(fRcuX*N_XCOLUMNS_RCU)))
        {
-         if((baseline->GetZ() < ((fRcuZ + 1)*N_ZROWS_RCU)) && (baseline->GetZ() >= fRcuZ*N_ZROWS_RCU))
+         if((baseline->GetZ() < (Int_t)((fRcuZ + 1)*N_ZROWS_RCU)) && (baseline->GetZ() >= (Int_t)(fRcuZ*N_ZROWS_RCU)))
            {
              fBaselines[baseline->GetX() - fRcuX*N_XCOLUMNS_RCU][baseline->GetZ() - fRcuZ*N_ZROWS_RCU][baseline->GetGain()] = baseline->GetBaseline();
              //              cout <<  fBaselines[baseline->GetX() - fRcuX*N_XCOLUMNS_RCU][baseline->GetZ() - fRcuZ*N_ZROWS_RCU][baseline->GetGain()] << endl;

diff --git a/HLT/PHOS/AliHLTPHOSRawAnalyzerComponent.h b/HLT/PHOS/AliHLTPHOSRawAnalyzerComponent.h
index 55bb6561add2347ad6943cef430e9a13a8afa11b..f6831950df3dcad54fc6e821c382e974e81f2e12 100644 (file)
--- a/HLT/PHOS/AliHLTPHOSRawAnalyzerComponent.h
+++ b/HLT/PHOS/AliHLTPHOSRawAnalyzerComponent.h
@@ -33,6 +33,8 @@ class AliHLTPHOSRawAnalyzerComponent: public AliHLTPHOSRcuProcessor
   virtual int DoEvent( const AliHLTComponentEventData& evtData, const AliHLTComponentBlockData* blocks, 
                     AliHLTComponentTriggerData& trigData, AliHLTUInt8_t* outputPtr, 
                     AliHLTUInt32_t& size, vector<AliHLTComponentBlockData>& outputBlocks ); 
+  using AliHLTPHOSRcuProcessor::DoEvent;
+
   void Reset();
   void ResetDataPtr(int startindex = 0, int sampleCnt = 0);
   void SetBaselines(const char* baselineFile);

diff --git a/HLT/PHOS/AliHLTPHOSRawAnalyzerKLevel.cxx b/HLT/PHOS/AliHLTPHOSRawAnalyzerKLevel.cxx
index 9ec1b03b8bc441e0bd870f75f8b58a43b3c94cc4..f6ad3a91289488e3d6e7f46118914169fb39f3b0 100644 (file)
--- a/HLT/PHOS/AliHLTPHOSRawAnalyzerKLevel.cxx
+++ b/HLT/PHOS/AliHLTPHOSRawAnalyzerKLevel.cxx
@@ -63,7 +63,7 @@ AliHLTPHOSRawAnalyzerKLevel::~AliHLTPHOSRawAnalyzerKLevel()
 **/
 //________________________________________________________________________________________________________
 void 
-AliHLTPHOSRawAnalyzerKLevel::Evaluate(int start, int length)
+AliHLTPHOSRawAnalyzerKLevel::Evaluate(int /*start*/, int /*length*/)
 {
   //thats all 
 } //end FitKLevel

diff --git a/HLT/PHOS/AliHLTPHOSRawAnalyzerLMS.cxx b/HLT/PHOS/AliHLTPHOSRawAnalyzerLMS.cxx
index e05b8c3fdb5639a34a88b1b4c11091a2ae95adde..736e881fe231544415ac42415e7547dba3c03509 100644 (file)
--- a/HLT/PHOS/AliHLTPHOSRawAnalyzerLMS.cxx
+++ b/HLT/PHOS/AliHLTPHOSRawAnalyzerLMS.cxx
@@ -42,7 +42,7 @@ AliHLTPHOSRawAnalyzerLMS::AliHLTPHOSRawAnalyzerLMS():AliHLTPHOSRawAnalyzer()
 * @param fs the sampling frequency in entities of MHz. Needed in order to calculate physical time
 **/
 //_____________________________________________________________________________________________________
-AliHLTPHOSRawAnalyzerLMS::AliHLTPHOSRawAnalyzerLMS(double *dtaPtr, double fs):AliHLTPHOSRawAnalyzer() 
+AliHLTPHOSRawAnalyzerLMS::AliHLTPHOSRawAnalyzerLMS(double * /*dtaPtr*/, double fs):AliHLTPHOSRawAnalyzer() 
 {
   //  fFloatDataPtr = dtaPtr;  
 
@@ -59,7 +59,7 @@ AliHLTPHOSRawAnalyzerLMS::~AliHLTPHOSRawAnalyzerLMS()
 
 //_____________________________________________________________________________________________________
 void 
-AliHLTPHOSRawAnalyzerLMS::Evaluate(int start, int length)
+AliHLTPHOSRawAnalyzerLMS::Evaluate(int /*start*/, int /*length*/)
 {
 
 } //end FitLMS

diff --git a/HLT/PHOS/AliHLTPHOSRawAnalyzerPeakFinder.cxx b/HLT/PHOS/AliHLTPHOSRawAnalyzerPeakFinder.cxx
index 9c103daef098e9f3737bcb3bc98b06753c31d18b..f5936f29be9a7e4d3a3e2b89fa8f2552b2975f80 100644 (file)
--- a/HLT/PHOS/AliHLTPHOSRawAnalyzerPeakFinder.cxx
+++ b/HLT/PHOS/AliHLTPHOSRawAnalyzerPeakFinder.cxx
@@ -97,7 +97,7 @@ AliHLTPHOSRawAnalyzerPeakFinder::SetAVector(Double_t *aVec, Int_t size)
 
 //___________________________________________________________________
 void 
-AliHLTPHOSRawAnalyzerPeakFinder::Evaluate(Int_t start, Int_t length)
+AliHLTPHOSRawAnalyzerPeakFinder::Evaluate(Int_t /*start*/, Int_t length)
 {
   fDTof = 0;
   fDAmpl = 0;

diff --git a/HLT/PHOS/AliHLTPHOSRcuDigitMaker.cxx b/HLT/PHOS/AliHLTPHOSRcuDigitMaker.cxx
index c18626426dceb507dbc0721e69f1c26113108abf..53838bad3cea20f0c55df08b90add3ee6a2921cb 100644 (file)
--- a/HLT/PHOS/AliHLTPHOSRcuDigitMaker.cxx
+++ b/HLT/PHOS/AliHLTPHOSRcuDigitMaker.cxx
@@ -27,8 +27,8 @@ AliHLTPHOSRcuDigitMaker::AliHLTPHOSRcuDigitMaker() :
   fDigitPtr(0),
   // fDigitStructPtr(0),
   fDigitCount(0), 
-  fDigitThreshold(0),
-  fNrPresamples(10)
+  fNrPresamples(10),
+  fDigitThreshold(0)
 {
   //comment
 }

diff --git a/HLT/PHOS/AliHLTPHOSRcuDigitMakerComponent.cxx b/HLT/PHOS/AliHLTPHOSRcuDigitMakerComponent.cxx
index a1ad24833be23eb320202ced27b66661587c0ace..84f99e2b4eccbf81a7c9fc65d96266979469221b 100644 (file)
--- a/HLT/PHOS/AliHLTPHOSRcuDigitMakerComponent.cxx
+++ b/HLT/PHOS/AliHLTPHOSRcuDigitMakerComponent.cxx
@@ -98,12 +98,12 @@ AliHLTPHOSRcuDigitMakerComponent::DoEvent(const AliHLTComponentEventData& evtDat
   UInt_t tSize            = 0;
   UInt_t offset           = 0; 
   UInt_t mysize           = 0;
-  Int_t nRecPoints        = 0;
-  Int_t index             = 0;
+  //Int_t nRecPoints        = 0;
+  //Int_t index             = 0;
   
-  Int_t fileCount = 0;
+  //Int_t fileCount = 0;
   Int_t digitCount = 0;
-  char filename [50];
+  //char filename [50];
 
 
   AliHLTUInt8_t* outBPtr;

diff --git a/HLT/PHOS/AliHLTPHOSRcuDigitMakerComponent.h b/HLT/PHOS/AliHLTPHOSRcuDigitMakerComponent.h
index 16e0aafbc9c4046cc23ba196842e8a90f7b68db9..cc7e8b04a7fb8cd7ef1820a44ec729cd2203b283 100644 (file)
--- a/HLT/PHOS/AliHLTPHOSRcuDigitMakerComponent.h
+++ b/HLT/PHOS/AliHLTPHOSRcuDigitMakerComponent.h
@@ -51,6 +51,7 @@ public:
   AliHLTComponent* Spawn();
   
 protected:
+  using AliHLTPHOSRcuProcessor::DoEvent;
   int DoInit(int argc, const char** argv);
   virtual int Deinit(); ////////// PTH WARNING you should Define a class AliHLTPHOSModuleProcessor
   

diff --git a/HLT/PHOS/AliHLTPHOSRcuHistogramProducer.cxx b/HLT/PHOS/AliHLTPHOSRcuHistogramProducer.cxx
index 92221fceb1ebc9e3386798f0b25fbd9d611022c6..b6a50df1c21b674d652bcb9c62fc27b1221a80ec 100644 (file)
--- a/HLT/PHOS/AliHLTPHOSRcuHistogramProducer.cxx
+++ b/HLT/PHOS/AliHLTPHOSRcuHistogramProducer.cxx
@@ -118,7 +118,7 @@ AliHLTPHOSRcuHistogramProducer::Init()
   int geomz;
     
 
-  for(int gain=0; gain< N_GAINS; gain++)
+  for(unsigned int gain=0; gain< N_GAINS; gain++)
     {
       sprintf(tmpHistoName, "DeadChanneMap_Module%d_rcuz%d_rcux%d_gain%d",(int)fModuleID,  fRcuZ, fRcuX, gain);
       //    fDeadChannelMapHistogramPtrs[gain] = new TH2D( tmpHistoName, tmpHistoName, N_BINS, XBIN_LOW, XBIN_UP);
@@ -135,11 +135,11 @@ AliHLTPHOSRcuHistogramProducer::Init()
 
 
 
-  for(int x = 0; x < N_XCOLUMNS_RCU; x ++)
+  for(unsigned int x = 0; x < N_XCOLUMNS_RCU; x ++)
     {
-      for(int z = 0; z < N_ZROWS_RCU; z ++)
+      for(unsigned int z = 0; z < N_ZROWS_RCU; z ++)
        {
-         for(int gain = 0; gain < N_GAINS; gain ++)
+         for(unsigned int gain = 0; gain < N_GAINS; gain ++)
            {
              geomx = x + N_XCOLUMNS_RCU*fRcuX;
              geomz = z + N_ZROWS_RCU*fRcuZ;
@@ -257,11 +257,11 @@ void
 AliHLTPHOSRcuHistogramProducer::FillLiveChannelHistograms()
 {
   //comment
-  for(int x = 0; x <  N_XCOLUMNS_RCU; x ++)
+  for(unsigned int x = 0; x <  N_XCOLUMNS_RCU; x ++)
     {
-      for(int z = 0; z < N_ZROWS_RCU; z ++)
+      for(unsigned int z = 0; z < N_ZROWS_RCU; z ++)
        {
-         for(int gain = 0; gain < N_GAINS; gain ++)
+         for(unsigned int gain = 0; gain < N_GAINS; gain ++)
            {
              fDeadChannelMapHistogramPtrs[gain]->SetBinContent(x ,z , fCellAccEnergy.fDeadChannelMap[x][z][gain]);
            }
@@ -274,11 +274,11 @@ void
 AliHLTPHOSRcuHistogramProducer::Reset()
 {
   //See header file for documentation
-  for(int x = 0; x < N_XCOLUMNS_RCU; x ++)
+  for(unsigned int x = 0; x < N_XCOLUMNS_RCU; x ++)
     {
-      for(int z = 0; z < N_ZROWS_RCU; z ++)
+      for(unsigned int z = 0; z < N_ZROWS_RCU; z ++)
        {
-         for(int gain = 0; gain < N_GAINS; gain ++)
+         for(unsigned int gain = 0; gain < N_GAINS; gain ++)
            {
              fEnergyAverageValues[x][z][gain] = 0; 
              fAccumulatedValues[x][z][gain]   = 0;
@@ -289,7 +289,7 @@ AliHLTPHOSRcuHistogramProducer::Reset()
        } 
     }
   
-  for(int i = 0; i <ALTRO_MAX_SAMPLES;  i++)
+  for(unsigned int i = 0; i <ALTRO_MAX_SAMPLES;  i++)
     {
       fTmpChannelData[i] = 0;
     }
@@ -358,11 +358,11 @@ AliHLTPHOSRcuHistogramProducer::WriteAllHistograms(char *opt)
 
   cout <<"printing histograms"<< endl;
 
-  for(int x = 0; x <  N_XCOLUMNS_RCU; x ++)
+  for(unsigned int x = 0; x <  N_XCOLUMNS_RCU; x ++)
     {
-      for(int z = 0; z < N_ZROWS_RCU; z ++)
+      for(unsigned int z = 0; z < N_ZROWS_RCU; z ++)
        {
-         for(int gain = 0; gain < N_GAINS; gain ++)
+         for(unsigned int gain = 0; gain < N_GAINS; gain ++)
            {
              //     cout << "the number of entries is " <<fEnergyHistogramPtrs[x][z][gain]->GetEntries()<< endl;
              fEnergyHistogramPtrs[x][z][gain]->Write();
@@ -413,11 +413,11 @@ AliHLTPHOSRcuHistogramProducer::ScanTimeString(char *timeString)
   int min;
   int sec;
   int year;
-  char sDate[5];
-  char sHour[5];
-  char sMin[5];
-  char sSec[5];
-  char sYear[10];
+  //char sDate[5];
+  //char sHour[5];
+  //char sMin[5];
+  //char sSec[5];
+  //char sYear[10];
   sscanf(timeString, "%s %s %d %d:%d:%d %d\n", day, month, &date, &hour, &min, &sec, &year);
   
 }

diff --git a/HLT/PHOS/AliHLTPHOSRcuHistogramProducerComponent.cxx b/HLT/PHOS/AliHLTPHOSRcuHistogramProducerComponent.cxx
index 5fc970b04a63c81114e766b61ebcc329f5e85a59..e419673417e73be27539adca1e89b980420abe78 100644 (file)
--- a/HLT/PHOS/AliHLTPHOSRcuHistogramProducerComponent.cxx
+++ b/HLT/PHOS/AliHLTPHOSRcuHistogramProducerComponent.cxx
@@ -34,7 +34,8 @@ AliHLTPHOSRcuHistogramProducerComponent gAliHLTPHOSRcuHistogramProducerComponent
 * and it fills the histograms with amplitudes per channel.               * 
 * Usage example see in PHOS/macros/Shuttle/AliPHOSCalibHistoProducer.C   *
 **************************************************************************/
-AliHLTPHOSRcuHistogramProducerComponent:: AliHLTPHOSRcuHistogramProducerComponent():AliHLTPHOSRcuProcessor(), fRcuHistoProducerPtr(0), fHistoWriteFrequency(100)
+AliHLTPHOSRcuHistogramProducerComponent:: AliHLTPHOSRcuHistogramProducerComponent() :
+  AliHLTPHOSRcuProcessor(), fHistoWriteFrequency(100), fRcuHistoProducerPtr(0), fOutPtr(NULL)
 {
   //Default constructor
 } 
@@ -97,7 +98,7 @@ AliHLTPHOSRcuHistogramProducerComponent::GetOutputDataSize(unsigned long& constB
 
 
 int  AliHLTPHOSRcuHistogramProducerComponent::DoEvent( const AliHLTComponentEventData& evtData, const AliHLTComponentBlockData* blocks, 
-                                             AliHLTComponentTriggerData& trigData, AliHLTUInt8_t* outputPtr, 
+                                             AliHLTComponentTriggerData& /*trigData*/, AliHLTUInt8_t* outputPtr, 
                                              AliHLTUInt32_t& size, vector<AliHLTComponentBlockData>& outputBlocks )
 {
   //  cout << "AliHLTPHOSRcuHistogramProducerComponent::DoEven TP0"   << endl;
@@ -149,11 +150,11 @@ int  AliHLTPHOSRcuHistogramProducerComponent::DoEvent( const AliHLTComponentEven
   fOutPtr->fRcuZ     = fRcuZ;
 
 
-  for(int x=0; x < N_XCOLUMNS_RCU; x ++)
+  for(unsigned int x=0; x < N_XCOLUMNS_RCU; x ++)
     {
-      for(int z=0; z < N_ZROWS_RCU; z ++)
+      for(unsigned int z=0; z < N_ZROWS_RCU; z ++)
        {
-         for(int gain =0;  gain < N_GAINS; gain ++)
+         for(unsigned int gain =0;  gain < N_GAINS; gain ++)
            {
              fOutPtr->fAccumulatedEnergies[x][z][gain] = innPtr.fAccumulatedEnergies[x][z][gain];
              fOutPtr->fHits[x][z][gain] = innPtr.fHits[x][z][gain];

diff --git a/HLT/PHOS/AliHLTPHOSRcuHistogramProducerComponent.h b/HLT/PHOS/AliHLTPHOSRcuHistogramProducerComponent.h
index 561c16d59d45c46be7febeda23be7347c4547483..56fccfa8055d633eb3a093511bc40332e3a30301 100644 (file)
--- a/HLT/PHOS/AliHLTPHOSRcuHistogramProducerComponent.h
+++ b/HLT/PHOS/AliHLTPHOSRcuHistogramProducerComponent.h
@@ -32,6 +32,9 @@ class AliHLTPHOSRcuHistogramProducerComponent:public AliHLTPHOSRcuProcessor
   virtual AliHLTComponent* Spawn();
   virtual const char* GetComponentID();
 
+ protected:
+  using AliHLTPHOSRcuProcessor::DoEvent;
+
  private:
   int fHistoWriteFrequency;
 

diff --git a/HLT/PHOS/AliHLTPHOSRcuProcessor.cxx b/HLT/PHOS/AliHLTPHOSRcuProcessor.cxx
index 0e56e94082753e1f7468c6082d26fa8ce49a41b4..633582d8a5aff95797dc62f79581ea7a8ad891f0 100644 (file)
--- a/HLT/PHOS/AliHLTPHOSRcuProcessor.cxx
+++ b/HLT/PHOS/AliHLTPHOSRcuProcessor.cxx
@@ -107,7 +107,7 @@ AliHLTPHOSRcuProcessor::ScanArguments(int argc, const char** argv)
 }
 
 void 
-AliHLTPHOSRcuProcessor::SetCoordinates(AliHLTUInt16_t equippmentID)
+AliHLTPHOSRcuProcessor::SetCoordinates(AliHLTUInt16_t /*equippmentID*/)
 {
   int rcuIndex =  (fkEquippmentID - 1792)%N_RCUS_PER_MODULE;
   fModuleID = (fkEquippmentID  -1792 -rcuIndex)/N_RCUS_PER_MODULE;

diff --git a/HLT/PHOS/AliHLTPHOSRcuTreeMaker.cxx b/HLT/PHOS/AliHLTPHOSRcuTreeMaker.cxx
index 82b5d9f5ac84008afa199e1b79fae72cadc6406a..e6f917998bcdf75563c07159b3c42c4536b9bab7 100644 (file)
--- a/HLT/PHOS/AliHLTPHOSRcuTreeMaker.cxx
+++ b/HLT/PHOS/AliHLTPHOSRcuTreeMaker.cxx
@@ -48,7 +48,7 @@ AliHLTPHOSRcuTreeMaker::MakeDigitArray(AliHLTPHOSRcuDigitContainerDataStruct *di
   AliHLTPHOSDigit *digit = 0;
   AliHLTPHOSDigitDataStruct *digitStruct = 0;
 
-  for(Int_t i = 0; i < digitContainer->fNDigits; i++)
+  for(UInt_t i = 0; i < digitContainer->fNDigits; i++)
     {
       digitStruct = &(digitContainer->fDigitDataStruct[i]);
       digit = (AliHLTPHOSDigit*)fDigitArrayPtr->New(i + nDigits);

diff --git a/HLT/PHOS/AliHLTPHOSRcuTreeMakerComponent.cxx b/HLT/PHOS/AliHLTPHOSRcuTreeMakerComponent.cxx
index 1cfee7a4bc9f30895978a0a54b434fe393e294ac..13edabecdcc71b4671c3ff8aa574898644e1189e 100644 (file)
--- a/HLT/PHOS/AliHLTPHOSRcuTreeMakerComponent.cxx
+++ b/HLT/PHOS/AliHLTPHOSRcuTreeMakerComponent.cxx
@@ -110,8 +110,8 @@ AliHLTPHOSRcuTreeMakerComponent::GetOutputDataSize(unsigned long& constBase, dou
 
 int 
 AliHLTPHOSRcuTreeMakerComponent::DoEvent(const AliHLTComponentEventData& evtData, const AliHLTComponentBlockData* blocks,
-                                       AliHLTComponentTriggerData& /*trigData*/, AliHLTUInt8_t* outputPtr, AliHLTUInt32_t& size,
-                                       std::vector<AliHLTComponentBlockData>& outputBlocks)
+                                       AliHLTComponentTriggerData& /*trigData*/, AliHLTUInt8_t* /*outputPtr*/, AliHLTUInt32_t& /*size*/,  //TODO: I think size should be set to zero when returning from this method if not data was written to the output buffer.
+                                       std::vector<AliHLTComponentBlockData>& /*outputBlocks*/)
 
 {
   //Do event
@@ -130,7 +130,7 @@ AliHLTPHOSRcuTreeMakerComponent::DoEvent(const AliHLTComponentEventData& evtData
       if ( iter->fDataType == AliHLTPHOSDefinitions::fgkAliHLTDigitDataType )
 
         {
-          digitEvent == true;
+          digitEvent = true;
           nDigits  = fTreeMakerPtr->MakeDigitArray ( reinterpret_cast<AliHLTPHOSRcuDigitContainerDataStruct*> ( iter->fPtr ), totalDigits );
           totalDigits += nDigits;
          //cout << totalDigits << endl;
@@ -177,7 +177,7 @@ AliHLTPHOSRcuTreeMakerComponent::DoInit ( int argc, const char** argv )
   fTreeMakerPtr->SetDigitTree(fDigitTreePtr);
     
   fstream runNbFile;
-  Int_t newRunNb;
+  //Int_t newRunNb;
   runNbFile.open("/opt/HLT-public/rundir/runNumber.txt");
   runNbFile >> fRunNb;
   runNbFile.close();

diff --git a/HLT/PHOS/AliHLTPHOSRcuTreeMakerComponent.h b/HLT/PHOS/AliHLTPHOSRcuTreeMakerComponent.h
index 3aae73ea043f0e2ee002c902bed0a20db7807e9f..3396f6181a22b852a2cc8e92649fd77928936fb7 100644 (file)
--- a/HLT/PHOS/AliHLTPHOSRcuTreeMakerComponent.h
+++ b/HLT/PHOS/AliHLTPHOSRcuTreeMakerComponent.h
@@ -53,6 +53,9 @@ class AliHLTPHOSRcuTreeMakerComponent : public AliHLTPHOSRcuProcessor
   void ResetTrees();
    
  protected:
+
+  using AliHLTPHOSRcuProcessor::DoEvent;
+
   int DoInit(int argc, const char** argv);
 
   virtual int Deinit(); ////////// PTH WARNING you should Define a class AliHLTPHOSModuleProcessor

diff --git a/HLT/PHOS/AliHLTPHOSSandboxComponent.cxx b/HLT/PHOS/AliHLTPHOSSandboxComponent.cxx
index 9579e8b2360e5eaf6940d8932ff353865bb19e22..d5c0b72521afc0aea7bdcb84696215bdc07351cd 100644 (file)
--- a/HLT/PHOS/AliHLTPHOSSandboxComponent.cxx
+++ b/HLT/PHOS/AliHLTPHOSSandboxComponent.cxx
@@ -112,8 +112,8 @@ AliHLTPHOSSandboxComponent::DoProcessing(const AliHLTComponentEventData& evtData
 */
 int 
 AliHLTPHOSSandboxComponent::DoEvent(const AliHLTComponentEventData& evtData, const AliHLTComponentBlockData* blocks,
-                                   AliHLTComponentTriggerData& /*trigData*/, AliHLTUInt8_t* outputPtr, AliHLTUInt32_t& size,
-                                   vector<AliHLTComponentBlockData>& outputBlocks)
+                                   AliHLTComponentTriggerData& /*trigData*/, AliHLTUInt8_t* /*outputPtr*/, AliHLTUInt32_t& /*size*/, //TODO: I think size should be set to zero when returning from this method if not data was written to the output buffer.
+                                   vector<AliHLTComponentBlockData>& /*outputBlocks*/)
 {
    //Do event
   
@@ -155,7 +155,7 @@ AliHLTPHOSSandboxComponent::DoEvent(const AliHLTComponentEventData& evtData, con
 
 
 int
-AliHLTPHOSSandboxComponent::DoInit(int argc, const char** argv )
+AliHLTPHOSSandboxComponent::DoInit(int argc, const char** /*argv*/ )
 {
   //Do initialization
 

diff --git a/HLT/PHOS/AliHLTPHOSSandboxComponent.h b/HLT/PHOS/AliHLTPHOSSandboxComponent.h
index 00410345b83123210589545337ad22740eaa14d7..80688280ae47e10952403f4b204ebab6ac88c35d 100644 (file)
--- a/HLT/PHOS/AliHLTPHOSSandboxComponent.h
+++ b/HLT/PHOS/AliHLTPHOSSandboxComponent.h
@@ -56,6 +56,9 @@ public:
   AliHLTComponent* Spawn();
   
 protected:
+
+  using AliHLTPHOSProcessor::DoEvent;
+
   int DoInit(int argc, const char** argv);
   virtual int Deinit(); ////////// PTH WARNING you should Define a class AliHLTPHOSModuleProcessor
 

diff --git a/HLT/PHOS/AliHLTPHOSTreeMaker.cxx b/HLT/PHOS/AliHLTPHOSTreeMaker.cxx
index 3e9affdc3f6d6f8266b1c3b56909f6f12d187f34..fd99f42c1d870b60c777b4b7e944bcacea591ca2 100644 (file)
--- a/HLT/PHOS/AliHLTPHOSTreeMaker.cxx
+++ b/HLT/PHOS/AliHLTPHOSTreeMaker.cxx
@@ -48,7 +48,7 @@ AliHLTPHOSTreeMaker::MakeDigitArray(AliHLTPHOSDigitContainerDataStruct *digitCon
   AliHLTPHOSDigit *digit = 0;
   AliHLTPHOSDigitDataStruct *digitStruct = 0;
 
-  for(Int_t i = 0; i < digitContainer->fNDigits; i++)
+  for(UInt_t i = 0; i < digitContainer->fNDigits; i++)
     {
       digitStruct = &(digitContainer->fDigitDataStruct[i]);
       digit = (AliHLTPHOSDigit*)fDigitArrayPtr->New(i + nDigits);

diff --git a/HLT/PHOS/AliHLTPHOSTreeMakerComponent.cxx b/HLT/PHOS/AliHLTPHOSTreeMakerComponent.cxx
index 6f4c855ed7165f2b32fb0daa3643a182da6aa9aa..1abbf6b4f2ba78dbb4e1285f73e71095c16913f4 100644 (file)
--- a/HLT/PHOS/AliHLTPHOSTreeMakerComponent.cxx
+++ b/HLT/PHOS/AliHLTPHOSTreeMakerComponent.cxx
@@ -103,8 +103,8 @@ AliHLTPHOSTreeMakerComponent::GetOutputDataSize(unsigned long& constBase, double
 
 int 
 AliHLTPHOSTreeMakerComponent::DoEvent(const AliHLTComponentEventData& evtData, const AliHLTComponentBlockData* blocks,
-                                       AliHLTComponentTriggerData& /*trigData*/, AliHLTUInt8_t* outputPtr, AliHLTUInt32_t& size,
-                                       std::vector<AliHLTComponentBlockData>& outputBlocks)
+                                       AliHLTComponentTriggerData& /*trigData*/, AliHLTUInt8_t* /*outputPtr*/, AliHLTUInt32_t& /*size*/,  //TODO: I think size should be set to zero when returning from this method if not data was written to the output buffer.
+                                       std::vector<AliHLTComponentBlockData>& /*outputBlocks*/)
 
 {
   //Do event
@@ -123,7 +123,7 @@ AliHLTPHOSTreeMakerComponent::DoEvent(const AliHLTComponentEventData& evtData, c
       if ( iter->fDataType == AliHLTPHOSDefinitions::fgkAliHLTDigitDataType )
 
         {
-          digitEvent == true;
+          digitEvent = true;
           nDigits  = fTreeMakerPtr->MakeDigitArray ( reinterpret_cast<AliHLTPHOSDigitContainerDataStruct*> ( iter->fPtr ), totalDigits );
           totalDigits += nDigits;
          //cout << totalDigits << endl;
@@ -170,7 +170,7 @@ AliHLTPHOSTreeMakerComponent::DoInit ( int argc, const char** argv )
   fTreeMakerPtr->SetDigitTree(fDigitTreePtr);
     
   fstream runNbFile;
-  Int_t newRunNb;
+  //Int_t newRunNb;
   runNbFile.open("/opt/HLT-public/rundir/runNumber.txt");
   runNbFile >> fRunNb;
   runNbFile.close();

diff --git a/HLT/PHOS/AliHLTPHOSTreeMakerComponent.h b/HLT/PHOS/AliHLTPHOSTreeMakerComponent.h
index 0e8abe1a64140473466e2e51075604aafaeabc23..66a655a599bd4680e3b87c0464282d83ec641e6e 100644 (file)
--- a/HLT/PHOS/AliHLTPHOSTreeMakerComponent.h
+++ b/HLT/PHOS/AliHLTPHOSTreeMakerComponent.h
@@ -54,6 +54,7 @@ class AliHLTPHOSTreeMakerComponent : public AliHLTPHOSProcessor
    
 
  protected:
+  using AliHLTPHOSProcessor::DoEvent;
   int DoInit(int argc, const char** argv);
 
   virtual int Deinit(); ////////// PTH WARNING you should Define a class AliHLTPHOSModuleProcessor