Fixing coding violations. Method AliITSQADataMakerRec::AreEqual defined static

diff --git a/ITS/AliITSQADataMakerRec.h b/ITS/AliITSQADataMakerRec.h
index 4776ce674b141a5ab7eef5d30f610e3c527cf7df..e556721206fb4e78e1186fd29ebcd93464b5efe0 100644 (file)
--- a/ITS/AliITSQADataMakerRec.h
+++ b/ITS/AliITSQADataMakerRec.h
@@ -63,7 +63,7 @@ public:
  Int_t GetDetTaskOffset(Int_t subdet,AliQAv1::TASKINDEX_t task,Int_t specie=0);
  Int_t GetDetTaskHisto(Int_t subdet,AliQAv1::TASKINDEX_t task);
  TH2F *GetITSGlobalHisto(Int_t layer);
- Bool_t AreEqual(Double_t a1, Double_t a2);
+ static Bool_t AreEqual(Double_t a1, Double_t a2);
 
  virtual void SetRunNumber(Int_t runnumber){fRunNumber=runnumber;};
  Int_t GetRunNumber(){return fRunNumber;};

diff --git a/ITS/AliITSQASSDChecker.cxx b/ITS/AliITSQASSDChecker.cxx
index 7c68fbd583330cd98e32acfd465a02ca32226d5f..b27eccc2ca949e987bbe68afb3fa6bb35fa10686 100644 (file)
--- a/ITS/AliITSQASSDChecker.cxx
+++ b/ITS/AliITSQASSDChecker.cxx
@@ -24,10 +24,11 @@
 // --- ROOT system ---
 #include "TH1.h"
 #include "TString.h"
-#include "Riostream.h"
+//#include "Riostream.h"
 
 // --- AliRoot header files ---
 #include "AliITSQASSDChecker.h"
+#include "AliITSQADataMakerRec.h"
 #include "AliLog.h"
 
 ClassImp(AliITSQASSDChecker)
@@ -41,7 +42,7 @@ AliITSQASSDChecker& AliITSQASSDChecker::operator = (const AliITSQASSDChecker& qa
 }
 
 void AliITSQASSDChecker::CheckRaws(TH1* histo) {  
-
+  // checker for RAWS
   Double_t minSSDDataSize = 0;
   Double_t maxSSDDataSize = 200;
   Double_t minDDLDataSize = 0;
@@ -92,7 +93,7 @@ void AliITSQASSDChecker::CheckRaws(TH1* histo) {
         if(histo->GetBinContent(histo->FindBin(i))==0) {
           AliWarning(Form("Data size / LDC histogram: bin for LDC %i is empty",i));
         }
-        else if(histo->GetBinContent(histo->FindBin(i))==minLDCDataSize||histo->GetBinContent(histo->FindBin(i))>maxLDCDataSize) AliWarning(Form("Data size LDC %i is %-.2g kB",i,histo->GetBinContent(i)));
+       else if(AliITSQADataMakerRec::AreEqual(histo->GetBinContent(histo->FindBin(i)),minLDCDataSize) ||histo->GetBinContent(histo->FindBin(i))>maxLDCDataSize) AliWarning(Form("Data size LDC %i is %-.2g kB",i,histo->GetBinContent(i)));
       }
     }
   }
@@ -173,13 +174,11 @@ void AliITSQASSDChecker::CheckRaws(TH1* histo) {
 
 }
 
-void AliITSQASSDChecker::CheckRecPoints(TH1* /*histo*/) {  
-
 
-}
 
 //__________________________________________________________________
-Double_t AliITSQASSDChecker::Check(AliQAv1::ALITASK_t /*index*/, TObjArray * list, const AliDetectorRecoParam * /*recoParam*/) {  
+Double_t AliITSQASSDChecker::Check(AliQAv1::ALITASK_t /*index*/, const TObjArray * list, const AliDetectorRecoParam * /*recoParam*/) { 
+  // main checker method 
   AliDebug(AliQAv1::GetQADebugLevel(),Form("AliITSQASSDChecker called with offset: %d\n", fSubDetOffset));
 
   AliInfo(Form("AliITSQASSDChecker called with offset: %d\n", fSubDetOffset) );
@@ -222,7 +221,7 @@ Double_t AliITSQASSDChecker::Check(AliQAv1::ALITASK_t /*index*/, TObjArray * lis
       }
     }
     if (count != 0) {
-      if (test==0) {
+      if (AliITSQADataMakerRec::AreEqual(test,0.)) {
         AliWarning("Histograms are there, but they are all empty: setting flag to kWARNING");
         test = 0.5;  //upper limit value to set kWARNING flag for a task
       }
@@ -243,15 +242,14 @@ Double_t AliITSQASSDChecker::Check(AliQAv1::ALITASK_t /*index*/, TObjArray * lis
 }
 
 //__________________________________________________________________
-void AliITSQASSDChecker::SetTaskOffset(Int_t TaskOffset)
-{
+void AliITSQASSDChecker::SetTaskOffset(Int_t TaskOffset){
+  // defines offset for SSD
   fSubDetOffset = TaskOffset;
 }
 
 //__________________________________________________________________
-void AliITSQASSDChecker::SetStepBit(Double_t *steprange)
-{
-
+void AliITSQASSDChecker::SetStepBit(const Double_t *steprange) {
+  // defines step range
   fStepBitSSD = new Double_t[AliQAv1::kNBIT];
   for(Int_t bit=0;bit<AliQAv1::kNBIT;bit++)
     {
@@ -260,9 +258,8 @@ void AliITSQASSDChecker::SetStepBit(Double_t *steprange)
 }
 
 //__________________________________________________________________
-void  AliITSQASSDChecker::SetSSDLimits(Float_t *lowvalue, Float_t * highvalue)
-{
-
+void  AliITSQASSDChecker::SetSSDLimits(const Float_t *lowvalue, const Float_t * highvalue){
+  // defines 
   fLowSSDValue = new Float_t[AliQAv1::kNBIT];
   fHighSSDValue= new Float_t[AliQAv1::kNBIT];
 

diff --git a/ITS/AliITSQASSDChecker.h b/ITS/AliITSQASSDChecker.h
index e9648e0b7bab3979307a4caf934a0f011b9a258b..08aacda29385452a0455be46a69f505db6097b62 100644 (file)
--- a/ITS/AliITSQASSDChecker.h
+++ b/ITS/AliITSQASSDChecker.h
@@ -20,8 +20,6 @@ class TH2F ;
 
 // --- AliRoot header files ---
 #include "AliQAv1.h"
-#include "AliQACheckerBase.h"
-#include "AliITSQAChecker.h"
 class AliITSLoader ; 
 
 class AliITSQASSDChecker: public TObject {
@@ -30,24 +28,24 @@ public:
   AliITSQASSDChecker():fSubDetOffset(0),fStepBitSSD(NULL),fLowSSDValue(NULL),fHighSSDValue(NULL) {;}          // ctor
   AliITSQASSDChecker& operator = (const AliITSQASSDChecker& qac) ; //operator =
   virtual ~AliITSQASSDChecker() {if(fStepBitSSD) delete[] fStepBitSSD ;if(fLowSSDValue)delete[]fLowSSDValue;if(fHighSSDValue) delete[]fHighSSDValue; } // dtor
-  virtual Double_t Check(AliQAv1::ALITASK_t /*index*/, TObjArray * /*list*/, const AliDetectorRecoParam * recoParam);
+  virtual Double_t Check(AliQAv1::ALITASK_t /*index*/, const TObjArray * list, const AliDetectorRecoParam * recoParam);
 
-  void SetStepBit(Double_t *steprange);
-  Double_t *GetStepBit(){return fStepBitSSD;};
+  void SetStepBit(const Double_t *steprange);
+  Double_t *GetStepBit() const {return fStepBitSSD;};
 
-  void CheckRaws(TH1 *);
-  void CheckRecPoints(TH1 *);
+  void CheckRaws(TH1* histo);
+  void CheckRecPoints(TH1 * /* histo */) const {return;}
   void SetTaskOffset(Int_t TaskOffset);
-  void SetSSDLimits(Float_t *lowvalue, Float_t * highvalue);
+  void SetSSDLimits(const Float_t *lowvalue, const Float_t * highvalue);
 
 
 private:
   
   AliITSQASSDChecker(const AliITSQASSDChecker& qac):TObject(),fSubDetOffset(qac.fSubDetOffset),fStepBitSSD(qac.fStepBitSSD),fLowSSDValue(qac.fLowSSDValue),fHighSSDValue(qac.fHighSSDValue) {;} // cpy ctor   
   Int_t fSubDetOffset;            // checking operation starting point
-  Double_t *fStepBitSSD;
-  Float_t *fLowSSDValue;
-  Float_t *fHighSSDValue;
+  Double_t *fStepBitSSD;          // step size 
+  Float_t *fLowSSDValue;          // low limit
+  Float_t *fHighSSDValue;         // high limit
   ClassDef(AliITSQASSDChecker,2)  // description 
 
 };