- coverity fixes for unused but set variables in various places

diff --git a/HLT/TRD/AliHLTTRDPreprocessorComponent.cxx b/HLT/TRD/AliHLTTRDPreprocessorComponent.cxx
index 20b7de59ba7b274e30c78cb789496169cccd06d6..1971185e7c71e6eb487f2a4edae03daac2c6a0f7 100644 (file)
--- a/HLT/TRD/AliHLTTRDPreprocessorComponent.cxx
+++ b/HLT/TRD/AliHLTTRDPreprocessorComponent.cxx
@@ -371,7 +371,7 @@ int AliHLTTRDPreprocessorComponent::DoEvent(const AliHLTComponentEventData& hltE
   // read and process GTU tracks
   UInt_t numGtuTracks = fGtuTrackArray->GetEntriesFast();
   AliESDTrdTrack *trdTrack = NULL;
-  UInt_t stack;
+  // UInt_t stack;
   Int_t refIndex[6];
 
   for (UInt_t iTrack = 0; iTrack < numGtuTracks; iTrack++) {
@@ -379,7 +379,7 @@ int AliHLTTRDPreprocessorComponent::DoEvent(const AliHLTComponentEventData& hltE
     if (trdTrack){
 
       AliTRDrawStream::AssignTracklets(trdTrack, trackletIndex, refIndex);
-      stack = trdTrack->GetStack();
+      // stack = trdTrack->GetStack();
 
       for (Int_t iLayer = 0; iLayer < 6; ++iLayer) {
        AliESDTrdTracklet *trkl = (refIndex[iLayer] > -1) ? (AliESDTrdTracklet*) trklList.At(refIndex[iLayer]) : 0x0;

diff --git a/HLT/trigger/AliHLTTRDTriggerComponent.cxx b/HLT/trigger/AliHLTTRDTriggerComponent.cxx
index eb7251bbe4f5ce7ac6ed7144d278a13861dcab61..d2adabc1c5bc09dda2c8785b1ed4c9b79dbfa98c 100644 (file)
--- a/HLT/trigger/AliHLTTRDTriggerComponent.cxx
+++ b/HLT/trigger/AliHLTTRDTriggerComponent.cxx
@@ -934,8 +934,10 @@ int AliHLTTRDTriggerComponent::MatchTRDTracksHLT(){
 
       //## use cuts here
       hltTrackPreSel[iHltTrack++] = isRelevant;
-      if (iHltTrack >= fkMaxRefTracks)
+      if (iHltTrack >= fkMaxRefTracks) {
        LogError("maximum number of HLT tracks exceeded.");
+       break;
+      }
     } // loop over HLT tracks;
 
     // search for matching HLT track for each GTU track
@@ -1776,7 +1778,7 @@ Int_t AliHLTTRDTriggerComponent::EstimateTrackDistance(AliExternalTrackParam *re
   Double_t ptrkl2[3];
   UInt_t trklDet;
   UShort_t trklLayer;
-  UInt_t stack_gtu;
+  // UInt_t stack_gtu;
   UShort_t stackInSector;
 
   AliTRDpadPlane* padPlane;
@@ -1785,7 +1787,7 @@ Int_t AliHLTTRDTriggerComponent::EstimateTrackDistance(AliExternalTrackParam *re
     if ((layerMask >> iLayer) & 1){
       trklDet = stack*6 + iLayer;
       trklLayer = iLayer;
-      stack_gtu = stack;
+      // stack_gtu = stack;
       stackInSector = stack % 5;
 
       // local coordinates of the outer end point of the tracklet

diff --git a/PWGPP/TRD/AliTRDonlineTrackletQA.cxx b/PWGPP/TRD/AliTRDonlineTrackletQA.cxx
index f90c26e4f9d8c126d36935bbd967b5c1a981120f..4dd9d70a4bbf0c683c36b9e8248abde6dcab2e41 100644 (file)
--- a/PWGPP/TRD/AliTRDonlineTrackletQA.cxx
+++ b/PWGPP/TRD/AliTRDonlineTrackletQA.cxx
@@ -412,7 +412,7 @@ void AliTRDonlineTrackletQA::Exec(const Option_t * /* option */)
 
       // search for the best match
       AliESDTrdTracklet *trackletMatch = 0x0;
-      Int_t dyMax = 20;
+      // Int_t dyMax = 20;
       Int_t yMax = 100;
       for (Int_t iTrackletSim = 0; iTrackletSim < trackletsSim[iDetector].GetEntries(); iTrackletSim++) {
        AliESDTrdTracklet *trackletSim = (AliESDTrdTracklet*) trackletsSim[iDetector].At(iTrackletSim);
@@ -428,7 +428,7 @@ void AliTRDonlineTrackletQA::Exec(const Option_t * /* option */)
 
        trackletMatch = trackletSim;
        yMax  = TMath::Abs(trackletRaw->GetBinY()  - trackletSim->GetBinY());
-       dyMax = TMath::Abs(trackletRaw->GetBinDy() - trackletSim->GetBinDy());
+       // dyMax = TMath::Abs(trackletRaw->GetBinDy() - trackletSim->GetBinDy());
       }
       if (trackletMatch) {
        fHistYdiff->Fill(trackletRaw->GetBinY()  - trackletMatch->GetBinY());

diff --git a/TRD/AliTRDonlineTrackMatching.cxx b/TRD/AliTRDonlineTrackMatching.cxx
index 91ed2784c8fec20b885b4cb4e701632349e51ce7..60a448f98bbab3277322ae4161832cecd1bfdbd6 100644 (file)
--- a/TRD/AliTRDonlineTrackMatching.cxx
+++ b/TRD/AliTRDonlineTrackMatching.cxx
@@ -530,6 +530,9 @@ Bool_t AliTRDonlineTrackMatching::ProcessEvent(AliESDEvent *esdEvent, Bool_t upd
     }
 
     if ((matchTrack) && (matchRating >= fMinMatchRating)){
+      AliDebug(1, Form("S%02d-%d  trd %d - esd %d   match!    pt:  %.2f  %.2f",
+                      trdTrack->GetSector(), trdTrack->GetStack(), iTrdTrack, matchEsdTrackIndexInStack,
+                      trdPt, matchTrack->GetSignedPt()));
 #ifdef TRD_TM_DEBUG
       printf("#TRACKMATCHING  S%02d-%d  trd %d - esd %d   match!    pt:  %.2f  %.2f\n",
             trdTrack->GetSector(), trdTrack->GetStack(), iTrdTrack, matchEsdTrackIndexInStack,

diff --git a/TRD/AliTRDtrapConfigHandler.cxx b/TRD/AliTRDtrapConfigHandler.cxx
index e6a60706a35c8d3250ea83e85c37ae5f7586a91d..d57cc4eb182f05c91ad87563bb12b747988c8369 100644 (file)
--- a/TRD/AliTRDtrapConfigHandler.cxx
+++ b/TRD/AliTRDtrapConfigHandler.cxx
@@ -606,7 +606,7 @@ Bool_t AliTRDtrapConfigHandler::AddValues(UInt_t det, UInt_t cmd, UInt_t extali,
     for(Int_t linkPair=0; linkPair<fgkMaxLinkPairs; linkPair++) {
       if(AliTRDfeeParam::ExtAliToAli(extali, linkPair, rocType, mcmList, mcmListSize)!=0) {
        Int_t i=0;
-        while(mcmList[i] != -1 && i<mcmListSize) {
+        while((i < mcmListSize) && (mcmList[i] != -1)) {
           if(mcmList[i]==127) {
            AliDebug(1, Form("broadcast write to %s: 0x%08x",
                             fTrapConfig->GetRegName((AliTRDtrapConfig::TrapReg_t) mcmReg), data));