Coverity fixes:

TRD/AliTRDgtuSim: - forward null checks
TRD/AliTRDtrackOnline: - self assignment

diff --git a/TRD/AliTRDgtuSim.cxx b/TRD/AliTRDgtuSim.cxx
index 107cc857da0dd6985643e0ad63181f853f954ba8..9e53d3dea9c327af7199b42e7b10e90ae7d21b7f 100644 (file)
--- a/TRD/AliTRDgtuSim.cxx
+++ b/TRD/AliTRDgtuSim.cxx
@@ -151,8 +151,7 @@ Bool_t AliTRDgtuSim::RunGTUFromTrackletFile(TString filename, Int_t event, Int_t
                       iLink, i-4, ((TObjString*) tokens->At(i))->GetString().Data(), trackletWord));
       AliTRDtrackletWord *tracklet = new (trklArray[trklArray.GetEntriesFast()])       AliTRDtrackletWord(trackletWord);
       AliTRDtrackletGTU   *trkl    = new (trklArrayGTU[trklArrayGTU.GetEntriesFast()]) AliTRDtrackletGTU(tracklet);
-      if (fTMU)
-       fTMU->AddTracklet(trkl, iLink);
+      fTMU->AddTracklet(trkl, iLink);
     }
     //
     delete tokens;
@@ -230,9 +229,7 @@ Bool_t AliTRDgtuSim::RunGTU(AliLoader *loader, AliESDEvent *esd, Int_t label, In
        }
        AliDebug(1, Form("adding tracklet: 0x%08x in sec %i stack %i link %i",
                         trkl->GetTrackletWord(), trkl->GetDetector() / 30, (trkl->GetDetector() % 30) / 6, trkl->GetHCId() % 12));
-       if (fTMU) {
-         fTMU->AddTracklet(trkl, iLink);
-       }
+       fTMU->AddTracklet(trkl, iLink);
     }
 
     if (pendingTracklets) {

diff --git a/TRD/AliTRDtrackOnline.cxx b/TRD/AliTRDtrackOnline.cxx
index 43be589f1ff8da13292c1ea63bbf41abe0f26713..ee65f2451169aa9da7766e810e5b91b8d223c518 100644 (file)
--- a/TRD/AliTRDtrackOnline.cxx
+++ b/TRD/AliTRDtrackOnline.cxx
@@ -300,9 +300,11 @@ AliTRDtrackResiduals::AliTRDtrackResiduals(const AliTRDtrackResiduals &rhs) :
 
 AliTRDtrackResiduals& AliTRDtrackResiduals::operator=(const AliTRDtrackResiduals &rhs)
 {
-  ROOT::Math::IBaseFunctionMultiDim::operator=(rhs);
-  fTrack = rhs.fTrack;
-  fParam = rhs.fParam;
+  if (&rhs != this) {
+    ROOT::Math::IBaseFunctionMultiDim::operator=(rhs);
+    fTrack = rhs.fTrack;
+    fParam = rhs.fParam;
+  }
 
   return *this;
 }