- fix coding rule violations

diff --git a/PWGPP/TRD/AliTRDonlineTrackletFilter.cxx b/PWGPP/TRD/AliTRDonlineTrackletFilter.cxx
index 9a0268060c6c76e0ecead083d9c76c28e7c7025a..5da9656f7a2385fda832eab620eac8914bd7b1c5 100644 (file)
--- a/PWGPP/TRD/AliTRDonlineTrackletFilter.cxx
+++ b/PWGPP/TRD/AliTRDonlineTrackletFilter.cxx
@@ -1,3 +1,10 @@
+// AliTRDonlineTrackletFilter implements an analysis task which reads
+// the tracklets from the TRD.Tracklets.root file and makes them
+// available to other analysis tasks. This allows to access the full
+// tracklet information without repeating the techncicalities in each
+// analysis task. The tracklets are made available in an exchange
+// container on the output slot 1.
+
 #include "TFile.h"
 #include "TTree.h"
 #include "TChain.h"
@@ -64,6 +71,8 @@ AliTRDonlineTrackletFilter::~AliTRDonlineTrackletFilter()
 
 void AliTRDonlineTrackletFilter::ConnectInputData(const Option_t */* option */)
 {
+  // connect all the input handlers to access the data
+
   fInputHandler = (AliInputEventHandler*) AliAnalysisManager::GetAnalysisManager()->GetInputEventHandler();
   if (fInputHandler)
     fInputEvent = fInputHandler->GetEvent();
@@ -75,6 +84,9 @@ void AliTRDonlineTrackletFilter::ConnectInputData(const Option_t */* option */)
 
 void AliTRDonlineTrackletFilter::CreateOutputObjects()
 {
+  // create the output objects used to make the tracklets available to
+  // other tasks
+
   OpenFile(1); 
   
   fTrackletTree = new TTree("tracklets", "on-line tracklets");
@@ -84,6 +96,8 @@ void AliTRDonlineTrackletFilter::CreateOutputObjects()
 
 Bool_t AliTRDonlineTrackletFilter::Notify()
 {
+  // we use notify to figure out which TRD.Tracklets.root file we have
+  // to use for accessing the tracklets
 
   TString filename(AliAnalysisManager::GetAnalysisManager()->GetTree()->GetCurrentFile()->GetName());
 

diff --git a/PWGPP/TRD/AliTRDonlineTrackletFilter.h b/PWGPP/TRD/AliTRDonlineTrackletFilter.h
index d543a2dcb8ff021b9cac975af337efa32be47c62..6f6dffe3fbf378f7c87e20d46df07c920273db41 100644 (file)
--- a/PWGPP/TRD/AliTRDonlineTrackletFilter.h
+++ b/PWGPP/TRD/AliTRDonlineTrackletFilter.h
@@ -1,3 +1,6 @@
+// AliTRDonlineTrackletFilter implements an analysis task which makes
+// the TRD on-line tracklets accessible for other analysis tasks.
+
 #ifndef ALITRDONLINETRACKLETFILTER
 #define ALITRDONLINETRACKLETFILTER
 
@@ -48,7 +51,7 @@ class AliTRDonlineTrackletFilter : public AliAnalysisTask
   // ----- internal use -----
   AliTRDgeometry       *fGeo; //! TRD geometry
 
-  Int_t fNevent;
+  Int_t fNevent; // current event number
 
   TString fPath; //!
   TFile *fTrackletFile; //!

diff --git a/PWGPP/TRD/AliTRDonlineTrackletQA.cxx b/PWGPP/TRD/AliTRDonlineTrackletQA.cxx
index e23a23df267f8f5dc9d79c85aeb51d1bceeaa04c..77b42ddb49852bc46da1a9f01524f337f15ab4e2 100644 (file)
--- a/PWGPP/TRD/AliTRDonlineTrackletQA.cxx
+++ b/PWGPP/TRD/AliTRDonlineTrackletQA.cxx
@@ -1,3 +1,10 @@
+// AliTRDonlineTrackletQA implements the standard QA for the TRD
+// on-line tracklets. It reads the tracklets provided by
+// AliTRDonlineTrackletFilter and analyses them. The QA can be run
+// on tracklets from simulation or from real data. In addition it is
+// possible to compare the tracklets from real data to re-simulation
+// based on the ADC data.
+
 #include "TFile.h"
 #include "TTree.h"
 #include "TChain.h"
@@ -677,7 +684,7 @@ void AliTRDonlineTrackletQA::PlotESD(AliTRDtrackletWord *trkl)
 }
 
 
-Int_t AliTRDonlineTrackletQA::GetTrackletsForMC(Int_t /* label */, Int_t /*idx*/ [])
+Int_t AliTRDonlineTrackletQA::GetTrackletsForMC(Int_t /* label */, Int_t /*idx*/ []) const
 {
   // get tracklets for MC label
   // not implemented

diff --git a/PWGPP/TRD/AliTRDonlineTrackletQA.h b/PWGPP/TRD/AliTRDonlineTrackletQA.h
index 76e400d146d52c23b866196fb36792b7f91acee6..6716cc531277aeb43d3d014d321af2322a026747 100644 (file)
--- a/PWGPP/TRD/AliTRDonlineTrackletQA.h
+++ b/PWGPP/TRD/AliTRDonlineTrackletQA.h
@@ -1,3 +1,6 @@
+// AliTRDonlineTrackletQA implements the standard QA for the TRD
+// on-line tracklets.
+
 #ifndef ALITRDONLINETRACKLETQA_H
 #define ALITRDONLINETRACKLETQA_H
 
@@ -32,7 +35,7 @@ class AliTRDonlineTrackletQA : public AliAnalysisTask
 
   void PlotESD(AliTRDtrackletWord *trkl);
 
-  Int_t GetTrackletsForMC(Int_t label, Int_t idx[]);
+  Int_t GetTrackletsForMC(Int_t label, Int_t idx[]) const;
 
  protected:
   AliESDEvent *fESD;                    //! current ESD event

diff --git a/TRD/AliTRDTriggerL0.cxx b/TRD/AliTRDTriggerL0.cxx
index cc69271ed3534cc77ed93e4d3174f91c1c38f33e..bba3389871760584153be0ff56903bf54cad5e04 100644 (file)
--- a/TRD/AliTRDTriggerL0.cxx
+++ b/TRD/AliTRDTriggerL0.cxx
@@ -36,16 +36,20 @@
 
 AliTRDTriggerL0::AliTRDTriggerL0()
 {
+  // constructor
+
   SetName("TRD");
 }
 
 AliTRDTriggerL0::~AliTRDTriggerL0()
 {
-
+  // destructor
 }
 
 void AliTRDTriggerL0::CreateInputs()
 {
+  // create the L0 inputs which are provided by the TRD
+
   if (fInputs.GetEntriesFast() > 0)
     return;
 
@@ -56,6 +60,7 @@ void AliTRDTriggerL0::CreateInputs()
 
 void AliTRDTriggerL0::Trigger()
 {
+  // do the actual trigger calculation
 
   AliRunLoader *runLoader = AliRunLoader::Instance();
   if (!runLoader)

diff --git a/TRD/AliTRDgtuTMU.cxx b/TRD/AliTRDgtuTMU.cxx
index 9a3be5028d66f19f80563dc9f805a96eb3f09ff6..6ca39098a0564bd9dcc8ba0943d84d1668df7161 100644 (file)
--- a/TRD/AliTRDgtuTMU.cxx
+++ b/TRD/AliTRDgtuTMU.cxx
@@ -1015,7 +1015,7 @@ Bool_t AliTRDgtuTMU::CalculateTrackParams(AliTRDtrackGTU *track)
 }
 
 
-Bool_t AliTRDgtuTMU::Uniquifier(TList *inlist, TList *outlist)
+Bool_t AliTRDgtuTMU::Uniquifier(const TList *inlist, TList *outlist)
 {
   // remove multiple occurences of the same track
 

diff --git a/TRD/AliTRDgtuTMU.h b/TRD/AliTRDgtuTMU.h
index 91deb77bb3d119a0a0c0ee816571bc9dc97b2835..8310b093c4204d5c83992c6f315d4b2aa6898e98 100644 (file)
--- a/TRD/AliTRDgtuTMU.h
+++ b/TRD/AliTRDgtuTMU.h
@@ -43,7 +43,7 @@ class AliTRDgtuTMU : public TObject {
   Bool_t RunTrackReconstruction(TList* ListOfTracks);
 
   Bool_t CalculateTrackParams(AliTRDtrackGTU *track);
-  Bool_t Uniquifier(TList* inlist, TList *outlist);
+  Bool_t Uniquifier(const TList* inlist, TList *outlist);
   Bool_t CalculatePID(AliTRDtrackGTU *track);
 
 protected:

diff --git a/TRD/AliTRDltuParam.cxx b/TRD/AliTRDltuParam.cxx
index 8945b8f10c72c7643e5eb4cde70bde4ee1e93e3a..14194b518e9df0efc1e0a23c7eadc5f9096cf97b 100644 (file)
--- a/TRD/AliTRDltuParam.cxx
+++ b/TRD/AliTRDltuParam.cxx
@@ -42,12 +42,12 @@ AliTRDltuParam::AliTRDltuParam() :
   fTiltCorr(kFALSE),
   fPidGainCorr(kFALSE)
 {
-
+  // default constructor
 }
 
 AliTRDltuParam::~AliTRDltuParam()
 {
-
+  // destructor
 }
 
 Int_t AliTRDltuParam::GetDyCorrection(Int_t det, Int_t rob, Int_t mcm) const
@@ -111,6 +111,9 @@ void AliTRDltuParam::GetDyRange(Int_t det, Int_t rob, Int_t mcm, Int_t ch,
 
 Float_t AliTRDltuParam::GetElongation(Int_t det, Int_t rob, Int_t mcm, Int_t ch) const
 {
+  // calculate the ratio of the distance to the primary vertex and the
+  // distance in x-direction for the given ADC channel
+
   Int_t layer = det % 6;
 
   Float_t elongation = TMath::Abs(GetDist(det, rob, mcm, ch) / fgX[layer]);
@@ -125,6 +128,8 @@ Float_t AliTRDltuParam::GetElongation(Int_t det, Int_t rob, Int_t mcm, Int_t ch)
 void AliTRDltuParam::GetCorrectionFactors(Int_t det, Int_t rob, Int_t mcm, Int_t ch,
                                          UInt_t &cor0, UInt_t &cor1, Float_t gain) const
 {
+  // calculate the gain correction factors for the given ADC channel
+
   if (fPidGainCorr==kFALSE)
     gain=1;
 
@@ -140,17 +145,23 @@ void AliTRDltuParam::GetCorrectionFactors(Int_t det, Int_t rob, Int_t mcm, Int_t
 
 Int_t AliTRDltuParam::GetNtimebins() const
 {
+  // return the number of timebins used
+
   return fNtimebins;
 }
 
 Float_t AliTRDltuParam::GetX(Int_t det, Int_t /* rob */, Int_t /* mcm */) const
 {
+  // return the distance to the beam axis in x-direction
+
   Int_t layer = det%6;
   return fgX[layer];
 }
 
 Float_t AliTRDltuParam::GetLocalY(Int_t det, Int_t rob, Int_t mcm, Int_t ch) const
 {
+  // get local y-position (r-phi) w.r.t. the chamber centre
+
   Int_t layer = det%6;
   // calculate the pad position as in the TRAP
   Float_t ypos = (-4 + 1 + (rob&0x1) * 4 + (mcm&0x3)) * 18 - ch - 0.5; // y position in bins of pad widths
@@ -159,6 +170,8 @@ Float_t AliTRDltuParam::GetLocalY(Int_t det, Int_t rob, Int_t mcm, Int_t ch) con
 
 Float_t AliTRDltuParam::GetLocalZ(Int_t det, Int_t rob, Int_t mcm) const
 {
+  // get local z-position w.r.t. to the chamber boundary
+
   Int_t stack = (det%30) / 6;
   Int_t layer = det % 6;
   Int_t row   = (rob/2) * 4 + mcm/4;
@@ -183,17 +196,23 @@ Float_t AliTRDltuParam::GetLocalZ(Int_t det, Int_t rob, Int_t mcm) const
 
 Float_t AliTRDltuParam::GetPerp(Int_t det, Int_t rob, Int_t mcm, Int_t ch) const
 {
+  // get transverse distance to the beam axis
+
   return TMath::Sqrt(GetLocalY(det, rob, mcm, ch)*GetLocalY(det, rob, mcm, ch) +
                     GetX(det, rob, mcm)*GetX(det, rob, mcm) );
 }
 
 Float_t AliTRDltuParam::GetPhi(Int_t det, Int_t rob, Int_t mcm, Int_t ch) const
 {
+  // calculate the azimuthal angle for the given ADC channel
+
   return TMath::ATan2(GetLocalY(det, rob, mcm, ch), GetX(det, rob, mcm));
 }
 
 Float_t AliTRDltuParam::GetDist(Int_t det, Int_t rob, Int_t mcm, Int_t ch) const
 {
+  // calculate the distance from the origin for the given ADC channel
+
   return TMath::Sqrt(GetLocalY(det, rob, mcm, ch)*GetLocalY(det, rob, mcm, ch) +
                     GetX(det, rob, mcm)*GetX(det, rob, mcm) +
                     GetLocalZ(det, rob, mcm)*GetLocalZ(det, rob, mcm) );

diff --git a/TRD/AliTRDmcmSim.cxx b/TRD/AliTRDmcmSim.cxx
index 7450e98ef6f30d7230b9fd4e293c0403e7926bc7..e0a8791a3c7ebb68dad84e912134f6d74b2ee332 100644 (file)
--- a/TRD/AliTRDmcmSim.cxx
+++ b/TRD/AliTRDmcmSim.cxx
@@ -498,7 +498,7 @@ void AliTRDmcmSim::Draw(Option_t* const option)
   }
 }
 
-void AliTRDmcmSim::SetData( Int_t adc, Int_t* const data )
+void AliTRDmcmSim::SetData( Int_t adc, const Int_t* const data )
 {
   //
   // Store ADC data into array of raw data
@@ -591,7 +591,7 @@ void AliTRDmcmSim::SetData(AliTRDarrayADC* const adcArray, AliTRDdigitsManager *
   }
 }
 
-void AliTRDmcmSim::SetDataByPad(AliTRDarrayADC* const adcArray, AliTRDdigitsManager * const digitsManager)
+void AliTRDmcmSim::SetDataByPad(const AliTRDarrayADC* const adcArray, AliTRDdigitsManager * const digitsManager)
 {
   // Set the ADC data from an AliTRDarrayADC
   // (by pad, to be used during initial reading in simulation)

diff --git a/TRD/AliTRDmcmSim.h b/TRD/AliTRDmcmSim.h
index 3b59d3dcd0859d4d7ae87ea4cc48db3d9fbeea90..de4da5c3cb93eabe151fe9984a43e76a33009ce5 100644 (file)
--- a/TRD/AliTRDmcmSim.h
+++ b/TRD/AliTRDmcmSim.h
@@ -44,11 +44,11 @@ class AliTRDmcmSim : public TObject {
          Int_t     GetDataFiltered(Int_t iadc, Int_t timebin) const { return (fADCF[iadc][timebin] >> 2); }
          // Get filtered ADC data
 
-          void      SetData(Int_t iadc, Int_t *adc);           // Set ADC data with array
+          void      SetData(Int_t iadc, const Int_t* const adc);           // Set ADC data with array
           void      SetData(Int_t iadc, Int_t it, Int_t adc); // Set ADC data
          void      SetData(AliTRDarrayADC * const adcArray,
                            AliTRDdigitsManager * const digitsManager = 0x0);         // Set ADC data from adcArray
-         void      SetDataByPad(AliTRDarrayADC *const adcArray,
+         void      SetDataByPad(const AliTRDarrayADC *const adcArray,
                                 AliTRDdigitsManager * const digitsManager = 0x0);    // Set ADC data from adcArray
           void      SetDataPedestal(Int_t iadc);              // Fill ADC data with pedestal values
 
@@ -72,7 +72,7 @@ class AliTRDmcmSim : public TObject {
 
          void      WriteData(AliTRDarrayADC *digits);
          Bool_t    StoreTracklets();                          // Stores tracklets via runloader
-         TString   GetTrklBranchName() { return fTrklBranchName; }
+         TString   GetTrklBranchName() const { return fTrklBranchName; }
          void      SetTrklBranchName(TString name) { fTrklBranchName = name; }
 
          Int_t     ProduceRawStream( UInt_t *buf, Int_t bufsize, UInt_t iEv = 0 ) const; // Produce raw data stream - Real data format

diff --git a/TRD/AliTRDrawStream.cxx b/TRD/AliTRDrawStream.cxx
index b33bec2aab851f1c7373b486b76bd65a442ba659..021e6f3a4bbd7d732ada94bdca3d40ab8542d8fb 100644 (file)
--- a/TRD/AliTRDrawStream.cxx
+++ b/TRD/AliTRDrawStream.cxx
@@ -1090,7 +1090,7 @@ Int_t AliTRDrawStream::ReadStackHeader(Int_t stack)
   AliDebug(1, DumpRaw(Form("stack %i header", stack), fPayloadCurr, fCurrStackHeaderSize[stack]));
 
   if (fPayloadCurr - fPayloadStart >= fPayloadSize - (Int_t) fCurrStackHeaderSize[stack]) {
-    EquipmentError(kStackHeaderInvalid, "Stack index header %i aborted", stack);
+    EquipmentError(kStackHeaderInvalid, "Stack index header %i incomplete", stack);
     // dumping stack header
     AliError(DumpRaw(Form("stack %i header", stack), fPayloadCurr, fCurrStackHeaderSize[stack]));
 
@@ -2152,7 +2152,7 @@ Bool_t AliTRDrawStream::DumpingMCM(Int_t det, Int_t rob, Int_t mcm)  const
   return kFALSE;
 }
 
-TString AliTRDrawStream::DumpRaw(TString title, UInt_t *start, Int_t length, UInt_t endmarker)
+TString AliTRDrawStream::DumpRaw(TString title, const UInt_t *start, Int_t length, UInt_t endmarker)
 {
   // dump raw data
 

diff --git a/TRD/AliTRDrawStream.h b/TRD/AliTRDrawStream.h
index c436ec0e5c5548377c2dc4c8f442cf1161d49fdb..c078f91150caef7876297d33ac03b3d4280c6f21 100644 (file)
--- a/TRD/AliTRDrawStream.h
+++ b/TRD/AliTRDrawStream.h
@@ -11,12 +11,11 @@
 #ifndef ALITRDRAWSTREAM_H
 #define ALITRDRAWSTREAM_H
 
-#include "TObject.h"
-#include "TClonesArray.h"
 #include "TTree.h"
-
 #include "AliLog.h"
+#include "TClonesArray.h"
 
+class TObject;
 class TObjArray;
 class TString;
 class TBranch;
@@ -172,7 +171,7 @@ class AliTRDrawStream : public TObject
   Bool_t IsDumping() const { return (fNDumpMCMs > 0); }
   Bool_t DumpingMCM(Int_t det, Int_t rob, Int_t mcm) const;
 
-  TString DumpRaw(TString title, UInt_t *start, Int_t length, UInt_t endmarker = 0xffffffff);
+  TString DumpRaw(TString title, const UInt_t *start, Int_t length, UInt_t endmarker = 0xffffffff);
   TString DumpMcmHeader(TString title, UInt_t word);
   TString DumpAdcMask(TString title, UInt_t word);
 

diff --git a/TRD/AliTRDtrackletMCM.cxx b/TRD/AliTRDtrackletMCM.cxx
index ff4cbfda642cadbc785fa9a7691d5507f9020659..f46a7a204525d506d4ecfda1bb8ed5fb56e2ec91 100644 (file)
--- a/TRD/AliTRDtrackletMCM.cxx
+++ b/TRD/AliTRDtrackletMCM.cxx
@@ -47,6 +47,8 @@ AliTRDtrackletMCM::AliTRDtrackletMCM(UInt_t trackletWord) :
   fResiduals(0x0),
   fClsCharges(0x0)
 {
+  // constructor
+
     fGeo = new AliTRDgeometry();
     fLabel[0] = -1;
     fLabel[1] = -1;
@@ -72,6 +74,8 @@ AliTRDtrackletMCM::AliTRDtrackletMCM(UInt_t trackletWord, Int_t hcid) :
   fResiduals(0x0),
   fClsCharges(0x0)
 {
+  // constructor
+
     fGeo = new AliTRDgeometry();
     fLabel[0] = -1;
     fLabel[1] = -1;
@@ -97,6 +101,8 @@ AliTRDtrackletMCM::AliTRDtrackletMCM(UInt_t trackletWord, Int_t hcid, Int_t rob,
   fResiduals(0x0),
   fClsCharges(0x0)
 {
+  // constructor
+
     fGeo = new AliTRDgeometry();
     fLabel[0] = -1;
     fLabel[1] = -1;
@@ -122,6 +128,8 @@ AliTRDtrackletMCM::AliTRDtrackletMCM(const AliTRDtrackletMCM &rhs) :
   fResiduals(0x0),
   fClsCharges(0x0)
 {
+  // copy constructor
+
     fGeo = new AliTRDgeometry();
     fResiduals = new Float_t[fNClusters];
     fClsCharges = new Float_t[fNClusters];
@@ -136,6 +144,8 @@ AliTRDtrackletMCM::AliTRDtrackletMCM(const AliTRDtrackletMCM &rhs) :
 
 AliTRDtrackletMCM::~AliTRDtrackletMCM()
 {
+  // destructor
+
   delete [] fResiduals;
   delete [] fClsCharges;
     delete fGeo;
@@ -164,6 +174,8 @@ Int_t AliTRDtrackletMCM::GetdY() const
 
 void AliTRDtrackletMCM::SetLabel(Int_t label[])
 {
+  // set the labels (up to 3)
+
   fLabel[0] = label[0];
   fLabel[1] = label[1];
   fLabel[2] = label[2];

diff --git a/TRD/AliTRDtrapConfig.cxx b/TRD/AliTRDtrapConfig.cxx
index bd53e949f4d82f056685ae32aa169cadd80742d6..cde01f70a520d18134e9fcc2d19b0790b0fc43b5 100644 (file)
--- a/TRD/AliTRDtrapConfig.cxx
+++ b/TRD/AliTRDtrapConfig.cxx
@@ -555,6 +555,8 @@ AliTRDtrapConfig* AliTRDtrapConfig::Instance()
 
 AliTRDtrapConfig::~AliTRDtrapConfig()
 {
+  // destructor
+
   for(Int_t iAddr = 0; iAddr < fgkDmemWords; iAddr++) {
      if(iAddr == fgkDmemAddrDeflCorr - fgkDmemStartAddress)
        delete [] fDmem[iAddr];
@@ -621,6 +623,8 @@ void AliTRDtrapConfig::ResetRegs()
 
 void AliTRDtrapConfig::ResetDmem()
 {
+  // reset the data memory
+
      for(Int_t iAddr = 0; iAddr < fgkDmemWords; iAddr++) {
        if(fDmemDepth[iAddr] == 0)
           continue;
@@ -935,6 +939,9 @@ Bool_t AliTRDtrapConfig::SetDmem(Int_t addr, UInt_t value, Int_t det, Int_t rob,
 
 UInt_t AliTRDtrapConfig::GetDmemUnsigned(Int_t addr) const
 {
+  // get the content of the data memory at the given address
+  // (only if the value is the same for all MCMs)
+
    addr = addr - fgkDmemStartAddress;
    if(addr < 0 || addr >=  fgkDmemWords) {
       AliError(Form("No DMEM address: 0x%08x", addr+fgkDmemStartAddress));
@@ -952,6 +959,9 @@ UInt_t AliTRDtrapConfig::GetDmemUnsigned(Int_t addr) const
 
 UInt_t AliTRDtrapConfig::GetDmemUnsigned(Int_t addr, Int_t det, Int_t rob, Int_t mcm) const
 {
+  // get the content of the data memory at the given address
+  // for a given MCM
+
    addr = addr - fgkDmemStartAddress;
    Int_t roc = det%30;
    Int_t loc;
@@ -1290,11 +1300,15 @@ AliTRDtrapConfig::TrapReg_t AliTRDtrapConfig::GetRegByAddress(Int_t address) con
 
 void AliTRDtrapConfig::PrintMemDatx(ostream &os, Int_t addr) const
 {
+  // print the content of the data memory as datx
+
    PrintMemDatx(os, addr, 0, 0, 127);
 }
 
 void AliTRDtrapConfig::PrintMemDatx(ostream &os, Int_t addr, Int_t det, Int_t rob, Int_t mcm) const
 {
+  // print the content of the data memory as datx
+
    if(addr < fgkDmemStartAddress || addr >= fgkDmemStartAddress+fgkDmemWords) {
       AliError(Form("Invalid DMEM address 0x%08x!", addr));
       return;
@@ -1305,12 +1319,16 @@ void AliTRDtrapConfig::PrintMemDatx(ostream &os, Int_t addr, Int_t det, Int_t ro
 
 void AliTRDtrapConfig::PrintMemDatx(ostream &os, TrapReg_t reg) const
 {
+  // print the content of the data memory as datx
+
    PrintMemDatx(os, reg, 0, 0, 127);
 }
 
 
 void AliTRDtrapConfig::PrintMemDatx(ostream &os, TrapReg_t reg, Int_t det, Int_t rob, Int_t mcm) const
 {
+  // print the content of the data memory as datx
+
    if(reg>= kLastReg) {
       AliError(Form("Invalid register %i!", reg));
       return;
@@ -1321,6 +1339,8 @@ void AliTRDtrapConfig::PrintMemDatx(ostream &os, TrapReg_t reg, Int_t det, Int_t
 
 void AliTRDtrapConfig::PrintDatx(ostream &os, UInt_t addr, UInt_t data, Int_t rob, Int_t mcm) const
 {
+  // print the value at the given address as datx
+
    os << std::setw(5) << 10
       << std::setw(8) << addr
       << std::setw(12) << data;

diff --git a/TRD/AliTRDtrapConfig.h b/TRD/AliTRDtrapConfig.h
index ddf77869158daa3141badbe0ee1116721542bca0..1e0126fba99bde66e7c0be3a8cf1978f32c37826 100644 (file)
--- a/TRD/AliTRDtrapConfig.h
+++ b/TRD/AliTRDtrapConfig.h
@@ -500,9 +500,9 @@ class AliTRDtrapConfig : public TObject
   Bool_t AddValues(UInt_t det, UInt_t cmd, UInt_t extali, Int_t addr, UInt_t data);
 
   // DMEM addresses
-  static const Int_t fgkDmemAddrLUTcor0       = 0xC02A;
-  static const Int_t fgkDmemAddrLUTcor1       = 0xC028;
-  static const Int_t fgkDmemAddrLUTnbins      = 0xC029;
+  static const Int_t fgkDmemAddrLUTcor0       = 0xC02A; // address for correction factor 0
+  static const Int_t fgkDmemAddrLUTcor1       = 0xC028; // address for correction factor 1
+  static const Int_t fgkDmemAddrLUTnbins      = 0xC029; // address for number of timebins
 
   static const Int_t fgkDmemAddrLUTStart      = 0xC100; // LUT start address
   static const Int_t fgkDmemAddrLUTEnd        = 0xC3FF; // maximum possible end address for the LUT table
@@ -557,8 +557,8 @@ class AliTRDtrapConfig : public TObject
   UInt_t* fDmem[fgkDmemWords]; // DMEM storage
   Int_t fDmemDepth[fgkDmemWords]; // memory space indicator for fDmem
 
-  static const Int_t fgkDmemSizeEmpty=0;
-  static const   Int_t fgkDmemSizeUniform = 1;
+  static const Int_t fgkDmemSizeEmpty=0; // size if no value stored
+  static const   Int_t fgkDmemSizeUniform = 1; // size for global values
   static const   Int_t fgkDmemSizeSmIndividual = 30*8*16;   // storage for each MCM within one supermodule
   static const   Int_t fgkDmemSizeTotalIndividual = 540*6*8*16;  // one individual value for each and every MCM in the TRD
   static const   Int_t fgkDmemSizeSmRocIndividual = 540; // one individual value for each chamber in TRD

diff --git a/TRD/AliTRDtrapConfigHandler.h b/TRD/AliTRDtrapConfigHandler.h
index 7d2ea6c35e80c270e12e79f4b1bb20cde5222a58..2e9d2517d1031860f066f513992d4b916e85b177 100644 (file)
--- a/TRD/AliTRDtrapConfigHandler.h
+++ b/TRD/AliTRDtrapConfigHandler.h
@@ -38,7 +38,7 @@ class AliTRDtrapConfigHandler : public TObject {
   void  ConfigureNTimebins(Int_t det);                          // timebins in the drift region
   void  ConfigurePIDcorr(Int_t det);                            // Calculate the mcm individual correction factors for the PID
 
-  Double_t Square(Double_t val) { return val*val; };          // returns the square of a given number
+  Double_t Square(Double_t val) const { return val*val; };          // returns the square of a given number
 
   AliTRDtrapConfigHandler(const AliTRDtrapConfigHandler &h);             // not implemented
   AliTRDtrapConfigHandler &operator=(const AliTRDtrapConfigHandler &h);  // not implemented