coverity

diff --git a/PWG1/TPC/AliPerformanceEff.cxx b/PWG1/TPC/AliPerformanceEff.cxx
index 667cbcd9a2bb3e3b151f6f983cda6bc64027c14a..162544ca58a3741ce51056fc95f43ded51763f65 100644 (file)
--- a/PWG1/TPC/AliPerformanceEff.cxx
+++ b/PWG1/TPC/AliPerformanceEff.cxx
@@ -188,7 +188,6 @@ void AliPerformanceEff::Init()
 void AliPerformanceEff::ProcessTPC(AliMCEvent* const mcEvent, AliESDEvent *const esdEvent)\r
 {\r
   // Fill TPC only efficiency comparison information \r
-  if(!mcEvent) return;\r
   if(!esdEvent) return;\r
 \r
   Int_t *labelsRec =  NULL;\r
@@ -315,7 +314,6 @@ void AliPerformanceEff::ProcessTPCSec(AliMCEvent* const mcEvent, AliESDEvent *co
 {\r
   // Fill TPC only efficiency comparison information for secondaries\r
 \r
-  if(!mcEvent) return;\r
   if(!esdEvent) return;\r
 \r
   Int_t *labelsRec =  NULL;\r
@@ -453,25 +451,23 @@ void AliPerformanceEff::ProcessTPCSec(AliMCEvent* const mcEvent, AliESDEvent *co
 void AliPerformanceEff::ProcessTPCITS(AliMCEvent* const mcEvent, AliESDEvent *const esdEvent)\r
 {\r
   // Fill efficiency comparison information\r
-  if(!mcEvent) return;\r
-  if(!esdEvent) return;\r
 \r
-  Int_t *labelsRec =  NULL;\r
-  labelsRec =  new Int_t[esdEvent->GetNumberOfTracks()];\r
-  if(!labelsRec) \r
+  Int_t *labelsRecTPCITS =  NULL;\r
+  labelsRecTPCITS =  new Int_t[esdEvent->GetNumberOfTracks()];\r
+  if(!labelsRecTPCITS) \r
   {\r
-     Printf("Cannot create labelsRec");\r
+     Printf("Cannot create labelsRecTPCITS");\r
      return;\r
   }\r
-  for(Int_t i=0;i<esdEvent->GetNumberOfTracks();i++) { labelsRec[i] = 0; }\r
+  for(Int_t i=0;i<esdEvent->GetNumberOfTracks();i++) { labelsRecTPCITS[i] = 0; }\r
 \r
-  Int_t *labelsAllRec =  NULL;\r
-  labelsAllRec =  new Int_t[esdEvent->GetNumberOfTracks()];\r
-  if(!labelsAllRec) { \r
-     Printf("Cannot create labelsAllRec");\r
+  Int_t *labelsAllRecTPCITS =  NULL;\r
+  labelsAllRecTPCITS =  new Int_t[esdEvent->GetNumberOfTracks()];\r
+  if(!labelsAllRecTPCITS) { \r
+     Printf("Cannot create labelsAllRecTPCITS");\r
      return;\r
   }\r
-  for(Int_t i=0;i<esdEvent->GetNumberOfTracks();i++) { labelsAllRec[i] = 0; }\r
+  for(Int_t i=0;i<esdEvent->GetNumberOfTracks();i++) { labelsAllRecTPCITS[i] = 0; }\r
 \r
   // loop over rec. tracks\r
   AliESDtrack *track=0;\r
@@ -485,11 +481,11 @@ void AliPerformanceEff::ProcessTPCITS(AliMCEvent* const mcEvent, AliESDEvent *co
     if(!fUseKinkDaughters && track->GetKinkIndex(0) > 0) continue;\r
 \r
     Int_t label = TMath::Abs(track->GetLabel()); \r
-    labelsAllRec[iTrack]=label;\r
+    labelsAllRecTPCITS[iTrack]=label;\r
 \r
     // iTPC+ITS\r
     if(IsRecTPCITS(track) != 0) \r
-      labelsRec[iTrack]=label;\r
+      labelsRecTPCITS[iTrack]=label;\r
   }\r
 \r
   // \r
@@ -520,7 +516,7 @@ void AliPerformanceEff::ProcessTPCITS(AliMCEvent* const mcEvent, AliESDEvent *co
     for(Int_t iRec=0; iRec<esdEvent->GetNumberOfTracks(); ++iRec) \r
     {\r
       // check findable\r
-      if(iMc == labelsAllRec[iRec]) \r
+      if(iMc == labelsAllRecTPCITS[iRec]) \r
       {\r
         findable = IsFindable(mcEvent,iMc);\r
        break;\r
@@ -531,7 +527,7 @@ void AliPerformanceEff::ProcessTPCITS(AliMCEvent* const mcEvent, AliESDEvent *co
     for(Int_t iRec=0; iRec<esdEvent->GetNumberOfTracks(); ++iRec) \r
     {\r
       // check reconstructed\r
-      if(iMc == labelsRec[iRec]) \r
+      if(iMc == labelsRecTPCITS[iRec]) \r
       {\r
         recStatus = kTRUE;\r
         break;\r
@@ -558,33 +554,32 @@ void AliPerformanceEff::ProcessTPCITS(AliMCEvent* const mcEvent, AliESDEvent *co
     fEffHisto->Fill(vEffHisto);\r
   }\r
 \r
-  if(labelsRec) delete [] labelsRec; labelsRec = 0;\r
-  if(labelsAllRec) delete [] labelsAllRec; labelsAllRec = 0;\r
+  if(labelsRecTPCITS) delete [] labelsRecTPCITS; labelsRecTPCITS = 0;\r
+  if(labelsAllRecTPCITS) delete [] labelsAllRecTPCITS; labelsAllRecTPCITS = 0;\r
 }\r
 \r
 //_____________________________________________________________________________\r
 void AliPerformanceEff::ProcessConstrained(AliMCEvent* const mcEvent, AliESDEvent *const esdEvent)\r
 {\r
   // Process comparison information \r
-  if(!mcEvent) return;\r
   if(!esdEvent) return;\r
 \r
-  Int_t *labelsRec =  NULL;\r
-  labelsRec =  new Int_t[esdEvent->GetNumberOfTracks()];\r
-  if(!labelsRec) \r
+  Int_t *labelsRecConstrained =  NULL;\r
+  labelsRecConstrained =  new Int_t[esdEvent->GetNumberOfTracks()];\r
+  if(!labelsRecConstrained) \r
   {\r
-     Printf("Cannot create labelsRec");\r
+     Printf("Cannot create labelsRecConstrained");\r
      return;\r
   }\r
-  for(Int_t i=0;i<esdEvent->GetNumberOfTracks();i++) { labelsRec[i] = 0; }\r
+  for(Int_t i=0;i<esdEvent->GetNumberOfTracks();i++) { labelsRecConstrained[i] = 0; }\r
 \r
-  Int_t *labelsAllRec =  NULL;\r
-  labelsAllRec =  new Int_t[esdEvent->GetNumberOfTracks()];\r
-  if(!labelsAllRec) { \r
-     Printf("Cannot create labelsAllRec");\r
+  Int_t *labelsAllRecConstrained =  NULL;\r
+  labelsAllRecConstrained =  new Int_t[esdEvent->GetNumberOfTracks()];\r
+  if(!labelsAllRecConstrained) { \r
+     Printf("Cannot create labelsAllRecConstrained");\r
      return;\r
   }\r
-  for(Int_t i=0;i<esdEvent->GetNumberOfTracks();i++) { labelsAllRec[i] = 0; }\r
+  for(Int_t i=0;i<esdEvent->GetNumberOfTracks();i++) { labelsAllRecConstrained[i] = 0; }\r
 \r
   // loop over rec. tracks\r
   AliESDtrack *track=0;\r
@@ -598,11 +593,11 @@ void AliPerformanceEff::ProcessConstrained(AliMCEvent* const mcEvent, AliESDEven
     if(!fUseKinkDaughters && track->GetKinkIndex(0) > 0) continue;\r
 \r
     Int_t label = TMath::Abs(track->GetLabel()); \r
-    labelsAllRec[iTrack]=label;\r
+    labelsAllRecConstrained[iTrack]=label;\r
 \r
     // Constrained\r
     if(IsRecConstrained(track) != 0) \r
-      labelsRec[iTrack]=label;\r
+      labelsRecConstrained[iTrack]=label;\r
 \r
   }\r
 \r
@@ -634,7 +629,7 @@ void AliPerformanceEff::ProcessConstrained(AliMCEvent* const mcEvent, AliESDEven
     for(Int_t iRec=0; iRec<esdEvent->GetNumberOfTracks(); ++iRec) \r
     {\r
       // check findable\r
-      if(iMc == labelsAllRec[iRec]) \r
+      if(iMc == labelsAllRecConstrained[iRec]) \r
       {\r
         findable = IsFindable(mcEvent,iMc);\r
        break;\r
@@ -645,7 +640,7 @@ void AliPerformanceEff::ProcessConstrained(AliMCEvent* const mcEvent, AliESDEven
     for(Int_t iRec=0; iRec<esdEvent->GetNumberOfTracks(); ++iRec) \r
     {\r
       // check reconstructed\r
-      if(iMc == labelsRec[iRec]) \r
+      if(iMc == labelsRecConstrained[iRec]) \r
       {\r
         recStatus = kTRUE;\r
         break;\r
@@ -672,8 +667,8 @@ void AliPerformanceEff::ProcessConstrained(AliMCEvent* const mcEvent, AliESDEven
     fEffHisto->Fill(vEffHisto);\r
   }\r
 \r
-  if(labelsRec) delete [] labelsRec; labelsRec = 0;\r
-  if(labelsAllRec) delete [] labelsAllRec; labelsAllRec = 0;\r
+  if(labelsRecConstrained) delete [] labelsRecConstrained; labelsRecConstrained = 0;\r
+  if(labelsAllRecConstrained) delete [] labelsAllRecConstrained; labelsAllRecConstrained = 0;\r
 }\r
 \r
 //_____________________________________________________________________________\r

diff --git a/PWG1/TPC/AliPerformanceRes.cxx b/PWG1/TPC/AliPerformanceRes.cxx
index 16b33fb9fa04825891cc9efd25c1540421607f7f..72d1c76c1782a57cda8c5c8c3f305de07627d077 100644 (file)
--- a/PWG1/TPC/AliPerformanceRes.cxx
+++ b/PWG1/TPC/AliPerformanceRes.cxx
@@ -915,8 +915,6 @@ void AliPerformanceRes::Exec(AliMCEvent* const mcEvent, AliESDEvent *const esdEv
       if(!friendTrack) continue;
     }
 
-    // check stack
-    if(!stack) continue;
     Int_t label = TMath::Abs(track->GetLabel()); 
     if ( label > stack->GetNtrack() ) 
     {

diff --git a/PWG1/TPC/AliRecInfoMaker.cxx b/PWG1/TPC/AliRecInfoMaker.cxx
index e69a2c25c30a5e88d2586649a46da8c0ef9b0fc9..13c562cbeabb5467270e17c592ef95b030919f6b 100644 (file)
--- a/PWG1/TPC/AliRecInfoMaker.cxx
+++ b/PWG1/TPC/AliRecInfoMaker.cxx
@@ -881,11 +881,15 @@ Int_t AliRecInfoMaker::TreeGenLoop(Int_t eventNr)
        }
       }        
       //
+      fRecInfo->SetESDtrack(track);
+
+      /*
       if (track) {
        fRecInfo->SetESDtrack(track);
       }else{
        fRecInfo->SetESDtrack(&dummytrack);
       }
+      */
       //
 
       fRecInfo->fReconstructed = 1;

diff --git a/PWG1/TPC/AliTPCPerformanceSummary.cxx b/PWG1/TPC/AliTPCPerformanceSummary.cxx
index 4b68af5ae6703b1e42b77f8e2b97b89e8b52b2b4..cf200c0c7ec09566a251abe10d76ad0707078ac2 100644 (file)
--- a/PWG1/TPC/AliTPCPerformanceSummary.cxx
+++ b/PWG1/TPC/AliTPCPerformanceSummary.cxx
@@ -1295,6 +1295,7 @@ Int_t AliTPCPerformanceSummary::AnalyzeEvent(const AliPerformanceTPC* pTPC, TTre
     static Double_t vertOK = 0;
     
     TH1* his1D=0;
+    TH1* hc=0;
     if (pTPC->GetHistos()->FindObject("h_tpc_event_6") && !fgForceTHnSparse) {    
         his1D = dynamic_cast<TH1*>(pTPC->GetHistos()->FindObject("h_tpc_event_6")->Clone());
     } else {
@@ -1339,18 +1340,25 @@ Int_t AliTPCPerformanceSummary::AnalyzeEvent(const AliPerformanceTPC* pTPC, TTre
     
     
     if (pTPC->GetHistos()->FindObject("h_tpc_event_recvertex_2") && !fgForceTHnSparse) {    
-        his1D = dynamic_cast<TH1*>(pTPC->GetHistos()->FindObject("h_tpc_event_recvertex_2")->Clone());
+        hc = dynamic_cast<TH1*>(pTPC->GetHistos()->FindObject("h_tpc_event_recvertex_2"));
+       if(!hc) return 1;
+        //his1D = dynamic_cast<TH1*>(pTPC->GetHistos()->FindObject("h_tpc_event_recvertex_2")->Clone());
+        his1D = (TH1*)hc->Clone();
     } else {
        his1D = pTPC->GetTPCEventHisto()->Projection(2);
-    }    meanVertZ = his1D->GetMean();
+    }    
     if(!his1D) return 1;
 
+    meanVertZ = his1D->GetMean();
     rmsVertZ    = his1D->GetRMS();
     delete his1D;
     
     
     if (pTPC->GetHistos()->FindObject("h_tpc_event_recvertex_3") && !fgForceTHnSparse) {    
-        his1D = dynamic_cast<TH1*>(pTPC->GetHistos()->FindObject("h_tpc_event_recvertex_3")->Clone());
+        hc = dynamic_cast<TH1*>(pTPC->GetHistos()->FindObject("h_tpc_event_recvertex_3"));
+       if(!hc) return 1;
+        //his1D = dynamic_cast<TH1*>(pTPC->GetHistos()->FindObject("h_tpc_event_recvertex_3")->Clone());
+        his1D = (TH1*)hc->Clone();
     } else {
        his1D = pTPC->GetTPCEventHisto()->Projection(3);
     }

diff --git a/PWG1/TPC/AliTreeDraw.cxx b/PWG1/TPC/AliTreeDraw.cxx
index aac4026ce19563c2f3e324c95d4571b7a414c881..0f832f171e04ce79c4cc440988cdb3f38604ce75 100644 (file)
--- a/PWG1/TPC/AliTreeDraw.cxx
+++ b/PWG1/TPC/AliTreeDraw.cxx
@@ -150,7 +150,7 @@ TH1F * AliTreeDraw::Eff(const char *variable, const char* selection, const char
   snprintf(inputGen,1000,"%s>>hGen", variable);
   fTree->Draw(inputGen, selection, "groff");
   char selectionRec[256];
-  snprintf(selectionRec,1000, "%s && %s", selection, quality);
+  snprintf(selectionRec,256, "%s && %s", selection, quality);
   char inputRec[1000];  
   snprintf(inputRec,1000,"%s>>hRec", variable);
   fTree->Draw(inputRec, selectionRec, "groff");
@@ -179,7 +179,7 @@ TH1F * AliTreeDraw::EffLog(const char *variable, const char* selection, const ch
   snprintf(inputGen,1000,"%s>>hGen", variable);
   fTree->Draw(inputGen, selection, "groff");
   char selectionRec[256];
-  snprintf(selectionRec,1000, "%s && %s", selection, quality);
+  snprintf(selectionRec,256, "%s && %s", selection, quality);
   char inputRec[1000];  
   snprintf(inputRec,1000,"%s>>hRec", variable);
   fTree->Draw(inputRec, selectionRec, "groff");