Some violations for AliRICHParam checked

diff --git a/RICH/AliRICHParam.cxx b/RICH/AliRICHParam.cxx
index 51ba87e41a3294662fc4c6ef9132f8d73abf1134..5583c548fad55a04baf5d2d82040b1a5623db5ce 100644 (file)
--- a/RICH/AliRICHParam.cxx
+++ b/RICH/AliRICHParam.cxx
@@ -40,6 +40,7 @@ Float_t  AliRICHParam::fgSigmaThSpread        =0.035; //
 //__________________________________________________________________________________________________
 void AliRICHParam::Print(Option_t*) const
 {
+//print some usefull (hopefully) info on some internal guts of RICH parametrisation 
   AliInfo(Form("Pads in chamber (%3i,%3i) in sector (%2i,%2i) pad size (%4.2f,%4.2f)",NpadsX(),NpadsY(),NpadsXsec(),NpadsYsec(),PadSizeX(),PadSizeY()));
   AliInfo(Form("Resolve clusters %i sagita %i Radio source %i Aerogel %i TestBeam %i",
                 IsResolveClusters(),IsWireSag(),IsRadioSrc(),IsAerogel(),IsTestBeam())); 
@@ -84,7 +85,8 @@ Float_t AliRICHParam::AbsCH4(Float_t eV)
 }//AbsoCH4()
 //__________________________________________________________________________________________________
 void AliRICHParam::TestSeg()
-{  
+{
+//Provides a set of pictures to test segementation currently in use.    
   new TCanvas("pads","PC segmentation - pads display",700,600);
   gPad->Range(-5,-5,PcSizeX()+5,PcSizeY()+15);
   TVector p(2);   TVector2 c;    TVector2 b;   //current: pad, pad center, pad boundary
@@ -141,22 +143,22 @@ void AliRICHParam::TestSeg()
 //__________________________________________________________________________________________________
 void AliRICHParam::TestResp()
 {
-//test the response set of methodes  
+//Provides a set of plot to check the response parametrisation currently in use.  
   TCanvas *pC=new TCanvas("c","Amplification test",900,800);
   pC->Divide(1,2);
   
   
-  const Int_t nPoints=8;
+  const Int_t kNpoints=8;
   THStack *pStackPhot=new THStack("StackPhot","photons");
   THStack *pStackMip =new THStack("StackMip","mips");
   TLegend *pLeg=new TLegend(0.6,0.2,0.9,0.5,"legend");    
-  TH1F *apHphot[nPoints];
-  TH1F *apHmip[nPoints];
+  TH1F *apHphot[kNpoints];
+  TH1F *apHmip[kNpoints];
   
   Double_t starty=0;
-  Double_t deltay=AliRICHParam::SectorSizeY()/nPoints;
+  Double_t deltay=AliRICHParam::SectorSizeY()/kNpoints;
   
-  for(int i=0;i<nPoints;i++){
+  for(int i=0;i<kNpoints;i++){
     apHphot[i]=new TH1F(Form("hphot%i",i),"Qdc for Photon;QDC;Counts",500,0,500); apHphot[i]->SetLineColor(i);pStackPhot->Add(apHphot[i]);                 
     apHmip[i] =new TH1F(Form("hmip%i",i),"Qdc for Mip;QDC;Counts",4000,0,4000);   apHmip[i]->SetLineColor(i);pStackMip->Add(apHmip[i]);                 
     
@@ -166,7 +168,7 @@ void AliRICHParam::TestResp()
   
   TVector2 x2(0,0);  
   for(Int_t i=0;i<10000;i++){//events loop
-    for(int j=0;j<nPoints;j++){
+    for(int j=0;j<kNpoints;j++){
       x2.Set(10,starty+j*deltay);
       apHphot[j]->Fill(TotQdc(x2,0));
       apHmip[j]->Fill(TotQdc(x2,gRandom->Landau(600,150)*1e-9));
@@ -179,7 +181,7 @@ void AliRICHParam::TestResp()
 //__________________________________________________________________________________________________
 void AliRICHParam::TestTrans()
 {
-//test the set of transformation methods
+//Provides a set of plots to test transformation methods
   new TCanvas("trasform","Test LRS-MRS transform");
   TLatex t; t.SetTextSize(0.02);
   
@@ -206,14 +208,16 @@ void AliRICHParam::TestTrans()
 //__________________________________________________________________________________________________
 void AliRICHParam::DrawAxis()
 {
-  Double_t X[6]={0,0,0,300,0,0};  Double_t Y[6]={0,0,0,0,300,0};  Double_t Z[6]={0,0,0,0,0,300};  
-  TPolyLine3D *pXaxis=new TPolyLine3D(2,X);pXaxis->SetLineColor(kRed);   pXaxis->Draw();
-  TPolyLine3D *pYaxis=new TPolyLine3D(2,Y);pYaxis->SetLineColor(kGreen); pYaxis->Draw();
-  TPolyLine3D *pZaxis=new TPolyLine3D(2,Z);pZaxis->SetLineColor(kBlue);  pZaxis->Draw();  
+//Utility: draws axis on geometry scene  
+  Double_t x[6]={0,0,0,300,0,0};  Double_t y[6]={0,0,0,0,300,0};  Double_t z[6]={0,0,0,0,0,300};  
+  TPolyLine3D *pXaxis=new TPolyLine3D(2,x);pXaxis->SetLineColor(kRed);   pXaxis->Draw();
+  TPolyLine3D *pYaxis=new TPolyLine3D(2,y);pYaxis->SetLineColor(kGreen); pYaxis->Draw();
+  TPolyLine3D *pZaxis=new TPolyLine3D(2,z);pZaxis->SetLineColor(kBlue);  pZaxis->Draw();  
 }
 //__________________________________________________________________________________________________
 void AliRICHParam::DrawSectors() 
 { 
+//Utility: draws RICH chamber sectors on event display.
   Double_t xLeft[5]  = {0,0,SectorSizeX(),SectorSizeX(),0};
   Double_t xRight[5] = {SectorSizeX()+DeadZone(),SectorSizeX()+DeadZone(),PcSizeX(),PcSizeX(),SectorSizeX()+DeadZone()};
   

diff --git a/RICH/AliRICHParam.h b/RICH/AliRICHParam.h
index 8053d39d3bcc150a6282ba0b13c2fb57e271206c..e69fab0d9ed662afffa74aed51b3a051b2cb6180 100644 (file)
--- a/RICH/AliRICHParam.h
+++ b/RICH/AliRICHParam.h
@@ -28,6 +28,11 @@ static const int kFeedback=50000051;  //??? go to something more general like TP
 
 class AliRICHChamber;
 
+// Class providing all the needed parametrised information
+// to construct the geometry, to define segmentation and to provide response model
+// In future will also provide all the staff needed for alignment and calibration
+
+
 class AliRICHParam :public TObject  
 {
 public:
@@ -86,13 +91,7 @@ public:
   static TVector2 MathiesonDelta()           {return TVector2(5*0.18,5*0.18);}            //area of 5 sigmas of Mathieson distribution (cm)
   static Int_t    MaxQdc()                   {return 4095;}                               //QDC number of channels          
   
-  static Int_t    HV(Int_t sector)           {
-    if (sector>=1 && sector <=6)
-      return fgHV[sector-1];
-    else {
-      return kBad;
-    } 
-  }       //high voltage for this sector
+  static Int_t    HV(Int_t sector)           {if (sector>=1 && sector <=6) return fgHV[sector-1];  else return kBad;} //high voltage for this sector
   static void     SetHV(Int_t sector,Int_t hv){fgHV[sector-1]=hv;}  
 //optical properties methodes  
   static Float_t  PhotonEnergy(Int_t i)    {return 0.1*i+5.5;}             //photon energy (eV) for i-th point
@@ -129,7 +128,7 @@ public:
          static Float_t  SigmaThMean()                 {return fgSigmaThMean;}                     //QDC electronic noise mean
          static Float_t  SigmaThSpread()               {return fgSigmaThSpread;}                   //QDC electronic noise width
                 
-  inline static Double_t CogCorr(Double_t x) {return 3.31267e-2*TMath::Sin(2*TMath::Pi()/PadSizeX()*x) //correction of cluster CoG due to sinoidal
+         static Double_t CogCorr(Double_t x) {return 3.31267e-2*TMath::Sin(2*TMath::Pi()/PadSizeX()*x) //correction of cluster CoG due to sinoidal
                                                     -2.66575e-3*TMath::Sin(4*TMath::Pi()/PadSizeX()*x)
                                                     +2.80553e-3*TMath::Sin(6*TMath::Pi()/PadSizeX()*x);}