Fixes for coverity

diff --git a/ZDC/AliZDCDigitizer.cxx b/ZDC/AliZDCDigitizer.cxx
index 2229a47593f1bcfb5df56e18852b3f49ff221ebe..838903c4fd41077724810d0e81f9016339a35847 100644 (file)
--- a/ZDC/AliZDCDigitizer.cxx
+++ b/ZDC/AliZDCDigitizer.cxx
@@ -769,7 +769,7 @@ Int_t AliZDCDigitizer::Pedestal(Int_t Det, Int_t Quad, Int_t Res) const
 {
   // Returns a pedestal for detector det, PM quad, channel with res.
   //
-  Float_t pedValue;
+  Float_t pedValue=0.;
   // Normal run
   if(fIsCalibration == 0){
     Int_t index=0, kNch=24;
@@ -782,13 +782,18 @@ Int_t AliZDCDigitizer::Pedestal(Int_t Det, Int_t Quad, Int_t Res) const
     }
     else index = (Det-1)/3+22+kNch*Res; // Reference PMs
     //
-    Float_t meanPed = fPedData->GetMeanPed(index);
-    Float_t pedWidth = fPedData->GetMeanPedWidth(index);
-    pedValue = gRandom->Gaus(meanPed,pedWidth);
-    //
-    /*printf("\t  AliZDCDigitizer::Pedestal -> det %d quad %d res %d - Ped[%d] = %d\n",
-       Det, Quad, Res, index,(Int_t) pedValue); // Chiara debugging!
-    */
+    if(fPedData){
+      Float_t meanPed = fPedData->GetMeanPed(index);
+      Float_t pedWidth = fPedData->GetMeanPedWidth(index);
+      pedValue = gRandom->Gaus(meanPed,pedWidth);
+      //
+      /*printf("\t  AliZDCDigitizer::Pedestal -> det %d quad %d res %d - Ped[%d] = %d\n",
+       Det, Quad, Res, index,(Int_t) pedValue); // Chiara debugging!
+      */
+    }
+    else{
+      printf("  AliZDCDigitizer::Pedestal -> No valid pedestal calibration object loaded!\n\n");
+    }
   }
   // To create calibration object
   else{
@@ -829,14 +834,13 @@ AliZDCPedestals* AliZDCDigitizer::GetPedData() const
 {
 
   // Getting pedestal calibration object for ZDC set
-
+  AliZDCPedestals *calibdata = 0x0;
   AliCDBEntry  *entry = AliCDBManager::Instance()->Get("ZDC/Calib/Pedestals");
   if(!entry) AliFatal("No calibration data loaded!");  
   else{
-    AliZDCPedestals *calibdata = dynamic_cast<AliZDCPedestals*>  (entry->GetObject());
+    calibdata = dynamic_cast<AliZDCPedestals*>  (entry->GetObject());
     if(!calibdata)  AliFatal("Wrong calibration object in calibration  file!");
-
-    return calibdata;
   }
+  return calibdata;
 }
 

diff --git a/ZDC/AliZDCQADataMakerRec.cxx b/ZDC/AliZDCQADataMakerRec.cxx
index 79f854354b708ff77af94cdaf4af381a3901be12..e87b0d563c662d198f818523df4d35b223322cec 100644 (file)
--- a/ZDC/AliZDCQADataMakerRec.cxx
+++ b/ZDC/AliZDCQADataMakerRec.cxx
@@ -87,12 +87,13 @@ AliZDCPedestals* AliZDCQADataMakerRec::GetPedCalibData() const
 {
 
   // Retrieving pedestal calibration object from OCDB
+  AliZDCPedestals *calibdata = 0x0;
   AliCDBEntry  *entry = AliCDBManager::Instance()->Get("ZDC/Calib/Pedestals");
   if(!entry) AliWarning("No calibration data loaded!");  
-
-  AliZDCPedestals *calibdata = (AliZDCPedestals*)  (entry->GetObject());
-  if(!calibdata) AliFatal("Wrong calibration object in calibration  file!");
-
+  else{
+    calibdata = (AliZDCPedestals*)  (entry->GetObject());
+    if(!calibdata) AliFatal("Wrong calibration object in calibration  file!");
+  }
   return calibdata;
 
 }
@@ -408,7 +409,13 @@ void AliZDCQADataMakerRec::MakeRaws(AliRawReader *rawReader)
     // Parameters for mean value pedestal subtraction
     int const kNch = 24;
     Float_t meanPed[2*kNch];    
-    for(Int_t jj=0; jj<2*kNch; jj++) meanPed[jj] = fPedCalibData->GetMeanPed(jj);
+    for(Int_t jj=0; jj<2*kNch; jj++){
+      if(fPedCalibData) meanPed[jj] = fPedCalibData->GetMeanPed(jj);
+      else{
+        meanPed[jj] = 0.;
+       printf("  AliZDCQADataMakerRec::MakeRaws -> No valid pedestal object loaded!\n\n");
+      }
+    }
     
     Float_t zncSignal=0., znaSignal=0., zpcSignal=0., zpaSignal=0.;
     Float_t zncSumQ=0., znaSumQ=0., zpcSumQ=0., zpaSumQ=0.;

diff --git a/ZDC/AliZDCRawStream.cxx b/ZDC/AliZDCRawStream.cxx
index f332132a0008689837e2ca475f33ff14daf81ea9..bbcb7b199287b0f47f5a4a43700424fec573ee14 100644 (file)
--- a/ZDC/AliZDCRawStream.cxx
+++ b/ZDC/AliZDCRawStream.cxx
@@ -253,14 +253,17 @@ void AliZDCRawStream::ReadChMap()
   AliDebug(2,"\t Reading ZDC ADC mapping from OCDB\n");
   AliZDCChMap * chMap = GetChMap();
   //chMap->Print("");
-  for(Int_t i=0; i<kNch; i++){
-    fMapADC[i][0] = chMap->GetADCModule(i);
-    fMapADC[i][1] = chMap->GetADCChannel(i);
-    fMapADC[i][2] = chMap->GetADCSignalCode(i);
-    fMapADC[i][3] = chMap->GetDetector(i);
-    fMapADC[i][4] = chMap->GetSector(i);
+  if(chMap){
+    for(Int_t i=0; i<kNch; i++){
+      fMapADC[i][0] = chMap->GetADCModule(i);
+      fMapADC[i][1] = chMap->GetADCChannel(i);
+      fMapADC[i][2] = chMap->GetADCSignalCode(i);
+      fMapADC[i][3] = chMap->GetDetector(i);
+      fMapADC[i][4] = chMap->GetSector(i);
+    }
+    fIsMapRead = kTRUE;
   }
-  fIsMapRead = kTRUE;
+  else printf("  AliZDCRawStream::ReadChMap -> No valid object fr mapping loaded!!!\n\n");
 }
 
 //_____________________________________________________________________________
@@ -994,14 +997,13 @@ AliZDCChMap* AliZDCRawStream::GetChMap() const
 {
 
   // Getting calibration object for ZDC
-
+  AliZDCChMap *calibdata = 0x0;
   AliCDBEntry  *entry = AliCDBManager::Instance()->Get("ZDC/Calib/ChMap");
   if(!entry) AliFatal("No calibration data loaded!");  
   else{
-   
-    AliZDCChMap *calibdata = dynamic_cast<AliZDCChMap*> (entry->GetObject());
+    calibdata = dynamic_cast<AliZDCChMap*> (entry->GetObject());
     if(!calibdata) AliFatal("Wrong calibration object in calibration  file!");
-
-    return calibdata;
   }
+
+  return calibdata;
 }

diff --git a/ZDC/AliZDCReconstructor.cxx b/ZDC/AliZDCReconstructor.cxx
index a156861562459edad91560a25e48ca86ff135a76..b95c7651e195c613bd55dec6ddd22a8982f4c951 100644 (file)
--- a/ZDC/AliZDCReconstructor.cxx
+++ b/ZDC/AliZDCReconstructor.cxx
@@ -220,11 +220,8 @@ void AliZDCReconstructor::Reconstruct(TTree* digitsTree, TTree* clustersTree) co
 
   // loop over digits
   Float_t tZN1Corr[10], tZP1Corr[10], tZN2Corr[10], tZP2Corr[10]; 
-  Float_t dZEM1Corr[2], dZEM2Corr[2], sPMRef1[2], sPMRef2[2]; 
-  for(Int_t i=0; i<10; i++){
-     tZN1Corr[i] = tZP1Corr[i] = tZN2Corr[i] = tZP2Corr[i] = 0.;
-     if(i<2) dZEM1Corr[i] = dZEM2Corr[i] = sPMRef1[i] = sPMRef2[i] = 0.;
-  }  
+  for(Int_t i=0; i<10; i++) tZN1Corr[i] = tZP1Corr[i] = tZN2Corr[i] = tZP2Corr[i] = 0.;  
+  Float_t dZEM1Corr[2]={0,0}, dZEM2Corr[2]={0,0}, sPMRef1[2]={0,0}, sPMRef2[2]={0,0}; 
   
   Int_t digNentries = digitsTree->GetEntries();
   Float_t ootDigi[kNch]; Int_t i=0;
@@ -375,11 +372,8 @@ void AliZDCReconstructor::Reconstruct(AliRawReader* rawReader, TTree* clustersTr
   }
   
   Float_t tZN1Corr[10], tZP1Corr[10], tZN2Corr[10], tZP2Corr[10]; 
-  Float_t dZEM1Corr[2], dZEM2Corr[2], sPMRef1[2], sPMRef2[2]; 
-  for(Int_t i=0; i<10; i++){
-     tZN1Corr[i] = tZP1Corr[i] = tZN2Corr[i] = tZP2Corr[i] = 0.;
-     if(i<2) dZEM1Corr[i] = dZEM2Corr[i] = sPMRef1[i] = sPMRef2[i] = 0.;
-  }  
+  for(Int_t i=0; i<10; i++) tZN1Corr[i] = tZP1Corr[i] = tZN2Corr[i] = tZP2Corr[i] = 0.;
+  Float_t dZEM1Corr[2]={0,0}, dZEM2Corr[2]={0,0}, sPMRef1[2]={0,0}, sPMRef2[2]={0,0}; 
 
   Bool_t isScalerOn=kFALSE;
   Int_t jsc=0, itdc=0, iprevtdc=-1, ihittdc=0;
@@ -479,7 +473,7 @@ void AliZDCReconstructor::Reconstruct(AliRawReader* rawReader, TTree* clustersTr
          pedindex = (det-1)/3 + 22;
          if(det == 1){
            if(gain==0) sPMRef1[0] += (Float_t) (rawData.GetADCValue()-meanPed[pedindex]);
-        else sPMRef1[1] += (Float_t) (rawData.GetADCValue()-meanPed[pedindex+kNch]);
+          else sPMRef1[1] += (Float_t) (rawData.GetADCValue()-meanPed[pedindex+kNch]);
          }
          else if(det == 4){
            if(gain==0) sPMRef2[0] += (Float_t) (rawData.GetADCValue()-meanPed[pedindex]);
@@ -636,7 +630,7 @@ void AliZDCReconstructor::Reconstruct(AliRawReader* rawReader, TTree* clustersTr
     dZEM2Corr[1] = adcZEMlg[1] - (corrCoeff1[11+kNch]*adcZEMootlg[1]+corrCoeff0[11+kNch]);
     // *************************************************************************
   }
-  else if(fPedSubMode==0 && fRecoMode==1){
+  /*else if(fPedSubMode==0 && fRecoMode==1){
     //  **** p-p data taking 2011 -> temporary patch to overcome DA problem ****
     //
     dZEM1Corr[0] = adcZEM[0]   - meanPed[10];
@@ -644,7 +638,7 @@ void AliZDCReconstructor::Reconstruct(AliRawReader* rawReader, TTree* clustersTr
     dZEM2Corr[0] = adcZEM[1]   - meanPed[11];
     dZEM2Corr[1] = adcZEMlg[1] - meanPed[11+kNch];
         // *************************************************************************
-  }
+  }*/
     
   if(fRecoMode==1) // p-p data
     ReconstructEventpp(clustersTree, tZN1Corr, tZP1Corr, tZN2Corr, tZP2Corr, 

diff --git a/ZDC/AliZDCTriggerProcessor.cxx b/ZDC/AliZDCTriggerProcessor.cxx
index 1f79e4fd955c3faf5496e9f2fa25c006ecff6852..b17adb88604a3b119ccd42f122dbd5961c62b2fb 100644 (file)
--- a/ZDC/AliZDCTriggerProcessor.cxx
+++ b/ZDC/AliZDCTriggerProcessor.cxx
@@ -91,8 +91,8 @@ UInt_t AliZDCTriggerProcessor::ProcessEvent()
 Bool_t AliZDCTriggerProcessor::MBTrigger()
 {
   // is the processed event a MB A-A event?
-  
-  Float_t mbTrheshold = fTriggerParam->GetADCMBThreshold();
+  Float_t mbTrheshold = 0.;
+  if(fTriggerParam) mbTrheshold = fTriggerParam->GetADCMBThreshold();
   // check whether ZDC signal > mbTrheshold
   if((fSignal[0]+fSignal[1]+fSignal[3]+fSignal[4]) > mbTrheshold)
        return kTRUE;
@@ -105,8 +105,14 @@ Bool_t AliZDCTriggerProcessor::CentralTrigger()
 {
   // is the processed event a central A-A event?
   
-  Float_t zemThr = fTriggerParam->GetADCZDCCentralityThr();
-  const Float_t* centralWin = fTriggerParam->GetADCCentralWindow();
+  Float_t zemThr = 0;
+  Float_t centralWin[2] = {0,0};
+  if(fTriggerParam){
+    zemThr = fTriggerParam->GetADCZDCCentralityThr();
+    const Float_t* cWin = fTriggerParam->GetADCCentralWindow();
+    centralWin[0] = cWin[0];
+    centralWin[1] = cWin[1];
+  }
   // 
   if((fSignal[0]+fSignal[1]+fSignal[3]+fSignal[4]) > centralWin[0]
      && 
@@ -122,8 +128,14 @@ Bool_t AliZDCTriggerProcessor::SemicentralTrigger()
 {
   // is the processed event a semicentral A-A event?
   
-  Float_t zemThr =  fTriggerParam->GetADCZDCCentralityThr();
-  const Float_t* semicentralWin =   fTriggerParam->GetADCSemicentralWindow();
+  Float_t zemThr = 0;  
+  Float_t semicentralWin[2] = {0,0};
+  if(fTriggerParam){
+    zemThr  =  fTriggerParam->GetADCZDCCentralityThr();
+    const Float_t* cWin =   fTriggerParam->GetADCSemicentralWindow();
+    semicentralWin[0] = cWin[0];
+    semicentralWin[1] = cWin[1];
+  }
   //
   if((fSignal[0]+fSignal[1]+fSignal[3]+fSignal[4]) > semicentralWin[0]
      && 
@@ -139,7 +151,14 @@ Bool_t AliZDCTriggerProcessor::EMDTrigger()
 {
   // is the processed an EMD event?
   
-  const Float_t* emdWin =   fTriggerParam->GetADCEMDWindow();
+  Float_t emdWin[4] = {0,0,0,0};
+  if(fTriggerParam){
+    const Float_t* eWin =   fTriggerParam->GetADCEMDWindow();
+    emdWin[0] = eWin[0];
+    emdWin[1] = eWin[1];
+    emdWin[2] = eWin[2];
+    emdWin[3] = eWin[3];
+  }
   // check whether ZNA AND ZNC signals fall into the 
   // 2 distinct windows defined for EMD trigger
   if(fSignal[0] > emdWin[0] && fSignal[0] < emdWin[1]
@@ -153,12 +172,13 @@ Bool_t AliZDCTriggerProcessor::EMDTrigger()
 AliZDCTriggerParameters* AliZDCTriggerProcessor::GetTriggerParamFromOCDB() const
 {
   // retrieving trigger parameter configuration form OCDB
+  AliZDCTriggerParameters *trigParam = 0x0;
   AliCDBEntry  *entry = AliCDBManager::Instance()->Get("ZDC/Trigger/");
   if(!entry) AliFatal("No calibration data loaded!");  
   else{
-    AliZDCTriggerParameters *trigParam = dynamic_cast<AliZDCTriggerParameters*>  (entry->GetObject());
+    trigParam = dynamic_cast<AliZDCTriggerParameters*>  (entry->GetObject());
     if(!trigParam)  AliFatal("Wrong calibration object in calibration  file!");
-
-    return trigParam;
   }
+
+  return trigParam;
 }