Fixing coverities

diff --git a/ZDC/AliZDCDigit.cxx b/ZDC/AliZDCDigit.cxx
index 43745cf5303d95219a7052f7b4c8f3981d60fc26..dc49e4ffe05b400fb101a9af7acae384f2ad4dab 100644 (file)
--- a/ZDC/AliZDCDigit.cxx
+++ b/ZDC/AliZDCDigit.cxx
@@ -58,3 +58,17 @@ AliZDCDigit::AliZDCDigit(const AliZDCDigit & digit):TObject(digit)
 
 }
 
+//____________________________________________________________________________
+AliZDCDigit &AliZDCDigit::operator=(const AliZDCDigit &digit)
+{
+  // Assignemnt constructor
+  if(&digit == this) return *this;
+
+  for(int i=0; i<2; i++){
+    fSector[i]   = digit.fSector[i];           
+    fADCValue[i] = digit.fADCValue[i];             
+  }
+  
+  return *this;
+}
+

diff --git a/ZDC/AliZDCDigit.h b/ZDC/AliZDCDigit.h
index 606bc9612879f5a404296ff72eca218d5d480cea..948d4d1513dc248f1ea1cde55a6632daf58394a1 100644 (file)
--- a/ZDC/AliZDCDigit.h
+++ b/ZDC/AliZDCDigit.h
@@ -20,6 +20,7 @@ class AliZDCDigit : public TObject {
   AliZDCDigit() ;
   AliZDCDigit(Int_t *Sector, Int_t *ADCValue);
   AliZDCDigit(const AliZDCDigit & digit);
+  AliZDCDigit& operator= (const AliZDCDigit &digit);
   virtual ~AliZDCDigit() {}
 
   // Getters 

diff --git a/ZDC/AliZDCFragment.cxx b/ZDC/AliZDCFragment.cxx
index 7e206b44e9dd0db846f2385759fdcff3eca807b7..544e3f60e55ca3f1d4bc5611f8b18647e046e37a 100644 (file)
--- a/ZDC/AliZDCFragment.cxx
+++ b/ZDC/AliZDCFragment.cxx
@@ -49,6 +49,10 @@ AliZDCFragment::AliZDCFragment():
   //
   // Default constructor
   //
+  for(Int_t i=0; i<=99; i++){
+     fZZ[i] = 0;
+     fNN[i] = 0;
+  }
 }
 
 //_____________________________________________________________________________

diff --git a/ZDC/AliZDCHit.cxx b/ZDC/AliZDCHit.cxx
index 551c0875f00abf93c84a0ebd1814ecd4588ca705..197842498672792d138de5cdf3def7cb058720cf 100644 (file)
--- a/ZDC/AliZDCHit.cxx
+++ b/ZDC/AliZDCHit.cxx
@@ -91,6 +91,31 @@ AliZDCHit::AliZDCHit(const AliZDCHit &oldhit) :
   fZ = oldhit.Z();
   for(Int_t i=0; i<2; i++) fVolume[i] = oldhit.GetVolume(i);
 }
+
+//_____________________________________________________________________________
+AliZDCHit &AliZDCHit::operator= (const AliZDCHit &hit) 
+{
+  //assignemnt operator
+  if(&hit == this) return *this;
+  
+  fPrimKinEn = hit.GetPrimKinEn();
+  fXImpact = hit.GetXImpact();
+  fYImpact = hit.GetYImpact();  
+  fSFlag = hit.GetSFlag();
+  fLightPMQ = hit.GetLightPMQ(); 
+  fLightPMC = hit.GetLightPMC();
+  fEnergy = hit.GetEnergy();
+  fPDGCode = hit.GetPDGCode();
+  fMotherPDGCode = hit.GetMotherPDGCode();
+  fTrackTOF = hit.GetTrackTOF();
+
+  fX = hit.X();
+  fY = hit.Y();
+  fZ = hit.Z();
+  for(Int_t i=0; i<2; i++) fVolume[i] = hit.GetVolume(i);
+  
+  return *this;
+}
   
   
 //_____________________________________________________________________________

diff --git a/ZDC/AliZDCHit.h b/ZDC/AliZDCHit.h
index 6b1f5664e79d07f21bc73de4a26ac1186dfb461c..b4cd99eb106f89cfeeed308ae9ee2bc11ea5af84 100644 (file)
--- a/ZDC/AliZDCHit.h
+++ b/ZDC/AliZDCHit.h
@@ -14,8 +14,8 @@ class AliZDCHit : public AliHit {
 public:
   AliZDCHit();
   AliZDCHit(Int_t shunt, Int_t track, Int_t *vol, Float_t *hits);
-  //AliZDCHit(const AliZDCHit* oldhit) {*this=*oldhit;}
   AliZDCHit(const AliZDCHit &oldhit);
+  AliZDCHit& operator= (const AliZDCHit &hit);
   virtual ~AliZDCHit() {}
 
   // Getters 

diff --git a/ZDC/AliZDCQAChecker.h b/ZDC/AliZDCQAChecker.h
index c4069e08b6df4fb5506383a40d741321d6370dd4..e287bf604852b7da994c25655019679a6925f18e 100644 (file)
--- a/ZDC/AliZDCQAChecker.h
+++ b/ZDC/AliZDCQAChecker.h
@@ -20,6 +20,7 @@ class AliZDCQAChecker: public AliQACheckerBase {
 public:
   AliZDCQAChecker() : AliQACheckerBase("ZDC","ZDC Quality Assurance Data Maker") {;}          // ctor
   AliZDCQAChecker(const AliZDCQAChecker& qac) : AliQACheckerBase(qac.GetName(), qac.GetTitle()) {;} // cpy ctor   
+  AliZDCQAChecker& operator= (const AliZDCQAChecker &checker) {return *this;}
   virtual ~AliZDCQAChecker() {;} // dtor
 
  protected:

diff --git a/ZDC/AliZDCReco.cxx b/ZDC/AliZDCReco.cxx
index 2dd49ba4c987f72e176417a8fa90d72b40175079..4b9be7c2d2564050a133ad44c71163f58b39a0a1 100644 (file)
--- a/ZDC/AliZDCReco.cxx
+++ b/ZDC/AliZDCReco.cxx
@@ -182,6 +182,67 @@ fIsScalerOn(oldreco.IsScalerOn())
   }
 }
 
+
+//______________________________________________________________________________
+AliZDCReco &AliZDCReco::operator= (const AliZDCReco &reco) 
+{
+  // assignment operator
+  if(&reco == this) return *this;
+  
+  fNDetSpecNSideA = reco.GetNDetSpecNSideA();
+  fNDetSpecPSideA = reco.GetNDetSpecPSideA();
+  fNDetSpecNSideC = reco.GetNDetSpecNSideC();        
+  fNDetSpecPSideC = reco.GetNDetSpecPSideC();       
+  fNTrueSpectators = reco.GetNTrueSpectators();
+  fNTrueSpecSideA = reco.GetNTrueSpecSideA();
+  fNTrueSpecSideC = reco.GetNTrueSpecSideC();          
+  fNParticipants = reco.GetNParticipants();                   
+  fNPartSideA = reco.GetNPartSideA();                 
+  fNPartSideC = reco.GetNPartSideC();                         
+  fImpParameter = reco.GetImpParameter();      
+  fImpParSideA = reco.GetImpParSideA();      
+  fImpParSideC = reco.GetImpParSideC();
+  fRecoFlag = reco.GetRecoFlag();
+  fEnergyFlag = reco.GetEnergyFlag();
+  fIsScalerOn = reco.IsScalerOn();    
+
+  fZN1Energy[0]  = reco.GetZN1HREnergy();
+  fZP1Energy[0]  = reco.GetZP1HREnergy();              
+  fZN2Energy[0]  = reco.GetZN2HREnergy();           
+  fZP2Energy[0]  = reco.GetZP2HREnergy();       
+  //    
+  fZN1Energy[1]  = reco.GetZN1LREnergy();
+  fZP1Energy[1]  = reco.GetZP1LREnergy();             
+  fZN2Energy[1]  = reco.GetZN2LREnergy();          
+  fZP2Energy[1]  = reco.GetZP2LREnergy();          
+  //
+  for(Int_t i=0; i<5; i++){      
+     fZN1EnTow[i]  = reco.GetZN1HREnTow(i);
+     fZP1EnTow[i]  = reco.GetZP1HREnTow(i);
+     fZN2EnTow[i]  = reco.GetZN2HREnTow(i);
+     fZP2EnTow[i]  = reco.GetZP2HREnTow(i);
+     fZN1EnTow[i+5]  = reco.GetZN1LREnTow(i);
+     fZP1EnTow[i+5]  = reco.GetZP1LREnTow(i);
+     fZN2EnTow[i+5]  = reco.GetZN2LREnTow(i);
+     fZP2EnTow[i+5]  = reco.GetZP2LREnTow(i);
+  }
+  fZEM1signal[0] = reco.GetZEM1HRsignal();
+  fZEM1signal[1] = reco.GetZEM1LRsignal();
+  fZEM2signal[0] = reco.GetZEM2HRsignal();
+  fZEM2signal[1] = reco.GetZEM2LRsignal();
+  fPMRef1[0] = reco.GetPMRef1HRsignal();
+  fPMRef1[1] = reco.GetPMRef1LRsignal();
+  fPMRef2[0] = reco.GetPMRef2HRsignal();
+  fPMRef2[1] = reco.GetPMRef2LRsignal();
+  for(Int_t j=0; j<32; j++){
+    fZDCScaler[j] = reco.GetZDCScaler(j);
+    for(Int_t y=0; y<4; y++) fZDCTDCData[j][y] = reco.GetZDCTDCData(j, y);
+  }
+  
+  
+  return *this;
+}
+
 //______________________________________________________________________________
 void AliZDCReco::Print(Option_t *) const {
   //

diff --git a/ZDC/AliZDCReco.h b/ZDC/AliZDCReco.h
index f36ac5022de1520528c345f112a1495fabd54546..ee79fca064083b543b9d98a9a3c0c229fcceeca1 100644 (file)
--- a/ZDC/AliZDCReco.h
+++ b/ZDC/AliZDCReco.h
@@ -26,6 +26,7 @@ public:
             UInt_t* scaler, Int_t tdcData[32][4]);
 
   AliZDCReco(const AliZDCReco &oldreco);
+  AliZDCReco& operator= (const AliZDCReco &reco);
   virtual ~AliZDCReco() {}
 
   // Getters 

diff --git a/ZDC/AliZDCTriggerParameters.cxx b/ZDC/AliZDCTriggerParameters.cxx
index 62c064aa487848afd9e6e9b19877c367bb3b7307..1eb192e1d4145598c531bb787e4cebd55efc93bf 100644 (file)
--- a/ZDC/AliZDCTriggerParameters.cxx
+++ b/ZDC/AliZDCTriggerParameters.cxx
@@ -103,3 +103,28 @@ AliZDCTriggerParameters::AliZDCTriggerParameters(const AliZDCTriggerParameters&
   fDiscEMDWindow[3] = oldTrigPar.fDiscEMDWindow[3];
   
 }
+
+//____________________________________________________________________________
+AliZDCTriggerParameters &AliZDCTriggerParameters::operator= (const AliZDCTriggerParameters& param) 
+{
+  //assignement operator
+  
+  if(&param == this) return *this;
+
+  fADCZEMCentralityThr = param.fADCZEMCentralityThr;
+  fADCMBThreshold = param.fADCMBThreshold;
+  fDiscZEMCentralityThr = param.fDiscZEMCentralityThr;
+  fDiscMBThreshold = param.fDiscMBThreshold;
+  for(int i=0; i<2; i++) {
+       fADCCentralWindow[i] = param.fADCCentralWindow[i];
+       fADCSemicentralWindow[i] = param.fADCSemicentralWindow[i];
+       fDiscCentralWindow[i] = param.fDiscCentralWindow[i];
+       fDiscSemicentralWindow[i] = param.fDiscSemicentralWindow[i];
+ }
+ for(int j=0; j<4; j++){
+       fADCEMDWindow[j] = param.fADCEMDWindow[j];
+       fDiscEMDWindow[j] = param.fDiscEMDWindow[j];
+ }
+ 
+ return *this;
+}

diff --git a/ZDC/AliZDCTriggerParameters.h b/ZDC/AliZDCTriggerParameters.h
index 371f4d97aad01d8ce89c305ee503200c37422721..33686c347cbb464af2196fe0332f2aef7310800c 100644 (file)
--- a/ZDC/AliZDCTriggerParameters.h
+++ b/ZDC/AliZDCTriggerParameters.h
@@ -20,6 +20,7 @@ public:
   AliZDCTriggerParameters();
   AliZDCTriggerParameters(Float_t *adcParam, Float_t *discParam);
   AliZDCTriggerParameters(const AliZDCTriggerParameters &parameters);
+  AliZDCTriggerParameters& operator= (const AliZDCTriggerParameters &param);
   virtual ~AliZDCTriggerParameters() {;}
   
   Float_t   GetADCZDCCentralityThr()  const {return fADCZEMCentralityThr;}