bugfix: missing function implemented; next strike against warnings

diff --git a/HLT/BASE/AliHLTOUT.cxx b/HLT/BASE/AliHLTOUT.cxx
index 7c66804ae9fe371dbfc39360b6ac22e66343bc49..61e143fd729551b36dac870547dd52142b3928d2 100644 (file)
--- a/HLT/BASE/AliHLTOUT.cxx
+++ b/HLT/BASE/AliHLTOUT.cxx
@@ -76,7 +76,7 @@ int AliHLTOUT::GetNofDataBlocks()
 }
 
 int AliHLTOUT::SelectFirstDataBlock(AliHLTComponentDataType dt, AliHLTUInt32_t spec,
-                                   AliHLTModuleAgent::AliHLTOUTHandlerType handlerType)
+                                   AliHLTModuleAgent::AliHLTOUTHandlerType /*handlerType*/)
 {
   // see header file for class documentation
   if (CheckStatusFlag(kLocked)) return -EPERM;

diff --git a/HLT/TPCLib/comp/AliHLTTPCCompDumpComponent.cxx b/HLT/TPCLib/comp/AliHLTTPCCompDumpComponent.cxx
index 3c1da17fe2f7842d617f9ecf19dda989d759b1a6..5a97671d3d1848afce0ea1d127c763a1121365eb 100644 (file)
--- a/HLT/TPCLib/comp/AliHLTTPCCompDumpComponent.cxx
+++ b/HLT/TPCLib/comp/AliHLTTPCCompDumpComponent.cxx
@@ -96,7 +96,7 @@ AliHLTComponent* AliHLTTPCCompDumpComponent::Spawn()
     {
       // see header file for class documentation
       return new AliHLTTPCCompDumpComponent;
-    };
+    }
 
 void AliHLTTPCCompDumpComponent::InitBitDataInput( AliHLTUInt8_t* input, UInt_t inputSize )
     {
@@ -106,7 +106,7 @@ void AliHLTTPCCompDumpComponent::InitBitDataInput( AliHLTUInt8_t* input, UInt_t
       fBitDataCurrentInput = fBitDataCurrentInputStart = input;
       fBitDataCurrentInputEnd = input+inputSize;
       fBitDataCurrentWord = *fBitDataCurrentInput;
-    };
+    }
 
  bool AliHLTTPCCompDumpComponent::InputBit( AliHLTUInt8_t & value )
     {
@@ -126,7 +126,7 @@ void AliHLTTPCCompDumpComponent::InitBitDataInput( AliHLTUInt8_t* input, UInt_t
            }
        }
       return true;
-    };
+    }
 
 bool AliHLTTPCCompDumpComponent::InputBits( AliHLTUInt8_t & value, UInt_t const & bitCount )
     {
@@ -141,7 +141,7 @@ bool AliHLTTPCCompDumpComponent::InputBits( AliHLTUInt8_t & value, UInt_t const
        return false;
       value = (AliHLTUInt8_t)( temp & (AliHLTUInt64_t)0xFFFFFFFFULL );
       return true;
-    };
+    }
 
 bool AliHLTTPCCompDumpComponent::InputBits( AliHLTUInt16_t & value, UInt_t const & bitCount )
    {
@@ -156,7 +156,22 @@ bool AliHLTTPCCompDumpComponent::InputBits( AliHLTUInt16_t & value, UInt_t const
        return false;
      value = (AliHLTUInt16_t)( temp & (AliHLTUInt64_t)0xFFFFFFFFULL );
      return true;
-   };
+   }
+
+bool AliHLTTPCCompDumpComponent::InputBits( AliHLTUInt32_t & value, UInt_t const & bitCount )
+   {
+     // see header file for class documentation
+     if ( bitCount>32 )         
+       {        
+        HLTFatal( "Internal error: Attempt to write more than 32 bits (%u)", (unsigned)bitCount );      
+        return false;   
+       }        
+     AliHLTUInt64_t temp;       
+     if ( !InputBits( temp, bitCount ) )        
+       return false;    
+     value = (AliHLTUInt32_t)( temp & (AliHLTUInt64_t)0xFFFFFFFFULL );          
+     return true;       
+   }
 
 bool AliHLTTPCCompDumpComponent::InputBits( Int_t & value, UInt_t const & bitCount )
    {
@@ -171,7 +186,7 @@ bool AliHLTTPCCompDumpComponent::InputBits( Int_t & value, UInt_t const & bitCou
        return false;
      value = (Int_t)( temp & (AliHLTUInt64_t)0xFFFFFFFFULL );
      return true;
-   };
+   }
 
 bool AliHLTTPCCompDumpComponent::InputBits( AliHLTUInt64_t & value, UInt_t const & bitCount )
    {
@@ -207,7 +222,7 @@ bool AliHLTTPCCompDumpComponent::InputBits( AliHLTUInt64_t & value, UInt_t const
         bitsToRead -= curBitCount;
        }
      return true;
-   };
+   }
 
 void AliHLTTPCCompDumpComponent::Pad8Bits()
    {
@@ -220,7 +235,7 @@ void AliHLTTPCCompDumpComponent::Pad8Bits()
         fBitDataCurrentWord = *fBitDataCurrentInput;
         fBitDataCurrentPosInWord = 7;
        }
-   };
+   }
 
 bool AliHLTTPCCompDumpComponent::InputBytes( AliHLTUInt8_t* data, UInt_t const & byteCount )
    {
@@ -236,7 +251,7 @@ bool AliHLTTPCCompDumpComponent::InputBytes( AliHLTUInt8_t* data, UInt_t const &
         fBitDataCurrentPosInWord = 7;
        }
      return true;
-   };
+   }
 
 int AliHLTTPCCompDumpComponent::DoInit( int argc, const char** argv )
     {

diff --git a/HLT/TPCLib/comp/AliHLTTPCCompModelAnalysis.h b/HLT/TPCLib/comp/AliHLTTPCCompModelAnalysis.h
index 354177c3d2b1a4466c966bbe828c70309efa0134..d9cb0d9fc032bfb877984dde0608f648dfbc1941 100644 (file)
--- a/HLT/TPCLib/comp/AliHLTTPCCompModelAnalysis.h
+++ b/HLT/TPCLib/comp/AliHLTTPCCompModelAnalysis.h
@@ -73,7 +73,7 @@ public:
   Bool_t GetfTrackAnalysis() {return fTrackAnalysis;};
 
   /** fill track arrays with track data from original and secondary tracking 
-   * @param firsttracklets      pointer to track array to be filled
+   * @param tracklets           pointer to track array to be filled
    * @param fillingfirsttracks  boolean to decide which track array is to be filled (1 for first, 0 for second)
    * @return 0 upon success
    */
@@ -141,7 +141,7 @@ private:
   Bool_t GetTrashTrackPythiaInfo(AliHLTTPCTrack* discardedtrack);
 
   /** compare information of a cluster not assigned to any track with its Pythia information
-   * @param discarded cluster  pointer to discarded cluster
+   * @param discardedcluster  pointer to discarded cluster
    * @return 0 upon correct decision (cluster not assigned to any track is true in Pythia, i.e. cluster = noise cluster)
    * @return 1 upon wrong decision (cluster wrongly discarded, i.e. it belongs to a valuable track according to Pythia)
    */

diff --git a/HLT/TPCLib/comp/AliHLTTPCCompModelConverter.cxx b/HLT/TPCLib/comp/AliHLTTPCCompModelConverter.cxx
index b82ce4e9763b84194ece7135450cdbbd335e764f..c9e45f692af20635ff3ba6f3bb60c226345b3d93 100644 (file)
--- a/HLT/TPCLib/comp/AliHLTTPCCompModelConverter.cxx
+++ b/HLT/TPCLib/comp/AliHLTTPCCompModelConverter.cxx
@@ -53,8 +53,8 @@ AliHLTTPCCompModelConverter::AliHLTTPCCompModelConverter():
 AliHLTTPCCompModelConverter::AliHLTTPCCompModelConverter(AliHLTTPCCompModelAnalysis* modelanalysis):
   fInputTrackArray(),
   fOutputTrackArray("AliHLTTPCModelTrack"),
-  fMinHits(0),
-  fModelAnalysisInstance(modelanalysis)
+  fModelAnalysisInstance(modelanalysis),
+  fMinHits(0)
     {
       // see header file for class documentation
       for ( UInt_t slice=0; slice<36; slice++ )

diff --git a/HLT/TPCLib/comp/AliHLTTPCCompModelDeconverterComponent.cxx b/HLT/TPCLib/comp/AliHLTTPCCompModelDeconverterComponent.cxx
index 269300c805ee4a78ca17726f7764233f28de9338..cd75951b33ea585238f2b79158edae3e29041d04 100644 (file)
--- a/HLT/TPCLib/comp/AliHLTTPCCompModelDeconverterComponent.cxx
+++ b/HLT/TPCLib/comp/AliHLTTPCCompModelDeconverterComponent.cxx
@@ -44,7 +44,8 @@ AliHLTTPCCompModelDeconverterComponent gAliHLTTPCCompClusterModelDeconverterComp
 ClassImp(AliHLTTPCCompModelDeconverterComponent)
     
 AliHLTTPCCompModelDeconverterComponent::AliHLTTPCCompModelDeconverterComponent():
-    fOutputTracks(kTRUE)
+  fDeconverter(),
+  fOutputTracks(kTRUE)
     {
       // see header file for class documentation
     }

diff --git a/HLT/TPCLib/comp/AliHLTTPCCompModelDeflaterComponent.cxx b/HLT/TPCLib/comp/AliHLTTPCCompModelDeflaterComponent.cxx
index 1c659f2e419dcc497561f43e5d1bec615487c0aa..9e85622eaa08dfa166fd699936228fa615a0accc 100644 (file)
--- a/HLT/TPCLib/comp/AliHLTTPCCompModelDeflaterComponent.cxx
+++ b/HLT/TPCLib/comp/AliHLTTPCCompModelDeflaterComponent.cxx
@@ -36,9 +36,9 @@ AliHLTTPCCompModelDeflaterComponent gAliHLTTPCCompClusterModelDeflaterComponent;
 ClassImp(AliHLTTPCCompModelDeflaterComponent);
     
 AliHLTTPCCompModelDeflaterComponent::AliHLTTPCCompModelDeflaterComponent():
-  fForwardIfUncompressed(true),
   fModelDeflater(),
-  fConverter()
+  fConverter(),
+  fForwardIfUncompressed(true)
     {
       // see header file for class documentation
     }

diff --git a/HLT/comp/AliHLTCOMPHuffmanAltro.cxx b/HLT/comp/AliHLTCOMPHuffmanAltro.cxx
index 0c58c8426522116427e0261eaa7e04fcae7ff564..07166fbb721b30ae1ebf8d54f81a12eabcffb62c 100644 (file)
--- a/HLT/comp/AliHLTCOMPHuffmanAltro.cxx
+++ b/HLT/comp/AliHLTCOMPHuffmanAltro.cxx
@@ -1243,8 +1243,8 @@ Int_t AliHLTCOMPHuffmanAltro::CreateCodeTable()
   //  }
   
   // findout maximal and minimal codelength and print them out
-    Int_t maxcodelength = fTranslationTable[0].fvalidcodelength;
-    Int_t mincodelength = TIMEBINS;
+    UInt_t maxcodelength = fTranslationTable[0].fvalidcodelength;
+    UInt_t mincodelength = TIMEBINS;
 
     for (Int_t kk = 0; kk < TIMEBINS; kk++)
       {

diff --git a/HLT/comp/AliHLTCOMPHuffmanAltroComponent.cxx b/HLT/comp/AliHLTCOMPHuffmanAltroComponent.cxx
index 731b7978663bf90869e4a5f4fed10963b27f5e89..857a8b9b8117492f4d597cf8e9373a388fdc0cbe 100644 (file)
--- a/HLT/comp/AliHLTCOMPHuffmanAltroComponent.cxx
+++ b/HLT/comp/AliHLTCOMPHuffmanAltroComponent.cxx
@@ -40,13 +40,12 @@ AliHLTCOMPHuffmanAltroComponent::AliHLTCOMPHuffmanAltroComponent(bool compressio
   fHuffmanCompressor(NULL),
   fCompressionSwitch(compression),
   fTrainingMode(kFALSE),
-  fHuffmanData(NULL),
   fOrigin(kAliHLTVoidDataOrigin),
   fRunNumber(0),
   fDataSpec(0),
   fTablePath(),
-  fNrcuTrailerwords(0)
- 
+  fNrcuTrailerwords(0),
+  fHuffmanData(NULL) 
 {
    // see header file for class documentation
   // or