Fix coding rule violations

diff --git a/TRD/qaAnalysis/AliTRDqaBasic.cxx b/TRD/qaAnalysis/AliTRDqaBasic.cxx
index f08124577dfbbc502b7d7acbb867d44d28c5518a..a6cff6ede0f4763e1ad128beb33f1cdbeef25d2d 100644 (file)
--- a/TRD/qaAnalysis/AliTRDqaBasic.cxx
+++ b/TRD/qaAnalysis/AliTRDqaBasic.cxx
@@ -26,11 +26,9 @@
 #include "AliTRDqaBasic.h"
 #include "AliTRDqaAT.h"
 
-#include "TMath.h"
 #include "TH1D.h"
 #include "TH2D.h"
 #include "TFile.h"
-#include "TTree.h"
 #include "TChain.h"
 
 #include "AliESDEvent.h"
@@ -54,13 +52,13 @@ AliTRDqaBasic::AliTRDqaBasic()
     fPtPt(0)
 {
   //
-  // default dummy constructor
+  // default constructor
   //
  
 }
 //______________________________________________________________________________
 
-AliTRDqaBasic:: AliTRDqaBasic(AliTRDqaBasic& /*trd*/)
+AliTRDqaBasic:: AliTRDqaBasic(const AliTRDqaBasic & /*trd*/)
   : AliAnalysisTask("",""),  
     fChain(0),
     fESD(0),
@@ -75,13 +73,11 @@ AliTRDqaBasic:: AliTRDqaBasic(AliTRDqaBasic& /*trd*/)
     fPtPt(0)
 {
   //
-  // Dummy copy constructor
+  // Copy constructor
   //
 
-  //return *this;
 }
 
-
 //______________________________________________________________________________
 AliTRDqaBasic::AliTRDqaBasic(const char *name) 
   : AliAnalysisTask(name,""),  

diff --git a/TRD/qaAnalysis/AliTRDqaBasic.h b/TRD/qaAnalysis/AliTRDqaBasic.h
index aa7bc5ef67d16fbcaaf55d3527ebeef869820b8d..f67ee59c8521a47112fffd599d43f8bbe8c1ae56 100644 (file)
--- a/TRD/qaAnalysis/AliTRDqaBasic.h
+++ b/TRD/qaAnalysis/AliTRDqaBasic.h
@@ -1,5 +1,6 @@
-#ifndef ALITRDQBASIC_H
-#define ALITRDQBASIC_H
+#ifndef ALITRDQABASIC_H
+#define ALITRDQABASIC_H
+
 /* Copyright(c) 1998-1999, ALICE Experiment at CERN, All rights reserved. *
  * See cxx source for full Copyright notice     */
 
@@ -30,8 +31,8 @@ class AliTRDqaBasic : public AliAnalysisTask {
 
   AliTRDqaBasic();
   AliTRDqaBasic(const char *name);
-  AliTRDqaBasic(AliTRDqaBasic& trd);
-  AliTRDqaBasic& operator = (const AliTRDqaBasic& /*g*/) { return *this; };
+  AliTRDqaBasic(const AliTRDqaBasic & trd);
+  AliTRDqaBasic &operator=(const AliTRDqaBasic & /*g*/) { return *this; };
   virtual ~AliTRDqaBasic() {}
    
   virtual void Exec(Option_t * opt = "");

diff --git a/TRD/qaAnalysis/AliTRDqaElectronSpectra.cxx b/TRD/qaAnalysis/AliTRDqaElectronSpectra.cxx
index a75e13abad79386017fc6695eb66f828dcbeef11..fd7b04cd2e32cb1b695de2e29538f59a84a1c66b 100644 (file)
--- a/TRD/qaAnalysis/AliTRDqaElectronSpectra.cxx
+++ b/TRD/qaAnalysis/AliTRDqaElectronSpectra.cxx
@@ -31,11 +31,9 @@
 #include "AliTRDqaElectronSpectra.h"
 #include "AliTRDqaAT.h"
 
-#include "TMath.h"
 #include "TH1D.h"
 #include "TH2D.h"
 #include "TFile.h"
-#include "TTree.h"
 #include "TChain.h"
 
 #include "AliESDEvent.h"
@@ -70,7 +68,7 @@ AliTRDqaElectronSpectra::AliTRDqaElectronSpectra()
 }
 //______________________________________________________________________________
 
-AliTRDqaElectronSpectra:: AliTRDqaElectronSpectra(AliTRDqaElectronSpectra& /*trd*/)
+AliTRDqaElectronSpectra:: AliTRDqaElectronSpectra(const AliTRDqaElectronSpectra & /*trd*/)
   : AliAnalysisTask("",""),  
     fChain(0),
     fESD(0),

diff --git a/TRD/qaAnalysis/AliTRDqaElectronSpectra.h b/TRD/qaAnalysis/AliTRDqaElectronSpectra.h
index 2bcb8eceac8ac53bf1600f01eae53e858f34bc75..7bda75dbe0bd701638fa6c24e3b2858948351e52 100644 (file)
--- a/TRD/qaAnalysis/AliTRDqaElectronSpectra.h
+++ b/TRD/qaAnalysis/AliTRDqaElectronSpectra.h
@@ -32,8 +32,8 @@ class AliTRDqaElectronSpectra : public AliAnalysisTask {
 
   AliTRDqaElectronSpectra();
   AliTRDqaElectronSpectra(const char *name);
-  AliTRDqaElectronSpectra(AliTRDqaElectronSpectra& trd);
-  AliTRDqaElectronSpectra& operator = (const AliTRDqaElectronSpectra& /*g*/) { return *this; };
+  AliTRDqaElectronSpectra(const AliTRDqaElectronSpectra & trd);
+  AliTRDqaElectronSpectra &operator=(const AliTRDqaElectronSpectra & /*g*/) { return *this; };
   virtual ~AliTRDqaElectronSpectra() {}
    
   virtual void Exec(Option_t * opt = "");

diff --git a/TRD/qaAnalysis/AliTRDqaEnergyDeposit.cxx b/TRD/qaAnalysis/AliTRDqaEnergyDeposit.cxx
index 04816e5780d347f97afbe797c6cb628ae41ba6e1..8212e4d6cd8f715d1c18c17b7297e009a627e564 100644 (file)
--- a/TRD/qaAnalysis/AliTRDqaEnergyDeposit.cxx
+++ b/TRD/qaAnalysis/AliTRDqaEnergyDeposit.cxx
@@ -32,12 +32,10 @@
 #include "TH1D.h"
 #include "TH2D.h"
 #include "TFile.h"
-#include "TTree.h"
 #include "TChain.h"
 
 #include "AliESDEvent.h"
 #include "AliESDtrack.h"
-#include "AliKalmanTrack.h"
 
 //______________________________________________________________________________
 
@@ -47,19 +45,24 @@ AliTRDqaEnergyDeposit::AliTRDqaEnergyDeposit()
     fESD(0),
     fOutputContainer(0)
 {
-  // Dummy default constructor
+  //
+  // Default constructor
+  //
+
 }
+
 //______________________________________________________________________________
 
-AliTRDqaEnergyDeposit:: AliTRDqaEnergyDeposit(AliTRDqaEnergyDeposit& /*trd*/)
+AliTRDqaEnergyDeposit:: AliTRDqaEnergyDeposit(const AliTRDqaEnergyDeposit & /*trd*/)
   : AliAnalysisTask("",""),  
     fChain(0),
     fESD(0),
     fOutputContainer(0)
 {
-  // Dummy copy constructor
-  
-  //return *this;
+  //
+  // Copy constructor
+  //
+
 }
 
 //______________________________________________________________________________
@@ -69,11 +72,15 @@ AliTRDqaEnergyDeposit::AliTRDqaEnergyDeposit(const char *name)
     fESD(0),
     fOutputContainer(0)
 {
+  //
   // Constructor.
+  //
+
   // Input slot #0 works with an Ntuple
   DefineInput(0, TChain::Class());
   // Output slot #0 writes into a TH1 container
   DefineOutput(0,  TObjArray::Class()) ; 
+
 }
 
 //______________________________________________________________________________
@@ -139,11 +146,14 @@ void AliTRDqaEnergyDeposit::CreateOutputObjects()
 
   printf("n hist = %d\n", c);
 }
+
 //______________________________________________________________________________
 void AliTRDqaEnergyDeposit::Exec(Option_t *) 
 {
+  //
   // Process one event
-  
+  //
+
   //  Long64_t entry = fChain->GetReadEntry() ;
   
   // Processing of one event 
@@ -203,16 +213,21 @@ void AliTRDqaEnergyDeposit::Exec(Option_t *)
 }
 
 //______________________________________________________________________________
-void AliTRDqaEnergyDeposit::FillElectrons() {
-
-  
+void AliTRDqaEnergyDeposit::FillElectrons() const 
+{
+  //
+  // Fill the electrons
+  //  
 
 }
 
 //______________________________________________________________________________
 void AliTRDqaEnergyDeposit::Terminate(Option_t *)
 {
-  // retrieve histograms
+  //
+  // Retrieve histograms
+  //
+
   fOutputContainer = (TObjArray*)GetOutputData(0);
   
   // post processing

diff --git a/TRD/qaAnalysis/AliTRDqaEnergyDeposit.h b/TRD/qaAnalysis/AliTRDqaEnergyDeposit.h
index 148d6267d6e0eb383066b1b18dd220292a068e0e..bce5eb846152d655f9d505d26643d511a35651ae 100644 (file)
--- a/TRD/qaAnalysis/AliTRDqaEnergyDeposit.h
+++ b/TRD/qaAnalysis/AliTRDqaEnergyDeposit.h
@@ -28,8 +28,8 @@ class AliTRDqaEnergyDeposit : public AliAnalysisTask {
 public:
   AliTRDqaEnergyDeposit();
   AliTRDqaEnergyDeposit(const char *name);
-  AliTRDqaEnergyDeposit(AliTRDqaEnergyDeposit& trd);
-  AliTRDqaEnergyDeposit& operator = (const AliTRDqaEnergyDeposit& /*g*/) { return *this; };
+  AliTRDqaEnergyDeposit(const AliTRDqaEnergyDeposit & trd);
+  AliTRDqaEnergyDeposit &operator=(const AliTRDqaEnergyDeposit & /*g*/) { return *this; };
   virtual ~AliTRDqaEnergyDeposit() {}
    
   virtual void Exec(Option_t * opt = "");
@@ -54,10 +54,10 @@ protected:
 
   TH2D *fSignalPtPure[2*5];   // dedx for a clean sample 
 
-  void FillElectrons();
-  void FillPions() {}
-  void FillKaons() {}
-  void FillProtons() {}
+  void FillElectrons() const;
+  void FillPions() const {}
+  void FillKaons() const {}
+  void FillProtons() const {}
 
   ClassDef(AliTRDqaEnergyDeposit, 0); // a TRD analysis task 
 };