cholm [Wed, 16 Mar 2011 12:13:22 +0000 (12:13 +0000)]
Fixed coding convention issues as given by the automatic
rule checker in a mail from the 3rd of march, 2011.
All issues fixed, except
- FMD/AliFMDParameters.cxx:832
Rule RC19: In parameters of a method, objects that are passed
by pointer or by reference and that are not modified should be
declared const. Violation: Parameter declaration UShort_t&
det in method AliFMDParameters::Hardware2Detector can be
declared as const type & param
+ This is a false negative - which is obvious from the code
- FMD/AliFMDReconstructor.cxx:332
Rule RC19: In parameters of a method, objects that are passed
by pointer or by reference and that are not modified should be
declared const. Violation: Parameter declaration AliRawReader
reader in method AliFMDReconstructor::Digitize can be declared
as const type param
+ Again, this is a false negative, since the AliRawReader object _is_
modified - the state is changed
- FMD/AliFMDHitDigitizer.cxx:213
Rule RC19: In parameters of a method, objects that are passed
by pointer or by reference and that are not modified should be
declared const. Violation: Parameter declaration AliFMD fmd
in method AliFMDHitDigitizer::AliFMDHitDigitizer can be
declared as const type param
+ Again, false negative. The member fFMD is assigned to the passed
parameter and this is indeed modified several times throughout the
life time of the AliFMDHitDigitizer object.
- FMD/AliFMD3.cxx:123
Rule RC19: In parameters of a method, objects that are passed
by pointer or by reference and that are not modified should be
declared const. Violation: Parameter declaration Option_t opt
in method AliFMD3::ConeR can be declared as const type param
+ False negative. Strange actually, since typedef const char Option_t
- FMD/AliFMDBaseDigitizer.cxx:605
Rule RC19: In parameters of a method, objects that are passed
by pointer or by reference and that are not modified should be
declared const. Violation: Parameter declaration AliLoader
loader in method AliFMDBaseDigitizer::StoreDigits can be
declared as const type param
+ Again, false negative.
- FMD/AliFMDSpectraDisplay.cxx:237
Rule RC19: In parameters of a method, objects that are passed
by pointer or by reference and that are not modified should be
declared const. Violation: Parameter declaration
TGListTreeItem entry in method
AliFMDSpectraDisplay::AliFMDSpectraDisplayTop::HandleEntry can
be declared as const type param
+ This cannot be changed, since the call back from ROOT does not allow
that.
cholm [Tue, 15 Mar 2011 15:10:21 +0000 (15:10 +0000)]
Code update for handling centrality in the dN/deta analysis.
New MC specific event inspector
Various updates to run script
More flags for the histogram collector
and a few other things
amastros [Mon, 14 Mar 2011 14:03:12 +0000 (14:03 +0000)]
Changes from S. Rossegger :
1. Many fixes to comply with the AliRoot coding conventions
2. Improvement in "lowest pt tracked" -> now uses helix parametrization for calc. of a,b
3. Added a more sophisticaed efficiency calculation which includes the possibility to make chi2 cuts via Confidence Levels (method of Ruben Shahoyan) plus adding 'basic' detection efficiencies per layer
4. Adding "ITS Stand alone" tracking capabilities via forward+backward tracking -> Kalman smoothing is then used for the parameter estimates (important for efficiencies)