One more compilation warning

[u/mrichter/AliRoot.git] / ACORDE / AliACORDEDataDCS.cxx

diff --git a/ACORDE/AliACORDEDataDCS.cxx b/ACORDE/AliACORDEDataDCS.cxx
index 30f620b921e2a41772d0cdfff5e397e59e42268a..daf97e5514088d5e682ab0851a1dea5e50545856 100644 (file)
--- a/ACORDE/AliACORDEDataDCS.cxx
+++ b/ACORDE/AliACORDEDataDCS.cxx
@@ -1,3 +1,23 @@
+/****************************************************
+       
+  AliACORDEDataDCS class
+  create to make a pointer to the
+  ACORDE data DCS points
+
+  Author: Pedro Gonzalez (CIEMAT, Madrid)
+  ACORDE-DCS creator: Mario Ivan Martinez Hdez
+                       <mim@fcfm.buap.mx>
+
+  Last update: June 13th 2014 from Mario Rodríguez Cahuantzi (CINVESTAV, mrodriguez@fis.cinvestav.mx)
+       ==> wrong ACORDE aliases for AMANDA fixed (https://alice.its.cern.ch/jira/browse/ALIROOT-5479)
+               -- old alias: ACO_HV_MODULE[0..59]_VMON
+               -- new alias: ACO_HV_MODULE[0..59]_INSIDE_VMON ()/ ACO_HV_MODULE[0..59]_OUTSIDE_VMON
+
+  Last update: Fix of coding violations
+  Mario Rodriguez C. (FCFM-BUAP)
+  <mrodrigu@mail.cern.ch>
+
+*****************************************************/
 #include "AliACORDEDataDCS.h"
 
 #include "AliCDBMetaData.h"
@@ -25,7 +45,11 @@ AliACORDEDataDCS::AliACORDEDataDCS():
         fFunc(0),
        fIsProcessed(kFALSE)
 {
-       for(int i=0;i<kNHistos;i++) fHv[i]=0x0;
+       for(int i=0;i<kNHistos;i++) 
+       {
+               fHv[i]=0x0;
+               fMean[i] = fWidth[i] = 0.0;
+       }
         
 }
 
@@ -39,6 +63,9 @@ AliACORDEDataDCS::AliACORDEDataDCS(Int_t nRun, UInt_t startTime, UInt_t endTime)
         fFunc(0),
        fIsProcessed(kFALSE)
 {
+// Init of class AliACORDEDataDCS
+// Gettin the TimeStamp an put it on a string
+
        AliInfo(Form("\n\tRun %d \n\tStartTime %s \n\tEndTime %s", nRun,
        TTimeStamp(startTime).AsString(),
        TTimeStamp(endTime).AsString()));
@@ -51,7 +78,10 @@ AliACORDEDataDCS::AliACORDEDataDCS(Int_t nRun, UInt_t startTime, UInt_t endTime)
 //---------------------------------------------------------------
 AliACORDEDataDCS::~AliACORDEDataDCS() {
 
-       for(int i=0;i<kNHistos;i++) {delete fHv[i]; fHv[i]=0;}
+       for(int i=0;i<kNHistos;i++) 
+       {
+               delete fHv[i]; fHv[i]=0;
+       }
        fGraphs.Clear("C");
        fFunc=0;
 }
@@ -66,6 +96,8 @@ fGraphs("TGraph",kNGraphs),
 fFunc(0),
 fIsProcessed(kFALSE)
 {
+// Setting the initial values
+// fRUn, Start of Run, End of Run, IsProcessed
 
        fRun=data.fRun;
        fStartTime=data.fStartTime;
@@ -76,7 +108,12 @@ fIsProcessed(kFALSE)
 
         for(int i=0;i<kNAliases;i++){fAliasNames[i] = data.fAliasNames[i];}
 
-        for(int i=0;i<kNHistos;i++){fHv[i]=data.fHv[i];}
+        for(int i=0;i<kNHistos;i++)
+       {
+               fHv[i]=data.fHv[i];
+               fMean[i]=data.fMean[i];
+               fWidth[i]=data.fWidth[i];
+       }
 
 
 
@@ -85,24 +122,18 @@ fIsProcessed(kFALSE)
 //--------------------------------------------------------------
 AliACORDEDataDCS& AliACORDEDataDCS:: operator=(const AliACORDEDataDCS & data) { 
 
-       
-        this->fRun=data.fRun;
-       this->fStartTime=data.fStartTime;
-       this->fEndTime=data.fEndTime;
-       this->fFunc=data.fFunc;
-       this->fIsProcessed=data.fIsProcessed;
-
+       // use ctor copy
 
-        for(int i=0;i<kNAliases;i++){this->fAliasNames[i] = data.fAliasNames[i];}
+       if (&data == this) return *this;
 
-        for(int i=0;i<kNHistos;i++){this->fHv[i]=data.fHv[i];}
-
-       
-         return *this;
+       new (this) AliACORDEDataDCS(data);
+       return *this;
  
 }
 //---------------------------------------------------------------
-void AliACORDEDataDCS::ProcessData(TMap& aliasMap){
+void AliACORDEDataDCS::ProcessData(TMap& aliasMap)
+{
+// Process of the data from the aliases DCS-data points
 
        if(!(fHv[0])) Init();
 
@@ -121,7 +152,7 @@ void AliACORDEDataDCS::ProcessData(TMap& aliasMap){
 
                if(aliasArr->GetEntries()<2)
                 {
-                       AliError(Form("Alias %s has just %d entries!",
+               AliError(Form("Alias %s has just %d entries!",
                                        fAliasNames[j].Data(),aliasArr->GetEntries()));
                        continue;
                }
@@ -163,7 +194,10 @@ void AliACORDEDataDCS::ProcessData(TMap& aliasMap){
 }
 
 //---------------------------------------------------------------
-void AliACORDEDataDCS::Init(){
+void AliACORDEDataDCS::Init()
+{
+// Init of AliACORDEDatDCS procedure
+// Loop over the aliases
 
        TH1::AddDirectory(kFALSE);
 
@@ -172,8 +206,13 @@ void AliACORDEDataDCS::Init(){
         TString aliasName;
 
        for(int i=0;i<kNAliases;i++){
-
-                aliasName.Form("ACO_HV_MODULE%02d_VMON",i); 
+               if (i<kNAliases/2)
+               {
+                       aliasName.Form("ACO_HV_MODULE%02d_INSIDE_VMON",i);  //!::: first 60 entries for inside PMT's
+               }else
+               {
+                       aliasName.Form("ACO_HV_MODULE%02d_OUTSIDE_VMON",i-60); //!::: last 60 entries for outside PMT's
+               }
                fAliasNames[i] = aliasName;
        }
 
@@ -197,6 +236,7 @@ void AliACORDEDataDCS::Introduce(UInt_t numAlias, const TObjArray* aliasArr)
 //---------------------------------------------------------------
 void AliACORDEDataDCS::CreateGraph(int i, int dim, const Double_t *x, const Double_t *y)
 {
+// Create the plots for the ACORDE DCS 
 
        TGraph *gr = new(fGraphs[fGraphs.GetEntriesFast()]) TGraph(dim, x, y);