Remove compilser warnings

[u/mrichter/AliRoot.git] / HLT / TPCLib / AliHLTTPCCalibPedestalComponent.cxx

diff --git a/HLT/TPCLib/AliHLTTPCCalibPedestalComponent.cxx b/HLT/TPCLib/AliHLTTPCCalibPedestalComponent.cxx
index 940e342653ce771c5e34c8660aa2933a678e9856..57287dccc1c039dbc2e9a991b7d246967dc77ca3 100755 (executable)
--- a/HLT/TPCLib/AliHLTTPCCalibPedestalComponent.cxx
+++ b/HLT/TPCLib/AliHLTTPCCalibPedestalComponent.cxx
@@ -20,6 +20,12 @@
     @brief  A pedestal calibration component for the TPC.
 */
 
+// see header file for class documentation
+// or
+// refer to README to build package
+// or
+// visit http://web.ift.uib.no/~kjeks/doc/alice-hlt   
+
 #if __GNUC__>= 3
 using namespace std;
 #endif
@@ -39,9 +45,7 @@ using namespace std;
 #include <errno.h>
 #include "TString.h"
 
-// this is a global object used for automatic component registration, do not use this
-AliHLTTPCCalibPedestalComponent gAliHLTTPCCalibPedestalComponent;
-
+/** ROOT macro for the implementation of ROOT specific class methods */
 ClassImp(AliHLTTPCCalibPedestalComponent)
 
 AliHLTTPCCalibPedestalComponent::AliHLTTPCCalibPedestalComponent()
@@ -49,7 +53,10 @@ AliHLTTPCCalibPedestalComponent::AliHLTTPCCalibPedestalComponent()
   fRawReader(NULL),
   fRawStream(NULL),
   fCalibPedestal(NULL),
-  fRCUFormat(kFALSE),
+  // Note: initialization of min and max seems to be in the wrong order but is on
+  // purpose in order to work correctly with the conditional in DoEvent line 221
+  //  if ( patch < fMinPatch ) fMinPatch =  patch;
+  //  if ( patch > fMaxPatch ) fMaxPatch =  patch;
   fMinPatch(5),
   fMaxPatch(0),
   fSpecification(0) ,
@@ -61,28 +68,6 @@ AliHLTTPCCalibPedestalComponent::AliHLTTPCCalibPedestalComponent()
   // visit http://web.ift.uib.no/~kjeks/doc/alice-hlt
 }
 
-AliHLTTPCCalibPedestalComponent::AliHLTTPCCalibPedestalComponent(const AliHLTTPCCalibPedestalComponent&)
-  :
-  fRawReader(NULL),
-  fRawStream(NULL),
-  fCalibPedestal(NULL),
-  fRCUFormat(kFALSE),
-  fMinPatch(5),
-  fMaxPatch(0),
-  fSpecification(0),
-  fEnableAnalysis(kFALSE) {
-  // see header file for class documentation
-
-  HLTFatal("copy constructor untested");
-}
-
-AliHLTTPCCalibPedestalComponent& AliHLTTPCCalibPedestalComponent::operator=(const AliHLTTPCCalibPedestalComponent&) { 
-  // see header file for class documentation
-
-  HLTFatal("assignment operator untested");
-  return *this;
-}      
-
 AliHLTTPCCalibPedestalComponent::~AliHLTTPCCalibPedestalComponent() {
   // see header file for class documentation
 }
@@ -148,11 +133,9 @@ Int_t AliHLTTPCCalibPedestalComponent::ScanArgument( Int_t argc, const char** ar
     else {
       parameter = argv[1];
       if ( parameter.CompareTo("old") == 0 ) {
-       fRCUFormat = kTRUE;
         HLTInfo( "RCU Format is set to old." );
       }
       else if ( parameter.CompareTo("new") == 0 ) {
-       fRCUFormat = kFALSE;
         HLTInfo( "RCU Format is set to new." );
       }
       else {
@@ -185,12 +168,7 @@ Int_t AliHLTTPCCalibPedestalComponent::InitCalibration() {
   if (fRawReader)
     return EINPROGRESS;
 
-#if defined(HAVE_ALIRAWDATA) && defined(HAVE_ALITPCRAWSTREAM_H) 
   fRawReader = new AliRawReaderMemory();
-#else
-  HLTFatal("AliRawReader  not available - check your build");
-  return -ENODEV;
-#endif
 
   return 0;
 }
@@ -209,38 +187,35 @@ Int_t AliHLTTPCCalibPedestalComponent::DeinitCalibration() {
   return 0;
 }
 
-/*
- * --- setter for rcuformat need in AliTPCCalibPedestal class
- */
-Int_t AliHLTTPCCalibPedestalComponent::ProcessCalibration( const AliHLTComponentEventData& evtData, AliHLTComponentTriggerData& trigData ) {
+Int_t AliHLTTPCCalibPedestalComponent::ProcessCalibration( const AliHLTComponentEventData& /*evtData*/, 
+                                                          AliHLTComponentTriggerData& /*trigData*/ ) {
   // see header file for class documentation
   
   const AliHLTComponentBlockData* iter = NULL;
 
-  AliHLTUInt8_t slice, patch;
-  Int_t DDLid = 0;
+  AliHLTUInt8_t slice=0, patch=0;
+  Int_t ddlId = 0;
     
   // ** Loop over all input blocks and specify which data format should be read - only select Raw Data
-  iter = GetFirstInputBlock( AliHLTTPCDefinitions::fgkDDLPackedRawDataType );
+  iter = GetFirstInputBlock( kAliHLTDataTypeDDLRaw | kAliHLTDataOriginTPC);
   
   while ( iter != NULL ) {
     
     // ** Print Debug output which data format was received
-    char tmp1[14], tmp2[14];
-    DataType2Text( iter->fDataType, tmp1 );
-    DataType2Text( AliHLTTPCDefinitions::fgkDDLPackedRawDataType, tmp2 );
-
-    HLTDebug ( "Event received - Event 0x%08LX (%Lu) received datatype: %s - required datatype: %s", 
-              evtData.fEventID, evtData.fEventID, tmp1, tmp2 );
+    //    char tmp1[14], tmp2[14];
+    //    DataType2Text( iter->fDataType, tmp1 );
+    //    DataType2Text( AliHLTTPCDefinitions::fgkDDLPackedRawDataType, tmp2 );
+    //    HLTDebug ( "Event received - Event 0x%08LX (%Lu) received datatype: %s - required datatype: %s", 
+    //    evtData.fEventID, evtData.fEventID, tmp1, tmp2 );
 
     // ** Get DDL ID in order to tell the memory reader which slice/patch to use
     slice = AliHLTTPCDefinitions::GetMinSliceNr( *iter );
     patch = AliHLTTPCDefinitions::GetMinPatchNr( *iter );
 
-    if (patch < 2) DDLid = 768 + (2 * slice) + patch;
-    else DDLid = 838 + (4*slice) + patch;
+    if (patch < 2) ddlId = 768 + (2 * slice) + patch;
+    else ddlId = 838 + (4*slice) + patch;
 
-    HLTDebug ( "Input Raw Data - Slice/Patch: %d/%d - EquipmentID : %d.", slice, patch, DDLid );
+    HLTDebug ( "Input Raw Data - Slice/Patch: %d/%d - EquipmentID : %d.", slice, patch, ddlId );
 
     // ** Get min and max patch, used for output specification
     if ( patch < fMinPatch ) fMinPatch =  patch;
@@ -248,10 +223,9 @@ Int_t AliHLTTPCCalibPedestalComponent::ProcessCalibration( const AliHLTComponent
 
     // ** Init TPCRawStream
     fRawReader->SetMemory( reinterpret_cast<UChar_t*>( iter->fPtr ), iter->fSize );
-    fRawReader->SetEquipmentID(DDLid);
+    fRawReader->SetEquipmentID(ddlId);
 
     fRawStream = new AliTPCRawStream( fRawReader );
-    fRawStream->SetOldRCUFormat( fRCUFormat );
 
     // ** Process actual Pedestal Calibration - Fill histograms
     fCalibPedestal->ProcessEvent( fRawStream );
@@ -276,7 +250,8 @@ Int_t AliHLTTPCCalibPedestalComponent::ProcessCalibration( const AliHLTComponent
 } // Int_t AliHLTTPCCalibPedestalComponent::ProcessCalibration( const AliHLTComponentEventData& evtData, AliHLTComponentTriggerData& trigData ) {
 
 
-Int_t AliHLTTPCCalibPedestalComponent::ShipDataToFXS( const AliHLTComponentEventData& evtData, AliHLTComponentTriggerData& trigData ) {
+Int_t AliHLTTPCCalibPedestalComponent::ShipDataToFXS( const AliHLTComponentEventData& /*evtData*/, 
+                                                     AliHLTComponentTriggerData& /*trigData*/ ) {
   // see header file for class documentation
     
   if ( fEnableAnalysis )