coverity warnings fixed

[u/mrichter/AliRoot.git] / MUON / AliMUONGeometryDetElement.cxx

diff --git a/MUON/AliMUONGeometryDetElement.cxx b/MUON/AliMUONGeometryDetElement.cxx
index c4c7e2ed466f3b24cc2e1717c0c8f26a026e5212..be6b5b09c524747498e747d086a273bdeeeabb54 100644 (file)
--- a/MUON/AliMUONGeometryDetElement.cxx
+++ b/MUON/AliMUONGeometryDetElement.cxx
@@ -14,12 +14,13 @@
  **************************************************************************/
 
 // $Id$
-//
-// --------------------------------------
+
+//-----------------------------------------------------------------------------
 // Class AliMUONGeometryDetElement
 // --------------------------------------
 // The class defines the detection element.
 // Author: Ivana Hrivnacova, IPN Orsay
+//-----------------------------------------------------------------------------
 
 #include "AliMUONGeometryDetElement.h"
 
@@ -36,12 +37,35 @@ ClassImp(AliMUONGeometryDetElement)
 
 const TString AliMUONGeometryDetElement::fgkDENamePrefix = "DE";
 
+//______________________________________________________________________________
+TString AliMUONGeometryDetElement::GetDEName(Int_t detElemId)
+{
+/// Return the module name for given moduleId
+
+  TString deName(fgkDENamePrefix);
+  deName += detElemId;
+  return deName;
+}   
+
+//______________________________________________________________________________
+AliMUONGeometryDetElement::AliMUONGeometryDetElement(Int_t detElemId)
+ : TObject(),
+   fDEName(GetDEName(detElemId)),
+   fVolumePath(),
+   fLocalTransformation(0),
+   fGlobalTransformation(0)
+{ 
+/// Standard constructor
+
+  SetUniqueID(detElemId);
+}
+
 //______________________________________________________________________________
 AliMUONGeometryDetElement::AliMUONGeometryDetElement(
                                         Int_t detElemId,
                                         const TString& volumePath)
  : TObject(),
-   fDEName(),
+   fDEName(GetDEName(detElemId)),
    fVolumePath(volumePath),
    fLocalTransformation(0),
    fGlobalTransformation(0)
@@ -49,20 +73,17 @@ AliMUONGeometryDetElement::AliMUONGeometryDetElement(
 /// Standard constructor
 
   SetUniqueID(detElemId);
-  
-  fDEName = fgkDENamePrefix;
-  fDEName += detElemId;
 }
 
 //______________________________________________________________________________
-AliMUONGeometryDetElement::AliMUONGeometryDetElement()
+AliMUONGeometryDetElement::AliMUONGeometryDetElement(TRootIOCtor* /*ioCtor*/)
  : TObject(),
    fDEName(),
    fVolumePath(),
    fLocalTransformation(0),
    fGlobalTransformation(0)
 {
-/// Default constructor
+/// Root IO constructor
 }
 
 //______________________________________________________________________________
@@ -222,14 +243,17 @@ void  AliMUONGeometryDetElement::Local2Global(
 
 //______________________________________________________________________________
 void AliMUONGeometryDetElement::SetLocalTransformation(
-                                                const TGeoHMatrix& transform)
+                                                const TGeoHMatrix& transform, 
+                                                Bool_t warn)
 { 
 /// Set local transformation;
 /// give warning if the global transformation is already defined.
  
-  if (fLocalTransformation) {
+  if ( fLocalTransformation ) {
     delete fLocalTransformation;
-    AliWarning("Local transformation already defined was deleted.");
+    if ( warn ) {
+      AliWarning("Local transformation already defined was deleted.");
+    }  
   }  
 
   fLocalTransformation = new TGeoHMatrix(transform);
@@ -237,14 +261,17 @@ void AliMUONGeometryDetElement::SetLocalTransformation(
                                              
 //______________________________________________________________________________
 void AliMUONGeometryDetElement::SetGlobalTransformation(
-                                                const TGeoHMatrix& transform)
+                                                const TGeoHMatrix& transform,
+                                                Bool_t warn)
 { 
 /// Set global transformation;
 /// give warning if the global transformation is already defined.
  
   if (fGlobalTransformation) {
     delete fGlobalTransformation;
-    AliWarning("Global transformation already defined was deleted.");
+    if ( warn ) {
+      AliWarning("Global transformation already defined was deleted.");
+    }  
   }  
 
   fGlobalTransformation = new TGeoHMatrix(transform);