coverity fix

[u/mrichter/AliRoot.git] / PWG1 / TPC / AliPerformanceRes.cxx

diff --git a/PWG1/TPC/AliPerformanceRes.cxx b/PWG1/TPC/AliPerformanceRes.cxx
index 2d058042ef900618f5111204cbb29ba8e66fca3c..a3074b57fcfbab3c9144b8c5e3793197498bf02c 100644 (file)
--- a/PWG1/TPC/AliPerformanceRes.cxx
+++ b/PWG1/TPC/AliPerformanceRes.cxx
@@ -353,8 +353,7 @@ void AliPerformanceRes::ProcessTPCITS(AliStack* const stack, AliESDtrack *const
 
   if ((esdTrack->GetStatus()&AliESDtrack::kTPCrefit)==0) return; // TPC refit
   if (esdTrack->GetTPCNcls()<fCutsRC->GetMinNClustersTPC()) return; // min. nb. TPC clusters  
-  Int_t clusterITS[200];
-  if(esdTrack->GetITSclusters(clusterITS)<fCutsRC->GetMinNClustersITS()) return;  // min. nb. ITS clusters
+  if(esdTrack->GetITSclusters(0)<fCutsRC->GetMinNClustersITS()) return;  // min. nb. ITS clusters
 
   Float_t deltaPtTPC, deltaYTPC, deltaZTPC, deltaPhiTPC, deltaLambdaTPC; 
   Float_t pull1PtTPC, pullYTPC, pullZTPC, pullPhiTPC, pullLambdaTPC; 
@@ -911,13 +910,8 @@ void AliPerformanceRes::Exec(AliMCEvent* const mcEvent, AliESDEvent *const esdEv
     if(!track) continue;
 
     AliESDfriendTrack *friendTrack=0;
-    if(bUseESDfriend) {
-      friendTrack=esdFriend->GetTrack(iTrack);
-      if(!friendTrack) continue;
-    }
 
-    // check stack
-    if(!stack) continue;
+
     Int_t label = TMath::Abs(track->GetLabel()); 
     if ( label > stack->GetNtrack() ) 
     {
@@ -944,7 +938,15 @@ void AliPerformanceRes::Exec(AliMCEvent* const mcEvent, AliESDEvent *const esdEv
     else if(GetAnalysisMode() == 1) ProcessTPCITS(stack,track,esdEvent);
     else if(GetAnalysisMode() == 2) ProcessConstrained(stack,track,esdEvent);
     else if(GetAnalysisMode() == 3) ProcessInnerTPC(mcEvent,track,esdEvent);
-    else if(GetAnalysisMode() == 4) ProcessOuterTPC(mcEvent,track,friendTrack,esdEvent);
+    else if(GetAnalysisMode() == 4) {
+
+    if(bUseESDfriend) {
+      friendTrack=esdFriend->GetTrack(iTrack);
+      if(!friendTrack) continue;
+    }
+
+       ProcessOuterTPC(mcEvent,track,friendTrack,esdEvent);
+       }
     else {
       printf("ERROR: AnalysisMode %d \n",fAnalysisMode);
       return;
@@ -973,6 +975,7 @@ void AliPerformanceRes::Analyse() {
   TH1F *h=0;
   TH2F *h2D=0;
   TObjArray *aFolderObj = new TObjArray;
+  if(!aFolderObj) return;
 
   // write results in the folder 
   TCanvas * c = new TCanvas("Phi resol Tan","Phi resol Tan");
@@ -994,13 +997,13 @@ void AliPerformanceRes::Analyse() {
       h2D = (TH2F*)fResolHisto->Projection(i,j);
 
       h = AliPerformanceRes::MakeResol(h2D,1,0,100);
-      sprintf(name,"h_res_%d_vs_%d",i,j);
+      snprintf(name,256,"h_res_%d_vs_%d",i,j);
       h->SetName(name);
 
       h->GetXaxis()->SetTitle(fResolHisto->GetAxis(j)->GetTitle());
-      sprintf(title,"%s %s",fResolHisto->GetAxis(i)->GetTitle(),"(resolution)");
+      snprintf(title,256,"%s %s",fResolHisto->GetAxis(i)->GetTitle(),"(resolution)");
       h->GetYaxis()->SetTitle(title);
-      sprintf(title,"%s vs %s",title,fResolHisto->GetAxis(j)->GetTitle());
+      snprintf(title,256,"%s vs %s",title,fResolHisto->GetAxis(j)->GetTitle());
       h->SetTitle(title);
 
       if(j==9) h->SetBit(TH1::kLogX);    
@@ -1008,14 +1011,14 @@ void AliPerformanceRes::Analyse() {
 
       h = AliPerformanceRes::MakeResol(h2D,1,1,100);
       //h = (TH1F*)arr->At(1);
-      sprintf(name,"h_mean_res_%d_vs_%d",i,j);
+      snprintf(name,256,"h_mean_res_%d_vs_%d",i,j);
       h->SetName(name);
 
       h->GetXaxis()->SetTitle(fResolHisto->GetAxis(j)->GetTitle());
-      sprintf(title,"%s %s",fResolHisto->GetAxis(i)->GetTitle(),"(mean)");
+      snprintf(title,256,"%s %s",fResolHisto->GetAxis(i)->GetTitle(),"(mean)");
       h->GetYaxis()->SetTitle(title);
 
-      sprintf(title,"%s vs %s",title,fResolHisto->GetAxis(j)->GetTitle());
+      snprintf(title,256,"%s vs %s",title,fResolHisto->GetAxis(j)->GetTitle());
       h->SetTitle(title);
 
       if(j==9) h->SetBit(TH1::kLogX);    
@@ -1034,26 +1037,26 @@ void AliPerformanceRes::Analyse() {
       h2D = (TH2F*)fPullHisto->Projection(i,j);
 
       h = AliPerformanceRes::MakeResol(h2D,1,0,100);
-      sprintf(name,"h_pull_%d_vs_%d",i,j);
+      snprintf(name,256,"h_pull_%d_vs_%d",i,j);
       h->SetName(name);
 
       h->GetXaxis()->SetTitle(fPullHisto->GetAxis(j)->GetTitle());
-      sprintf(title,"%s %s",fPullHisto->GetAxis(i)->GetTitle(),"(resolution)");
+      snprintf(title,256,"%s %s",fPullHisto->GetAxis(i)->GetTitle(),"(resolution)");
       h->GetYaxis()->SetTitle(title);
-      sprintf(title,"%s vs %s",title,fPullHisto->GetAxis(j)->GetTitle());
+      snprintf(title,256,"%s vs %s",title,fPullHisto->GetAxis(j)->GetTitle());
       h->SetTitle(title);
 
       //if(j==9) h->SetBit(TH1::kLogX);    
       aFolderObj->Add(h);
 
       h = AliPerformanceRes::MakeResol(h2D,1,1,100);
-      sprintf(name,"h_mean_pull_%d_vs_%d",i,j);
+      snprintf(name,256,"h_mean_pull_%d_vs_%d",i,j);
       h->SetName(name);
 
       h->GetXaxis()->SetTitle(fPullHisto->GetAxis(j)->GetTitle());
-      sprintf(title,"%s %s",fPullHisto->GetAxis(i)->GetTitle(),"(mean)");
+      snprintf(title,256,"%s %s",fPullHisto->GetAxis(i)->GetTitle(),"(mean)");
       h->GetYaxis()->SetTitle(title);
-      sprintf(title,"%s vs %s",title,fPullHisto->GetAxis(j)->GetTitle());
+      snprintf(title,256,"%s vs %s",title,fPullHisto->GetAxis(j)->GetTitle());
       h->SetTitle(title);
 
       //if(j==9) h->SetBit(TH1::kLogX);