Fix Coverity

[u/mrichter/AliRoot.git] / PWG2 / FEMTOSCOPY / AliFemtoUser / AliFemtoModelBPLCMSCorrFctn.cxx

diff --git a/PWG2/FEMTOSCOPY/AliFemtoUser/AliFemtoModelBPLCMSCorrFctn.cxx b/PWG2/FEMTOSCOPY/AliFemtoUser/AliFemtoModelBPLCMSCorrFctn.cxx
index 83972a000b97e2dc3af1a4997947e361403f6a41..d086e5fa0f1f13b0af45676dad4abd23aea476a8 100644 (file)
--- a/PWG2/FEMTOSCOPY/AliFemtoUser/AliFemtoModelBPLCMSCorrFctn.cxx
+++ b/PWG2/FEMTOSCOPY/AliFemtoUser/AliFemtoModelBPLCMSCorrFctn.cxx
@@ -29,20 +29,20 @@ AliFemtoModelBPLCMSCorrFctn::AliFemtoModelBPLCMSCorrFctn(char* title, const int&
   fUseRPSelection(0)
 {
   // set up true numerator
-  char tTitNumT[100] = "Num3DTrue";
-  strcat(tTitNumT,title);
+  char tTitNumT[101] = "Num3DTrue";
+  strncat(tTitNumT,title, 100);
   fNumerator3DTrue = new TH3D(tTitNumT,title,nbins,QLo,QHi,nbins,QLo,QHi,nbins,QLo,QHi);
   // set up fake numerator
-  char tTitNumF[100] = "Num3DFake";
-  strcat(tTitNumF,title);
+  char tTitNumF[101] = "Num3DFake";
+  strncat(tTitNumF,title, 100);
   fNumerator3DFake = new TH3D(tTitNumF,title,nbins,QLo,QHi,nbins,QLo,QHi,nbins,QLo,QHi);
   // set up denominator
-  char tTitDen[100] = "Den3D";
-  strcat(tTitDen,title);
+  char tTitDen[101] = "Den3D";
+  strncat(tTitDen,title, 100);
   fDenominator3D = new TH3D(tTitDen,title,nbins,QLo,QHi,nbins,QLo,QHi,nbins,QLo,QHi);
   // set up ave qInv
-  char tTitQinv[100] = "Qinv";
-  strcat(tTitQinv,title);
+  char tTitQinv[101] = "Qinv";
+  strncat(tTitQinv,title, 100);
   fQinvHisto = new TH3D(tTitQinv,title,nbins,QLo,QHi,nbins,QLo,QHi,nbins,QLo,QHi);
 
   // to enable error bar calculation...
@@ -132,18 +132,18 @@ AliFemtoString AliFemtoModelBPLCMSCorrFctn::Report(){
   // Prepare a report from the execution
   string stemp = "LCMS Frame Bertsch-Pratt 3D Model Correlation Function Report:\n";
   char ctemp[100];
-  sprintf(ctemp,"Number of entries in numerator:\t%E\n",fNumeratorTrue->GetEntries());
+  snprintf(ctemp , 100, "Number of entries in numerator:\t%E\n",fNumeratorTrue->GetEntries());
   stemp += ctemp;
-  sprintf(ctemp,"Number of entries in denominator:\t%E\n",fDenominator->GetEntries());
+  snprintf(ctemp , 100, "Number of entries in denominator:\t%E\n",fDenominator->GetEntries());
   stemp += ctemp;
   /*  if (fCorrection)
       {
       float radius = fCorrection->GetRadius();
-      sprintf(ctemp,"Coulomb correction used radius of\t%E\n",radius);
+      snprintf(ctemp , 100, "Coulomb correction used radius of\t%E\n",radius);
       }
       else
       {
-      sprintf(ctemp,"No Coulomb Correction applied to this CorrFctn\n");
+      snprintf(ctemp , 100, "No Coulomb Correction applied to this CorrFctn\n");
       }
       stemp += ctemp;
   */
@@ -169,7 +169,7 @@ void AliFemtoModelBPLCMSCorrFctn::AddRealPair( AliFemtoPair* pair)
          cout << "RP aware cut requested, but not connected to the CF" << endl;
          if (!(fPairCut->Pass(pair))) return;
        }
-       if (!(ktc->Pass(pair, arp->GetCurrentReactionPlane()))) return;
+       else if (!(ktc->Pass(pair, arp->GetCurrentReactionPlane()))) return;
       }
     }
     else
@@ -204,7 +204,7 @@ void AliFemtoModelBPLCMSCorrFctn::AddMixedPair( AliFemtoPair* pair){
          cout << "RP aware cut requested, but not connected to the CF" << endl;
          if (!(fPairCut->Pass(pair))) return;
        }
-       if (!(ktc->Pass(pair, arp->GetCurrentReactionPlane()))) return;
+       else if (!(ktc->Pass(pair, arp->GetCurrentReactionPlane()))) return;
       }
     }
     else