Removing some meaningless const (coverity)

[u/mrichter/AliRoot.git] / T0 / AliT0CalibSeasonTimeShift.cxx

diff --git a/T0/AliT0CalibSeasonTimeShift.cxx b/T0/AliT0CalibSeasonTimeShift.cxx
index 7bcec7a531d5b8e53613af09213884876d408af8..7b11878b3885e98c5b9f9bf7f7761b509691064e 100644 (file)
--- a/T0/AliT0CalibSeasonTimeShift.cxx
+++ b/T0/AliT0CalibSeasonTimeShift.cxx
@@ -36,7 +36,8 @@ ClassImp(AliT0CalibSeasonTimeShift)
   AliT0CalibSeasonTimeShift::AliT0CalibSeasonTimeShift():TNamed()
 {
   //
-
+  for (Int_t i=0; i<4; i++)
+    fMeanPar[i] = fSigmaPar[i] = 0; 
 }
 
 //________________________________________________________________
@@ -47,7 +48,11 @@ AliT0CalibSeasonTimeShift::AliT0CalibSeasonTimeShift(const char* name):TNamed()
   TString namst = "Calib_";
   namst += name;
   SetName(namst.Data());
-  SetTitle(namst.Data());
+  SetTitle(namst.Data()); 
+  
+  for (Int_t i=0; i<4; i++)
+    fMeanPar[i] = fSigmaPar[i] = 0; 
+ 
 }
 
 //________________________________________________________________
@@ -57,6 +62,7 @@ AliT0CalibSeasonTimeShift::AliT0CalibSeasonTimeShift(const AliT0CalibSeasonTimeS
 // copy constructor
   SetName(calibda.GetName());
   SetTitle(calibda.GetName());
+  ((AliT0CalibSeasonTimeShift &) calibda).Copy(*this);
 
 
 }
@@ -67,6 +73,7 @@ AliT0CalibSeasonTimeShift &AliT0CalibSeasonTimeShift::operator =(const AliT0Cali
 // assignment operator
   SetName(calibda.GetName());
   SetTitle(calibda.GetName());
+  if (this != &calibda) ((AliT0CalibSeasonTimeShift &) calibda).Copy(*this);
  
   return *this;
 }
@@ -104,66 +111,68 @@ Bool_t  AliT0CalibSeasonTimeShift::SetT0Par(Float_t par[4],Float_t spar[4])
 }
 
 //________________________________________________________________
-Bool_t AliT0CalibSeasonTimeShift::SetT0Par(const char* filePhys, Float_t *cdbtime)
+Int_t AliT0CalibSeasonTimeShift::SetT0Par(const char* filePhys, Float_t *cdbtime)
 {
-  // compute online equalized time
+  // compute shifts fo T0A, T0C, T0AC and resolution
+  //Status : writeok:
+  // 0 OK
+  // 2000 - no data file
+  // 300 no one histogram or it is empty
+  //-100 peak is very narrow
+
   Float_t mean, sigma;
-  Bool_t ok=true;
+  Int_t ok = 0;
   TH1F *cfd = NULL;
-  TObjArray * TzeroObj = NULL;
+  TObjArray * tzeroObj = NULL;
 
   gFile = TFile::Open(filePhys);
   if(!gFile) {
     AliError("No input PHYS data found ");
-    ok = false;
+    return 2000;
   }
-  else
-    {
-      //    gFile->ls();
-    TDirectory *dr = (TDirectory*) gFile->Get("T0Calib");
-    if (dr) TzeroObj = (TObjArray*) dr->Get("T0Calib");
+  else {
+    //    gFile->ls();
+    //    TDirectory *dr = (TDirectory*) gFile->Get("T0Calib");
+    tzeroObj = dynamic_cast<TObjArray*>(gFile->Get("T0Calib"));
     TString histname[4]={"fTzeroORAplusORC", "fTzeroORA", "fTzeroORC",  "fResolution"};
     for (Int_t i=0; i<4; i++)
       {
        if(cfd) cfd->Reset();
-       if(TzeroObj) 
-         cfd = (TH1F*)TzeroObj->FindObject( histname[i].Data());
+       if(tzeroObj) 
+         cfd = (TH1F*)tzeroObj->FindObject( histname[i].Data());
        else
          cfd =  (TH1F*)gFile ->Get(histname[i].Data());
 
        if(!cfd) {
-         AliWarning(Form("no histograms collected for %s", histname[i].Data()));
-         ok=false;
-         //  fMeanPar[i] = cdbtime[i];
-         //fSigmaPar[i] = 0;
-         return ok;
+         AliError(Form("no histograms collected for %s", histname[i].Data()));
+         return 300;
        }
        if(cfd) {
-           GetMeanAndSigma(cfd, mean, sigma);
-           if (sigma == 0 || sigma > 500 || cfd->GetEntries()<200 ){
-             //ok = false;
-             fMeanPar[i] = cdbtime[i];
-             fSigmaPar[i] = -1;
-           }
-           if ( sigma > 0 && sigma < 500 && cfd->GetEntries()>200)
-             { 
-               fMeanPar[i] =   mean;
-               fSigmaPar[i] = sigma;
-               ok=true;
-             }
+         if( cfd->GetEntries() == 0) {
+         AliError(Form("%s histogram is empty", histname[i].Data()));
+         return 300;
+         }
+         GetMeanAndSigma(cfd, mean, sigma);
+         if (sigma == 0 || sigma > 600 || cfd->GetEntries()<50 ){ //!!!
+           AliError(Form("%s low statsitics or bad histogram", histname[i].Data()));
+           return 400;
          }
+         if ( sigma > 0 && sigma < 600 && cfd->GetEntries()>=50) //!!!
+           { 
+             fMeanPar[i] =   mean;
+             fSigmaPar[i] = sigma;
+           }
+       }
       } 
-    
-    gFile->Close();
-    delete gFile;
-    
-    }
+  }
+  gFile->Close();
+  delete gFile;
   return ok;
 }
 //________________________________________________________________________
 void AliT0CalibSeasonTimeShift::GetMeanAndSigma(TH1F* hist,  Float_t &mean, Float_t &sigma) {
 
-  const double window =2.;  //fit window 
+  const double window =3.;  //fit window 
  
   double meanEstimate, sigmaEstimate; 
   int maxBin;
@@ -172,7 +181,7 @@ void AliT0CalibSeasonTimeShift::GetMeanAndSigma(TH1F* hist,  Float_t &mean, Floa
   sigmaEstimate = hist->GetRMS();
   TF1* fit= new TF1("fit","gaus", meanEstimate - window*sigmaEstimate, meanEstimate + window*sigmaEstimate);
   fit->SetParameters(hist->GetBinContent(maxBin), meanEstimate, sigmaEstimate);
-  hist->Fit("fit","RQ","Q");
+  hist->Fit("fit","R","");
 
   mean  = (Float_t) fit->GetParameter(1);
   sigma = (Float_t) fit->GetParameter(2);