Bool_t AliDigits::OutOfBoundsError(const char *where, Int_t row, Int_t column)
{
// Generate an out-of-bounds error. Always returns false.
- ::Error(where, "row %d col %d out of bounds (size: %d x %d, this: 0x%08x)",
- row, column, fNrows, fNcols, this);
+ ::Error(where, "row %d col %d out of bounds (size: %d x %d, this: 0x%08lx)",
+ row, column, fNrows, fNcols, (ULong_t) this);
return kFALSE;
}
Int_t AliDigits::GetSize()
{
//
- //return size of object
+ //return size of object as represented in the memory
//
- Int_t size = sizeof(this);
+ // Int_t size = sizeof(this);
+ Int_t size = 0; // COVERITY consider the previous statment as bug
+ //
if (fIndex!=0) size+= sizeof(fIndex)+fIndex->GetSize()*sizeof(Int_t);
if (fElements!=0) size+= sizeof(fElements)+fElements->GetSize()*sizeof(Short_t);
return size;
//
//make digits histo
char ch[30];
- sprintf(ch,"Segment_%d ",GetID());
+ snprintf(ch,30, "Segment_%d ",GetID());
if ( (fNrows<1)|| (fNcols<1)) {
return 0;
}
}else
if (row>fNrows){
Invalidate();
+ delete [] buf;
return;
}
}
fCurrentCol = -1;
fCurrentIndex = -1;
Int_t i;
- for (i=0; (( i<fNelems) && (fElements->At(i)<=fThreshold));i++); //MI1211
+ for (i=0; (( i<fNelems) && (fElements->At(i)<=fThreshold));i++) {} //MI1211
if (i == fNelems) return kFALSE;
fCurrentCol =i/fNrows;
fCurrentRow =i%fNrows;
//
if (fCurrentIndex<0) return kFALSE; // if we didn't adjust first
Int_t i;
- for (i=fCurrentIndex+1; ( (i<fNelems) && (fElements->At(i)<=fThreshold) ) ;i++);
+ for (i=fCurrentIndex+1; ( (i<fNelems) && (fElements->At(i)<=fThreshold) ) ;i++) {}
if (i >= fNelems) {
fCurrentIndex = -1;
return kFALSE;