minor coverity defect: added protection for self-assignment

[u/mrichter/AliRoot.git] / ANALYSIS / AliAnalysisTask.cxx

diff --git a/ANALYSIS/AliAnalysisTask.cxx b/ANALYSIS/AliAnalysisTask.cxx
index 362c4551c50aa362a8eada192f4746c65fe3b455..0d608b294ced93a4b73fd4c3665acc8c7540bc83 100644 (file)
--- a/ANALYSIS/AliAnalysisTask.cxx
+++ b/ANALYSIS/AliAnalysisTask.cxx
@@ -100,7 +100,9 @@
 #include <Riostream.h>
 #include <TFile.h>
 #include <TClass.h>
+#include <TCollection.h>
 #include <TTree.h>
+#include <TROOT.h>
 
 #include "AliAnalysisTask.h"
 #include "AliAnalysisDataSlot.h"
@@ -118,7 +120,8 @@ AliAnalysisTask::AliAnalysisTask()
                  fOutputReady(NULL),
                  fPublishedData(NULL),
                  fInputs(NULL),
-                 fOutputs(NULL)
+                 fOutputs(NULL),
+                 fBranchNames()
 {
 // Default constructor.
 }
@@ -133,7 +136,8 @@ AliAnalysisTask::AliAnalysisTask(const char *name, const char *title)
                  fOutputReady(NULL),
                  fPublishedData(NULL),
                  fInputs(NULL),
-                 fOutputs(NULL)                 
+                 fOutputs(NULL),
+                 fBranchNames()                 
 {
 // Constructor.
    fInputs      = new TObjArray(2);
@@ -150,7 +154,8 @@ AliAnalysisTask::AliAnalysisTask(const AliAnalysisTask &task)
                  fOutputReady(NULL),
                  fPublishedData(NULL),
                  fInputs(NULL),
-                 fOutputs(NULL)                 
+                 fOutputs(NULL),
+                 fBranchNames(task.fBranchNames)
 {
 // Copy ctor.
    fInputs      = new TObjArray((fNinputs)?fNinputs:2);
@@ -194,6 +199,7 @@ AliAnalysisTask& AliAnalysisTask::operator=(const AliAnalysisTask& task)
       fOutputReady[i] = IsOutputReady(i);
       fOutputs->AddAt(new AliAnalysisDataSlot(*task.GetOutputSlot(i)),i);
    }         
+   fBranchNames = task.fBranchNames;
    return *this;
 }
 
@@ -249,6 +255,47 @@ void AliAnalysisTask::CheckNotify(Bool_t init)
    fInitialized = kTRUE;
 }
 
+//______________________________________________________________________________
+Bool_t AliAnalysisTask::CheckPostData() const
+{
+// Checks if data was posted to all outputs defined by the task. If task does
+// not have output slots this returns always kTRUE.
+   Bool_t dataPosted = kTRUE;
+   AliAnalysisDataContainer *coutput;
+   AliAnalysisManager *mgr = AliAnalysisManager::GetAnalysisManager();
+   for (Int_t islot=0; islot<fNoutputs; islot++) {
+      coutput = GetOutputSlot(islot)->GetContainer();
+      if (!mgr->GetOutputs()->FindObject(coutput)) continue;
+      if (!coutput->GetData()) {
+         Error("CheckPostData", "Data not posted for slot #%d of task %s (%s)", 
+               islot, GetName(), ClassName());
+         dataPosted = kFALSE;
+      }   
+   }
+   CheckOwnership();
+   return dataPosted;
+}
+
+//______________________________________________________________________________
+Bool_t AliAnalysisTask::CheckOwnership() const
+{
+// Check ownership of containers posted on output slots (1 level only)
+   TObject *outdata;
+   for (Int_t islot=0; islot<fNoutputs; islot++) {
+      outdata = GetOutputData(islot);
+      if (outdata && outdata->InheritsFrom(TCollection::Class())) {
+         TCollection *coll = (TCollection*)outdata;
+         if (!coll->IsOwner()) {
+            Error("CheckOwnership","####### IMPORTANT! ####### \n\n\n\
+                Task %s (%s) posts a container that is not owner at output #%d. This may apply for other embedded containers. \n\n\
+                ####### FIX YOUR CODE, THIS WILL PRODUCE A FATAL ERROR IN FUTURE! ##########", GetName(), ClassName(), islot);
+             return kFALSE;   
+         }
+      }
+   }
+   return kTRUE;
+}
+      
 //______________________________________________________________________________
 Bool_t AliAnalysisTask::ConnectInput(Int_t islot, AliAnalysisDataContainer *cont)
 {
@@ -462,24 +509,9 @@ TFile *AliAnalysisTask::OpenFile(Int_t iout, Option_t *option) const
       Error("OpenFile", "No output slot for task %s with index %d", GetName(), iout);
       return NULL;
    }   
-   // We allow file opening also on the slaves (AG)
-   AliAnalysisManager *mgr = AliAnalysisManager::GetAnalysisManager();
+   // Method delegated to the analysis manager (A.G. 02/11/09)
    AliAnalysisDataContainer *cont = GetOutputSlot(iout)->GetContainer();
-   TFile *f = NULL;
-   if (!strlen(cont->GetFileName())) {
-      Error("OpenFile", "No file name specified for container %s", cont->GetName());
-      return f;
-   }   
-   if (mgr->GetAnalysisType()==AliAnalysisManager::kProofAnalysis && cont->IsSpecialOutput())
-      f = mgr->OpenProofFile(cont->GetFileName(),option);
-   else
-      f = new TFile(cont->GetFileName(), option);
-   if (f && !f->IsZombie()) {
-      cont->SetFile(f);
-      return f;
-   }
-   cont->SetFile(NULL);
-   return NULL;
+   return AliAnalysisManager::OpenFile(cont, option);
 }
 
 //______________________________________________________________________________
@@ -489,6 +521,13 @@ Bool_t AliAnalysisTask::Notify()
    return kTRUE;
 }
 
+//______________________________________________________________________________
+Bool_t AliAnalysisTask::NotifyBinChange()
+{
+// Overload this IF you need to treat bin change in event mixing.
+   return kTRUE;
+}
+
 //______________________________________________________________________________
 void AliAnalysisTask::Terminate(Option_t *)
 {
@@ -557,7 +596,6 @@ Bool_t AliAnalysisTask::CheckCircularDeps()
 void AliAnalysisTask::PrintTask(Option_t *option, Int_t indent) const
 {
 // Print task info.
-   AliAnalysisTask *thistask = (AliAnalysisTask*)this;
    TString opt(option);
    opt.ToLower();
    Bool_t dep = (opt.Contains("dep"))?kTRUE:kFALSE;
@@ -566,8 +604,9 @@ void AliAnalysisTask::PrintTask(Option_t *option, Int_t indent) const
    AliAnalysisDataContainer *cont;
    for (Int_t i=0; i<indent; i++) ind += " ";
    if (!dep || (dep && IsChecked())) {
+      printf("______________________________________________________________________________\n");
       printf("%s\n", Form("%stask: %s  ACTIVE=%i POST_LOOP=%i", ind.Data(), GetName(),IsActive(),IsPostEventLoop()));
-      if (dep) thistask->SetChecked(kFALSE);
+      if (dep) const_cast<AliAnalysisTask*>(this)->SetChecked(kFALSE);
       else {
          for (islot=0; islot<fNinputs; islot++) {
             printf("%s", Form("%s   INPUT #%i: %s <- ",ind.Data(),islot, GetInputType(islot)->GetName()));
@@ -584,6 +623,7 @@ void AliAnalysisTask::PrintTask(Option_t *option, Int_t indent) const
       }
    }
    PrintContainers(option, indent+3);
+   if (!fBranchNames.IsNull()) printf("Requested branches:   %s\n", fBranchNames.Data());
 }      
 
 //______________________________________________________________________________
@@ -614,3 +654,18 @@ void AliAnalysisTask::SetPostEventLoop(Bool_t flag)
    }   
 }
    
+//______________________________________________________________________________
+void AliAnalysisTask::GetBranches(const char *type, TString &result) const
+{
+// Get the list of branches for a given type (ESD, AOD). The list of branches
+// requested by a task has to ve declared in the form:
+//   SetBranches("ESD:branch1,branch2,...,branchN AOD:branch1,branch2,...,branchM")
+   result = "";
+   if (fBranchNames.IsNull()) return;
+   Int_t index1 = fBranchNames.Index(type);
+   if (index1<0) return;
+   index1 += 1+strlen(type);
+   Int_t index2 = fBranchNames.Index(" ", index1);
+   if (index2<0) index2 = fBranchNames.Length();
+   result = fBranchNames(index1, index2-index1);
+}