attempt to address new coverity reports for AliCalo stuff and QA checker

[u/mrichter/AliRoot.git] / EMCAL / AliCaloRawAnalyzer.cxx

diff --git a/EMCAL/AliCaloRawAnalyzer.cxx b/EMCAL/AliCaloRawAnalyzer.cxx
index 770164ca7693a28f5ed172d889d899fc23e17fa7..bdec18b523c47ffd4c60f83b5a787fb5d2892cd4 100644 (file)
--- a/EMCAL/AliCaloRawAnalyzer.cxx
+++ b/EMCAL/AliCaloRawAnalyzer.cxx
@@ -46,28 +46,21 @@ AliCaloRawAnalyzer::AliCaloRawAnalyzer(const char *name, const char *nameshort)
   fIsZerosupressed( false ),
   fVerbose( false ),
   fAlgo(Algo::kNONE), 
-// fFp(0), 
   fL1Phase(0),
   fAmp(0),
   fTof(0),
   fTau( EMCAL::TAU )
-//  fFixTau(true)
 {
   //Comment 
-
-  //  snprintf(fName, 256,"%s", name);
-  // snprintf(fNameShort,256, "%s", nameshort);
- 
-  sprintf(fName ,"%s", name);
-  sprintf(fNameShort, "%s", nameshort);
+  snprintf(fName, 256,"%s", name);
+  snprintf(fNameShort,256, "%s", nameshort);
+  //  sprintf(fName ,"%s", name);
+  // sprintf(fNameShort, "%s", nameshort);
   
   for(int i=0; i < ALTROMAXSAMPLES; i++ )
     {
       fReversed[i] = 0;
     }
-
-  // fFp = fopen("amp2.txt", "w");
-
 }
 
 AliCaloRawAnalyzer::~AliCaloRawAnalyzer()
@@ -298,7 +291,7 @@ AliCaloRawAnalyzer::IsInTimeRange( const int maxindex, const int maxtindx, const
 
 
 void 
-AliCaloRawAnalyzer::PrintBunches( const vector<AliCaloBunchInfo> &bvctr ) const
+AliCaloRawAnalyzer::PrintBunches( const vector<AliCaloBunchInfo> &bvctr ) 
 {
   //comment
   cout << __FILE__ << __LINE__<< "*************** Printing Bunches *******************" << endl;
@@ -314,7 +307,7 @@ AliCaloRawAnalyzer::PrintBunches( const vector<AliCaloBunchInfo> &bvctr ) const
 
 
 void 
-AliCaloRawAnalyzer::PrintBunch( const AliCaloBunchInfo &bunch ) const
+AliCaloRawAnalyzer::PrintBunch( const AliCaloBunchInfo &bunch )
 {
   //comment
   cout << __FILE__ << ":" << __LINE__ << endl;
@@ -418,17 +411,6 @@ AliCaloRawAnalyzer::CalculateMeanAndRMS(const Int_t first, const Int_t last,
 
 
 
-// AliCaloFitResults
-// AliCaloRawAnalyzer::Evaluate( const vector<AliCaloBunchInfo>  &/*bunchvector*/, const UInt_t /*altrocfg1*/,  const UInt_t /*altrocfg2*/)
-// { // method to do the selection of what should possibly be fitted
-//   // not implemented for base class
-//   cout << __FILE__ << ":" << __LINE__ << " " << endl;
-  
-//   return AliCaloFitResults( 0, 0 );
-// }
-
-
-
 int
 AliCaloRawAnalyzer::PreFitEvaluateSamples( const vector<AliCaloBunchInfo>  &bunchvector, const UInt_t altrocfg1,  
                                           const UInt_t altrocfg2, Int_t & index, Float_t & maxf, short & maxamp,