coverity fix

[u/mrichter/AliRoot.git] / ITS / AliITSQASSDRefData.cxx

diff --git a/ITS/AliITSQASSDRefData.cxx b/ITS/AliITSQASSDRefData.cxx
index d48989301b84d6aba07a2f273378f17a8c9d99b0..a2062479b7e57e0f9274f102335a14058283baf5 100644 (file)
--- a/ITS/AliITSQASSDRefData.cxx
+++ b/ITS/AliITSQASSDRefData.cxx
@@ -97,7 +97,7 @@ void AliITSQASSDRefData::AddReference(const char* name="",
     return;
   }
   
-  if(name!=""&&GetID(name)!=-1) {
+  if( (strcmp(name,"")!=0) && GetID(name)!=-1) {
     AliError(Form("Reference with name %s already exists. Choose other name or use SetReferenceValue(const char*, Double_t) to overwrite",name));
     return;
   }
@@ -116,12 +116,10 @@ Int_t AliITSQASSDRefData::GetID(const char* name) {
   TString stringName = name;
   TObjString *dummyString = 0;
   for (Int_t id=0; id<fNameList->GetEntriesFast(); id++){
-    dummyString = dynamic_cast <TObjString *>(fNameList->At(id));
+    dummyString = static_cast <TObjString *>(fNameList->At(id));
     refName = dummyString->GetString();
-    //Printf("(AliITSQASSDRefData::GetID) String name from the list: %s",refName.Data());
     if(refName == stringName) {
       status = id;
-      //Printf("(AliITSQASSDRefData::GetID) String name found from the list: %s - Id: %d",refName.Data(),status);
     }
   }
 
@@ -134,11 +132,10 @@ Double_t AliITSQASSDRefData::GetReferenceValue(const char* name) {
   TString refName = "";
   TObjString *dummyString = 0;
   for (Int_t id=0; id<fNameList->GetEntriesFast(); id++){
-    dummyString = dynamic_cast <TObjString *>(fNameList->At(id));
+    dummyString = static_cast <TObjString *>(fNameList->At(id));
     refName = dummyString->GetString();
 
-    if(refName.Data()==name)
-      return fRefList->At(id);
+    if(refName.Data()==name) return fRefList->At(id);
   }
   AliError(Form("Reference name %s unknown",name));
   return -1;
@@ -164,7 +161,7 @@ void AliITSQASSDRefData::PrintTable() {
   TString refName = "";
   TObjString *dummyString = 0;
   for(id=0; id<fRefList->GetSize()-1; id++) {
-    dummyString = dynamic_cast <TObjString *>(fNameList->At(id));
+    dummyString = static_cast <TObjString *>(fNameList->At(id));
     refName = dummyString->GetString();
     Printf("%i ------ %4.3g -------- %s",id,fRefList->At(id),refName.Data());